summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-10-30Fix zip slip security flawandre.schmid44-2173/+1918
Apply zip slip checking in zip operations throughout the system. Centralizes most of the zip logic in one class. Create tests to zip functionalities and zip slip problem. Change-Id: I721f3d44b34fe6d242c9537f5a515ce1bb534c9a Issue-ID: SDC-1401 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-10-30Validate SOL004 manifest signature orderandre.schmid7-59/+51
SOL004 Manifest signature must be the last entry of the manifest. Change-Id: Ie3835f7140ccdf92ef5518ca2d7571930de81971 Issue-ID: SDC-2587 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-10-30add artifacts support in TOSCA exported yml fileLiang Ding15-461/+659
Change-Id: I56f8a6a1ce758876e83a7ee8318b79644ae7d5cb Issue-ID: SDC-1952 Signed-off-by: Liang Ding <liang.ding@intel.com>
2019-10-29Fix for status properties value.aribeiro348-16768/+16758
These changes were made to align the normative types to the TOSCA property definition requirements. Issue-ID: SDC-322 Change-Id: I32e815dd26990dd6c82c859ad051b271db3c8029 Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
2019-10-29Bump SDC version 1.6.0Ofir Sonsino164-166/+166
Change-Id: Ibacb46d19d49023a62caa8f5217086cea6c91ac4 Issue-ID: SDC-2560 Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
2019-10-25Avoid duplicated verification if package is signedvasraz2-93/+100
Fix potential thread leak by using try-with-resource. Change-Id: I20eda524cd028b9dfdfa83207a059f4e1dfeff5e Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-2580
2019-10-24Fix and refactor manifest parsingandre.schmid44-460/+1536
Fix a CMS signature reading expected token. Fix the necessity of a empty line in the end of the manifest. Implement CMS signature, Source checksum algorithm and digest reading. Indicate the line number and content when a manifest error occurs. Remove unnecessary recursive reading. Centralize manifest tokens. Improve tests by checking the expected error. Document the code. Change-Id: I7d12020d8922fc5d4c8d9f238557dfbcc0b65757 Issue-ID: SDC-2563 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-10-21Fix factory instance creation instabilityandre.schmid20-272/+216
Refactor the factory registry and instance creation. Remove unnecessary static code in Factory creation. Centralize the responsibility to read the factory registry configuration and cache the factory instances in a Singleton called FactoryRegistryManager. Clean the base abstract factory that was sharing non factory code, it had all the factory registry code statically, never used by the concrete factory classes. Change-Id: Ie2e9c29013acd36ddaf15383dd6b06432fbdbb66 Issue-ID: SDC-1905 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-10-16Changes for new service categoryatif husain6-6/+42
Introduced new service category, Partner Domain Service Added logic to disable composition for Partner Domain Service category Issue-ID: SDC-2382 Change-Id: I6ed135733c6f05914e102c037ebe9057ad731e75 Signed-off-by: Atif Husain <atif.husain@team.telstra.com>
2019-10-13El Alto known issuesOfir Sonsino1-1/+1
Change-Id: I293935d6a159691390bd90dd3fc2998821c97773 Issue-ID: SDC-2569 Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
2019-10-08Fix failing unit testvasraz1-132/+138
Issue-ID: SDC-2609 Change-Id: Ibf411a8d10af858ee2f42f9b4b565b81fee33ebe Signed-off-by: vasraz <vasyl.razinkov@est.tech>
2019-10-06Document fixed OJSI tickets in release notesKrzysztof Opasiak1-0/+7
Issue-ID: OJSI-31 Issue-ID: OJSI-76 Issue-ID: OJSI-77 Issue-ID: OJSI-78 Issue-ID: OJSI-79 Issue-ID: OJSI-80 Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com> Change-Id: Ie57bdbfae0b40ff7633ff674d22ac5ad3c5cf866
2019-10-04Revert "Sonar fix NullPointerException"Ofir Sonsino3-4/+6
This reverts commit b0f96a46e2720c75eb035bbe94015e5a1c6b0b32. Issue-ID: SDC-2542 Change-Id: I63b5349670c8e5fa814d686cfa93173d0ea6297e Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
2019-10-03Fix for error message.aribeiro7-28/+28
Fixing error message for invalid values across SDC backend API. Issue-ID: SDC-2324 Change-Id: If01307138baf7692e398abf20eb75bbe9a8aa394 Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
2019-10-03Add support for HTTPS in sanity testsPetr Ospalý15-22/+130
If 'disableHttp' is enabled then HTTP ports are replaced with HTTPS ports. Also added the latest trustore with AAF issuer. And because certs for SDC components have CN set to "sdc" - environment json must have the domain names correctly too...it will not work with plain IPs. The changes have been tested from CSIT perspective so if something is missing here or wrong then it is due to the fact that I was focusing on bringing https support to the same level as are http tests and there is also the fact that I do not know SDC component at all. The changes are also done in a manner of previous ones - hacked on top of the current codebase, which is in dire need of a rewrite: - duplicated trustores and other artifacts - duplicated scripts and/or similar script with small differences - ui tests use old ubuntu image vs api tests on alpine - chef codebase is very messy and I see no benefit in the current usage Issue-ID: SDC-2564 Signed-off-by: Petr Ospalý <p.ospaly@partner.samsung.com> Change-Id: I32e0fb7723ab8489eb09372d410c6f34aaf7cfc8
2019-10-03Add substitution mapping to sanity testandre.schmid1-0/+0
Change-Id: Ib970a5929f12144faa2e655f5f898c645feb17b7 Issue-ID: SDC-2282 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-10-03Sonar fix NullPointerExceptionArindam Mondal3-6/+4
Issue-ID: SDC-2542 Change-Id: I08a93932d2776c40a982bb802aeac994c1f35841 Signed-off-by: arindamm <arind.mondal@samsung.com>
2019-10-03Fix for closing sdc splashscreen.aribeiro1-0/+3
After loading, the SDC splashscreen will now disappear after a total of 4 seconds. Issue-ID: SDC-2258 Change-Id: I16629b2cf90f6cca0469ceb506128dabfc1ea3e1 Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
2019-10-02Update release notesOfir Sonsino1-79/+68
Change-Id: I4ea66e1bef928bb4d43d23e063d9af1c44aa1e8d Issue-ID: SDC-2569 Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
2019-09-18npm registry fixOfir Sonsino1-2/+1
Change-Id: I6e4b866c118b0c11518a0aff6fce59956b123013 Issue-ID: SDC-2560 Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
2019-09-10Bump SDC version 1.5.2Ofir Sonsino164-165/+165
Change-Id: Ib672dc8d60a0b6f4b37fd94afe84bc27dfba4c44 Issue-ID: SDC-2560 Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
2019-09-09Updated the sdc cert for ONAP namespace in the kubernetes.k.kedron15-16/+16
Issue-ID: SDC-2539 Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: I4dba563d5dd8b041a2a61076a9ccbabcc4d22316
2019-09-06fix a nested node type issueLiang Ding2-1/+11
the newly added node type is considered as nested when substitution_mapping is enabled in TOSCA yaml file Change-Id: Ibdee29d7a553c7b1ce085cbe971ceace6c4488f5 Issue-ID: SDC-2282 Signed-off-by: Liang Ding <liang.ding@intel.com>
2019-09-06Revert "Basic authorization for unsecured endpoint"andre.schmid2-144/+0
This reverts commit 34e04405 Change-Id: I6e27ce2d04b50417c3b0c9e5da217cbc57f8d277 Issue-ID: SDC-2556 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-09-04openecomp-be code coverage increasePiotr Darosz9-0/+285
Add tests for classes in sdc.vendorsoftwareproduct.types.schemagenerator package Change-Id: Iabd22f88a5106c881ee687a4b57a62f59c0bc10e Issue-ID: SDC-2326 Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
2019-09-04catalog-be code coverage increasePiotr Darosz3-29/+527
Add tests for DistributionCatalogServlet class Change-Id: I3da0460f09c803a0ec5a26bd2c7f70f36c6998a1 Issue-ID: SDC-2326 Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
2019-09-04unit tests - catalog-modelTomasz Golabek3-0/+246
Coverage increasing Change-Id: Idb7902578aca65eaee1a63871e9b84e3c4767233 Issue-ID: SDC-2326 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2019-09-04unit tests - NetworkPackageHealerTomasz Golabek2-373/+423
Additional junit tests using mockito Change-Id: I1a48d0dd15a3319dc096816ea36346f4b13322fc Issue-ID: SDC-2326 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2019-09-04common code coverage increasePiotr Darosz47-4/+1666
Add tests for classes in sdc.tosca.datatypes.model package Change-Id: Ifc277512d833b2501f0e594b9062d39c26565055 Issue-ID: SDC-2326 Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
2019-09-04openecomp-be code coverage increasePiotr Darosz5-0/+422
Add tests for classes in openecomp.core.model.types package Change-Id: I1c8044b2c8d422468dba610b2012e1cb34a75835 Issue-ID: SDC-2326 Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
2019-09-04unit tests - openecomp-sdcTomasz Golabek7-0/+234
Additional junit tests mostly for pojos Change-Id: I851d7df94b1e1c225d087b8881c3c1cd30867efb Issue-ID: SDC-2326 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2019-09-03Implement PNFD Model driven conversionandre.schmid102-523/+3677
Change-Id: I7427e82353cac17817457294d78953f867d2d6e8 Issue-ID: SDC-2509 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-09-03Onboard Package Handlingaribeiro23-303/+533
Retain the original onboarded package when it comes in zip/csar format. Issue-ID: SDC-2510 Change-Id: Ie293db25eca8872be26ffc8475b25ccace1aab6f Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
2019-09-03catalog-be code coverage increasePiotr Darosz1-27/+777
Increase code coverage in ResourcesServlet class Change-Id: I633da1a41d7266dd1b218814bf5d52de73c8d264 Issue-ID: SDC-2326 Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
2019-09-03unit tests - openecomp-sdcTomasz Golabek11-40/+248
Additional junit tests for action, type etc. Change-Id: I93b088035fca13db4fdcf9da0d58e7f01ee4f976 Issue-ID: SDC-2326 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2019-09-03unit tests - common-app-apiTomasz Golabek4-0/+236
Additional junit tests for common Change-Id: I79dd83e4de767652c019db292bdf7a23d9dca8a4 Issue-ID: SDC-2326 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2019-09-03openecomp-utilities-lib code coverage increasePiotr Darosz2-3/+66
Add tests for RequirementDefinitionDeserializer class Change-Id: I038f73fad4daa3eab931c566668359db9b5f6dc6 Issue-ID: SDC-2326 Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
2019-09-03unit tests - catalog-modelTomasz Golabek4-117/+182
Additional junit tests for be-model Change-Id: I7364cd33411d7f6eb69f9a02b2aea889c594ea7b Issue-ID: SDC-2326 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2019-09-03General Sonar fixesArindam Mondal5-22/+69
+)Organize imports ++) log formatter Issue-ID: SDC-2542 Change-Id: Ibb4b568b19ee40a68f783bfa820bd7c73aae5c1f Signed-off-by: arindamm <arind.mondal@samsung.com>
2019-09-03Fixed ready-probe filek.kedron2-3/+2
Fixed ready-probe script url endpoint. Issue-ID: SDC-2548 Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: Ibfc2d9199bd01678766810540df594d70812bd9e
2019-09-03catalog-be code coverage increasePiotr Darosz1-183/+955
Increase test code coverage in ElementServletTest Change-Id: I65d08d901f30c218e60b5630132d9eb8b4a90a9a Issue-ID: SDC-2326 Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
2019-09-03openecomp-be code coverage increasePiotr Darosz12-18/+336
Add tests for classes in generator.datatypes.tosca package Change-Id: Ic21b4e05d15e881016fa5f25113625bc441924c9 Issue-ID: SDC-2326 Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
2019-09-03openecomp-be code coverage increasePiotr Darosz18-6/+525
Add tests for classes in vendorsoftwareproduct.types.composition package Change-Id: I2b05536a4fd80021bfedd2e7ff0f1747f6227935 Issue-ID: SDC-2326 Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
2019-09-02unit tests - catalog-modelTomasz Golabek1-15/+154
Additional junit tests for ToscaListValueConverter Change-Id: I41e8b501129ceb0640e54e4173b3cdf13983ccd8 Issue-ID: SDC-2326 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2019-09-02Basic authorization for unsecured endpointm.kowalski32-0/+144
Issue-ID: OJSI-90 Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com> Change-Id: I3423d316e4853cfd5fa4aee50ad6506937bd6381
2019-09-02catalog-be code coverage increasePiotr Darosz2-0/+1007
Added tests for ArtifactExternalServlet Change-Id: Ic20e172e910f9c5e18d3f43f78a10a36c588f16d Issue-ID: SDC-2326 Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
2019-09-02unit tests - openecomp-beTomasz Golabek5-0/+171
Additional junit tests for zusammen models Change-Id: I4593d5c5dfd9619f36c69096462ed5de08b189f0 Issue-ID: SDC-2326 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2019-09-02testing common-app-api utils YamlToObjectConverterBartosz Gardziejewski1-0/+176
Issue-ID: SDC-2326 Signed-off-by: Bartosz Gardziejewski <bartosz.gardziejewski@nokia.com> Change-Id: I10fc2d7a35150e97b90a1c69c4faac949e439db3
2019-09-02unit tests - openecomp-bePiotr Darosz8-0/+335
Additional junit tests for dao-types Issue-ID: SDC-2326 Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com> Change-Id: I195610e66628d5d8546846592c98c726ba81824d
2019-09-01General sonar fixesArindam Mondal2-5/+1
+) Removed empty method ++)Removed unused import Issue-ID: SDC-2542 Change-Id: I9081e7c5f2b9329101c231ae18b4075e33219535 Signed-off-by: arindamm <arind.mondal@samsung.com>