summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-06-30Fix issue introduced by #109494vasraz1-7/+1
use maven checkstyle.skip remove duplicated dependency Change-Id: I942a9612df7093206d0019d69a8f28c6dff7bcf6 Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-3148
2020-06-30Fix test coverage drop introduced by #109510vasraz20-113/+36
Change-Id: Ic74f11f60ff7673330a8c3521da49a92f70ae0fb Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-3149
2020-06-29Fix for NullPointerException while onboarding VFKrupaNagabhushan1-1/+1
Issue-ID: SDC-3161 Signed-off-by: KrupaNagabhushan <krupa.nagabhushan@est.tech> Change-Id: I6eefcb86c6ef97fb19449e1fc45cee3cb91b3a2a
2020-06-25Rationalize maven dependenciesJulienBe58-531/+35
Issue-ID: SDC-3149 Signed-off-by: JulienBe <julien.bertozzi@intl.att.com> Change-Id: I1ee42494a4cc5b185b6dfcbee44399d2960cf880
2020-06-25Cleaned up ArtifactValidatorExecuter and IArtifactValidatorExecutorFrancis Toth19-286/+189
This commit intends to clean the tests related to ArtifactValidatorExecuter and IArtifactValidatorExecutor by introducing the concept of test contract. Some renaming have to be done to fix the typo in Executer (it should be named Executor), hence the number of changes. Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I5cd4512c425ae01f4f1118c9d61e6fce3df94f1d Issue-ID: SDC-2499
2020-06-25add a new profil for fast buildJulienBe13-1/+43
Issue-ID: SDC-3148 Signed-off-by: JulienBe <julien.bertozzi@intl.att.com> Change-Id: Ie98194fe6d136f57491a0590ab2afc9db59fbfbd
2020-06-25Fix Security VulnerabilityChrisC1-1/+1
Fix Sonar Major by switching to better protocol Issue-ID: SDC-3116 Signed-off-by: ChrisC <christophe.closset@intl.att.com> Change-Id: I9f5d8640c991ae895a41dadf67a11872952fe38a
2020-06-25Fix AssertChrisC1-3/+3
Fix Sonar Asserts Issue-ID: SDC-3116 Signed-off-by: ChrisC <christophe.closset@intl.att.com> Change-Id: I92dcd21a3cec903792c20275be8b955c5910e566
2020-06-24Fix for name clash in csar generationKrupaNagabhushan1-2/+6
Issue-ID: SDC-3144 Change-Id: Ia9b66bb14bbff3add70eed8dfe41acc55c72b35b Signed-off-by: KrupaNagabhushan <krupa.nagabhushan@est.tech>
2020-06-24Improvement sdc-BE-init python scriptsk.kedron18-105/+253
- Implemented retries when request fail - Moved configuration variables to the Properties file - Extended sdcBeProxy - Implemented script to run import/update (should fix deployment glitch) - Updated the import_Normatives recipes to use new script Issue-ID: SDC-2784 Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: I83fab898783ad8d3b3d532af43d75bc54d033c33
2020-06-24Refactoring the check backend, create consumersk.kedron13-174/+138
Continue refactoring: - added script for healthCheck, create new consumers - also update chef recipes to use new script Issue-ID: SDC-2784 Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: I158d816362f91f74b217fe85112cf7c14da8f1ec
2020-06-24Add Node Filter Business Logic Unit Testsaribeiro4-28/+509
Issue-ID: SDC-3125 Signed-off-by: aribeiro <anderson.ribeiro@est.tech> Change-Id: I80c755f4fffa813396ceb85c6aa7fde5b32590cd
2020-06-24Refactoring the sdc-BE-init python scriptsk.kedron75-3543/+1571
Deeper refactoring of python script: - create the python package with init script - support for python 3.x - reuse code - new design - support for .json conf file - update the docker chef script Issue-ID: SDC-2784 Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: I02169eb7d0e3e90851ba1811536d1712c3b4145f
2020-06-23Decouple TXT Report file writing and formatting logic (6/6)Francis Toth20-222/+136
This commit moves the writeReportLineToFile from ReportManager to ReportFile, deletes ReportManager (as it's not longer used), and finalizes the decoupling between the writing and the formatting logic of the TXT Report file. Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: Ia5cce71535ea808e6e24807ed62ae9b262eab6ad Issue-ID: SDC-2499
2020-06-23Decouple TXT Report file writing and formatting logic (5/6)Francis Toth6-36/+60
This commit aims to move the reportEndOfToolRun function from ReportManager (deprecated) to ReportFile. Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I17731864c34ed9a70b1b1e91b89bad835dc72449 Issue-ID: SDC-2499
2020-06-23Improve test coveragexuegao1-33/+4
Adding more tests to improve test coverage. Issue-ID: SDC-3129 Signed-off-by: xuegao <xg353y@intl.att.com> Change-Id: I23a717bfb6a0004e58ff3ca37d6dd877a956931e Signed-off-by: xuegao <xg353y@intl.att.com>
2020-06-23Refactor ToscaTypeTestxuegao2-29/+114
Adding more tests and adding assert for old tests. Issue-ID: SDC-3143 Signed-off-by: xuegao <xg353y@intl.att.com> Change-Id: Id7cf5ec763b0d43dece9493613e336a4b3df9b72 Signed-off-by: xuegao <xg353y@intl.att.com>
2020-06-22Decouple TXT Report file writing and formatting logic (4/6)Francis Toth4-23/+26
This commit aims to move the reportValidatorTypeSummary function from ReportManager (deprecated) to ReportFile. Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I30898d69bbcdb129a2dac917c4dee3c276556e91 Issue-ID: SDC-2499
2020-06-21Decouple TXT Report file writing and formatting logic (3/6)Francis Toth4-20/+23
This commit aims to move the printValidationTaskStatus function's logic from ReportManager (deprecated) to ReportFile. Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: Ic33a519f4c70276d404a83bf7de8a27f0007b285 Issue-ID: SDC-2499
2020-06-21Improve ActionUtil coverage and improve Sonar scoreJulienBe2-238/+317
Issue-ID: SDC-3133 Signed-off-by: JulienBe <julien.bertozzi@intl.att.com> Change-Id: I5e6f927599520efa5bfa5856863ca173ecdfb553 Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>
2020-06-21Toggletalio33-475/+706
Add toggling mechanism to catalog side. The first toggleable feature is healing - this was added to healing flow, in healJanusGraphDao Issue-ID: SDC-2874 Signed-off-by: talio <talio@amdocs.com> Change-Id: If386651cab8304ebaf13497ded3a7a50bd60e477 Signed-off-by: talio <talio@amdocs.com>
2020-06-21Add Node Filter Servlets Unit Testsaribeiro4-25/+515
Issue-ID: SDC-3117 Signed-off-by: aribeiro <anderson.ribeiro@est.tech> Change-Id: I84e728f21290a59c7674f97d5977b945b93ef546
2020-06-21Add Support for node_filtersaribeiro17-958/+1061
Allows for node_filter to be specified for a node template to provide processing instructions to the orchestrator Issue-ID: SDC-3095 Change-Id: I4e496e300552049d9bfd00df878b86d9fb97312b Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
2020-06-21Fix sonar issuessebdet4-33/+24
Fix sonar/checkstyle issues in sdc code Issue-ID: SDC-3116 Change-Id: I87802cc9edb378bdbe456c3ca4f10d8c6ebe9425 Signed-off-by: sebdet <sebastien.determe@intl.att.com>
2020-06-21Fix sonar issuessebdet1-380/+363
Fix sonar/checkstyle issues in sdc code Issue-ID: SDC-3116 Signed-off-by: sebdet <sebastien.determe@intl.att.com> Change-Id: I87802bb9edb378bdbe456c3ca4f10d8c6dae9437
2020-06-21Decouple TXT Report file writing and formatting logic (2/6)Francis Toth4-14/+15
This commit aims to move the reportStartValidatorRun function's logic from ReportManager (deprecated) to ReportFile. Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I93c2e8f98cdef598094647d734d0deec0f1941db Issue-ID: SDC-2499
2020-06-21Fix Assert usageChrisC1-244/+243
Sonar Fix, fix assert usage in this file Issue-ID: SDC-3116 Signed-off-by: ChrisC <christophe.closset@intl.att.com> Change-Id: I292649e84e589a35eb69139de53b3ee95223be26
2020-06-21fix sonar issues related to MessageContainer.javaJulienBe2-45/+108
Issue-ID: SDC-3127 Signed-off-by: JulienBe <julien.bertozzi@intl.att.com> Change-Id: I02357fa3cbf7afd7845737ba01c72dc202401882 Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>
2020-06-19Remove duplicate codexuegao1-17/+1
Removing duplicate code. Issue-ID: SDC-3132 Signed-off-by: xuegao <xg353y@intl.att.com> Change-Id: I595a791ebd7cb160d7149ea92a6434d52cfc9f48
2020-06-19Remove unused methodxuegao3-113/+54
Removing unused method in Constraint and use lombok annotations instead. Issue-ID: SDC-3130 Signed-off-by: xuegao <xg353y@intl.att.com> Change-Id: Ia718d184c55d40503f42830966bb11675b7c3f85 Signed-off-by: xuegao <xg353y@intl.att.com>
2020-06-19Fix Vulnerabilitiesxuegao4-38/+13
Fix the vulnerabilities reported by Sonar. Issue-ID: SDC-3114 Signed-off-by: xuegao <xg353y@intl.att.com> Change-Id: Icf97e427ef0c192b2f279380d7ee9eb570949d1f Signed-off-by: xuegao <xg353y@intl.att.com>
2020-06-19Fix Sonar issuesChrisC1-49/+46
Assert params updated to be in correct order Issue-ID: SDC-3116 Signed-off-by: ChrisC <christophe.closset@intl.att.com> Change-Id: I8be2dec4a1d5ec9ab59ea8fddab540958fe25511
2020-06-19Fix Sonar issuesChrisC1-20/+21
Assert params updated to be in correct order Issue-ID: SDC-3116 Signed-off-by: ChrisC <christophe.closset@intl.att.com> Change-Id: I10168defa289e45102f7f8aa436db8ca7176fe6a
2020-06-19Fix Sonar issuesChrisC1-3/+4
Fix assertThat usage and tests Issue-ID: SDC-3116 Signed-off-by: ChrisC <christophe.closset@intl.att.com> Change-Id: Ife533a479096047c4ccb7ae46dfaaa6e2ece974d
2020-06-19improve test coverageJulienBe1-0/+56
Issue-ID: SDC-3120 Signed-off-by: JulienBe <julien.bertozzi@intl.att.com> Change-Id: I8e02fcb3f495d70c14e6e9cf0304085d77918805
2020-06-19Decouple TXT Report file writing and formatting logic (1/6)Francis Toth15-49/+138
This commit is the first of a series aiming to decouple the writing and formatting logic of text report files in the asdc tool. Unfortunately because of a significant amount of technical debt, a small hack had to be done so that the header of the file is not written twice. This will be removed in a future change. Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I8d2a7c1353d59562d8026088824c26ae0daa36e9 Issue-ID: SDC-2499
2020-06-19Fix more doc warningsChrisC6-17/+17
Fix couple of doc warnings Issue-ID: SDC-1357 Signed-off-by: ChrisC <christophe.closset@intl.att.com> Change-Id: I3c195ab8d9caacce7dde5d8e9631a0fb7c2ea25a
2020-06-19datatypes.Constants:JulienBe7-88/+64
- adhere to naming conventions - remove unused Issue-ID: SDC-3126 Change-Id: I4ea23a8c69aaaf8fcc404868d3c59c47d09ba442 Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>
2020-06-18Importing VSP with node_type in separate fileMichaelMorris4-5/+88
Import fails when a node_type referenced in the main template is defined in a separate yaml file in the csar even when that separate file is correctly imported in the main template Change-Id: I6abe074585c2ce592fe9bed7abe76f0856bcfe93 Issue-ID: SDC-2850 Signed-off-by: MichaelMorris <michael.morris@est.tech>
2020-06-18create tests for ScalarUnitValidator.javaJulienBe2-2/+64
Issue-ID: SDC-3123 Change-Id: Iaa60ce2df46ee7a4d9138a56cf4d4c115a059240 Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>
2020-06-18create tests for PropertyTypeExt.java and remove unsused methodJulienBe2-44/+74
Issue-ID: SDC-3124 Change-Id: I5d3baeeff23c0003952eabc39a5f9dd296dd7c39 Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>
2020-06-18Decouple CSV Report file writing and formatting logicFrancis Toth11-62/+303
Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I6168b71bb54192a806ff6aa437788bedad933c76 Issue-ID: SDC-2499
2020-06-17Fix Java Code Conventions non-compliance issuesxuegao2-8/+4
Update locations of the constructor and private variable to comply with the Java Code Conventions. Issue-ID: SDC-3121 Signed-off-by: xuegao <xg353y@intl.att.com> Change-Id: I0114c880e389f0ed167262c9cd513583be35ba56 Signed-off-by: xuegao <xg353y@intl.att.com>
2020-06-17Reduce nest statement levelsxuegao1-32/+34
Reduce the if/for/switch/try nest statement levels to less than 3. Issue-ID: SDC-3119 Signed-off-by: xuegao <xg353y@intl.att.com> Change-Id: I60f0c0203db4495c6e10127114acdb8586867b14 Signed-off-by: xuegao <xg353y@intl.att.com>
2020-06-17Refactor ArtifactsBusinessLogic::getUpdatedGroupInstancesFrancis Toth1-23/+20
Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I6d62c1f916aa820f84328d25d2afbc7470397b0d Issue-ID: SDC-2961
2020-06-17Reduce nest statement levelsxuegao1-10/+11
Reduce the if/for/switch/try nest statement levels to less than 3. Issue-ID: SDC-3118 Signed-off-by: xuegao <xg353y@intl.att.com> Change-Id: I490e66a807a0a8508b7e3c1da332546f2ced3005
2020-06-17Extract ComponentCache from CsarUtilsFrancis Toth4-89/+306
This commit aims to decouple the component caching logic from CsarUtils to its own class. Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: Ia7e9284639ec8cd87ca5107e12f295e2eb599768 Issue-ID: SDC-2812
2020-06-17Support the substitution_mappings in the VNFDMichaelMorris3-10/+44
Signed-off-by: MichaelMorris <michael.morris@est.tech> Issue-ID: SDC-2957 Change-Id: I8a385b02568b3bf3d83a250cbe36a7e7f61e710c
2020-06-16Fix Sonar issuesChrisC2-24/+28
Hide implicit public constructor in utility class Issue-ID: SDC-3116 Signed-off-by: ChrisC <christophe.closset@intl.att.com> Change-Id: I4edd2ac37aab2fd587b5d46391dd669181385748
2020-06-16add information on the containers based on what is available in the wikiJulienBe1-2/+80
Issue-ID: SDC-2449 Change-Id: I740a14623161e051399f03d1788ae8a2605c1076 Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>