summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-05-28Allow global types generationaribeiro8-31/+234
This change allows to configure which global type file will be added to the generated CSAR Issue-ID: SDC-3021 Change-Id: I83c0c3f317c4a4e5e8dbf22cb3dbd47e63562d3a Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
2020-05-27Revert "Java 11 migration: fixing problems on 'catalog-fe'"aribeiro2-3/+8
This reverts commit 50906f4dcd00b0162298d1f86d72dcfc4d3caee9. Issue-ID: SDC-3088 Change-Id: I13c48243b3a137c7e66da1ef217a0ecbbd55f216 Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
2020-05-27Refactor CsarUtils::WriteArtifactDefinitionFrancis Toth4-70/+73
Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I167a05d8fbc2085a3e25eeb5bfd6b30f0e80462e Issue-ID: SDC-2812
2020-05-27Add ArtifactsBusinessLogic::fetchLatestComponentMetadataFrancis Toth1-43/+47
Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: Ibb8621a91551a2e4ffcac1145f85ed7983063d02 Issue-ID: SDC-2812
2020-05-27Work on unchecked Optional accessChris André1-21/+58
- extract code to static methods - throw an explicit exception now if element not found Issue-ID: SDC-2987 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I693bb53059b056235b567ac1f9f752a33512505a
2020-05-26Fix for locked componentaribeiro2-13/+22
After add, update or remove node_filter the component was left locked on SDC Issue-ID: SDC-3072 Change-Id: I27058760704bd6261619946becda3612a6386432 Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
2020-05-26Fix wrong tests directory structurevasraz6-0/+0
Change-Id: I0538e5ad56c9a77a0e9cb40d629739e979b67495 Issue-ID: SDC-3073 Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
2020-05-26Java 11 migration: fixing problem on 'openecomp-tosca-converter-core'Chris André1-2/+2
- Explicitely indicate the type associated with 'Collection' Issue-ID: SDC-3030 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I557eb205598c337b75b06a2c7d705276aeb543a1
2020-05-25Java 11 migration: fixing problems on 'catalog-fe'Chris André2-8/+3
- Upgrade `jersey-bom` version variable to the most recent stable one - Removed `jersey-common` version variable and replaced its references with `jersey-bom` Issue-ID: SDC-3036 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I414e3814d6d4fc1d927b302efb5dd08659676dc2
2020-05-25Refactor CsarUtil::addInnerComponentsToCSARFrancis Toth1-20/+36
Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I7f32d729a96f696c217631cd019105c17cb36a8c Issue-ID: SDC-2812
2020-05-24Support setting SDC-BE configuration at deployment timevasraz2-76/+77
Change-Id: Id1ebcb01d81b8e0cd681dcb304aa77bb3248d69c Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-3076
2020-05-24Fix potential NullPointer in SchemaFileImportandre.schmid1-10/+17
While reading the YAML to import, if the content was missing the entry node_types it was causing a NullPointerException. Also the exception was being suppressed, making very difficult to understand what happened. Change-Id: I44badbee1c739ddf6db08b4e518adb33c430fa84 Issue-ID: SDC-3070 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2020-05-24500 error at WFD artifact-deliveries apiBen David, Elad (eb7504)1-3/+4
Change-Id: I9227387c26b6ee4c68c635b78c4980a9c07b3d35 Issue-ID: SDC-3052 Signed-off-by: Ben David, Elad (eb7504) <eb7504@intl.att.com>
2020-05-24Work around potential NullPointerExceptions in ToscaElementLifecycleOperationChris André2-26/+252
- Rewrite of `checkinToscaELement` - Extracted methods from `checkinToscaELement` Issue-ID: SDC-2964 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I99d2c5aaa73b955ef5aa60eeb7644bb47ac12bd6
2020-05-21Refactor ArtifactsBusinessLogic::getRelatedComponentInstanceFrancis Toth1-51/+49
This commit aims to refactor the ArtifactsBusinessLogic::getRelatedComponentInstance, and getRelatedComponentComponentInstance. It improves how Either is used, fixes a potential NullPointerException, reduces some duplication along with cyclomatic complexity. Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I2503f5e2a697f793e4dcf32d7793f83c4a25ff46 Issue-ID: SDC-2812
2020-05-20Remove wildcard pattern when retrieving componentsFrancis Toth3-40/+71
This commit aims to remove a redundant cast while preparing the field for some Either refactoring in ArtifactsBusinessLogic. The reasons for removing the wildcard pattern are explained in SDC-3040 (a sub-task of SDC-2812). Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I573c01eca56f096ccb54e564d0144291121bde22 Issue-ID: SDC-2812
2020-05-20Refactor ArtifactsBusinessLogic::handleDeleteInternalFrancis Toth1-18/+42
This commit is a first step towards the ArtifactsBusinessLogic::handleDeleteInternal function refactoring. It aims to improve how Either is used, and to reduce its cyclomatic complexity along with some duplications. Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I1b476ccc0e0341975b80c10dc79c5dc1592267f4 Issue-ID: SDC-2812
2020-05-19remove powermock dependency from pom xmlsRodrigo Lima16-193/+18
- Remove powermock from pom xml files - Remove powermock from ActivityLogManagerFactoryImplTest Issue-ID: SDC-3071 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: I4c4b8b0751f4ce8895617a951429111fc08d8e2e
2020-05-19Add null test to ComponentInstanceBusinessLogicChris André1-55/+81
- Added test in `changeInstanceVersion` for null value Issue-ID: SDC-2908 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I42a428c4b245a55b7229e2ec9b781e9af4403662
2020-05-19Refactor ArtifactsBusinessLogic::generateAndSaveToscaArtifactFrancis Toth1-34/+30
This commit aims to make some minor refactoring related to the either used in ArtifactsBusinessLogic::generateAndSaveToscaArtifact. Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I4923e014146a17f1cd035db3513359a2ab8f38f2 Issue-ID: SDC-2812
2020-05-18Refactor CsarUtil::extractVfcArtifactFrancis Toth2-38/+58
Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: Ica8d17d4f3c763920f406ccb89fb3e464d05eab4 Issue-ID: SDC-2812
2020-05-18Refactor tosca representation retrieval in CsarUtils::populateZipFrancis Toth1-30/+56
This commit aims to simplify CsarUtils::populateZip by extracting how a tosca representation is fetched to another function. this enables to reduce the overall cyclomatic complexity of the function. Some additional work still needs to be done especially regarding the ToscaRepresentation and MainYamlWithDependencies classes (These happen to be really similar). This will be done in another change in the near future. Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I93600d0752565de523cf2285b1fa2ba43a96334f Issue-ID: SDC-2812
2020-05-18OrchestrationTemplateDaoZusammenImpl - Add tests for the presence of ↵Chris André1-28/+37
Optional values Issue-ID: SDC-3015 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: Iae0ce3d1b4bb5a72f04f0cd8a890c84eb15b214c
2020-05-17Remove powermock from ContextTrackerRodrigo Lima2-74/+78
- Remove powermock from ContextTrackerTest - Add package level constructor to ContextTracker to pass clear and put functions Issue-ID: SDC-3058 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: I82519538b763b00f2768801f06929773bfb58013
2020-05-17Remove powermock from ValidationConfigManagerTestRodrigo Lima1-8/+2
- Remove powermock reference from ValidationConfigManagerTest Issue-ID: SDC-3064 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: Ib330b0fcaf132e5d67f65b482a80b5b75f8c336b
2020-05-17Remove powermock from ArtifactValidationUtilsTestRodrigo Lima1-24/+17
- Remove powermock reference from ArtifactValidationUtilsTest - Use junit 5 imports instead of junit 4 Issue-ID: SDC-3067 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: I6388e133024ed1e7604e90fc24ba3e84a33da4f7
2020-05-17Remove powermock from ReportManagerTestRodrigo Lima1-19/+9
- Remove powermock reference from ReportManagerTest - Use Junit 5 imports instead of junit 4 Issue-ID: SDC-3066 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: Iece6e5741d5f2f5bc5db2ec7c85c63948776d601
2020-05-17Remove powermock from HostAddressCacheTestRodrigo Lima2-28/+51
- Remove powermock and easymock from HostAddressCacheTest - Add package level constructor to HostAddressCache and pass read address function to verified in unit test Issue-ID: SDC-3068 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: I749211393d9e0ecb3ff3b587dc0f811b58bb967c
2020-05-17sdc-backend-init does not restart on healthcheck failureFuss, Areli (af732p)2-1/+3
Issue-ID: SDC-3063 Change-Id: I6c4a796f42060832ee8a37a708dedda7e7e98c70 Signed-off-by: Fuss, Areli (af732p) <areli.fuss@intl.att.com>
2020-05-17Fix edit deployment artifact icon, and downloadTufman, Shay (st198j)1-5/+10
Change-Id: I9e66870b03fcc5edcea30a18809cf8a2c539e674 Issue-ID: SDC-3053 Signed-off-by: Tufman, Shay (st198j) <st198j@att.com>
2020-05-17Work around potential NullPointerExceptions in ComponentInstanceOperationChris André1-36/+37
- Rewrite of `updateAttributeValueInResourceInstance` Issue-ID: SDC-2923 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I1becdec8c10515976835e7d8fb0208b9cbad10bb
2020-05-12Add tests for the presence of Optional valuesChris André1-11/+20
Issue-ID: SDC-3014 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I041c0109c41bb1a716792074c004fd8f54857038
2020-05-12Increase test coverage - openecomp-sdc-vendor-software-product-corevasraz14-0/+568
Change-Id: I1af31c1f14d72fbc30a026f7ae787ae9d4b03b36 Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-3001
2020-05-12Remove powermock from SecurityManagerTestRodrigo Lima2-15/+10
- Add new package level constructor to SecurityManager - Remove powermock from SecurityManagerTest Issue-ID: SDC-3054 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: I04c53601f31d2aad84de8f8801f6889f8b9d4260
2020-05-12Remove unused ArtifactsBusinessLogic::updateArtifactsFlowForInterfaceOperationsFrancis Toth1-63/+0
This commit deletes the ArtifactsBusinessLogic::updateArtifactsFlowForInterfaceOperations function as it is no longer used anywhere. Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I1dd950930485fc83bb02c889dafc5461192accbc Issue-ID: SDC-2812
2020-05-12Remove outputFullFilePath from ValidationConfigManagerFrancis Toth35-673/+629
This commit aims to extract the outputFullFilePath field from ValidationConfigManager in order to improve testability. This commit contains multiple minor modifications resulting from bubbling up the outputFullFilePath static field to where it is actually set. Most of the modifications result from changing the signature of the functions which formerly relied on ValidationConfigManager.getOutputFullFilePath. Change-Id: I0a28e527cabe606de8af62b8dcbc4b4e70db98ed Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Issue-ID: SDC-2499
2020-05-11Fix security issues in SecurityUtilNeil Derraugh2-203/+0
- Removed hard coded key - Specified mode and padding to address risky algorithm Issue-ID: SDC-3017 Signed-off-by: Neil Derraugh <neil.derraugh@yoppworks.com> Change-Id: I6c21174003fcb5669de49158d8dd6bf9907f50c6
2020-05-11Refactor CsarUtil::writeComponentInterfaceFrancis Toth1-18/+22
Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I6a40119540c18469db44e218984b4d4b92d3f4af Issue-ID: SDC-2812
2020-05-11Refactor ArtifactsBusinessLogic::generateToscaArtifactFrancis Toth1-35/+55
This commit aims to refactor how Either is used in ArtifactsBusinessLogic::generateToscaArtifact. In order to keep the refactoring relatively small, we evalute its result at the call site. Change-Id: I669b30b44e9c69d1b3968fd719c5340b2dff83f5 Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Issue-ID: SDC-2812
2020-05-10Refactor to remove false positives from SonarChris André2-47/+111
- change `updateResourceInstancesNames` to account for case where `preparedResource` is null - change `findInputByName` to return an Either<InputDefinition, RuntimeException> in order to make exceptions explicit - create `rollbackWithEither` (+ tests) to make exceptions more explicit Issue-ID: SDC-2992 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I487994a3f9e88b0a2b14d2679c3587d85d8aa12d
2020-05-10Refactor ArtifactsBusinessLogic::handleDelete and ↵Francis Toth6-63/+53
ArtifactsBusinessLogic::deleteArtifactByInterface Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I89f12c70f388375ed13554edf62bf6a442c9036a Issue-ID: SDC-2812
2020-05-10Allow any extension to WORKFLOW artifact typeandre.schmid1-2/+0
Allow any extension to WORKFLOW artifact as it was before the artifact type configuration change SDC-2754. Change-Id: I6c497cd83e36fe4df0cc800b9301010c22aa79f7 Issue-ID: SDC-3019 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2020-05-10Remove powermock from ComponentProcessesImplTestRodrigo Lima2-44/+22
- Remove powermock from ComponentProcessesImplTest and add new constructor to ComponentProcessesImpl Issue-ID: SDC-3042 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: I1766371a42a65d6b11c9b7b6783a312db2ed723e
2020-05-10Remove powermock from NicsImplTestRodrigo Lima2-35/+16
- Remove powermock from NicsImplTest and add new constructor to NicsImpl Issue-ID: SDC-3043 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: Iec9343a403278f7db41d1654960c1060c3e75a99
2020-05-10Remove powermock from ImagesImplTestRodrigo Lima2-27/+17
- Remove powermock from ImagesImplTest and add new constructor to ImagesImpl Issue-ID: SDC-3038 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: I6439a90a71d9de94c2233f8b64fed9da4860dd2e
2020-05-10Remove powermock from ComponentDependenciesImplTestRodrigo Lima2-27/+15
- Remove powermock from ComponentDependenciesImplTest and add new constructor to ComponentDependenciesImpl Issue-ID: SDC-3027 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: I045e268230d94d4f52c4b85069eddade7678edee
2020-05-10Remove porwermock from ComponentImplTestRodrigo Lima2-27/+14
- Remove power mock from ComponentImplTest - Add new constructor to ComponentsImpl Issue-ID: SDC-3026 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: I919fdb55990d813f4ac2950e3950b28e4686acbc
2020-05-10Remove powermock from ComponentMonitoringUploadsImplTestRodrigo Lima2-31/+19
- Remove powermock from ComponentMonitoringUploadsImplTest. - Add new constructor to ComponentMonitoringUploadsImpl. Issue-ID: SDC-3024 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: Ic8583db9c459c4d39258129a3b70cc108b30d7de
2020-05-10Moved ArtifactsBusinessLogic::buildJsonStringForCsarVfcArtifact to JsonUtilsFrancis Toth4-28/+125
Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: Ia3bb9fe9f97e1759e4e5b70eb5e5396ed87d716d Issue-ID: SDC-2961
2020-05-10Remove powermock from ComputeImplTestRodrigo Lima2-35/+16
- Remove powermock from ComputeImplTest and add new constructor to ComputeImpl Issue-ID: SDC-3046 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: Idf3e67c52f1d65e059bbcfcda5a477e2398b0a3e