Age | Commit message (Collapse) | Author | Files | Lines |
|
This commit is a minor refactoring required to refactor CsarUtils::collectComponentInstanceArtifacts. In order to keep this commit small, we only focused CsarUtils::collectComponentTypeArtifacts, and removed any output that is not reflected by the function's result type. Modifying an argument is a actually a bad practice as explained in Clean Code by Robert Martin (cf. "Output arguments should be avoided"). This commit aims to enforce this aspect.
Change-Id: Ice4d6c9a78e7706c639dd60bc272253e298bc7be
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Issue-ID: SDC-2812
|
|
Remove unused/duplicated dependencies
Change-Id: Ic2239acc5ddde1d0874b5139c228934ec1e61cd0
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-2985
|
|
ExternalTestingImpl
Issue-ID: SDC-3003
Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com>
Change-Id: I720c6cf271a1444a584f42cdca2a7e4f2c59a85d
|
|
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I41994c98515844030eed1d6f2756c9779e864cff
Issue-ID: SDC-2812
|
|
This commit only intends to extract the inner static class ArtifactOperationInfo from the ArtifactsBusinessLogic class. In addition, getters have been added to get the artifactOperationEnum field's state (this allowed to reduce some boilerplate).
Change-Id: Ib79a75893ef11ba0d25e0578d7e95f60284589d0
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Issue-ID: SDC-2961
|
|
This commit aims to remove the Powermockito dependency from NetworksImplTest.
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I7eecb877f86a64514609e11fd9501f3fb972a866
Issue-ID: SDC-2984
|
|
- Remove powermockit from ApiTest. Add new constructor to ExternalTestingImpl in order to pass
vendorSoftwareProductManager param.
Issue-ID: SDC-3003
Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com>
Change-Id: Ibdaa12a986557dbf1d4cdf6d4c1952ba642582cf
|
|
Change-Id: I86e4935fd418bb01971f21ae32351be6044a2566
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-3001
|
|
Change-Id: Ifaaf73998ee0f7df66082fdc4963b4c05678e5c1
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-3001
|
|
This commit aims to refactor the CsarUtils::validateNonMetaArtifact function and make it up to standards regarding how fj.Either should be used.
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: Icadfce7229839e53bd09926b6865f2872c39d1a5
Issue-ID: SDC-2812
|
|
It creates a index.html page that will end up in the
onboarding-FE .war file. When the /onboarding context
is accessed, a blank page will show up instead of the
contents of the .war.
Change-Id: I0fb4be28e193e6e6bbd58c1af9a49d5750981b7e
Issue-ID: SDC-3000
Signed-off-by: andre.schmid <andre.schmid@est.tech>
|
|
Change-Id: I00c9cf90d7486af33955acae7dfe653e14ceebdc
Issue-ID: SDC-2997
Signed-off-by: Ben David, Elad (eb7504) <eb7504@intl.att.com>
|
|
Issue-ID: SDC-2989
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I7fe273d869035f8852dbc398de60cc49dec2ce6e
|
|
- Remove the use of mockito verify from TypeUtilsTest
Issue-ID: SDC-2993
Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com>
Change-Id: I42c9c972cead10afaa3ec299624cf3d26e4d04db
|
|
Change-Id: Ib9e4eb054cd23db9359b6d4db4ce079007c1e4e7
Issue-ID: SDC-2963
Signed-off-by: andre.schmid <andre.schmid@est.tech>
|
|
Change-Id: Ia42775388c3ad9539b7d0020476f0f7a91ce8bb9
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-2938
|
|
- change in the final condition of `isGenerateGroupUUID`
- Added tests related to modified code
Issue-ID: SDC-2913
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I22738f9f4922467209a16a4d6b3b78d7bfac11c9
|
|
Change-Id: I1732ae05cfbe93c1bef8c249e16088a0cad34106
Issue-ID: SDC-2812
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
|
|
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I136ebda0ff92d6c42368f102ccf2b10f37524808
Issue-ID: SDC-2812
|
|
This commit aims to extract the csvReportFilePath field from ValidationConfigManager in order to improve testability. This commit contains multiple minor modifications resulting from bubbling up the csvReportFilePath static field to where it is actually set. Put differently, most of the modifications result from changing the signature of the functions which formerly relied on ValidationConfigManager.getCSVReportFilePath.
Change-Id: I82c3b0fca8a0f407319e40ecfff45e89ec1d4323
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Issue-ID: SDC-2499
|
|
- Replace null return values with empty Map objects
Issue-ID: SDC-2928
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I3357a8789a00201a7ffda1dbf0be5f08cbb9c33b
|
|
Configures jest test coverage and missing sonar
properties for javascript file scan and report.
Change-Id: I9170a176cc4e580ac14f669c334ee949942503f6
Issue-ID: SDC-2741
Signed-off-by: andre.schmid <andre.schmid@est.tech>
|
|
- Check name and value in method setToscaPresentationValue
Issue-ID: SDC-2926
Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com>
Change-Id: I0d66b29c84139afff92065769bf1b79082959333
|
|
- Added test in `getFilteredComponentInstanceProperties` for null value
- Removed nested `if` statements in `isMatchingComplexPropertyByRecursively`
Issue-ID: SDC-2907
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I13a47b0dfe7aa6dec845a856c58bba8be5c1eead
|
|
To add an operation with an existing Workflow in a RESOURCE,
the Artifact Type WORKFLOW needs to support the extension
"bpmn" and the component type "RESOURCE".
Change-Id: Ic7eb9afe3ced0348f7aadcc43edf121a0bdcf015
Issue-ID: SDC-2954
Signed-off-by: andre.schmid <andre.schmid@est.tech>
|
|
Fixes potential NPE in ArtifactsBusinessLogic introduced by SDC-2754.
Change-Id: If53915ffc41ddd0dbcf00ea318cdae6f1b5471ad
Issue-ID: SDC-2959
Signed-off-by: andre.schmid <andre.schmid@est.tech>
|
|
- Formatting code following project's code style
- Added early check for null value for `containerV`
Issue-ID: SDC-2905
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I648e9a4a04be3f2e7cd3e30a70c04de2257a99d3
|
|
- Changed String representing encoding to Java's StandardCharsets.UTF_8
- Added explicit else condition in order to not rely on `abortWith`'s side effects
Issue-ID: SDC-2917
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I81cb94c399ff1d810e85c7b63fde195928ab1b08
|
|
- Change `isPropertiesListSizesNotEquals` to `isPropertiesListSizesEquals`
- Added assertions to silence SonarCloud
Issue-ID: SDC-2914
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I88003de54aea6c28575fecf0f41b4c5ef36ef154
|
|
Issue-ID: SDC-2911
Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com>
Change-Id: Ic7f0ef631ed98e8baf2ea32b6bfc56a7142738f8
|
|
- check if instanceId null in method isNotEmptyMapOfProperties
Issue-ID: SDC-2920
Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com>
Change-Id: I70667142ed51834de638903ccae4ffcb896cccab
|
|
Change-Id: I06462b6180a1f1a310aae994f4e703a498f80247
Issue-ID: SDC-2933
Signed-off-by: Baumel, Dvir (db384r) <dvir.baumel@intl.att.com>
|
|
Issue-ID: SDC-2890
Change-Id: I1559ebc60076bd0884ae1136c9c904f7ab46e72e
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
|
|
Signed-off-by: Reo Inoue <inoue.reo@jp.fujitsu.com>
Issue-ID: SDC-2931
Change-Id: I6b40f538ff9ce7eed22ce71c542b188a8c866f26
|
|
- Added test in `handleAuditingDaoResponse` for null value related to `resAuditingGenericEvent`
Issue-ID: SDC-2909
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I422629cdbd4f05e10609cd78b7328c4e9f45538b
|
|
- check if parentResource null in methods setRequirements and setCapabilities
Issue-ID: SDC-2912
Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com>
Change-Id: I1ea5a8cf26e3883b5d26fb970bc0abc4cbf1ee9a
|
|
- Added if statement in `updateArtifactOnGraph` to account for the case where variable `artifactInst` has not been properly initialized
Issue-ID: SDC-2919
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I73fe3b3bcef59e5797a0f7cfe7b6894816d0d3fb
|
|
- Fixed typo in a call to `logger.debug`
- Modified if statement following recommendation from SonarCloud
Issue-ID: SDC-2918
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I75d50d74703bf7c706b84723bb5d43760b8b7baf
|
|
Issue-ID: SDC-2915
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I4e6f27b707b1bdbbecf9a97606c9a655d834fe56
|
|
Issue-ID: SDC-2916
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: Ieb0a79c8d3a891a08cd758e1a4ebab7679166476
|
|
Change-Id: Ie410001eae688aa9d0c579f35eb57eeebfe9ae08
Issue-ID: SDC-2934
Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
|
|
Fixes webpack dev server proxy to uicache removed in
SDC-2843, Change Id: I9a6c89e45ea425eb9abf827906562e14a39cf1ff.
Change-Id: I83aa842df4c7bf3d140216c93b48eb1cfec48656
Issue-ID: SDC-2944
Signed-off-by: andre.schmid <andre.schmid@est.tech>
|
|
Fixes webpack workflow proxy configuration.
Fixes FE proxy while rewriting URLs to workflow plugin.
Fixes compilation problems to run locally the catalog-ui.
Change-Id: I89f3f46bd8ce0159713b1d0d957a2e75f8a3d062
Issue-ID: SDC-2943
Signed-off-by: andre.schmid <andre.schmid@est.tech>
|
|
ESAPI encoder cannot be loaded due to a missing ESAPI.properties file
in path, which causes an exception and breaks the online checking call.
The plugin is always shown as offline.
Change-Id: I05088d200e9a1bea1de2e00c07d5bbf6e3a67d41
Issue-ID: SDC-2945
Signed-off-by: andre.schmid <andre.schmid@est.tech>
|
|
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I1c3a845c44722010e8933876e59752cef00937f0
Issue-ID: SDC-2499
|
|
Fix issue in SdcSchemaFileImport "STDERR: Error in file creation :
data, /tmp/sdctool/tosca/data-types/data.yml
(No such file or directory)", during the cassandra init.
Introduced by SDC-2898.
Change-Id: Ifd2018fac456f15d03fc39ea766a6ae0c3eda081
Issue-ID: SDC-2939
Signed-off-by: andre.schmid <andre.schmid@est.tech>
|
|
Generic Artifact Browser is failing in tests due
to an assertion problem.
Change-Id: Ib398d04f0a876ae7d531af14e129f0dc6838dd52
Issue-ID: SDC-2903
Signed-off-by: andre.schmid <andre.schmid@est.tech>
|
|
Issue-ID: SDC-2898
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I0a0163937ee2e760f3074d858dfc68a7b262ecd9
|
|
- Formatting code following project's code style
- Added early check for null value for `containerV`
Issue-ID: SDC-2904
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: Ib8d7c1bf36608855c73d8a0df637e86aefce9377
|
|
Remove duplicated entries
Default value for Boolean type should not be a String
According to the description for the keyname 'attachments:' it should be of type List rather than String
Issue-ID: SDC-2870
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
Change-Id: Iac2b4f89dac16a6aef9dcabea74def5cacff99a6
|