1 files changed, 409 insertions, 0 deletions
diff --git a/openecomp-be/backend/openecomp-sdc-vendor-software-product-manager/src/test/java/org/openecomp/sdc/vendorsoftwareproduct/impl/DeplomentFlavorManagerImplTest.java b/openecomp-be/backend/openecomp-sdc-vendor-software-product-manager/src/test/java/org/openecomp/sdc/vendorsoftwareproduct/impl/DeplomentFlavorManagerImplTest.java
new file mode 100644
index 0000000000..e082b25435
--- /dev/null
+++ b/openecomp-be/backend/openecomp-sdc-vendor-software-product-manager/src/test/java/org/openecomp/sdc/vendorsoftwareproduct/impl/DeplomentFlavorManagerImplTest.java
@@ -0,0 +1,409 @@
+package org.openecomp.sdc.vendorsoftwareproduct.impl;
+
+
+import static org.mockito.Matchers.anyObject;
+import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.verify;
+
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+import org.mockito.Spy;
+import org.openecomp.core.utilities.json.JsonUtil;
+import org.openecomp.sdc.common.errors.CoreException;
+import org.openecomp.sdc.vendorsoftwareproduct.dao.ComponentDao;
+import org.openecomp.sdc.vendorsoftwareproduct.dao.ComputeDao;
+import org.openecomp.sdc.vendorsoftwareproduct.dao.DeploymentFlavorDao;
+import org.openecomp.sdc.vendorsoftwareproduct.dao.VendorSoftwareProductInfoDao;
+import org.openecomp.sdc.vendorsoftwareproduct.dao.type.ComponentEntity;
+import org.openecomp.sdc.vendorsoftwareproduct.dao.type.ComputeEntity;
+import org.openecomp.sdc.vendorsoftwareproduct.dao.type.DeploymentFlavorEntity;
+import org.openecomp.sdc.vendorsoftwareproduct.dao.type.VspDetails;
+import org.openecomp.sdc.vendorsoftwareproduct.errors.VendorSoftwareProductErrorCodes;
+import org.openecomp.sdc.vendorsoftwareproduct.services.composition.CompositionEntityDataManager;
+import org.openecomp.sdc.vendorsoftwareproduct.types.CompositionEntityResponse;
+import org.openecomp.sdc.vendorsoftwareproduct.types.QuestionnaireResponse;
+import org.openecomp.sdc.vendorsoftwareproduct.types.composition.Component;
+import org.openecomp.sdc.vendorsoftwareproduct.types.composition.ComponentComputeAssociation;
+import org.openecomp.sdc.vendorsoftwareproduct.types.composition.CompositionEntityType;
+import org.openecomp.sdc.vendorsoftwareproduct.types.composition.CompositionEntityValidationData;
+import org.openecomp.sdc.vendorsoftwareproduct.types.composition.DeploymentFlavor;
+import org.openecomp.sdc.versioning.dao.types.Version;
+import org.openecomp.sdc.versioning.errors.VersioningErrorCodes;
+import org.testng.Assert;
+import org.testng.annotations.BeforeMethod;
+import org.testng.annotations.Test;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.List;
+
+public class DeplomentFlavorManagerImplTest {
+  private static final String USER = "depFlavorTestUser";
+  private static final String VSP_ID = "VSP_ID";
+  private static final Version VERSION = new Version(0, 1);
+  private static final String COMPONENT_ID = "COMPONENT_ID";
+  private static final String DF1_ID = "df1";
+  private static final String DF2_ID = "df2";
+
+  @Mock
+  private CompositionEntityDataManager compositionEntityDataManagerMock;
+  @Mock
+  private VendorSoftwareProductInfoDao vspInfoDao;
+  @Mock
+  DeploymentFlavorDao deploymentFlavorDaoMock;
+  @Mock
+  ComponentDao componentDaoMock;
+  @Mock
+  ComputeDao computeDaoMock;
+  @InjectMocks
+  @Spy
+  private DeploymentFlavorManagerImpl deploymentFlavorManager;
+
+  @BeforeMethod
+  public void setUp() throws Exception {
+    MockitoAnnotations.initMocks(this);
+  }
+
+  @Test
+  public void testListWhenNone() {
+    final Collection<DeploymentFlavorEntity> deploymentFlavorEntities =
+        deploymentFlavorManager.listDeploymentFlavors(VSP_ID, VERSION,  USER);
+    Assert.assertEquals(deploymentFlavorEntities.size(), 0);
+  }
+
+  @Test
+  public void testCreateOnNotManual_negative() {
+
+    testCreate_negative(new DeploymentFlavorEntity(VSP_ID, VERSION,  null), USER,
+        VendorSoftwareProductErrorCodes.CREATE_DEPLOYMENT_FLAVOR_NOT_ALLOWED_IN_HEAT_ONBOARDING);
+  }
+
+  @Test
+  public void testCreateManualDepFlavor() {
+    DeploymentFlavorEntity expected = createDeploymentFlavor(VSP_ID, VERSION,  DF1_ID);
+    doReturn(true).when(vspInfoDao).isManual(anyObject(), anyObject());
+
+    VspDetails vspDetails = new VspDetails(VSP_ID, VERSION);
+    doReturn(vspDetails).when(vspInfoDao).get(anyObject());
+
+    deploymentFlavorManager.createDeploymentFlavor(expected, USER);
+    verify(compositionEntityDataManagerMock).createDeploymentFlavor(expected);
+  }
+
+  @Test
+  public void testCreateManualDepFlavorWithDuplicateName() {
+    DeploymentFlavorEntity expected = createDeploymentFlavor(VSP_ID, VERSION, DF1_ID);
+    doReturn(true).when(vspInfoDao).isManual(anyObject(), anyObject());
+
+    DeploymentFlavorEntity expectedDiffName = createDeploymentFlavor(VSP_ID, VERSION, DF1_ID);
+    DeploymentFlavor deploymentFlavor = expectedDiffName.getDeploymentFlavorCompositionData();
+    deploymentFlavor.setModel(DF1_ID + " Name");
+    expectedDiffName.setDeploymentFlavorCompositionData(deploymentFlavor);
+    List<DeploymentFlavorEntity> list = new ArrayList<DeploymentFlavorEntity>();
+    list.add(expectedDiffName);
+    doReturn(list).when(deploymentFlavorDaoMock).list(anyObject());
+
+    try {
+      deploymentFlavorManager.createDeploymentFlavor(expected, USER);
+      Assert.fail();
+    }
+    catch (CoreException ex) {
+      Assert.assertEquals(VendorSoftwareProductErrorCodes.DUPLICATE_DEPLOYMENT_FLAVOR_MODEL_NOT_ALLOWED,
+          ex.code().id());
+    }
+  }
+
+  @Test
+  public void testCreateManualDepFlavorWithFGNotInVSP() {
+    DeploymentFlavorEntity expected = createDeploymentFlavor(VSP_ID, VERSION, DF1_ID);
+    final DeploymentFlavor deploymentFlavor =
+        JsonUtil.json2Object(expected.getCompositionData(), DeploymentFlavor.class);
+    deploymentFlavor.setFeatureGroupId("fg3");
+    expected.setCompositionData(JsonUtil.object2Json(deploymentFlavor));
+
+    doReturn(true).when(vspInfoDao).isManual(anyObject(), anyObject());
+
+    List<String> featureGrps = new ArrayList<String>();
+    featureGrps.add("fg1");
+    featureGrps.add("fg2");
+
+    VspDetails vspDetails = new VspDetails(VSP_ID, VERSION);
+    vspDetails.setFeatureGroups(featureGrps);
+    doReturn(vspDetails).when(vspInfoDao).get(anyObject());
+
+
+    try {
+      deploymentFlavorManager.createDeploymentFlavor(expected, USER);
+      Assert.fail();
+    }
+    catch (CoreException ex) {
+      Assert.assertEquals(VendorSoftwareProductErrorCodes.FEATURE_GROUP_NOT_EXIST_FOR_VSP,
+          ex.code().id());
+    }
+  }
+
+  @Test
+  public void testCreateManualDepFlavorWithNullCompInAssociation() {
+    DeploymentFlavorEntity expected = createDeploymentFlavor(VSP_ID, VERSION,  DF1_ID);
+    final DeploymentFlavor deploymentFlavor =
+        JsonUtil.json2Object(expected.getCompositionData(), DeploymentFlavor.class);
+    ComponentComputeAssociation association = new ComponentComputeAssociation();
+    association.setComponentId(null);
+    association.setComputeFlavorId("CF1");
+    List<ComponentComputeAssociation> list = new ArrayList<ComponentComputeAssociation>();
+    list.add(association);
+    deploymentFlavor.setComponentComputeAssociations(list);
+    expected.setCompositionData(JsonUtil.object2Json(deploymentFlavor));
+
+    doReturn(true).when(vspInfoDao).isManual(anyObject(), anyObject());
+
+    VspDetails vspDetails = new VspDetails(VSP_ID, VERSION);
+    doReturn(vspDetails).when(vspInfoDao).get(anyObject());
+
+    try {
+      deploymentFlavorManager.createDeploymentFlavor(expected, USER);
+    }
+    catch (CoreException ex) {
+      Assert.assertEquals(VendorSoftwareProductErrorCodes.INVALID_COMPONENT_COMPUTE_ASSOCIATION,
+          ex.code().id());
+      Assert.assertEquals("Invalid request,for valid association please provide ComponentId for Compute Flavor",
+          ex.getMessage());
+    }
+  }
+
+  @Test
+  public void testCreateManualDepFlavorWithInvalidComputeInAssociation() {
+    DeploymentFlavorEntity expected = createDeploymentFlavor(VSP_ID, VERSION,  DF1_ID);
+    final DeploymentFlavor deploymentFlavor =
+        JsonUtil.json2Object(expected.getCompositionData(), DeploymentFlavor.class);
+    ComponentComputeAssociation association = new ComponentComputeAssociation();
+    association.setComponentId(COMPONENT_ID);
+    association.setComputeFlavorId("CF1");
+    List<ComponentComputeAssociation> list = new ArrayList<ComponentComputeAssociation>();
+    list.add(association);
+    deploymentFlavor.setComponentComputeAssociations(list);
+    expected.setCompositionData(JsonUtil.object2Json(deploymentFlavor));
+
+    doReturn(true).when(vspInfoDao).isManual(anyObject(), anyObject());
+
+    VspDetails vspDetails = new VspDetails(VSP_ID, VERSION);
+    doReturn(vspDetails).when(vspInfoDao).get(anyObject());
+
+    ComponentEntity component = new ComponentEntity(VSP_ID, VERSION, USER);
+    doReturn(component).when(componentDaoMock).get(anyObject());
+
+    doReturn(null).when(computeDaoMock).get(anyObject());
+
+    try {
+      deploymentFlavorManager.createDeploymentFlavor(expected, USER);
+    }
+    catch (CoreException ex) {
+      Assert.assertEquals(VendorSoftwareProductErrorCodes.INVALID_COMPUTE_FLAVOR_ID,
+          ex.code().id());
+    }
+  }
+
+  @Test
+  public void testCreateManualDepFlavorWithDuplicateVfcAssociation() {
+    DeploymentFlavorEntity expected = createDeploymentFlavor(VSP_ID, VERSION,  DF1_ID);
+    final DeploymentFlavor deploymentFlavor =
+        JsonUtil.json2Object(expected.getCompositionData(), DeploymentFlavor.class);
+    ComponentComputeAssociation association = new ComponentComputeAssociation();
+    association.setComponentId(COMPONENT_ID);
+    association.setComputeFlavorId("CF1");
+    List<ComponentComputeAssociation> list = new ArrayList<ComponentComputeAssociation>();
+    list.add(association);
+    list.add(association);
+    deploymentFlavor.setComponentComputeAssociations(list);
+    expected.setCompositionData(JsonUtil.object2Json(deploymentFlavor));
+
+    doReturn(true).when(vspInfoDao).isManual(anyObject(), anyObject());
+
+    VspDetails vspDetails = new VspDetails(VSP_ID, VERSION);
+    doReturn(vspDetails).when(vspInfoDao).get(anyObject());
+
+    ComponentEntity component = new ComponentEntity(VSP_ID, VERSION, USER);
+    doReturn(component).when(componentDaoMock).get(anyObject());
+
+    ComputeEntity computeEntity = new ComputeEntity(VSP_ID, VERSION, COMPONENT_ID, "CF1");
+    doReturn(computeEntity).when(computeDaoMock).get(anyObject());
+
+    try {
+      deploymentFlavorManager.createDeploymentFlavor(expected, USER);
+    }
+    catch (CoreException ex) {
+      Assert.assertEquals(VendorSoftwareProductErrorCodes.SAME_VFC_ASSOCIATION_MORE_THAN_ONCE_NOT_ALLOWED,
+          ex.code().id());
+    }
+  }
+
+  @Test
+  public void testList() {
+
+    doReturn(Arrays.asList(
+        createDeploymentFlavor(VSP_ID, VERSION,  DF1_ID),
+        createDeploymentFlavor(VSP_ID, VERSION,  DF2_ID)))
+        .when(deploymentFlavorDaoMock).list(anyObject());
+
+
+    final Collection<DeploymentFlavorEntity> deploymentFlavorEntities =
+        deploymentFlavorManager.listDeploymentFlavors(VSP_ID, VERSION,  USER);
+    Assert.assertEquals(deploymentFlavorEntities.size(), 2);
+    for (DeploymentFlavorEntity deploymentFlavorEntity : deploymentFlavorEntities) {
+      Assert.assertEquals(deploymentFlavorEntity.getDeploymentFlavorCompositionData().getModel()
+          , DF1_ID.equals(deploymentFlavorEntity.getId()) ? DF1_ID+" name" : DF2_ID+" name" );
+    }
+  }
+
+  @Test
+  public void testUpdateHeatDepFlavor() {
+    testUpdate_negative(VSP_ID, VERSION, DF1_ID, USER,
+        VendorSoftwareProductErrorCodes.EDIT_DEPLOYMENT_FLAVOR_NOT_ALLOWED_IN_HEAT_ONBOARDING);
+  }
+
+  @Test
+  public void testUpdateNonExistingManualDepFlavorId_negative() {
+    doReturn(true).when(vspInfoDao).isManual(anyObject(), anyObject());
+    testUpdate_negative(VSP_ID, VERSION, DF1_ID, USER,
+        VersioningErrorCodes.VERSIONABLE_SUB_ENTITY_NOT_FOUND);
+  }
+
+  @Test
+  public void testManualUpdateDepFlavor() {
+    doReturn(true).when(vspInfoDao).isManual(anyObject(), anyObject());
+
+    doReturn(createDeploymentFlavor(VSP_ID, VERSION, DF1_ID))
+        .when(deploymentFlavorDaoMock).get(anyObject());
+
+    doReturn(new CompositionEntityValidationData(CompositionEntityType.image, DF1_ID))
+        .when(compositionEntityDataManagerMock)
+        .validateEntity(anyObject(), anyObject(), anyObject());
+
+    VspDetails vspDetails = new VspDetails(VSP_ID, VERSION);
+    doReturn(vspDetails).when(vspInfoDao).get(anyObject());
+
+    DeploymentFlavorEntity deploymentFlavorEntity = new DeploymentFlavorEntity(VSP_ID, VERSION, DF1_ID);
+    DeploymentFlavor deploymentFlavor = new DeploymentFlavor();
+    deploymentFlavor.setModel(DF1_ID + " name");
+    deploymentFlavor.setDescription(DF1_ID + " desc updated");
+    deploymentFlavorEntity.setDeploymentFlavorCompositionData(deploymentFlavor);
+
+    CompositionEntityValidationData validationData =
+        deploymentFlavorManager.updateDeploymentFlavor(deploymentFlavorEntity, USER);
+    Assert.assertTrue(validationData == null || validationData.getErrors() == null);
+    verify(deploymentFlavorDaoMock).update(deploymentFlavorEntity);
+  }
+
+  @Test
+  public void testGetNonExistingDepFlavorId_negative() {
+    testGet_negative(VSP_ID, VERSION, "non existing image id", USER,
+        VersioningErrorCodes.VERSIONABLE_SUB_ENTITY_NOT_FOUND);
+  }
+
+  @Test
+  public void testGet() {
+    DeploymentFlavorEntity expected = createDeploymentFlavor(VSP_ID, VERSION, DF1_ID);
+    doReturn(expected).when(deploymentFlavorDaoMock).get(anyObject());
+
+    VspDetails vspDetails = new VspDetails(VSP_ID, VERSION);
+    doReturn(vspDetails).when(vspInfoDao).get(anyObject());
+
+    CompositionEntityResponse<DeploymentFlavor> response =
+        deploymentFlavorManager.getDeploymentFlavor(VSP_ID, VERSION, DF1_ID, USER);
+    Assert.assertEquals(response.getId(), expected.getId());
+    Assert.assertEquals(response.getData().getModel(), expected.getDeploymentFlavorCompositionData().
+        getModel());
+    Assert.assertEquals(response.getData().getDescription(), expected.getDeploymentFlavorCompositionData().
+        getDescription());
+  }
+
+  @Test
+  public void testDeleteDepFlavorOnHEAT() {
+    DeploymentFlavorEntity expected = createDeploymentFlavor(VSP_ID, VERSION, DF1_ID);
+    doReturn(expected).when(deploymentFlavorDaoMock).get(anyObject());
+    testDelete_negative(VSP_ID, VERSION,  DF1_ID, USER,
+        VendorSoftwareProductErrorCodes.DELETE_DEPLOYMENT_FLAVOR_NOT_ALLOWED_IN_HEAT_ONBOARDING);
+  }
+
+  @Test
+  public void testDeleteOnNotExistImage() {
+    testDelete_negative(VSP_ID, VERSION,  DF1_ID, USER,
+        VersioningErrorCodes.VERSIONABLE_SUB_ENTITY_NOT_FOUND);
+  }
+
+  @Test
+  public void testDeleteOnManualImage() {
+    DeploymentFlavorEntity expected = createDeploymentFlavor(VSP_ID, VERSION, DF1_ID);
+    doReturn(expected).when(deploymentFlavorDaoMock).get(anyObject());
+    doReturn(true).when(vspInfoDao).isManual(anyObject(), anyObject());
+    deploymentFlavorManager.deleteDeploymentFlavor(VSP_ID, VERSION, DF1_ID, USER);
+    verify(deploymentFlavorDaoMock).delete(anyObject());
+  }
+
+  private void testList_negative(String vspId, Version version, String componentId, String user,
+                                 String expectedErrorCode, String expectedErrorMsg) {
+    try {
+      deploymentFlavorManager.listDeploymentFlavors(vspId, version, user);
+      Assert.fail();
+    } catch (CoreException exception) {
+      Assert.assertEquals(exception.code().id(), expectedErrorCode);
+      Assert.assertEquals(exception.getMessage(), expectedErrorMsg);
+    }
+  }
+
+  private void testCreate_negative(DeploymentFlavorEntity deploymentFlavorEntity, String user, String
+      expectedErrorCode) {
+    try {
+      deploymentFlavorManager.createDeploymentFlavor(deploymentFlavorEntity, user);
+      Assert.fail();
+    } catch (CoreException exception) {
+      Assert.assertEquals(exception.code().id(), expectedErrorCode);
+    }
+  }
+
+  private void testDelete_negative(String vspId, Version version, String deploymentFlavorId,
+                                   String user,
+                                   String expectedErrorCode) {
+    try {
+      deploymentFlavorManager.deleteDeploymentFlavor(vspId, version, deploymentFlavorId, user);
+      Assert.fail();
+    } catch (CoreException exception) {
+      Assert.assertEquals(exception.code().id(), expectedErrorCode);
+    }
+  }
+
+  static DeploymentFlavorEntity createDeploymentFlavor(String vspId, Version version, String deploymentFlavorId) {
+
+    DeploymentFlavorEntity deploymentFlavorEntity = new DeploymentFlavorEntity(vspId, version, deploymentFlavorId);
+    DeploymentFlavor deploymentFlavor = new DeploymentFlavor();
+    deploymentFlavor.setModel(deploymentFlavorId + " name");
+    deploymentFlavor.setDescription(deploymentFlavorId + " desc");
+
+    deploymentFlavorEntity.setDeploymentFlavorCompositionData(deploymentFlavor);
+    return deploymentFlavorEntity;
+  }
+
+  private void testUpdate_negative(String vspId, Version version, String
+      deploymentFlavorId, String user, String expectedErrorCode) {
+    try {
+      deploymentFlavorManager
+          .updateDeploymentFlavor(new DeploymentFlavorEntity(vspId, version, deploymentFlavorId), user);
+      Assert.fail();
+    } catch (CoreException exception) {
+      Assert.assertEquals(exception.code().id(), expectedErrorCode);
+    }
+  }
+
+  private void testGet_negative(String vspId, Version version, String deploymentFlavorId,
+                                String user, String expectedErrorCode) {
+    try {
+      deploymentFlavorManager.getDeploymentFlavor(vspId, version, deploymentFlavorId, user);
+      Assert.fail();
+    } catch (CoreException exception) {
+      Assert.assertEquals(exception.code().id(), expectedErrorCode);
+    }
+  }
+
+}