3 files changed, 86 insertions, 19 deletions

diff --git a/catalog-model/src/test/java/org/openecomp/sdc/be/model/tosca/converters/DataTypePropertyConverterTest.java b/catalog-model/src/test/java/org/openecomp/sdc/be/model/tosca/converters/DataTypePropertyConverterTest.java
index d5425504e6..e15d784c7a 100644
--- a/catalog-model/src/test/java/org/openecomp/sdc/be/model/tosca/converters/DataTypePropertyConverterTest.java
+++ b/catalog-model/src/test/java/org/openecomp/sdc/be/model/tosca/converters/DataTypePropertyConverterTest.java
@@ -1,19 +1,19 @@
 package org.openecomp.sdc.be.model.tosca.converters;
 
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNull;
+import com.google.gson.JsonObject;
+import org.junit.Before;
+import org.junit.Test;
+import org.openecomp.sdc.be.model.DataTypeDefinition;
+import org.openecomp.sdc.be.model.PropertyDefinition;
 
+import javax.json.Json;
 import java.util.Arrays;
 import java.util.Collections;
 import java.util.HashMap;
 import java.util.Map;
 
-import org.junit.Before;
-import org.junit.Test;
-import org.openecomp.sdc.be.model.DataTypeDefinition;
-import org.openecomp.sdc.be.model.PropertyDefinition;
-
-import com.google.gson.JsonObject;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNull;
 
 public class DataTypePropertyConverterTest {
 
diff --git a/catalog-model/src/test/java/org/openecomp/sdc/be/model/tosca/converters/ToscaFloatConverterTest.java b/catalog-model/src/test/java/org/openecomp/sdc/be/model/tosca/converters/ToscaFloatConverterTest.java
index 5367dcb8a3..7e9388ee1b 100644
--- a/catalog-model/src/test/java/org/openecomp/sdc/be/model/tosca/converters/ToscaFloatConverterTest.java
+++ b/catalog-model/src/test/java/org/openecomp/sdc/be/model/tosca/converters/ToscaFloatConverterTest.java
@@ -2,22 +2,73 @@ package org.openecomp.sdc.be.model.tosca.converters;
 
 import org.junit.Test;
 
+import java.util.Collections;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
+import static org.junit.Assert.assertNull;
+
 
 public class ToscaFloatConverterTest {
 
-	private ToscaFloatConverter createTestSubject() {
-		return  ToscaFloatConverter.getInstance();
-	}
+    @Test
+    public void convertEmptyString_returnNull() {
+        assertNull(executeFloatConversion(""));
+    }
+
+    @Test
+    public void convertNull_returnNull() {
+        assertNull(executeFloatConversion(null));
+    }
+
+    @Test
+    public void convertWholeNumber() {
+        assertThat(executeFloatConversion("1234"))
+                .isEqualTo("1234");
+    }
+
+    @Test
+    public void convertFloatNumber() {
+        assertThat(executeFloatConversion("3.141"))
+                .isEqualTo("3.141");
+    }
+
+    @Test
+    public void convertNotValidFloat() {
+        assertThatExceptionOfType(NumberFormatException.class).isThrownBy(() -> executeFloatConversion("123.55.66"));
+    }
+
+    @Test
+    public void convertNumericWithSpecialChars() {
+        assertThatExceptionOfType(NumberFormatException.class).isThrownBy(() -> executeFloatConversion("123,55"));
+        assertThatExceptionOfType(NumberFormatException.class).isThrownBy(() -> executeFloatConversion("123&55"));
+        assertThatExceptionOfType(NumberFormatException.class).isThrownBy(() -> executeFloatConversion("123$$55"));
+        assertThatExceptionOfType(NumberFormatException.class).isThrownBy(() -> executeFloatConversion("123#55"));
+    }
+
+    @Test
+    public void convertNonNumeric() {
+        assertThatExceptionOfType(NumberFormatException.class).isThrownBy(() -> executeFloatConversion("1234ABC"));
+    }
 
-	
-	@Test
-	public void testGetInstance() throws Exception {
-		ToscaFloatConverter result;
+    @Test
+    public void convertNumericWithCapitalFloatSign() {
+        assertThat(executeFloatConversion("1234F"))
+                .isEqualTo("1234");
+    }
 
-		// default test
-		result = ToscaFloatConverter.getInstance();
-	}
+    @Test
+    public void convertNumericWithSmallLetterFloatSign() {
+        assertThat(executeFloatConversion("1234f"))
+                .isEqualTo("1234");
+    }
 
-	
+    @Test
+    public void convertNumericWithFloatSignNotAtTheEnd_ThrowsException() {
+        assertThatExceptionOfType(NumberFormatException.class).isThrownBy(() -> executeFloatConversion("12f34"));
+    }
 
+    private String executeFloatConversion(String s) {
+        return ToscaFloatConverter.getInstance().convert(s, null, Collections.emptyMap());
+    }
 }
\ No newline at end of file
diff --git a/catalog-model/src/test/java/org/openecomp/sdc/be/model/tosca/validators/MapValidatorTest.java b/catalog-model/src/test/java/org/openecomp/sdc/be/model/tosca/validators/MapValidatorTest.java
new file mode 100644
index 0000000000..6f33b19de3
--- /dev/null
+++ b/catalog-model/src/test/java/org/openecomp/sdc/be/model/tosca/validators/MapValidatorTest.java
@@ -0,0 +1,16 @@
+package org.openecomp.sdc.be.model.tosca.validators;
+
+import org.junit.Test;
+
+import java.util.Collections;
+
+import static org.junit.Assert.*;
+
+public class MapValidatorTest {
+
+    @Test
+    public void isValid_nonMapString() {
+        assertFalse(MapValidator.getInstance().isValid("abc", "string", Collections.emptyMap()));
+        assertFalse(MapValidator.getInstance().isValid("1", "string", Collections.emptyMap()));
+    }
+}
\ No newline at end of file