1 files changed, 53 insertions, 5 deletions

diff --git a/catalog-be/src/test/java/org/openecomp/sdc/be/components/impl/ImportUtilsTest.java b/catalog-be/src/test/java/org/openecomp/sdc/be/components/impl/ImportUtilsTest.java
index b23b8abd1e..681e9cda95 100644
--- a/catalog-be/src/test/java/org/openecomp/sdc/be/components/impl/ImportUtilsTest.java
+++ b/catalog-be/src/test/java/org/openecomp/sdc/be/components/impl/ImportUtilsTest.java
@@ -20,8 +20,8 @@
 
 package org.openecomp.sdc.be.components.impl;
 
+import com.google.common.collect.Lists;
 import fj.data.Either;
-import mockit.Mock;
 import org.junit.Test;
 import org.mockito.Mockito;
 import org.openecomp.sdc.be.components.impl.ImportUtils.ResultStatusEnum;
@@ -30,8 +30,10 @@ import org.openecomp.sdc.be.datatypes.elements.PropertyDataDefinition;
 import org.openecomp.sdc.be.datatypes.elements.SchemaDefinition;
 import org.openecomp.sdc.be.model.HeatParameterDefinition;
 import org.openecomp.sdc.be.model.InputDefinition;
+import org.openecomp.sdc.be.model.PropertyConstraint;
 import org.openecomp.sdc.be.model.PropertyDefinition;
 import org.openecomp.sdc.be.model.operations.impl.AnnotationTypeOperations;
+import org.openecomp.sdc.be.model.tosca.constraints.ValidValuesConstraint;
 import org.openecomp.sdc.be.utils.TypeUtils;
 import org.openecomp.sdc.common.api.ArtifactTypeEnum;
 import org.yaml.snakeyaml.Yaml;
@@ -39,10 +41,10 @@ import org.yaml.snakeyaml.Yaml;
 import java.io.IOException;
 import java.nio.file.FileSystems;
 import java.nio.file.Files;
-import java.util.*;
-import java.util.Map.Entry;
-
-import static org.junit.Assert.*;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
 import java.util.Map;
 import java.util.Map.Entry;
 
@@ -241,6 +243,26 @@ public class ImportUtilsTest {
 
     }
 
+    // @Test
+    // public void testCreateFullHeatParameterModuleWithInvalidType(){
+    //
+    // String name = "fullParameter";
+    // String description = "description_text";
+    //
+    // Map<String, Object> parametersMap = new HashMap<String, Object>();
+    // Map<String, Object> firstParam = createParameterMap("aaa", "aaa",
+    // name, description);
+    // parametersMap.put(ToscaTagNamesEnum.PARAMETERS.getElementName(),
+    // firstParam);
+    //
+    // Either<List<HeatParameterDefinition>,ResultStatusEnum> heatParameters =
+    // ImportUtils.getHeatParameters(parametersMap);
+    // assertTrue(heatParameters.isRight());
+    // assertEquals(ResultStatusEnum.INVALID_PROPERTY_TYPE,
+    // heatParameters.right().value());
+    //
+    // }
+
     @Test
     public void testCreateFullHeatParameterModuleWithMissingType() {
 
@@ -302,6 +324,32 @@ public class ImportUtilsTest {
     }
 
     @Test
+    public void testGetPropertiesWithConstraintsFromYml() throws IOException {
+
+        Map<String, Object> toscaJson = (Map<String, Object>) loadJsonFromFile("propertyConstraintsTest.yml");
+        Either<Map<String, PropertyDefinition>, ResultStatusEnum> actualProperties = ImportUtils.getProperties(toscaJson);
+        assertTrue(actualProperties.isLeft());
+        Map<String, PropertyDefinition> properties = actualProperties.left().value();
+        assertTrue(properties.containsKey("service_type"));
+        PropertyDefinition property = properties.get("service_type");
+        assertTrue(property.getConstraints()!= null && property.getConstraints().size() == 1);
+        assertTrue(property.getConstraints().get(0) instanceof ValidValuesConstraint);
+        assertTrue(((ValidValuesConstraint) property.getConstraints().get(0)).getValidValues() != null);
+        List<String> validValues = ((ValidValuesConstraint) property.getConstraints().get(0)).getValidValues();
+        assertTrue(validValues.containsAll(Lists.newArrayList("firewall", "analyzer", "source-nat", "loadbalancer")));
+
+        assertTrue(properties.containsKey("service_interface_type_list"));
+        property = properties.get("service_interface_type_list");
+        assertTrue(property.getSchema()!= null && property.getSchema().getProperty() != null);
+        PropertyDefinition innerProperty = new PropertyDefinition(property.getSchema().getProperty());
+        List<PropertyConstraint> innerConstraints = innerProperty.getConstraints();
+        assertTrue(innerConstraints.get(0) instanceof ValidValuesConstraint);
+        assertTrue(((ValidValuesConstraint) innerConstraints.get(0)).getValidValues() != null);
+        validValues = ((ValidValuesConstraint) innerConstraints.get(0)).getValidValues();
+        assertTrue(validValues.containsAll(Lists.newArrayList("management", "left", "right", "other")));
+    }
+
+    @Test
     public void testGetInputsFromYml() throws IOException {
 
         Map<String, Object> toscaJson = (Map<String, Object>) loadJsonFromFile("importToscaInputs.yml");