diff options
Diffstat (limited to 'catalog-be/src/main/java/org/openecomp/sdc/be/components/impl/GroupBusinessLogic.java')
| -rw-r--r-- | catalog-be/src/main/java/org/openecomp/sdc/be/components/impl/GroupBusinessLogic.java | 1523 |
1 files changed, 1262 insertions, 261 deletions
diff --git a/catalog-be/src/main/java/org/openecomp/sdc/be/components/impl/GroupBusinessLogic.java b/catalog-be/src/main/java/org/openecomp/sdc/be/components/impl/GroupBusinessLogic.java index 3b4528d3a3..ba08f11928 100644 --- a/catalog-be/src/main/java/org/openecomp/sdc/be/components/impl/GroupBusinessLogic.java +++ b/catalog-be/src/main/java/org/openecomp/sdc/be/components/impl/GroupBusinessLogic.java @@ -20,9 +20,11 @@ package org.openecomp.sdc.be.components.impl; +import java.io.IOException; import java.util.ArrayList; import java.util.Collection; import java.util.Collections; +import java.util.EnumMap; import java.util.HashMap; import java.util.HashSet; import java.util.List; @@ -34,11 +36,21 @@ import java.util.function.Function; import java.util.regex.Pattern; import java.util.stream.Collectors; +import org.apache.commons.collections.CollectionUtils; +import org.apache.commons.collections.MapUtils; import org.apache.commons.io.FilenameUtils; +import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.math.NumberUtils; +import org.apache.commons.lang3.tuple.ImmutablePair; +import org.codehaus.jackson.JsonGenerationException; +import org.codehaus.jackson.map.JsonMappingException; import org.openecomp.sdc.be.config.BeEcompErrorManager; import org.openecomp.sdc.be.config.BeEcompErrorManager.ErrorSeverity; import org.openecomp.sdc.be.dao.api.ActionStatus; +import org.openecomp.sdc.be.dao.jsongraph.utils.JsonParserUtils; import org.openecomp.sdc.be.dao.titan.TitanOperationStatus; +import org.openecomp.sdc.be.datatypes.elements.GroupDataDefinition; +import org.openecomp.sdc.be.datatypes.elements.PropertyDataDefinition; import org.openecomp.sdc.be.datatypes.enums.ComponentTypeEnum; import org.openecomp.sdc.be.datatypes.enums.NodeTypeEnum; import org.openecomp.sdc.be.info.ArtifactDefinitionInfo; @@ -48,29 +60,42 @@ import org.openecomp.sdc.be.model.ArtifactDefinition; import org.openecomp.sdc.be.model.Component; import org.openecomp.sdc.be.model.ComponentInstance; import org.openecomp.sdc.be.model.ComponentParametersView; +import org.openecomp.sdc.be.model.DataTypeDefinition; import org.openecomp.sdc.be.model.GroupDefinition; +import org.openecomp.sdc.be.model.GroupInstance; +import org.openecomp.sdc.be.model.GroupInstanceProperty; import org.openecomp.sdc.be.model.GroupProperty; import org.openecomp.sdc.be.model.GroupTypeDefinition; +import org.openecomp.sdc.be.model.PropertyDefinition; +import org.openecomp.sdc.be.model.PropertyDefinition.GroupInstancePropertyValueUpdateBehavior; +import org.openecomp.sdc.be.model.PropertyDefinition.PropertyNames; +import org.openecomp.sdc.be.model.cache.ApplicationDataTypeCache; +import org.openecomp.sdc.be.model.jsontitan.operations.ArtifactsOperations; +import org.openecomp.sdc.be.model.jsontitan.operations.GroupsOperation; import org.openecomp.sdc.be.model.Resource; import org.openecomp.sdc.be.model.User; import org.openecomp.sdc.be.model.operations.api.StorageOperationStatus; -import org.openecomp.sdc.be.model.operations.impl.ComponentOperation; +import org.openecomp.sdc.be.model.operations.impl.DaoStatusConverter; import org.openecomp.sdc.be.model.operations.impl.GroupOperation; import org.openecomp.sdc.be.model.operations.impl.GroupTypeOperation; -import org.openecomp.sdc.be.model.operations.impl.ResourceOperation; import org.openecomp.sdc.be.model.operations.impl.UniqueIdBuilder; import org.openecomp.sdc.common.api.Constants; -import org.openecomp.sdc.common.config.EcompErrorName; import org.openecomp.sdc.exception.ResponseFormat; import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import org.springframework.beans.factory.annotation.Autowired; + +import com.google.gson.Gson; +import com.google.gson.GsonBuilder; +import com.google.gson.JsonSyntaxException; import fj.data.Either; @org.springframework.stereotype.Component("groupBusinessLogic") public class GroupBusinessLogic extends BaseBusinessLogic { + private static String ADDING_GROUP = "AddingGroup"; - public static String INITIAL_VERSION = "1"; + public static final String INITIAL_VERSION = "1"; private static final String CREATE_GROUP = "CreateGroup"; @@ -87,8 +112,15 @@ public class GroupBusinessLogic extends BaseBusinessLogic { @javax.annotation.Resource private GroupTypeOperation groupTypeOperation; - @javax.annotation.Resource - private GroupOperation groupOperation; + + @Autowired + ArtifactsOperations artifactsOperation; + + @Autowired + private GroupsOperation groupsOperation; + @Autowired + private ApplicationDataTypeCache dataTypeCache; + /** * @@ -113,7 +145,7 @@ public class GroupBusinessLogic extends BaseBusinessLogic { * @param inTransaction * @return */ - public Either<GroupDefinition, ResponseFormat> createGroup(String componentId, String userId, ComponentTypeEnum componentType, GroupDefinition groupDefinition, boolean inTransaction) { + /*public Either<GroupDefinition, ResponseFormat> createGroup(String componentId, String userId, ComponentTypeEnum componentType, GroupDefinition groupDefinition, boolean inTransaction) { Either<GroupDefinition, ResponseFormat> result = null; @@ -142,7 +174,7 @@ public class GroupBusinessLogic extends BaseBusinessLogic { componentParametersView.setIgnoreUsers(false); componentParametersView.setIgnoreComponentInstances(false); - Either<? extends org.openecomp.sdc.be.model.Component, ResponseFormat> validateComponent = validateComponentExists(realComponentId, componentType, componentParametersView, userId, null, user); + Either<? extends org.openecomp.sdc.be.model.Component, ResponseFormat> validateComponent = validateComponentExists(realComponentId, componentType, componentParametersView); if (validateComponent.isRight()) { result = Either.right(validateComponent.right().value()); @@ -164,16 +196,16 @@ public class GroupBusinessLogic extends BaseBusinessLogic { if (result == null || result.isRight()) { log.debug("Going to execute rollback on create group."); - titanGenericDao.rollback(); + titanDao.rollback(); } else { log.debug("Going to execute commit on create group."); - titanGenericDao.commit(); + titanDao.commit(); } } } - } + }*/ private String getComponentTypeForResponse(org.openecomp.sdc.be.model.Component component) { String componentTypeForResponse = "SERVICE"; @@ -203,7 +235,7 @@ public class GroupBusinessLogic extends BaseBusinessLogic { } List<String> currentArtifacts = deploymentArtifacts.values().stream().map(p -> p.getUniqueId()).collect(Collectors.toList()); - log.debug("The deployment artifacts of component {} are {}", component.getNormalizedName(), deploymentArtifacts); + log.debug("The deployment artifacts of component {} are {}" , component.getNormalizedName(), deploymentArtifacts); if (false == currentArtifacts.containsAll(artifacts)) { BeEcompErrorManager.getInstance().logInvalidInputError(context, "Not all artifacts belongs to component " + component.getNormalizedName(), ErrorSeverity.INFO); return Either.right(componentsUtils.getResponseFormat(ActionStatus.INVALID_CONTENT)); @@ -214,43 +246,6 @@ public class GroupBusinessLogic extends BaseBusinessLogic { } /** - * Verify that the artifact members belongs to the component - * - * @param component - * @param artifacts - * @return - */ - private Either<List<ArtifactDefinition>, ResponseFormat> getArtifactsBelongsToComponent(Component component, List<String> artifacts, String context) { - - /* - * if (artifacts == null || true == artifacts.isEmpty()) { return Either.left(true); } - */ - - Map<String, ArtifactDefinition> deploymentArtifacts = component.getDeploymentArtifacts(); - if (deploymentArtifacts == null || true == deploymentArtifacts.isEmpty()) { - BeEcompErrorManager.getInstance().logInvalidInputError(context, "No deployment artifact found under component " + component.getNormalizedName(), ErrorSeverity.INFO); - return Either.right(componentsUtils.getResponseFormat(ActionStatus.INVALID_CONTENT)); - } - List<ArtifactDefinition> resultList = new ArrayList(); - - for (String artifactId : artifacts) { - Optional<ArtifactDefinition> groupArtifactOp = deploymentArtifacts.values().stream().filter(p -> p.getUniqueId().equals(artifactId)).findAny(); - - if (groupArtifactOp.isPresent()) { - ArtifactDefinition groupArtifact = groupArtifactOp.get(); - resultList.add(groupArtifact); - } else { - BeEcompErrorManager.getInstance().logInvalidInputError(context, "Not all artifacts belongs to component " + component.getNormalizedName(), ErrorSeverity.INFO); - return Either.right(componentsUtils.getResponseFormat(ActionStatus.INVALID_CONTENT)); - - } - } - - return Either.left(resultList); - - } - - /** * verify that the members are component instances of the component * * @param component @@ -290,67 +285,54 @@ public class GroupBusinessLogic extends BaseBusinessLogic { } } - ComponentOperation componentOperation = getComponentOperationByParentComponentType(componentType); - if (componentOperation instanceof ResourceOperation) { - ResourceOperation resourceOperation = (ResourceOperation) componentOperation; - - for (Entry<String, String> groupMember : groupMembers.entrySet()) { - - String componentInstName = groupMember.getKey(); - String componentInstUid = groupMember.getValue(); - - ComponentInstance componentInstance = compInstUidToCompInstMap.get(componentInstUid); - String componentUid = componentInstance.getComponentUid(); - List<String> componentToscaNames = new ArrayList<>(); - TitanOperationStatus status = resourceOperation.fillResourceDerivedListFromGraph(componentUid, componentToscaNames); - if (status != TitanOperationStatus.OK) { - BeEcompErrorManager.getInstance().logInternalFlowError(CREATE_GROUP, "Cannot find tosca list of component id " + componentUid, ErrorSeverity.ERROR); - return Either.right(componentsUtils.getResponseFormat(ActionStatus.GENERAL_ERROR)); - } - - log.debug("The tosca names of component id {} are {}", componentUid, memberToscaTypes); - - boolean found = false; - for (String memberToscaType : memberToscaTypes) { - if (componentToscaNames.contains(memberToscaType)) { - found = true; - break; - } - } - if (found == false) { - BeEcompErrorManager.getInstance().logInvalidInputError(CREATE_GROUP, - "No tosca types from " + memberToscaTypes + " can be found in the tosca list " + componentToscaNames + " of component " + componentInstance.getNormalizedName(), ErrorSeverity.INFO); - /* - * # %1 - member name # %2 - group name # %3 - group type - */ - return Either.right(componentsUtils.getResponseFormat(ActionStatus.GROUP_INVALID_TOSCA_NAME_OF_COMPONENT_INSTANCE, componentInstName, groupName, groupType)); - } else { - log.debug("Component instance {} fits to one of the required tosca types", componentInstance.getNormalizedName()); - } - } - } else { - BeEcompErrorManager.getInstance().logInvalidInputError(CREATE_GROUP, "Cannot find tosca list since it is not supported for product", ErrorSeverity.ERROR); - return Either.right(componentsUtils.getResponseFormat(ActionStatus.GENERAL_ERROR)); - } +// ComponentOperation componentOperation = getComponentOperationByParentComponentType(componentType); +// if (componentOperation instanceof ResourceOperation) { +// ResourceOperation resourceOperation = (ResourceOperation) componentOperation; +// +// for (Entry<String, String> groupMember : groupMembers.entrySet()) { +// +// String componentInstName = groupMember.getKey(); +// String componentInstUid = groupMember.getValue(); +// +// ComponentInstance componentInstance = compInstUidToCompInstMap.get(componentInstUid); +// String componentUid = componentInstance.getComponentUid(); +// List<String> componentToscaNames = new ArrayList<>(); +// TitanOperationStatus status = resourceOperation.fillResourceDerivedListFromGraph(componentUid, componentToscaNames); +// if (status != TitanOperationStatus.OK) { +// BeEcompErrorManager.getInstance().logInternalFlowError(CREATE_GROUP, "Cannot find tosca list of component id " + componentUid, ErrorSeverity.ERROR); +// return Either.right(componentsUtils.getResponseFormat(ActionStatus.GENERAL_ERROR)); +// } +// +// log.debug("The tosca names of component id {} are {}", componentUid, memberToscaTypes); +// +// boolean found = false; +// for (String memberToscaType : memberToscaTypes) { +// if (componentToscaNames.contains(memberToscaType)) { +// found = true; +// break; +// } +// } +// if (found == false) { +// BeEcompErrorManager.getInstance().logInvalidInputError(CREATE_GROUP, +// "No tosca types from " + memberToscaTypes + " can be found in the tosca list " + componentToscaNames + " of component " + componentInstance.getNormalizedName(), ErrorSeverity.INFO); +// /* +// * # %1 - member name # %2 - group name # %3 - group type +// */ +// return Either.right(componentsUtils.getResponseFormat(ActionStatus.GROUP_INVALID_TOSCA_NAME_OF_COMPONENT_INSTANCE, componentInstName, groupName, groupType)); +// } else { +// log.debug("Component instance {} fits to one of the required tosca types", componentInstance.getNormalizedName()); +// } +// } +// } else { +// BeEcompErrorManager.getInstance().logInvalidInputError(CREATE_GROUP, "Cannot find tosca list since it is not supported for product", ErrorSeverity.ERROR); +// return Either.right(componentsUtils.getResponseFormat(ActionStatus.GENERAL_ERROR)); +// } } return Either.left(true); } - public ComponentOperation getComponentOperation(NodeTypeEnum componentType) { - - switch (componentType) { - case Service: - case ResourceInstance: - return serviceOperation; - case Resource: - return resourceOperation; - default: - return null; - } - } - /** * Update specific group version * @@ -358,7 +340,7 @@ public class GroupBusinessLogic extends BaseBusinessLogic { * @param inTransaction * @return */ - public Either<GroupDefinition, StorageOperationStatus> updateGroupVersion(GroupDefinition groupDefinition, boolean inTransaction) { + /*public Either<GroupDefinition, StorageOperationStatus> updateGroupVersion(GroupDefinition groupDefinition, boolean inTransaction) { Either<GroupDefinition, StorageOperationStatus> result = null; List<String> groupIdsToUpdateVersion = new ArrayList<>(); groupIdsToUpdateVersion.add(groupDefinition.getUniqueId()); @@ -370,7 +352,9 @@ public class GroupBusinessLogic extends BaseBusinessLogic { result = Either.right(updateGroupVersion.right().value()); } return result; - } + }*/ + + /** * Update list of groups versions @@ -379,7 +363,7 @@ public class GroupBusinessLogic extends BaseBusinessLogic { * @param inTransaction * @return */ - public Either<List<GroupDefinition>, StorageOperationStatus> updateGroupVersion(List<String> groupsUniqueId, boolean inTransaction) { + /*public Either<List<GroupDefinition>, StorageOperationStatus> updateGroupVersion(List<String> groupsUniqueId, boolean inTransaction) { Either<List<GroupDefinition>, StorageOperationStatus> result = null; @@ -395,93 +379,396 @@ public class GroupBusinessLogic extends BaseBusinessLogic { if (result == null || result.isRight()) { log.debug("Going to execute rollback on create group."); - titanGenericDao.rollback(); + titanDao.rollback(); } else { log.debug("Going to execute commit on create group."); - titanGenericDao.commit(); + titanDao.commit(); } } } + }*/ + +/** + * Update GroupDefinition metadata + * @param componentId + * @param user + * @param componentType + * @param updatedGroup + * @param inTransaction + * @return + */ + public Either<GroupDefinition, ResponseFormat> validateAndUpdateGroupMetadata( + String componentId, + User user, + ComponentTypeEnum componentType, + GroupDefinition updatedGroup, + boolean inTransaction) { + + Either<GroupDefinition, ResponseFormat> result = null; + try{ + // Validate user exist + Either<User, ResponseFormat> validateUserExists = validateUserExists(user.getUserId(), UPDATE_GROUP, inTransaction); + if (validateUserExists.isRight()) { + result = Either.right(validateUserExists.right().value()); + return result; + } + // Validate component exist + Either<? extends org.openecomp.sdc.be.model.Component, ResponseFormat> validateComponent = validateComponentExists(componentId, componentType, null); + if (validateComponent.isRight()) { + result = Either.right(validateComponent.right().value()); + return result; + } + org.openecomp.sdc.be.model.Component component = validateComponent.left().value(); + // validate we can work on component + Either<Boolean, ResponseFormat> canWork = validateCanWorkOnComponent(component, user.getUserId()); + if (canWork.isRight()) { + result = Either.right(canWork.right().value()); + return result; + } + List<GroupDefinition> currentGroups = component.getGroups(); + if(CollectionUtils.isEmpty(currentGroups)){ + log.error("Failed to update the metadata of group {} on component {}. The status is {}. ", updatedGroup.getName(), component.getName(), ActionStatus.GROUP_IS_MISSING); + result = Either.right(componentsUtils.getResponseFormat(ActionStatus.GROUP_IS_MISSING, updatedGroup.getName(), component.getName(), component.getComponentType().getValue())); + return result; + } + // Validate groups exists in the component + Optional<GroupDefinition> currentGroupOpt = currentGroups.stream().filter(g -> g.getUniqueId().equals(updatedGroup.getUniqueId())).findAny(); + if(!currentGroupOpt.isPresent()){ + log.error("Failed to update the metadata of group {} on component {}. The status is {}. ", updatedGroup.getName(), component.getName(), ActionStatus.GROUP_IS_MISSING); + result = Either.right(componentsUtils.getResponseFormat(ActionStatus.GROUP_IS_MISSING, updatedGroup.getName(), component.getName(), component.getComponentType().getValue())); + return result; + } + GroupDefinition currentGroup = currentGroupOpt.get(); + Either<Boolean, ResponseFormat> lockResult = lockComponent(componentId, component, "Update GroupDefinition Metadata"); + if (lockResult.isRight()) { + result = Either.right(lockResult.right().value()); + return result; + } + // Validate group type is vfModule + if (!currentGroup.getType().equals(Constants.DEFAULT_GROUP_VF_MODULE)) { + log.error("Failed to update the metadata of group {}. Group type is {} and different then: {}", currentGroup.getName(), currentGroup.getType(), Constants.DEFAULT_GROUP_VF_MODULE); + ResponseFormat responseFormat = componentsUtils.getResponseFormat(ActionStatus.INVALID_VF_MODULE_TYPE, updatedGroup.getType()); + result = Either.right(responseFormat); + return result; + } + result = updateGroupMetadata(component, currentGroup, updatedGroup); + return result; + + } finally { + if(result.isLeft()){ + titanDao.commit(); + } else { + titanDao.rollback(); + } + graphLockOperation.unlockComponent(componentId, componentType.getNodeType()); + } + } + + private Either<GroupDefinition, ResponseFormat> updateGroupMetadata(Component component, GroupDefinition currentGroup, GroupDefinition updatedGroup) { + String currentGroupName = currentGroup.getName(); + Either<GroupDefinition, ResponseFormat> result = validateAndUpdateGroupMetadata(currentGroup, updatedGroup); + + if(result.isRight()){ + log.debug("Failed to validate a metadata of the group {} on component {}. ", updatedGroup.getName(), component.getName()); + } + if(result.isLeft()){ + result = updateGroup(component, currentGroup, currentGroupName); + } + return result; + } + + private Either<GroupDefinition, ResponseFormat> updateGroup(Component component, GroupDefinition updatedGroup, String currentGroupName) { + Either<GroupDefinition, StorageOperationStatus> handleGroupRes; + Either<GroupDefinition, ResponseFormat> result = null; + if(updatedGroup.getName().equals(currentGroupName)){ + handleGroupRes = groupsOperation.updateGroup(component, updatedGroup); + if(handleGroupRes.isRight()){ + log.debug("Failed to update a metadata of the group {} on component {}. ", updatedGroup.getName(), component.getName()); + result = Either.right(componentsUtils.getResponseFormat(componentsUtils.convertFromStorageResponse(handleGroupRes.right().value()))); + } + } else { + StorageOperationStatus deleteStatus = groupsOperation.deleteGroup(component, currentGroupName); + if(deleteStatus != StorageOperationStatus.OK){ + log.debug("Failed to delete the group {} from component {}. ", updatedGroup.getName(), component.getName()); + result = Either.right(componentsUtils.getResponseFormat(componentsUtils.convertFromStorageResponse(deleteStatus))); + } + handleGroupRes = groupsOperation.addGroup(component, updatedGroup); + if(handleGroupRes.isRight()){ + log.debug("Failed to add the group {} to component {}. ", updatedGroup.getName(), component.getName()); + result = Either.right(componentsUtils.getResponseFormat(componentsUtils.convertFromStorageResponse(handleGroupRes.right().value()))); + } + } + if(result == null){ + result = Either.left(updatedGroup); + } + return result; } /** - * Update GroupDefinition metadata - * + * Validate and Update Group Property * @param componentId + * @param groupUniqueId * @param user - * @param groupId * @param componentType - * @param groupUpdate + * @param groupPropertiesToUpdate * @param inTransaction * @return */ - public Either<GroupDefinition, ResponseFormat> updateGroupMetadata(String componentId, User user, String groupUniqueId, ComponentTypeEnum componentType, GroupDefinition groupUpdate, boolean inTransaction) { - - Either<GroupDefinition, ResponseFormat> result = null; + public Either<List<GroupProperty>, ResponseFormat> validateAndUpdateGroupProperties( + String componentId, + String groupUniqueId, + User user, + ComponentTypeEnum componentType, + List<GroupProperty> groupPropertiesToUpdate, boolean inTransaction) { + + Either<List<GroupProperty>, ResponseFormat> result = Either.left(groupPropertiesToUpdate); + try{ + Optional<GroupDefinition> optionalGroupConnectedToVf = null; + GroupDefinition currentGroup = null; + StorageOperationStatus lockResult = graphLockOperation.lockComponent(componentId, componentType.getNodeType()); + if( lockResult != StorageOperationStatus.OK ){ + result = Either.right(componentsUtils.getResponseFormat(componentsUtils.convertFromStorageResponse( + lockResult, componentType), componentId)); + } + if( result.isLeft() ){ + //VF exist because lock succedded + Resource vf = (Resource) toscaOperationFacade.getToscaElement(componentId).left().value(); + optionalGroupConnectedToVf = + //All groups on resource + vf.getGroups().stream(). + //Filter in group sent is part of VF groups + filter( e -> e.getUniqueId().equals(groupUniqueId)). + //Collect + findAny(); + if( !optionalGroupConnectedToVf.isPresent() ){ + result = Either.right(componentsUtils.getResponseFormat(ActionStatus.GROUP_IS_MISSING, + groupUniqueId, vf.getName(), ComponentTypeEnum.RESOURCE.getValue())); + } + } + + if( result.isLeft() ){ + currentGroup = optionalGroupConnectedToVf.get(); + result = validateGroupPropertyAndResetEmptyValue(currentGroup, groupPropertiesToUpdate); + } + if( result.isLeft() ){ + result = updateGroupPropertiesValue(componentId, currentGroup, groupPropertiesToUpdate, inTransaction); + if (result.isRight()) { + BeEcompErrorManager.getInstance().logBeSystemError("Update GroupProperties"); + log.debug("failed to update Vf {}", componentId); + } + } - // Validate user and validate group belongs to component - List<GroupDefinition> groups = new ArrayList<>(); - groups.add(groupUpdate); - Either<Component, ResponseFormat> validateGroupsBeforeUpdate = validateGroupsBeforeUpdate(componentId, user.getUserId(), componentType, groups, inTransaction); - if (validateGroupsBeforeUpdate.isRight()) { - result = Either.right(validateGroupsBeforeUpdate.right().value()); - return result; } - Component component = validateGroupsBeforeUpdate.left().value(); + catch(Exception e){ + log.debug("Error in validateAndUpdateGroupProperty {}", e); + result = Either.right(componentsUtils.getResponseFormat(ActionStatus.GENERAL_ERROR)); + } + finally{ + graphLockOperation.unlockComponent(componentId, componentType.getNodeType()); + } + return result; + } + private void resetEmptyValueWithDefaults(List<GroupProperty> groupPropertiesToUpdate, GroupDefinition originalGroup) { + Map<String, GroupProperty> originalProperties = + //Stream of original properties from group + originalGroup.convertToGroupProperties().stream(). + //Collecting to map with name as key + collect(Collectors.toMap(e -> e.getName(), e -> e)); + for( GroupProperty gp : groupPropertiesToUpdate){ + if( StringUtils.isEmpty(gp.getValue())){ + gp.setValue(originalProperties.get(gp.getName()).getDefaultValue()); + } + } + + } - // Get the GroupDefinition object - Either<GroupDefinition, StorageOperationStatus> groupStatus = groupOperation.getGroup(groupUniqueId); - if (groupStatus.isRight()) { - return Either.right(componentsUtils.getResponseFormat(componentsUtils.convertFromStorageResponse(groupStatus.right().value(), ComponentTypeEnum.SERVICE), "")); + private Either<List<GroupProperty>, ResponseFormat> validateGroupPropertyAndResetEmptyValue( + GroupDefinition originalGroup, List<GroupProperty> groupPropertiesToUpdate) { + + Either<List<GroupProperty>, ResponseFormat> ret = validateOnlyValueChanged(groupPropertiesToUpdate, originalGroup); + if (ret.isLeft()) { + resetEmptyValueWithDefaults(groupPropertiesToUpdate, originalGroup); } - GroupDefinition currentGroup = groupStatus.left().value(); + if (ret.isLeft()) { + // Validate Type Match Value + Optional<StorageOperationStatus> optionalError = + //Stream of group properties + groupPropertiesToUpdate.stream(). + //Validate each and map to returned Strorage status value + map( e -> groupOperation .validateAndUpdatePropertyValue(e)). + //Keep only failed result if there is such + filter( e -> e != StorageOperationStatus.OK). + //collect + findFirst(); + if( optionalError.isPresent()){ + ActionStatus actionStatus = componentsUtils.convertFromStorageResponse(optionalError.get()); + ret = Either.right(componentsUtils.getResponseFormat(actionStatus)); + } - // Validate group type is vfModule - if (!currentGroup.getType().equals(Constants.DEFAULT_GROUP_VF_MODULE)) { - log.error("Group update metadata: Group type is different then: {}", Constants.DEFAULT_GROUP_VF_MODULE); - ResponseFormat responseFormat = componentsUtils.getResponseFormat(ActionStatus.INVALID_VF_MODULE_TYPE, groupUpdate.getType()); - return Either.right(responseFormat); } + if (ret.isLeft()) { + // Validate min max ect... + ret = validatePropertyBusinessLogic(groupPropertiesToUpdate, originalGroup); + } - Either<GroupDefinition, ResponseFormat> validationRsponse = validateAndUpdateGroupMetadata(currentGroup, groupUpdate); - if (validationRsponse.isRight()) { - log.info("Group update metadata: validations field."); - return validationRsponse; + return ret; + } + private Either<List<GroupProperty>, ResponseFormat> validatePropertyBusinessLogic( + List<GroupProperty> groupPropertiesToUpdate, GroupDefinition originalGroup) { + + Either<List<GroupProperty>, ResponseFormat> ret = Either.left(groupPropertiesToUpdate); + + Map<PropertyNames, String> nameValueMap = new HashMap<>(); + for(GroupProperty gp : groupPropertiesToUpdate){ + //Filter out non special properties which does not have Enum + final PropertyNames gpEnum = PropertyNames.findName(gp.getName()); + if( gpEnum != null ){ + nameValueMap.put(gpEnum, gp.getValue()); + } + } + + if ( !MapUtils.isEmpty(nameValueMap) ) { + + if (nameValueMap.containsKey(PropertyNames.INITIAL_COUNT) || nameValueMap.containsKey(PropertyNames.MAX_INSTANCES) + || nameValueMap.containsKey(PropertyNames.MIN_INSTANCES)) { + + + Map<PropertyNames, String> oldValueMap = prepareMapWithOriginalProperties(originalGroup); + + Either<Boolean, ResponseFormat> eitherValid = validateMinMaxAndInitialCountPropertyLogicVF(nameValueMap, + oldValueMap); + if (eitherValid.isRight()) { + ret = Either.right(eitherValid.right().value()); + } + } + if (ret.isLeft() && (nameValueMap.containsKey(PropertyNames.VF_MODULE_DESCRIPTION) + || nameValueMap.containsKey(PropertyNames.VF_MODULE_LABEL))) { + + Optional<ResponseFormat> optionalError = + //Stream of group Properties + groupPropertiesToUpdate.stream(). + //Filter in only properties that needs text validation + filter(e -> enumHasValueFilter(e.getName(), + enumName -> PropertyNames.findName(enumName), + PropertyNames.VF_MODULE_DESCRIPTION, PropertyNames.VF_MODULE_LABEL)). + //validate text properties + map( e -> validateFreeText(e)). + //filter in only errors if exist + filter( e -> e.isRight()). + //map the Either value to the Error + map( e -> e.right().value()) + //collect + .findFirst(); + if( optionalError.isPresent() ){ + ret = Either.right(optionalError.get()); + } + + } } - GroupDefinition groupToUpdate = validationRsponse.left().value(); - // lock resource - Either<Boolean, ResponseFormat> lockResult = lockComponent(componentId, component, "Update GroupDefinition Metadata"); - if (lockResult.isRight()) { - return Either.right(lockResult.right().value()); + return ret; + } + + private Map<PropertyNames, String> prepareMapWithOriginalProperties(GroupDefinition originalGroup) { + Map<PropertyNames, String> oldValueMap = new HashMap<>(); + PropertyNames[] propertiesToCheck = new PropertyNames[] { PropertyNames.INITIAL_COUNT, + PropertyNames.MAX_INSTANCES, PropertyNames.MIN_INSTANCES }; + + for(GroupProperty gp : originalGroup.convertToGroupProperties()){ + if( enumHasValueFilter(gp.getName(), enumName -> PropertyNames.findName(enumName), propertiesToCheck)){ + oldValueMap.put(PropertyNames.findName(gp.getName()), gp.getValue()); + } } - try { - Either<GroupDefinition, StorageOperationStatus> updateResponse = groupOperation.updateGroupName(groupUniqueId, groupUpdate.getName(), inTransaction); - if (updateResponse.isRight()) { - titanGenericDao.rollback(); - BeEcompErrorManager.getInstance().processEcompError(EcompErrorName.BeSystemError, "Update GroupDefinition Metadata"); - BeEcompErrorManager.getInstance().logBeSystemError("Update GroupDefinition Metadata"); - log.debug("failed to update sevice {}", groupToUpdate.getUniqueId()); - return Either.right(componentsUtils.getResponseFormat(ActionStatus.GENERAL_ERROR)); - } - titanGenericDao.commit(); - return Either.left(updateResponse.left().value()); - } finally { - graphLockOperation.unlockComponent(componentId, componentType.getNodeType()); + if( StringUtils.isEmpty(oldValueMap.get(PropertyNames.MAX_INSTANCES)) ){ + oldValueMap.put(PropertyNames.MAX_INSTANCES, String.valueOf(Integer.MAX_VALUE)); + } + return oldValueMap; + } + + private Either<List<GroupProperty>, ResponseFormat> validateOnlyValueChanged( + List<GroupProperty> groupPropertiesToUpdate, GroupDefinition originalGroup) { + + Either<List<GroupProperty>, ResponseFormat> ret = Either.left(groupPropertiesToUpdate); + if( CollectionUtils.isEmpty(groupPropertiesToUpdate) ){ + ret = Either.right(componentsUtils.getResponseFormat(ActionStatus.PROPERTY_NOT_FOUND, StringUtils.EMPTY)); + } + else if (CollectionUtils.isEmpty(originalGroup.getProperties())) { + ret = Either.right(componentsUtils.getResponseFormat(ActionStatus.PROPERTY_NOT_FOUND, + groupPropertiesToUpdate.get(NumberUtils.INTEGER_ZERO).getName())); + } else { + Map<String, GroupProperty> namePropertyMap = + //Original Group Properties Stream + originalGroup.convertToGroupProperties().stream(). + //Collect to map with name as key + collect(Collectors.toMap(e -> e.getName(), e -> e)); + + Optional<GroupProperty> optionalMissingProperty = + //Group Properties to be updated Stream + groupPropertiesToUpdate.stream(). + //Filter in property that is not contained in original if there is such + filter(e -> !namePropertyMap.containsKey(e.getName())). + //collect + findFirst(); + + if (optionalMissingProperty.isPresent()) { + ret = Either.right(componentsUtils.getResponseFormat(ActionStatus.PROPERTY_NOT_FOUND, + optionalMissingProperty.get().getName())); + } + else{ + Optional<GroupProperty> optionalNonValueChange = + //groups to be updated stream + groupPropertiesToUpdate.stream(). + //filter in only properties with non-value (illegal) change + filter( e -> !isOnlyGroupPropertyValueChanged(e, namePropertyMap.get(e.getName()))). + //Collect + findFirst(); + if (optionalNonValueChange.isPresent()) { + ret = Either.right(componentsUtils.getResponseFormat(ActionStatus.INVALID_PROPERTY, + optionalNonValueChange.get().getName())); + + } + } + } + return ret; } /** + * if groupProperty are the same or if only value is different returns true, otherwise returns false. + * @param groupProperty + * @param groupProperty2 + * @return + */ + private boolean isOnlyGroupPropertyValueChanged(GroupProperty groupProperty, GroupProperty groupProperty2) { + //Create 2 duplicates for groupPropery and reset their values + Gson gson = new GsonBuilder().setPrettyPrinting().create(); + try { + GroupProperty groupPropertyDuplicate = new GroupProperty(groupProperty); + groupPropertyDuplicate.setValue(null); + groupPropertyDuplicate.setSchema(null); + groupPropertyDuplicate.setParentUniqueId(null); +// GroupProperty groupProperty2Duplicate = gson.fromJson(JsonParserUtils.jsonToString(groupProperty2), GroupProperty.class); + GroupProperty groupProperty2Duplicate = new GroupProperty(groupProperty2); + groupProperty2Duplicate.setValue(null); + groupProperty2Duplicate.setSchema(null); + groupProperty2Duplicate.setParentUniqueId(null); + return groupPropertyDuplicate.equals(groupProperty2Duplicate) && StringUtils.equals(groupPropertyDuplicate.getValueUniqueUid(), groupProperty2Duplicate.getValueUniqueUid()); + } catch (Exception e) { + log.debug("Failed validate group properties. ", e); + return false; + } + } + /** * Validate and update GroupDefinition metadata * * @param user * @param currentGroup * @param groupUpdate * @return - */ + **/ private Either<GroupDefinition, ResponseFormat> validateAndUpdateGroupMetadata(GroupDefinition currentGroup, GroupDefinition groupUpdate) { // Check if to update, and update GroupDefinition name. Either<Boolean, ResponseFormat> response = validateAndUpdateGroupName(currentGroup, groupUpdate); @@ -577,7 +864,7 @@ public class GroupBusinessLogic extends BaseBusinessLogic { * @param inTransaction * @return */ - public Either<List<GroupDefinition>, ResponseFormat> associateArtifactsToGroup(String componentId, String userId, ComponentTypeEnum componentType, List<GroupDefinition> groups, boolean shouldLockComp, boolean inTransaction) { + /*public Either<List<GroupDefinition>, ResponseFormat> associateArtifactsToGroup(String componentId, String userId, ComponentTypeEnum componentType, List<GroupDefinition> groups, boolean shouldLockComp, boolean inTransaction) { Either<List<GroupDefinition>, ResponseFormat> result = null; @@ -634,7 +921,7 @@ public class GroupBusinessLogic extends BaseBusinessLogic { boolean isChanged = componentArtifacts.removeAll(artifactsToAssociate); if (isChanged) {// I.e. At least one artifact is already // associated to the group - log.debug("Some of the artifacts already associated to group {}", groupDefinition.getUniqueId()); + log.debug("Some of the artifacts already associated to group {}" , groupDefinition.getUniqueId()); return Either.right(componentsUtils.getResponseFormat(ActionStatus.GROUP_ARTIFACT_ALREADY_ASSOCIATED, componentGroup.getName())); } } @@ -661,10 +948,10 @@ public class GroupBusinessLogic extends BaseBusinessLogic { if (result == null || result.isRight()) { log.debug("Going to execute rollback on create group."); - titanGenericDao.rollback(); + titanDao.rollback(); } else { log.debug("Going to execute commit on create group."); - titanGenericDao.commit(); + titanDao.commit(); } } @@ -675,9 +962,9 @@ public class GroupBusinessLogic extends BaseBusinessLogic { } } - } + }*/ - public Either<List<GroupDefinition>, ResponseFormat> associateMembersToGroup(String componentId, String userId, ComponentTypeEnum componentType, List<GroupDefinition> groups, boolean shouldLockComp, boolean inTransaction) { + /*public Either<List<GroupDefinition>, ResponseFormat> associateMembersToGroup(String componentId, String userId, ComponentTypeEnum componentType, List<GroupDefinition> groups, boolean shouldLockComp, boolean inTransaction) { Either<List<GroupDefinition>, ResponseFormat> result = null; @@ -739,10 +1026,10 @@ public class GroupBusinessLogic extends BaseBusinessLogic { if (result == null || result.isRight()) { log.debug("Going to execute rollback on create group."); - titanGenericDao.rollback(); + titanDao.rollback(); } else { log.debug("Going to execute commit on create group."); - titanGenericDao.commit(); + titanDao.commit(); } } @@ -753,7 +1040,7 @@ public class GroupBusinessLogic extends BaseBusinessLogic { } } - } + }*/ /** * associate artifacts to a given group @@ -778,8 +1065,6 @@ public class GroupBusinessLogic extends BaseBusinessLogic { return result; } - User user = validateUserExists.left().value(); - // Validate component exist org.openecomp.sdc.be.model.Component component = null; String realComponentId = componentId; @@ -790,85 +1075,88 @@ public class GroupBusinessLogic extends BaseBusinessLogic { componentParametersView.setIgnoreGroups(false); componentParametersView.setIgnoreArtifacts(false); componentParametersView.setIgnoreUsers(false); - componentParametersView.setIgnoreComponentInstances(false); - Either<? extends org.openecomp.sdc.be.model.Component, ResponseFormat> validateComponent = validateComponentExists(realComponentId, componentType, componentParametersView, userId, null, user); + Either<? extends org.openecomp.sdc.be.model.Component, ResponseFormat> validateComponent = validateComponentExists(realComponentId, componentType, componentParametersView); if (validateComponent.isRight()) { result = Either.right(validateComponent.right().value()); return result; } component = validateComponent.left().value(); - // validate we can work on component - /* - * Either<Boolean, ResponseFormat> canWork = validateCanWorkOnComponent( component, userId); if (canWork.isRight()) { result = Either.right(canWork.right().value()); return result; } - */ - List<GroupDefinition> groups = component.getGroups(); - Optional<GroupDefinition> findAny = groups.stream().filter(p -> p.getUniqueId().equals(groupId)).findAny(); - if (findAny.isPresent()) { - GroupDefinition group = findAny.get(); - Boolean isBase = null;// Constants.IS_BASE; - List<GroupProperty> props = group.getProperties(); - if (props != null && !props.isEmpty()) { - Optional<GroupProperty> isBasePropOp = props.stream().filter(p -> p.getName().equals(Constants.IS_BASE)).findAny(); - if (isBasePropOp.isPresent()) { - GroupProperty propIsBase = isBasePropOp.get(); - isBase = Boolean.parseBoolean(propIsBase.getValue()); + Either<GroupDefinition, StorageOperationStatus> groupEither = findGroupOnComponent(component, groupId); + + if (groupEither.isRight()) { + log.debug("Faild to find group {} under component {}", groupId, component.getUniqueId()); + BeEcompErrorManager.getInstance().logInvalidInputError(GET_GROUP, "group " + groupId + " not found under component " + component.getUniqueId(), ErrorSeverity.INFO); + String componentTypeForResponse = getComponentTypeForResponse(component); + result = Either.right(componentsUtils.getResponseFormat(ActionStatus.GROUP_IS_MISSING, groupId, component.getSystemName(), componentTypeForResponse)); + return result; + } + GroupDefinition group = groupEither.left().value(); + + + Boolean isBase = null;// Constants.IS_BASE; + List<GroupProperty> props = group.convertToGroupProperties(); + if (props != null && !props.isEmpty()) { + Optional<GroupProperty> isBasePropOp = props.stream().filter(p -> p.getName().equals(Constants.IS_BASE)).findAny(); + if (isBasePropOp.isPresent()) { + GroupProperty propIsBase = isBasePropOp.get(); + isBase = Boolean.parseBoolean(propIsBase.getValue()); - } else { - BeEcompErrorManager.getInstance().logInvalidInputError(GET_GROUP, "failed to find prop isBase " + component.getNormalizedName(), ErrorSeverity.INFO); - // return - // Either.right(componentsUtils.getResponseFormat(ActionStatus.INVALID_CONTENT)); + } else { + BeEcompErrorManager.getInstance().logInvalidInputError(GET_GROUP, "failed to find prop isBase " + component.getNormalizedName(), ErrorSeverity.INFO); + // return + // Either.right(componentsUtils.getResponseFormat(ActionStatus.INVALID_CONTENT)); - } } + } - List<ArtifactDefinitionInfo> artifacts = new ArrayList(); - List<String> artifactsIds = group.getArtifacts(); - if (artifactsIds != null && !artifactsIds.isEmpty()) { - Either<List<ArtifactDefinition>, ResponseFormat> getArtifacts = getArtifactsBelongsToComponent(component, artifactsIds, GET_GROUP); - if (getArtifacts.isRight()) { - log.debug("Faild to find artifacts in group {} under component {}", groupId, component.getUniqueId()); - // result = Either.right(getArtifacts.right().value()); - // return result; - } else { - - List<ArtifactDefinition> artifactsFromComponent = getArtifacts.left().value(); - if (artifactsFromComponent != null && !artifactsFromComponent.isEmpty()) { - for (ArtifactDefinition artifactDefinition : artifactsFromComponent) { - ArtifactDefinitionInfo artifactDefinitionInfo = new ArtifactDefinitionInfo(artifactDefinition); - artifacts.add(artifactDefinitionInfo); - } - } + List<ArtifactDefinitionInfo> artifacts = new ArrayList<>(); + List<ArtifactDefinition> artifactsFromComponent = new ArrayList<>(); + List<String> artifactsIds = group.getArtifacts(); + + Map<String, ArtifactDefinition> deploymentArtifacts = null; + if(MapUtils.isNotEmpty(component.getDeploymentArtifacts())){ + deploymentArtifacts = component.getDeploymentArtifacts().values().stream().collect(Collectors.toMap(a -> a.getUniqueId(), a -> a)); + } + + if (artifactsIds != null && !artifactsIds.isEmpty()) { + for(String id: artifactsIds){ + if (MapUtils.isEmpty(deploymentArtifacts) || !deploymentArtifacts.containsKey(id)) { + log.debug("Failed to get artifact {} . Status is {} ", id, StorageOperationStatus.NOT_FOUND); + ResponseFormat responseFormat = componentsUtils.getResponseFormat(componentsUtils.convertFromStorageResponse(StorageOperationStatus.NOT_FOUND)); + result = Either.right(responseFormat); + return result; + } + artifactsFromComponent.add(deploymentArtifacts.get(id)); + } + if (!artifactsFromComponent.isEmpty()) { + for (ArtifactDefinition artifactDefinition : artifactsFromComponent) { + ArtifactDefinitionInfo artifactDefinitionInfo = new ArtifactDefinitionInfo(artifactDefinition); + artifacts.add(artifactDefinitionInfo); } } - GroupDefinitionInfo resultInfo = new GroupDefinitionInfo(group); - resultInfo.setIsBase(isBase); - if (!artifacts.isEmpty()) - resultInfo.setArtifacts(artifacts); - result = Either.left(resultInfo); + } + GroupDefinitionInfo resultInfo = new GroupDefinitionInfo(group); + resultInfo.setIsBase(isBase); + if (!artifacts.isEmpty()) + resultInfo.setArtifacts(artifacts); - return result; + result = Either.left(resultInfo); - } else { - log.debug("Faild to find group {} under component {}", groupId, component.getUniqueId()); - BeEcompErrorManager.getInstance().logInvalidInputError(GET_GROUP, "group " + groupId + " not found under component " + component.getUniqueId(), ErrorSeverity.INFO); - String componentTypeForResponse = getComponentTypeForResponse(component); - result = Either.right(componentsUtils.getResponseFormat(ActionStatus.GROUP_IS_MISSING, groupId, component.getSystemName(), componentTypeForResponse)); - return result; + return result; - } } finally { if (false == inTransaction) { if (result == null || result.isRight()) { log.debug("Going to execute rollback on create group."); - titanGenericDao.rollback(); + titanDao.rollback(); } else { log.debug("Going to execute commit on create group."); - titanGenericDao.commit(); + titanDao.commit(); } } @@ -877,6 +1165,21 @@ public class GroupBusinessLogic extends BaseBusinessLogic { } + private Either<GroupDefinition, StorageOperationStatus> findGroupOnComponent(Component component, String groupId) { + + Either<GroupDefinition, StorageOperationStatus> result = null; + if(CollectionUtils.isNotEmpty(component.getGroups())){ + Optional<GroupDefinition> foundGroup = component.getGroups().stream().filter(g -> g.getUniqueId().equals(groupId)).findFirst(); + if(foundGroup.isPresent()){ + result = Either.left(foundGroup.get()); + } + } + if(result == null){ + result = Either.right(StorageOperationStatus.NOT_FOUND); + } + return result; + } + /** * @param componentId * @param userId @@ -895,7 +1198,6 @@ public class GroupBusinessLogic extends BaseBusinessLogic { result = Either.right(validateUserExists.right().value()); return result; } - User user = validateUserExists.left().value(); // Validate component exist String realComponentId = componentId; @@ -907,7 +1209,7 @@ public class GroupBusinessLogic extends BaseBusinessLogic { componentParametersView.setIgnoreUsers(false); componentParametersView.setIgnoreComponentInstances(false); - Either<? extends org.openecomp.sdc.be.model.Component, ResponseFormat> validateComponent = validateComponentExists(realComponentId, componentType, componentParametersView, userId, null, user); + Either<? extends org.openecomp.sdc.be.model.Component, ResponseFormat> validateComponent = validateComponentExists(realComponentId, componentType, componentParametersView); if (validateComponent.isRight()) { result = Either.right(validateComponent.right().value()); @@ -945,14 +1247,6 @@ public class GroupBusinessLogic extends BaseBusinessLogic { return Either.left(component); } - private ResponseFormat validateGroupsInComponent(List<GroupDefinition> groups, org.openecomp.sdc.be.model.Component component) { - - Function<GroupDefinition, String> getByName = s -> s.getName(); - - return validateGroupsInComponentByFunc(groups, component, getByName); - - } - /** * @param groups * @param component @@ -1014,7 +1308,7 @@ public class GroupBusinessLogic extends BaseBusinessLogic { * @param inTransaction * @return */ - public Either<List<GroupDefinition>, ResponseFormat> dissociateArtifactsFromGroup(String componentId, String userId, ComponentTypeEnum componentType, List<GroupDefinition> groups, boolean shouldLockComp, boolean inTransaction) { + /*public Either<List<GroupDefinition>, ResponseFormat> dissociateArtifactsFromGroup(String componentId, String userId, ComponentTypeEnum componentType, List<GroupDefinition> groups, boolean shouldLockComp, boolean inTransaction) { Either<List<GroupDefinition>, ResponseFormat> result = null; @@ -1073,13 +1367,13 @@ public class GroupBusinessLogic extends BaseBusinessLogic { if (false == containsAll) { // At least one artifact is // not associated to the // group - log.debug("Some of the artifacts already dissociated to group {}", groupDefinition.getUniqueId()); + log.debug("Some of the artifacts already dissociated to group {}" , groupDefinition.getUniqueId()); return Either.right(componentsUtils.getResponseFormat(ActionStatus.GROUP_ARTIFACT_ALREADY_DISSOCIATED, componentGroup.getName())); } } else { if (artifactsSizeInGroup == 0) { if (artifactsToDissociate != null && false == artifactsToDissociate.isEmpty()) { - log.debug("No artifact is found under the group {}", groupDefinition.getUniqueId()); + log.debug("No artifact is found under the group {}" , groupDefinition.getUniqueId()); return Either.right(componentsUtils.getResponseFormat(ActionStatus.GROUP_ARTIFACT_ALREADY_DISSOCIATED, componentGroup.getName())); } } @@ -1107,10 +1401,10 @@ public class GroupBusinessLogic extends BaseBusinessLogic { if (result == null || result.isRight()) { log.debug("Going to execute rollback on create group."); - titanGenericDao.rollback(); + titanDao.rollback(); } else { log.debug("Going to execute commit on create group."); - titanGenericDao.commit(); + titanDao.commit(); } } @@ -1121,9 +1415,9 @@ public class GroupBusinessLogic extends BaseBusinessLogic { } - } + }*/ - public Either<List<GroupDefinition>, ResponseFormat> createGroups(String componentId, String userId, ComponentTypeEnum componentType, List<GroupDefinition> groupDefinitions, boolean shouldLockComp, boolean inTransaction) { + /*public Either<List<GroupDefinition>, ResponseFormat> createGroups(String componentId, String userId, ComponentTypeEnum componentType, List<GroupDefinition> groupDefinitions, boolean shouldLockComp, boolean inTransaction) { Either<List<GroupDefinition>, ResponseFormat> result = null; @@ -1131,9 +1425,9 @@ public class GroupBusinessLogic extends BaseBusinessLogic { org.openecomp.sdc.be.model.Component component = null; try { - if (groupDefinitions != null && false == groupDefinitions.isEmpty()) { + if (groupDefinitions != null && !groupDefinitions.isEmpty()) { - if (shouldLockComp == true && inTransaction == true) { + if (shouldLockComp && inTransaction) { BeEcompErrorManager.getInstance().logInternalFlowError("createGroups", "Cannot lock component since we are inside a transaction", ErrorSeverity.ERROR); // Cannot lock component since we are in a middle of another // transaction. @@ -1157,7 +1451,7 @@ public class GroupBusinessLogic extends BaseBusinessLogic { componentParametersView.setIgnoreUsers(false); componentParametersView.setIgnoreComponentInstances(false); - Either<? extends org.openecomp.sdc.be.model.Component, ResponseFormat> validateComponent = validateComponentExists(componentId, componentType, componentParametersView, userId, null, user); + Either<? extends org.openecomp.sdc.be.model.Component, ResponseFormat> validateComponent = validateComponentExists(componentId, componentType, componentParametersView); if (validateComponent.isRight()) { result = Either.right(validateComponent.right().value()); @@ -1181,7 +1475,7 @@ public class GroupBusinessLogic extends BaseBusinessLogic { for (GroupDefinition groupDefinition : groupDefinitions) { Either<GroupDefinition, ResponseFormat> createGroup = this.createGroup(component, user, componentType, groupDefinition, true); if (createGroup.isRight()) { - log.debug("Failed to create group {}.", groupDefinition); + log.debug("Failed to create group {}." , groupDefinition ); result = Either.right(createGroup.right().value()); return result; } @@ -1199,10 +1493,10 @@ public class GroupBusinessLogic extends BaseBusinessLogic { if (result == null || result.isRight()) { log.debug("Going to execute rollback on create group."); - titanGenericDao.rollback(); + titanDao.rollback(); } else { log.debug("Going to execute commit on create group."); - titanGenericDao.commit(); + titanDao.commit(); } } @@ -1219,7 +1513,7 @@ public class GroupBusinessLogic extends BaseBusinessLogic { Either<GroupDefinition, ResponseFormat> result = null; - log.debug("Going to create group {}", groupDefinition); + log.trace("Going to create group {}" , groupDefinition); try { @@ -1314,10 +1608,10 @@ public class GroupBusinessLogic extends BaseBusinessLogic { if (result == null || result.isRight()) { log.debug("Going to execute rollback on create group."); - titanGenericDao.rollback(); + titanDao.rollback(); } else { log.debug("Going to execute commit on create group."); - titanGenericDao.commit(); + titanDao.commit(); } } @@ -1351,8 +1645,23 @@ public class GroupBusinessLogic extends BaseBusinessLogic { updatedGroups.add(updateGroupNameRes.left().value()); } return updateGroupNamesRes; - } + }*/ + + private Either<List<GroupProperty>, ResponseFormat> updateGroupPropertiesValue(String componentId, + GroupDefinition currentGroup, List<GroupProperty> groupPropertyToUpdate, boolean inTransaction) { + Either<List<GroupProperty>, ResponseFormat> result; + Either<List<GroupProperty>, StorageOperationStatus> eitherUpdate = groupsOperation + .updateGroupPropertiesOnComponent(componentId, currentGroup, groupPropertyToUpdate); + if (eitherUpdate.isRight()) { + ActionStatus actionStatus = componentsUtils.convertFromStorageResponse(eitherUpdate.right().value()); + result = Either.right(componentsUtils.getResponseFormat(actionStatus)); + } else { + result = Either.left(eitherUpdate.left().value()); + } + return result; + } + public Either<Boolean, ResponseFormat> validateGenerateVfModuleGroupNames(List<ArtifactTemplateInfo> allGroups, String resourceSystemName, int startGroupCounter) { Either<Boolean, ResponseFormat> validateGenerateGroupNamesRes = Either.left(true); Collections.sort(allGroups, (art1, art2) -> ArtifactTemplateInfo.compareByGroupName(art1, art2)); @@ -1438,7 +1747,7 @@ public class GroupBusinessLogic extends BaseBusinessLogic { return counter; } - public Either<List<GroupDefinition>, ResponseFormat> validateUpdateVfGroupNamesOnGraph(List<GroupDefinition> groups, String resourceSystemName, boolean inTransaction) { + public Either<List<GroupDefinition>, ResponseFormat> validateUpdateVfGroupNamesOnGraph(List<GroupDefinition> groups, Component component, boolean inTransaction) { List<GroupDefinition> updatedGroups = new ArrayList<>(); Either<List<GroupDefinition>, ResponseFormat> result = Either.left(updatedGroups); @@ -1451,27 +1760,25 @@ public class GroupBusinessLogic extends BaseBusinessLogic { int counter; if (groupType.equals(Constants.DEFAULT_GROUP_VF_MODULE) && Pattern.compile(Constants.MODULE_OLD_NAME_PATTERN).matcher(oldGroupName).matches()) { counter = Integer.parseInt(group.getName().split(Constants.MODULE_NAME_DELIMITER)[1]); - newGroupNameRes = validateGenerateVfModuleGroupName(resourceSystemName, group.getDescription(), counter); + newGroupNameRes = validateGenerateVfModuleGroupName(component.getSystemName(), group.getDescription(), counter); if (newGroupNameRes.isRight()) { log.debug("Failed to generate new vf module group name. Status is {} ", newGroupNameRes.right().value()); result = Either.right(newGroupNameRes.right().value()); break; } newGroupName = newGroupNameRes.left().value(); - updateGroupNameRes = groupOperation.updateGroupName(group.getUniqueId(), newGroupName, inTransaction); - if (updateGroupNameRes.isRight()) { - log.debug("Failed to update vf module group name for group {} . Status is {} ", oldGroupName, updateGroupNameRes.right().value()); - ResponseFormat responseFormat = componentsUtils.getResponseFormat(componentsUtils.convertFromStorageResponse(updateGroupNameRes.right().value())); - result = Either.right(responseFormat); - break; - } + group.setName(newGroupName); + } updatedGroups.add(group); + } + + result = Either.left(updatedGroups); return result; } - public Either<List<GroupDefinition>, ResponseFormat> createGroups(Component component, User user, ComponentTypeEnum componentType, List<GroupDefinition> groupDefinitions, boolean inTransaction) { + /*public Either<List<GroupDefinition>, ResponseFormat> createGroups(Component component, User user, ComponentTypeEnum componentType, List<GroupDefinition> groupDefinitions, boolean inTransaction) { List<GroupDefinition> generatedGroups = new ArrayList<>(); Either<List<GroupDefinition>, ResponseFormat> result = Either.left(generatedGroups); @@ -1497,16 +1804,710 @@ public class GroupBusinessLogic extends BaseBusinessLogic { if (result == null || result.isRight()) { log.debug("Going to execute rollback on create group."); - titanGenericDao.rollback(); + titanDao.rollback(); + } else { + log.debug("Going to execute commit on create group."); + titanDao.commit(); + } + + } + + } + + }*/ + + public Either<GroupDefinitionInfo, ResponseFormat> getGroupInstWithArtifactsById(ComponentTypeEnum componentType, String componentId, String componentInstanceId, String groupInstId, String userId, boolean inTransaction) { + Either<GroupDefinitionInfo, ResponseFormat> result = null; + + // Validate user exist + Either<User, ResponseFormat> validateUserExists = validateUserExists(userId, UPDATE_GROUP, true); + + if (validateUserExists.isRight()) { + result = Either.right(validateUserExists.right().value()); + return result; + } + + // Validate component exist + org.openecomp.sdc.be.model.Component component = null; + String realComponentId = componentId; + + try { + ComponentParametersView componentParametersView = new ComponentParametersView(); + componentParametersView.disableAll(); + componentParametersView.setIgnoreUsers(false); + componentParametersView.setIgnoreComponentInstances(false); + componentParametersView.setIgnoreArtifacts(false); + + Either<? extends org.openecomp.sdc.be.model.Component, ResponseFormat> validateComponent = validateComponentExists(realComponentId, componentType, componentParametersView); + if (validateComponent.isRight()) { + result = Either.right(validateComponent.right().value()); + return result; + } + component = validateComponent.left().value(); + Either<ImmutablePair<ComponentInstance, GroupInstance>, StorageOperationStatus> findComponentInstanceAndGroupInstanceRes = findComponentInstanceAndGroupInstanceOnComponent(component, componentInstanceId, groupInstId); + + if (findComponentInstanceAndGroupInstanceRes.isRight()) { + log.debug("Failed to get group {} . Status is {} ", groupInstId, findComponentInstanceAndGroupInstanceRes.right().value()); + ResponseFormat responseFormat = componentsUtils.getResponseFormat(componentsUtils.convertFromStorageResponse(findComponentInstanceAndGroupInstanceRes.right().value())); + result = Either.right(responseFormat); + return result; + } + + GroupInstance group = findComponentInstanceAndGroupInstanceRes.left().value().getRight(); + ComponentInstance componentInstance = findComponentInstanceAndGroupInstanceRes.left().value().getLeft(); + + Boolean isBase = null;// Constants.IS_BASE; + List<? extends GroupProperty> props = group.convertToGroupInstancesProperties(); + if (props != null && !props.isEmpty()) { + Optional<? extends GroupProperty> isBasePropOp = props.stream().filter(p -> p.getName().equals(Constants.IS_BASE)).findAny(); + if (isBasePropOp.isPresent()) { + GroupProperty propIsBase = isBasePropOp.get(); + isBase = Boolean.parseBoolean(propIsBase.getValue()); + + } else { + BeEcompErrorManager.getInstance().logInvalidInputError(GET_GROUP, "failed to find prop isBase " + component.getNormalizedName(), ErrorSeverity.INFO); + // return + // Either.right(componentsUtils.getResponseFormat(ActionStatus.INVALID_CONTENT)); + + } + } + + List<ArtifactDefinitionInfo> artifacts = new ArrayList<>(); + List<ArtifactDefinition> artifactsFromComponent = new ArrayList<>(); + List<String> artifactsIds = group.getArtifacts(); + if (artifactsIds != null && !artifactsIds.isEmpty()) { + + for(String id: artifactsIds){ + Either<ArtifactDefinition, StorageOperationStatus> artifactEither = artifactsOperation.getArtifactById(componentInstance.getComponentUid(), id); + if (artifactEither.isRight()) { + log.debug("Failed to get artifact {} . Status is {} ", id, artifactEither.right().value()); + ResponseFormat responseFormat = componentsUtils.getResponseFormat(componentsUtils.convertFromStorageResponse(artifactEither.right().value())); + result = Either.right(responseFormat); + return result; + } + artifactsFromComponent.add(artifactEither.left().value()); + } + if (!artifactsFromComponent.isEmpty()) { + for (ArtifactDefinition artifactDefinition : artifactsFromComponent) { + ArtifactDefinitionInfo artifactDefinitionInfo = new ArtifactDefinitionInfo(artifactDefinition); + artifacts.add(artifactDefinitionInfo); + } + } + + + } + GroupDefinitionInfo resultInfo = new GroupDefinitionInfo(group); + resultInfo.setIsBase(isBase); + if (!artifacts.isEmpty()) + resultInfo.setArtifacts(artifacts); + + result = Either.left(resultInfo); + + return result; + + + } finally { + + if (false == inTransaction) { + + if (result == null || result.isRight()) { + log.debug("Going to execute rollback on create group."); + titanDao.rollback(); } else { log.debug("Going to execute commit on create group."); - titanGenericDao.commit(); + titanDao.commit(); + } + + } + + } + } + + private Either<ImmutablePair<ComponentInstance, GroupInstance>, StorageOperationStatus> findComponentInstanceAndGroupInstanceOnComponent(Component component, String componentInstanceId, String groupInstId) { + + Either<ImmutablePair<ComponentInstance,GroupInstance>, StorageOperationStatus> result = null; + if(CollectionUtils.isNotEmpty(component.getComponentInstances())){ + Optional<GroupInstance> foundGroup; + Optional<ComponentInstance> foundComponent = component.getComponentInstances().stream().filter(ci -> ci.getUniqueId().equals(componentInstanceId)).findFirst(); + if(foundComponent.isPresent() && CollectionUtils.isNotEmpty(foundComponent.get().getGroupInstances())){ + foundGroup = foundComponent.get().getGroupInstances().stream().filter(gi -> gi.getUniqueId().equals(groupInstId)).findFirst(); + if(foundGroup.isPresent()){ + result = Either.left(new ImmutablePair<>(foundComponent.get(), foundGroup.get())); + } + } + } + if(result == null){ + result = Either.right(StorageOperationStatus.NOT_FOUND); + } + return result; + } + + private int getLatestIntProperty(Map<PropertyNames, String> newValues, Map<PropertyNames, String> parentValues, + PropertyNames propertyKey) { + String value; + if( newValues.containsKey(propertyKey) ){ + value = newValues.get(propertyKey); + } + else{ + value = parentValues.get(propertyKey); + } + return Integer.valueOf(value); + } + + private boolean isPropertyChanged(Map<PropertyNames, String> newValues, Map<PropertyNames, String> parentValues, + final PropertyNames minInstances) { + return newValues.containsKey(minInstances) && newValues.containsKey(minInstances) && !newValues.get(minInstances).equals(parentValues.get(minInstances)); + } + + private Either<Boolean, ResponseFormat> validateMinMaxAndInitialCountPropertyLogicVF( + Map<PropertyNames, String> newValues, Map<PropertyNames, String> parentValues) { + + int latestMaxInstances = getLatestIntProperty(newValues, parentValues, PropertyNames.MAX_INSTANCES); + int latestInitialCount = getLatestIntProperty(newValues, parentValues, PropertyNames.INITIAL_COUNT); + int latestMinInstances = getLatestIntProperty(newValues, parentValues, PropertyNames.MIN_INSTANCES); + Either<Boolean, ResponseFormat> result = Either.left(true); + + if (isPropertyChanged(newValues, parentValues, PropertyNames.INITIAL_COUNT) && result.isLeft()) { + if (latestInitialCount > latestMaxInstances || latestInitialCount < latestMinInstances) { + result = Either.right( + componentsUtils.getResponseFormat(ActionStatus.INVALID_GROUP_INITIAL_COUNT_PROPERTY_VALUE, + PropertyNames.INITIAL_COUNT.getPropertyName(), String.valueOf(latestMinInstances), + String.valueOf(latestMaxInstances))); + } + } + if (isPropertyChanged(newValues, parentValues, PropertyNames.MAX_INSTANCES) && result.isLeft()) { + if (latestMaxInstances < latestInitialCount) { + result = Either.right(componentsUtils.getResponseFormat( + ActionStatus.INVALID_GROUP_PROPERTY_VALUE_LOWER_HIGHER, + PropertyNames.MAX_INSTANCES.getPropertyName(), "higher", String.valueOf(latestInitialCount))); + } + + } + if (isPropertyChanged(newValues, parentValues, PropertyNames.MIN_INSTANCES) && result.isLeft()) { + if (latestMinInstances > latestInitialCount) { + result = Either.right(componentsUtils.getResponseFormat( + ActionStatus.INVALID_GROUP_PROPERTY_VALUE_LOWER_HIGHER, + PropertyNames.MIN_INSTANCES.getPropertyName(), "lower", String.valueOf(latestInitialCount))); + } + + } + return result; + } + private Either<Boolean, ResponseFormat> validateMinMaxAndInitialCountPropertyLogic(Map<PropertyNames, String> newValues, Map<PropertyNames, String> currValues, Map<PropertyNames, String> parentValues) { + + Either<Boolean, ResponseFormat> result; + for(Entry<PropertyNames, String> entry : newValues.entrySet()){ + PropertyNames currPropertyName = entry.getKey(); + if(currPropertyName == PropertyNames.MIN_INSTANCES){ + String minValue = parentValues.get(PropertyNames.MIN_INSTANCES); + String maxValue = newValues.containsKey(PropertyNames.INITIAL_COUNT) ? newValues.get(PropertyNames.MAX_INSTANCES) : currValues.get(PropertyNames.INITIAL_COUNT); + result = validateValueInRange(new ImmutablePair<PropertyNames, String>(currPropertyName, entry.getValue()), + new ImmutablePair<PropertyNames, String>(PropertyNames.MIN_INSTANCES, minValue), + new ImmutablePair<PropertyNames, String>(PropertyNames.MAX_INSTANCES, maxValue)); + if(result.isRight()){ + return result; + } + } + else if(currPropertyName == PropertyNames.INITIAL_COUNT){ + String minValue = newValues.containsKey(PropertyNames.MIN_INSTANCES) ? newValues.get(PropertyNames.MIN_INSTANCES) : currValues.get(PropertyNames.MIN_INSTANCES); + String maxValue = newValues.containsKey(PropertyNames.MAX_INSTANCES) ? newValues.get(PropertyNames.MAX_INSTANCES) : currValues.get(PropertyNames.MAX_INSTANCES); + result = validateValueInRange(new ImmutablePair<PropertyNames, String>(currPropertyName, entry.getValue()), + new ImmutablePair<PropertyNames, String>(PropertyNames.MIN_INSTANCES,minValue), + new ImmutablePair<PropertyNames, String>(PropertyNames.MAX_INSTANCES, maxValue)); + if(result.isRight()){ + return result; + } + } + else if(currPropertyName == PropertyNames.MAX_INSTANCES){ + String minValue = newValues.containsKey(PropertyNames.INITIAL_COUNT) ? newValues.get(PropertyNames.MIN_INSTANCES) : currValues.get(PropertyNames.INITIAL_COUNT); + String maxValue = parentValues.get(PropertyNames.MAX_INSTANCES); + result = validateValueInRange(new ImmutablePair<PropertyNames, String>(currPropertyName, entry.getValue()), + new ImmutablePair<PropertyNames, String>(PropertyNames.MIN_INSTANCES, minValue), + new ImmutablePair<PropertyNames, String>(PropertyNames.MAX_INSTANCES, maxValue)); + if(result.isRight()){ + return result; } + } + } + return Either.left(true); + } + private Either<Boolean, ResponseFormat> validateValueInRange(ImmutablePair<PropertyNames,String> newValue, ImmutablePair<PropertyNames,String> min, ImmutablePair<PropertyNames,String> max) { + Either<Boolean, ResponseFormat> result; + final String warnMessage = "Failed to validate {} as property value of {}. It must be not higher than {}, and not lower than {}."; + int newValueInt = parseIntValue(newValue.getValue(), newValue.getKey()); + int minInt = parseIntValue(min.getValue(), min.getKey()); + int maxInt = parseIntValue(max.getValue(), max.getKey()); + if(newValueInt < 0 || minInt < 0 || maxInt < 0){ + result = Either.right(componentsUtils.getResponseFormat(ActionStatus.INVALID_PROPERTY)); + } + else if (newValueInt < minInt || newValueInt > maxInt) { + log.debug(warnMessage, newValue.getValue(), newValue.getKey().getPropertyName(), min.getValue(), max.getValue()); + result = Either.right(componentsUtils.getResponseFormat( + ActionStatus.INVALID_GROUP_MIN_MAX_INSTANCES_PROPERTY_VALUE, + newValue.getKey().getPropertyName(), maxInt == Integer.MAX_VALUE ? Constants.UNBOUNDED : max.getValue(), min.getValue())); + }else{ + result = Either.left(true); + } + return result; + } + + private int parseIntValue(String value, PropertyNames propertyName) { + int result; + if(propertyName == PropertyNames.MAX_INSTANCES ){ + result = convertIfUnboundMax(value); + } else if (NumberUtils.isNumber(value)) { + result = Integer.parseInt(value); + } else{ + result = -1; + } + return result; + } + +/** + * validates received new property values and updates group instance in case of success + * @param oldGroupInstance + * @param groupInstanceId + * @param newProperties + * @param inTransaction + * @return + */ + public Either<GroupInstance, ResponseFormat> validateAndUpdateGroupInstancePropertyValues(String componentId, String instanceId, GroupInstance oldGroupInstance, List<GroupInstanceProperty> newProperties, boolean inTransaction) { + + Either<GroupInstance, ResponseFormat> actionResult = null; + Either<GroupInstance, StorageOperationStatus> updateGroupInstanceResult = null; + Either<List<GroupInstanceProperty>, ResponseFormat> validateRes = validateReduceGroupInstancePropertiesBeforeUpdate(oldGroupInstance, newProperties); + if(validateRes.isRight()){ + log.debug("Failed to validate group instance {} properties before update. ", oldGroupInstance.getName()); + actionResult = Either.right(validateRes.right().value()); + } + if(actionResult == null){ + List<GroupInstanceProperty> validatedReducedNewProperties = validateRes.left().value(); + updateGroupInstanceResult = groupsOperation.updateGroupInstancePropertyValuesOnGraph(componentId, instanceId, oldGroupInstance, validatedReducedNewProperties); + if(updateGroupInstanceResult.isRight()){ + log.debug("Failed to update group instance {} property values. ", oldGroupInstance.getName()); + actionResult = Either.right(componentsUtils.getResponseFormat(componentsUtils.convertFromStorageResponse(updateGroupInstanceResult.right().value()))); + } + } + if(actionResult == null){ + actionResult = Either.left(updateGroupInstanceResult.left().value()); + } + return actionResult; + } + + private Either<List<GroupInstanceProperty>, ResponseFormat> validateReduceGroupInstancePropertiesBeforeUpdate(GroupInstance oldGroupInstance, List<GroupInstanceProperty> newProperties) { + + Either<Boolean, ResponseFormat> validationRes = null; + Either<List<GroupInstanceProperty>, ResponseFormat> actionResult; + Map<String,GroupInstanceProperty> existingProperties = oldGroupInstance.convertToGroupInstancesProperties().stream().collect(Collectors.toMap(p->p.getName(),p->p)); + Map<PropertyNames, String> newPropertyValues = new EnumMap<>(PropertyNames.class); + List<GroupInstanceProperty> reducedProperties = new ArrayList<>(); + String currPropertyName; + try{ + for(GroupInstanceProperty currNewProperty : newProperties){ + currPropertyName = currNewProperty.getName(); + validationRes = handleAndAddProperty(reducedProperties, newPropertyValues, currNewProperty, existingProperties.get(currPropertyName)); + if(validationRes.isRight()){ + log.debug("Failed to handle property {} of group instance {}. ", currPropertyName, oldGroupInstance.getName()); + break; + } } + if(validationRes == null || validationRes.isLeft()){ + Map<PropertyNames, String> existingPropertyValues = new EnumMap<>(PropertyNames.class); + Map<PropertyNames, String> parentPropertyValues = new EnumMap<>(PropertyNames.class); + fillValuesAndParentValuesFromExistingProperties(existingProperties, existingPropertyValues, parentPropertyValues); + validationRes = validateMinMaxAndInitialCountPropertyLogic(newPropertyValues, existingPropertyValues, parentPropertyValues); + } + if(validationRes.isLeft()){ + actionResult = Either.left(reducedProperties); + } else { + actionResult = Either.right(validationRes.right().value()); + } + } catch( Exception e){ + log.error("Exception occured during validation and reducing group instance properties. The message is {}", e.getMessage(), e); + actionResult = Either.right(componentsUtils.getResponseFormat(ActionStatus.GENERAL_ERROR)); + } + return actionResult; + } + private void fillValuesAndParentValuesFromExistingProperties(Map<String, GroupInstanceProperty> existingProperties, + Map<PropertyNames, String> propertyValues, Map<PropertyNames, String> parentPropertyValues) { + PropertyNames[] allPropertyNames = PropertyNames.values(); + for(PropertyNames name : allPropertyNames){ + if(isUpdatable(name)){ + propertyValues.put(name, String.valueOf(existingProperties.get(name.getPropertyName()).getValue())); + parentPropertyValues.put(name, String.valueOf(existingProperties.get(name.getPropertyName()).getParentValue())); + } } + } + private Either<Boolean, ResponseFormat> handleAndAddProperty(List<GroupInstanceProperty> reducedProperties, Map<PropertyNames, String> newPropertyValues, + GroupInstanceProperty currNewProperty, GroupInstanceProperty currExistingProperty) { + + Either<Boolean, ResponseFormat> validationRes = null; + String currPropertyName = currNewProperty.getName(); + PropertyNames propertyName = PropertyNames.findName(currPropertyName); + try{ + if(currExistingProperty == null){ + log.warn("The value of property with the name {} cannot be updated. The property not found on group instance. ", currPropertyName); + } + else if(isUpdatable(propertyName)){ + validationRes = validateAndUpdatePropertyValue(currNewProperty, currExistingProperty); + if(validationRes.isRight()){ + log.debug("Failed to validate property value {} of property {}. ", currNewProperty.getValue() , currPropertyName); + } else { + addPropertyUpdatedValues(reducedProperties, propertyName, newPropertyValues, currNewProperty, currExistingProperty); + } + } + else{ + validateImmutableProperty(currExistingProperty, currNewProperty); + } + if(validationRes == null){ + validationRes = Either.left(true); + } + } catch( Exception e){ + log.error("Exception occured during handle and adding property. The message is {}", e.getMessage(), e); + validationRes = Either.right(componentsUtils.getResponseFormat(ActionStatus.GENERAL_ERROR)); + } + return validationRes; } + private boolean isUpdatable(PropertyNames updatablePropertyName) { + return updatablePropertyName != null && + updatablePropertyName.getUpdateBehavior().getLevelNumber() >= GroupInstancePropertyValueUpdateBehavior.UPDATABLE_ON_SERVICE_LEVEL.getLevelNumber(); + } + + private void addPropertyUpdatedValues(List<GroupInstanceProperty> reducedProperties, PropertyNames propertyName, Map<PropertyNames, String> newPropertyValues, + GroupInstanceProperty newProperty, GroupInstanceProperty existingProperty) { + + String newValue = newProperty.getValue(); + if(!newValue.equals(String.valueOf(existingProperty.getValue()))){ + newProperty.setValueUniqueUid(existingProperty.getValueUniqueUid()); + reducedProperties.add(newProperty); + } + if(!isEmptyMinInitialCountValue(propertyName, newValue)){ + newPropertyValues.put(propertyName, newValue); + } + } + + private boolean isEmptyMinInitialCountValue(PropertyNames propertyName, String newValue) { + boolean result = false; + if((propertyName == PropertyNames.MIN_INSTANCES || propertyName == PropertyNames.INITIAL_COUNT) && !NumberUtils.isNumber(newValue)){ + result = true; + } + return result; + } + + private int convertIfUnboundMax(String value) { + + int result; + if(!NumberUtils.isNumber(value)){ + result = Integer.MAX_VALUE; + } + else{ + result = Integer.parseInt(value); + } + return result; + } + + private Either<Boolean, ResponseFormat> validateAndUpdatePropertyValue(GroupInstanceProperty newProperty, GroupInstanceProperty existingProperty) { + + Either<Boolean, ResponseFormat> validationRes = null; + String parentValue = existingProperty.getParentValue(); + + newProperty.setParentValue(parentValue); + if(StringUtils.isEmpty(newProperty.getValue())){ + newProperty.setValue(parentValue); + } + if(StringUtils.isEmpty(existingProperty.getValue())){ + existingProperty.setValue(parentValue); + } + StorageOperationStatus status = groupOperation.validateAndUpdatePropertyValue(newProperty); + if(status != StorageOperationStatus.OK){ + log.debug("Failed to validate property value {} of property with name {}. Status is {}. ", newProperty.getValue(), newProperty.getName(), status); + validationRes = Either.right(componentsUtils.getResponseFormat(componentsUtils.convertFromStorageResponse(status))); + } + if(validationRes == null){ + validationRes = Either.left(true); + } + return validationRes; + } + + private void validateImmutableProperty(GroupProperty oldProperty, GroupProperty newProperty) { + if(oldProperty.getValue() == null && newProperty.getValue() != null || oldProperty.getValue()!=null && !oldProperty.getValue().equals(newProperty.getValue())){ + log.warn("The value of property with the name {} cannot be updated on service level. Going to ignore new property value {}. ",oldProperty.getName(), newProperty.getValue()); + } + } + + public Either<List<GroupDefinition>, ResponseFormat> createGroups(Component component, User user, ComponentTypeEnum componentType, List<GroupDefinition> groupDefinitions) { + + Map<String,GroupDataDefinition> groups = new HashMap<>(); + //Map<String, MapPropertiesDataDefinition> groupsPropertiesMap = new HashMap<>(); + Either<List<GroupDefinition>, ResponseFormat> result = null; + Either<List<GroupDefinition>, StorageOperationStatus> createGroupsResult = null; + Either<Map<String, DataTypeDefinition>, TitanOperationStatus> allDataTypes = dataTypeCache.getAll(); + if (allDataTypes.isRight()) { + TitanOperationStatus status = allDataTypes.right().value(); + BeEcompErrorManager.getInstance().logInternalFlowError("AddPropertyToGroup", "Failed to add property to group. Status is " + status, ErrorSeverity.ERROR); + return Either.right(componentsUtils.getResponseFormat(componentsUtils.convertFromStorageResponse(DaoStatusConverter.convertTitanStatusToStorageStatus(status)))); + + } + + //handle groups and convert to tosca data + if (groupDefinitions != null && !groupDefinitions.isEmpty()) { + for (GroupDefinition groupDefinition : groupDefinitions) { + Either<GroupDefinition, ResponseFormat> handleGroupRes = handleGroup(component, user, componentType, groupDefinition, allDataTypes.left().value()); + if (handleGroupRes.isRight()) { + result = Either.right(handleGroupRes.right().value()); + break; + } + GroupDefinition handledGroup = handleGroupRes.left().value(); + groups.put(handledGroup.getName(), new GroupDataDefinition(handledGroup)); + + } + } + if(result == null){ + createGroupsResult = groupsOperation.createGroups(component, user, componentType, groups); + if(createGroupsResult.isRight()){ + result = Either.right(componentsUtils.getResponseFormat(componentsUtils.convertFromStorageResponse(createGroupsResult.right().value()))); + } + } + if(result == null){ + result = Either.left(createGroupsResult.left().value()); + } + return result; + } + + public Either<List<GroupDefinition>, ResponseFormat> addGroups(Component component, User user, ComponentTypeEnum componentType, List<GroupDefinition> groupDefinitions) { + + + Either<List<GroupDefinition>, ResponseFormat> result = null; + Either<List<GroupDefinition>, StorageOperationStatus> createGroupsResult = null; + List<GroupDataDefinition> groups = new ArrayList<>(); + + Either<Map<String, DataTypeDefinition>, TitanOperationStatus> allDataTypes = dataTypeCache.getAll(); + if (allDataTypes.isRight()) { + TitanOperationStatus status = allDataTypes.right().value(); + BeEcompErrorManager.getInstance().logInternalFlowError("AddPropertyToGroup", "Failed to add property to group. Status is " + status, ErrorSeverity.ERROR); + return Either.right(componentsUtils.getResponseFormat(componentsUtils.convertFromStorageResponse(DaoStatusConverter.convertTitanStatusToStorageStatus(status)))); + + } + + //handle groups and convert to tosca data + if (groupDefinitions != null && !groupDefinitions.isEmpty()) { + for (GroupDefinition groupDefinition : groupDefinitions) { + Either<GroupDefinition, ResponseFormat> handleGroupRes = handleGroup(component, user, componentType, groupDefinition, allDataTypes.left().value()); + if (handleGroupRes.isRight()) { + result = Either.right(handleGroupRes.right().value()); + break; + } + GroupDefinition handledGroup = handleGroupRes.left().value(); + groups.add(new GroupDataDefinition(handledGroup)); + } + } + if(result == null){ + createGroupsResult = groupsOperation.addGroups(component, user, componentType, groups); + if(createGroupsResult.isRight()){ + result = Either.right(componentsUtils.getResponseFormat(componentsUtils.convertFromStorageResponse(createGroupsResult.right().value()))); + } + } + if(result == null){ + result = Either.left(createGroupsResult.left().value()); + } + return result; + } + + public Either<List<GroupDefinition>, ResponseFormat> deleteGroups(Component component, User user, ComponentTypeEnum componentType, List<GroupDefinition> groupDefinitions) { + + + Either<List<GroupDefinition>, ResponseFormat> result = null; + Either<List<GroupDefinition>, StorageOperationStatus> createGroupsResult = null; + + createGroupsResult = groupsOperation.deleteGroups(component, user, componentType, groupDefinitions.stream().map(x-> new GroupDataDefinition(x)).collect(Collectors.toList())); + if(createGroupsResult.isRight()){ + result = Either.right(componentsUtils.getResponseFormat(componentsUtils.convertFromStorageResponse(createGroupsResult.right().value()))); + } + + if(result == null){ + result = Either.left(createGroupsResult.left().value()); + } + return result; + } + + /** + * Update specific group version + * + * @param groupDefinition + * @param inTransaction + * @return + */ + public Either<List<GroupDefinition>, ResponseFormat> updateGroups(Component component, ComponentTypeEnum componentType, List<GroupDefinition> groupDefinitions) { + + Either<List<GroupDefinition>, ResponseFormat> result = null; + Either<List<GroupDefinition>, StorageOperationStatus> createGroupsResult = null; + + createGroupsResult = groupsOperation.updateGroups(component, componentType, groupDefinitions.stream().map(x-> new GroupDataDefinition(x)).collect(Collectors.toList())); + if(createGroupsResult.isRight()){ + result = Either.right(componentsUtils.getResponseFormat(componentsUtils.convertFromStorageResponse(createGroupsResult.right().value()))); + } + + if(result == null){ + result = Either.left(createGroupsResult.left().value()); + } + return result; + } + + public Either<GroupDefinition, ResponseFormat> handleGroup(Component component, User user, ComponentTypeEnum componentType, GroupDefinition groupDefinition, Map<String, DataTypeDefinition> allDAtaTypes) { + + Either<GroupDefinition, ResponseFormat> result = null; + + log.trace("Going to create group {}" , groupDefinition); + // 3. verify group not already exist + List<GroupDefinition> groups = component.getGroups(); + boolean found = false; + if (groups != null && false == groups.isEmpty()) { + + GroupDefinition existGroupDef = groups.stream().filter(p -> p.getName().equalsIgnoreCase(groupDefinition.getName())).findFirst().orElse(null); + + found = existGroupDef != null; + } + if (true == found) { + String componentTypeForResponse = getComponentTypeForResponse(component); + result = Either.right(componentsUtils.getResponseFormat(ActionStatus.GROUP_ALREADY_EXIST, groupDefinition.getName(), component.getNormalizedName(), componentTypeForResponse)); + return result; + } + // 4. verify type of group exist + String groupType = groupDefinition.getType(); + if (groupType == null || groupType.isEmpty()) { + result = Either.right(componentsUtils.getResponseFormat(ActionStatus.GROUP_MISSING_GROUP_TYPE, groupDefinition.getName())); + return result; + } + Either<GroupTypeDefinition, StorageOperationStatus> getGroupType = groupTypeOperation.getLatestGroupTypeByType(groupType, true); + if (getGroupType.isRight()) { + StorageOperationStatus status = getGroupType.right().value(); + if (status == StorageOperationStatus.NOT_FOUND) { + BeEcompErrorManager.getInstance().logInvalidInputError(CREATE_GROUP, "group type " + groupType + " cannot be found", ErrorSeverity.INFO); + result = Either.right(componentsUtils.getResponseFormat(ActionStatus.GROUP_TYPE_IS_INVALID, groupType)); + return result; + } else { + result = Either.right(componentsUtils.getResponseFormat(ActionStatus.GENERAL_ERROR)); + return result; + } + } + // 6. verify the component instances type are allowed according to + // the member types in the group type + GroupTypeDefinition groupTypeDefinition = getGroupType.left().value(); + + Either<Boolean, ResponseFormat> areValidMembers = verifyComponentInstancesAreValidMembers(component, componentType, groupDefinition.getName(), groupType, groupDefinition.getMembers(), groupTypeDefinition.getMembers()); + + if (areValidMembers.isRight()) { + ResponseFormat responseFormat = areValidMembers.right().value(); + result = Either.right(responseFormat); + return result; + } + // 7. verify the artifacts belongs to the component + Either<Boolean, ResponseFormat> areValidArtifacts = verifyArtifactsBelongsToComponent(component, groupDefinition.getArtifacts(), CREATE_GROUP); + if (areValidArtifacts.isRight()) { + ResponseFormat responseFormat = areValidArtifacts.right().value(); + result = Either.right(responseFormat); + return result; + } + List<PropertyDefinition> groupTypeProperties = groupTypeDefinition.getProperties(); + + List<GroupProperty> properties = groupDefinition.convertToGroupProperties(); + List<GroupProperty> updatedGroupTypeProperties = new ArrayList<>(); + if (properties != null && false == properties.isEmpty()) { + + if (groupTypeProperties == null || true == groupTypeProperties.isEmpty()) { + BeEcompErrorManager.getInstance().logInvalidInputError(ADDING_GROUP, "group type does not have properties", ErrorSeverity.INFO); + return Either.right(componentsUtils.getResponseFormat(componentsUtils.convertFromStorageResponse(DaoStatusConverter.convertTitanStatusToStorageStatus(TitanOperationStatus.MATCH_NOT_FOUND)))); + } + + Map<String, PropertyDefinition> groupTypePropertiesMap = groupTypeProperties.stream().collect(Collectors.toMap(p -> p.getName(), p -> p)); + + Either<GroupProperty, TitanOperationStatus> addPropertyResult = null; + int i = 1; + for (GroupProperty prop : properties) { + addPropertyResult = handleProperty(prop, groupTypePropertiesMap.get(prop.getName()), i, allDAtaTypes); + if(addPropertyResult.isRight()){ + BeEcompErrorManager.getInstance().logInvalidInputError(ADDING_GROUP, "failed to validate property", ErrorSeverity.INFO); + return Either.right(componentsUtils.getResponseFormat(componentsUtils.convertFromStorageResponse(DaoStatusConverter.convertTitanStatusToStorageStatus(addPropertyResult.right().value())))); + } + updatedGroupTypeProperties.add(addPropertyResult.left().value()); + + i++; + } + } + if(groupDefinition.getUniqueId() == null){ + String uid = UniqueIdBuilder.buildGroupingUid(component.getUniqueId(), groupDefinition.getName()); + groupDefinition.setUniqueId(uid); + } + groupDefinition.convertFromGroupProperties(updatedGroupTypeProperties); + groupDefinition.setInvariantUUID(UniqueIdBuilder.buildInvariantUUID()); + groupDefinition.setGroupUUID(UniqueIdBuilder.generateUUID()); + groupDefinition.setVersion(INITIAL_VERSION); + groupDefinition.setTypeUid(groupTypeDefinition.getUniqueId()); + + return Either.left(groupDefinition); + } + + + + public Either<GroupProperty, TitanOperationStatus> handleProperty(GroupProperty groupProperty, PropertyDefinition prop, Integer index, Map<String, DataTypeDefinition> allDataTypes) { + + if (prop == null) { + return Either.right(TitanOperationStatus.ILLEGAL_ARGUMENT); + } + + PropertyDataDefinition propDataDef = prop; + String propertyType = propDataDef.getType(); + String value = groupProperty.getValue(); + + Either<String, TitanOperationStatus> checkInnerType = propertyOperation.checkInnerType(propDataDef); + if (checkInnerType.isRight()) { + TitanOperationStatus status = checkInnerType.right().value(); + return Either.right(status); + } + + String innerType = checkInnerType.left().value(); + + + log.debug("Before validateAndUpdatePropertyValue"); + Either<Object, Boolean> isValid = propertyOperation.validateAndUpdatePropertyValue(propertyType, value, innerType, allDataTypes); + log.debug("After validateAndUpdatePropertyValue. isValid = {}", isValid); + + String newValue = value; + if (isValid.isRight()) { + Boolean res = isValid.right().value(); + if (res == false) { + return Either.right(TitanOperationStatus.ILLEGAL_ARGUMENT); + } + } else { + Object object = isValid.left().value(); + if (object != null) { + newValue = object.toString(); + } + } + + String uniqueId = UniqueIdBuilder.buildGroupPropertyValueUid((String) prop.getUniqueId(), index); + + groupProperty.setUniqueId(uniqueId); + groupProperty.setValue(newValue); + groupProperty.setType(prop.getType()); + groupProperty.setDefaultValue(prop.getDefaultValue()); + groupProperty.setDescription(prop.getDescription()); + groupProperty.setSchema(prop.getSchema()); + groupProperty.setPassword(prop.isPassword()); + groupProperty.setParentUniqueId(prop.getUniqueId()); + + + log.debug("Before adding property value to graph {}", groupProperty); + + + return Either.left(groupProperty); + } + + + + } |