Implement HTTPS calls into DCAE-DS DT

Implemented HTTPS calls into dcaedt_be
-Added p12 keystore certificate.
-Updated application configuration.
-Added trust-store.
-Updated the onap/base_sdc-jetty docker image version
-Updated the chef script to properly used of new  docker image version

Issue-ID: SDC-2522
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: I90a7dfb4d32ed661e632b79ce5b55d349177edce

20 files changed, 58 insertions, 129 deletions

diff --git a/Dockerfile b/Dockerfile
index d45fefa..5d7f8f2 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,25 +1,15 @@
-FROM onap/base_sdc-jetty:1.2.0-SNAPSHOT-latest
+FROM onap/base_sdc-jetty:1.4.1
 
-COPY docker/chef-solo /var/opt/dcae-dt/chef-solo/
+COPY docker/chef-solo /root/chef-solo/
 
-COPY docker/startup.sh /var/opt/dcae-dt/
+COPY docker/chef-repo/cookbooks /root/chef-solo/cookbooks/
 
-ADD target/dcae-dt.war ${JETTY_BASE}/webapps/
+ADD --chown=jetty:jetty target/dcae-dt.war ${JETTY_BASE}/webapps/
 
 USER root
 
-RUN mkdir -p /opt/logs/dcae-dt
+COPY docker/startup.sh /root/
 
-COPY docker/set_user.sh /tmp/set_user.sh
+RUN chmod 770 /root/startup.sh
 
-RUN sh -x /tmp/set_user.sh && rm -f /tmp/set_user.sh
-
-RUN chown -R jetty:jetty ${JETTY_BASE}/webapps  /var/opt/dcae-dt  /opt/logs  /var/lib/jetty
-
-RUN chmod 770 /var/opt/dcae-dt/startup.sh
-
-EXPOSE 8186 9446
-
-USER jetty
-
-ENTRYPOINT [ "/var/opt/dcae-dt/startup.sh" ]
\ No newline at end of file
+ENTRYPOINT [ "/root/startup.sh" ]
diff --git a/docker/chef-solo/cookbooks/dcae-dt/README.md b/docker/chef-repo/cookbooks/dcae-dt/README.md
index de00ec4..de00ec4 100644
--- a/docker/chef-solo/cookbooks/dcae-dt/README.md
+++ b/docker/chef-repo/cookbooks/dcae-dt/README.md
diff --git a/docker/chef-solo/cookbooks/dcae-dt/attributes/default.rb b/docker/chef-repo/cookbooks/dcae-dt/attributes/default.rb
index 22650c5..05e9fd8 100644
--- a/docker/chef-solo/cookbooks/dcae-dt/attributes/default.rb
+++ b/docker/chef-repo/cookbooks/dcae-dt/attributes/default.rb
@@ -11,9 +11,9 @@ default['DCAE']['FE'][:https_port] = 9444
 default['DCAE']['DT'][:http_port] = 8186
 default['DCAE']['DT'][:https_port] = 9446
 
-default['jetty'][:keystore_pwd] = "OBF:1cp61iuj194s194u194w194y1is31cok"
-default['jetty'][:keymanager_pwd] = "OBF:1cp61iuj194s194u194w194y1is31cok"
-default['jetty'][:truststore_pwd] = "OBF:1cp61iuj194s194u194w194y1is31cok"
+default['jetty']['keystore_pwd'] = "rTIS;B4kM]2GHcNK2c3B4&Ng"
+default['jetty']['keymanager_pwd'] = "rTIS;B4kM]2GHcNK2c3B4&Ng"
+default['jetty']['truststore_pwd'] = "Y,f975ZNJfVZhV*{+Y[}pA?0"
 
 default['disableHttp'] = true
 
diff --git a/docker/chef-repo/cookbooks/dcae-dt/chefignore b/docker/chef-repo/cookbooks/dcae-dt/chefignore
new file mode 100644
index 0000000..ba30af6
--- /dev/null
+++ b/docker/chef-repo/cookbooks/dcae-dt/chefignore
@@ -0,0 +1,11 @@
+# Put files/directories that should be ignored in this file.
+# Lines that start with '# ' are comments.
+
+# emacs
+*~
+
+# vim
+*.sw[a-z]
+
+# subversion
+*/.svn/*
diff --git a/docker/chef-repo/cookbooks/dcae-dt/files/default/org.onap.sdc.p12 b/docker/chef-repo/cookbooks/dcae-dt/files/default/org.onap.sdc.p12
new file mode 100644
index 0000000..ee000dc
--- /dev/null
+++ b/docker/chef-repo/cookbooks/dcae-dt/files/default/org.onap.sdc.p12
diff --git a/docker/chef-repo/cookbooks/dcae-dt/files/default/org.onap.sdc.trust.jks b/docker/chef-repo/cookbooks/dcae-dt/files/default/org.onap.sdc.trust.jks
new file mode 100644
index 0000000..342c4f2
--- /dev/null
+++ b/docker/chef-repo/cookbooks/dcae-dt/files/default/org.onap.sdc.trust.jks
diff --git a/docker/chef-solo/cookbooks/dcae-dt/recipes/dcae_dt_setup.rb b/docker/chef-repo/cookbooks/dcae-dt/recipes/dcae_dt_setup.rb
index 240ea10..69d5a03 100644
--- a/docker/chef-solo/cookbooks/dcae-dt/recipes/dcae_dt_setup.rb
+++ b/docker/chef-repo/cookbooks/dcae-dt/recipes/dcae_dt_setup.rb
@@ -1,16 +1,11 @@
-jetty_base = "#{node['JETTY_BASE']}"
-dcae_logs = "#{node['APP_LOG_DIR']}"
-
 dcae_fe_vip = node['DCAE_FE_VIP']
 
 if node['disableHttp']
   protocol = "https"
-  dcae_be_port = node['DCAE']['BE'][:https_port]
   dcae_fe_port = node['DCAE']['FE'][:https_port]
   dcae_dt_port = node['DCAE']['DT'][:https_port]
 else
   protocol = "http"
-  dcae_be_port = node['DCAE']['BE'][:http_port]
   dcae_fe_port = node['DCAE']['FE'][:http_port]
   dcae_dt_port = node['DCAE']['DT'][:http_port]
 end
@@ -18,7 +13,15 @@ end
 printf("DEBUG: [%s]:[%s] disableHttp=[%s], protocol=[%s], dcae_dt_port=[%s] !!! \n", cookbook_name, recipe_name, node['disableHttp'], protocol, dcae_dt_port )
 
 
-directory "#{jetty_base}/config" do
+directory "DT_tempdir_creation" do
+    path "#{ENV['JETTY_BASE']}/temp"
+    owner 'jetty'
+    group 'jetty'
+    mode '0755'
+    action :create
+end
+
+directory "#{ENV['JETTY_BASE']}/config" do
   owner "jetty"
   group "jetty"
   mode '0755'
@@ -26,7 +29,7 @@ directory "#{jetty_base}/config" do
   action :create
 end
 
-directory "#{jetty_base}/config/dcae-dt" do
+directory "#{ENV['JETTY_BASE']}/config/dcae-dt" do
   owner "jetty"
   group "jetty"
   mode '0755'
@@ -36,12 +39,12 @@ end
 
 template "dcae-dt-config" do
   sensitive true
-  path "#{jetty_base}/config/dcae-dt/application.properties"
+  path "#{ENV['JETTY_BASE']}/config/dcae-dt/application.properties"
   source "dcae-application.properties.erb"
   owner "jetty"
   group "jetty"
   mode "0755"
-  variables ({
+  variables({
     :dcae_fe_vip => dcae_fe_vip,
     :dcae_fe_port => dcae_fe_port,
     :protocol => protocol,
@@ -52,18 +55,9 @@ end
 
 template "dcae-logback-spring-config" do
   sensitive true
-  path "#{jetty_base}/config/dcae-dt/logback-spring.xml"
+  path "#{ENV['JETTY_BASE']}/config/dcae-dt/logback-spring.xml"
   source "dcae-logback-spring.erb"
   owner "jetty"
   group "jetty"
   mode "0755"
 end
-
-
-directory "#{dcae_logs}" do
-  owner "jetty"
-  group "jetty"
-  mode '0755'
-  recursive true
-  action :create
-end
diff --git a/docker/chef-solo/cookbooks/dcae-dt/recipes/jetty_setup.rb b/docker/chef-repo/cookbooks/dcae-dt/recipes/jetty_setup.rb
index f07f0e9..28bbf3c 100644
--- a/docker/chef-solo/cookbooks/dcae-dt/recipes/jetty_setup.rb
+++ b/docker/chef-repo/cookbooks/dcae-dt/recipes/jetty_setup.rb
@@ -1,6 +1,3 @@
-jetty_base = "#{node['JETTY_BASE']}"
-jetty_home = "#{node['JETTY_HOME']}"
-
 #Set the http module option
 if node['disableHttp']
   http_option = "#--module=http"
@@ -13,7 +10,7 @@ printf("DEBUG: [%s]:[%s] disableHttp=[%s], http_option=[%s] !!! \n", cookbook_na
 
 
 directory "Jetty_etcdir_creation" do
-    path "/#{jetty_base}/etc"
+    path "#{ENV['JETTY_BASE']}/etc"
     owner 'jetty'
     group 'jetty'
     mode '0755'
@@ -22,61 +19,61 @@ end
 
 
 # Create Keystore
-cookbook_file "#{jetty_base}/etc/keystore" do
-   source "keystore"
+cookbook_file "#{ENV['JETTY_BASE']}/etc/org.onap.sdc.p12" do
+   source "org.onap.sdc.p12"
    owner "jetty"
    group "jetty"
    mode 0755
 end
 
 # Create Trustore
-cookbook_file "#{jetty_base}/etc/truststore" do
-   source "truststore"
+cookbook_file "#{ENV['JETTY_BASE']}/etc/org.onap.sdc.trust.jks" do
+   source "org.onap.sdc.trust.jks"
    owner "jetty"
    group "jetty"
    mode 0755
 end
 
 bash "create-jetty-modules" do
-  cwd "#{jetty_base}"
+  cwd "#{ENV['JETTY_BASE']}"
   code <<-EOH
-    cd "#{jetty_base}"
-    java -jar "#{jetty_home}"/start.jar --add-to-start=deploy
-    java -jar "#{jetty_home}"/start.jar --add-to-startd=http,https,logging,setuid
+    cd "#{ENV['JETTY_BASE']}"
+    java -jar "#{ENV['JETTY_HOME']}"/start.jar --add-to-start=deploy
+    java -jar "#{ENV['JETTY_HOME']}"/start.jar --add-to-startd=http,https,console-capture,setuid
   EOH
 end
 
 # configure Jetty modules
 template "http-ini" do
-   path "#{jetty_base}/start.d/http.ini"
+   path "#{ENV['JETTY_BASE']}/start.d/http.ini"
    source "http-ini.erb"
    owner "jetty"
    group "jetty"
    mode "0755"
-   variables ({
+   variables({
      :http_option => http_option ,
      :http_port => "#{node['DCAE']['DT'][:http_port]}"
     })
 end
 
 template "https-ini" do
-   path "#{jetty_base}/start.d/https.ini"
+   path "#{ENV['JETTY_BASE']}/start.d/https.ini"
    source "https-ini.erb"
    owner "jetty"
    group "jetty"
    mode "0755"
-   variables ({
+   variables({
      :https_port => "#{node['DCAE']['DT'][:https_port]}"
    })
 end
 
 template "ssl-ini" do
-   path "#{jetty_base}/start.d/ssl.ini"
+   path "#{ENV['JETTY_BASE']}/start.d/ssl.ini"
    source "ssl-ini.erb"
    owner "jetty"
    group "jetty"
    mode "0755"
-   variables ({
+   variables({
      :https_port => "#{node['DCAE']['DT'][:https_port]}" ,
      :jetty_keystore_pwd => "#{node['jetty'][:keystore_pwd]}" ,
      :jetty_keymanager_pwd => "#{node['jetty'][:keymanager_pwd]}" ,
diff --git a/docker/chef-solo/cookbooks/dcae-dt/templates/default/dcae-application.properties.erb b/docker/chef-repo/cookbooks/dcae-dt/templates/default/dcae-application.properties.erb
index 789d103..789d103 100644
--- a/docker/chef-solo/cookbooks/dcae-dt/templates/default/dcae-application.properties.erb
+++ b/docker/chef-repo/cookbooks/dcae-dt/templates/default/dcae-application.properties.erb
diff --git a/docker/chef-solo/cookbooks/dcae-dt/templates/default/dcae-logback-spring.erb b/docker/chef-repo/cookbooks/dcae-dt/templates/default/dcae-logback-spring.erb
index 7c0bfb6..7c0bfb6 100644
--- a/docker/chef-solo/cookbooks/dcae-dt/templates/default/dcae-logback-spring.erb
+++ b/docker/chef-repo/cookbooks/dcae-dt/templates/default/dcae-logback-spring.erb
diff --git a/docker/chef-solo/cookbooks/dcae-dt/templates/default/http-ini.erb b/docker/chef-repo/cookbooks/dcae-dt/templates/default/http-ini.erb
index 8f26690..8f26690 100644
--- a/docker/chef-solo/cookbooks/dcae-dt/templates/default/http-ini.erb
+++ b/docker/chef-repo/cookbooks/dcae-dt/templates/default/http-ini.erb
diff --git a/docker/chef-solo/cookbooks/dcae-dt/templates/default/https-ini.erb b/docker/chef-repo/cookbooks/dcae-dt/templates/default/https-ini.erb
index 9999a41..9999a41 100644
--- a/docker/chef-solo/cookbooks/dcae-dt/templates/default/https-ini.erb
+++ b/docker/chef-repo/cookbooks/dcae-dt/templates/default/https-ini.erb
diff --git a/docker/chef-solo/cookbooks/dcae-dt/templates/default/ssl-ini.erb b/docker/chef-repo/cookbooks/dcae-dt/templates/default/ssl-ini.erb
index 9abac51..278fdea 100644
--- a/docker/chef-solo/cookbooks/dcae-dt/templates/default/ssl-ini.erb
+++ b/docker/chef-repo/cookbooks/dcae-dt/templates/default/ssl-ini.erb
@@ -42,10 +42,10 @@ jetty.ssl.port=<%= @https_port %>
 ## See http://www.eclipse.org/jetty/documentation/current/configuring-security-secure-passwords.html
 
 ## Keystore file path (relative to $jetty.base)
-#jetty.sslContext.keyStorePath=etc/keystore
+jetty.sslContext.keyStorePath=etc/org.onap.sdc.p12
 
 ## Truststore file path (relative to $jetty.base)
-#jetty.sslContext.trustStorePath=etc/truststore
+jetty.sslContext.trustStorePath=etc/org.onap.sdc.trust.jks
 
 ## Keystore password
 # jetty.sslContext.keyStorePassword=OBF:1vny1zlo1x8e1vnw1vn61x8g1zlu1vn4
diff --git a/docker/chef-solo/cookbooks/dcae-dt/.gitignore b/docker/chef-solo/cookbooks/dcae-dt/.gitignore
deleted file mode 100644
index b31c0d3..0000000
--- a/docker/chef-solo/cookbooks/dcae-dt/.gitignore
+++ /dev/null
@@ -1,20 +0,0 @@
-.vagrant
-Berksfile.lock
-*~
-*#
-.#*
-\#*#
-.*.sw[a-z]
-*.un~
-
-# Bundler
-Gemfile.lock
-bin/*
-.bundle/*
-
-.kitchen/
-.kitchen.local.yml
-
-######### Private
-run.me
-DCAE-CI01.json
diff --git a/docker/chef-solo/cookbooks/dcae-dt/.kitchen.yml b/docker/chef-solo/cookbooks/dcae-dt/.kitchen.yml
deleted file mode 100644
index 8e76353..0000000
--- a/docker/chef-solo/cookbooks/dcae-dt/.kitchen.yml
+++ /dev/null
@@ -1,16 +0,0 @@
----
-driver:
-  name: vagrant
-
-provisioner:
-  name: chef_zero
-
-platforms:
-  - name: ubuntu-16.04
-  - name: centos-7.1
-
-suites:
-  - name: default
-    run_list:
-      - recipe[dcae-dt::default]
-    attributes:
diff --git a/docker/chef-solo/cookbooks/dcae-dt/files/default/keystore b/docker/chef-solo/cookbooks/dcae-dt/files/default/keystore
deleted file mode 100644
index c408393..0000000
--- a/docker/chef-solo/cookbooks/dcae-dt/files/default/keystore
+++ /dev/null
diff --git a/docker/chef-solo/cookbooks/dcae-dt/files/default/truststore b/docker/chef-solo/cookbooks/dcae-dt/files/default/truststore
deleted file mode 100644
index c408393..0000000
--- a/docker/chef-solo/cookbooks/dcae-dt/files/default/truststore
+++ /dev/null
diff --git a/docker/chef-solo/cookbooks/dcae-dt/metadata.rb b/docker/chef-solo/cookbooks/dcae-dt/metadata.rb
deleted file mode 100644
index f114e32..0000000
--- a/docker/chef-solo/cookbooks/dcae-dt/metadata.rb
+++ /dev/null
@@ -1,7 +0,0 @@
-name 'dcae-dt'
-maintainer 'The Authors'
-maintainer_email 'you@example.com'
-license 'all_rights'
-description 'Installs/Configures dcae-dt'
-long_description 'Installs/Configures dcae-dt'
-version '1.0.0'
diff --git a/docker/set_user.sh b/docker/set_user.sh
deleted file mode 100755
index 539a200..0000000
--- a/docker/set_user.sh
+++ /dev/null
@@ -1,20 +0,0 @@
-#!/bin/sh
-# Create user
-
-USER="jetty"
-GROUP="jetty"
-UID="352070"
-GID="35953"
-
-# Remove user:
-deluser ${USER}
-
-##delgroup ${GROUP}
-
-echo "${USER}:x:${UID}:${GID}::/home/${USER}:Linux User,,,:/home/jetty:/bin/false" >> /etc/passwd
-
-echo "${GROUP}:x:${GID}:${USER}" >> /etc/group
-
-echo "${USER}:!:17501:0:99999:7:::" >> /etc/shadow
-
-mkdir /home/${USER} && chown ${USER}:${GROUP} /home/${USER}
diff --git a/docker/startup.sh b/docker/startup.sh
index 4f363da..00bda01 100644
--- a/docker/startup.sh
+++ b/docker/startup.sh
@@ -1,19 +1,19 @@
 #!/bin/sh
-#set -x
 
-# Run chef-solo for configuration
-cd /var/opt/dcae-dt/chef-solo
-chef-solo -c solo.rb -E ${ENVNAME} --log_level "debug" --logfile "/opt/logs/dcae-dt/chef-dcae-dt.log"
+JAVA_OPTIONS=" ${JAVA_OPTIONS} -Dconfig.home=${JETTY_BASE}/config
+                               -Dlog.home=${JETTY_BASE}/logs
+                               -Dlogback.configurationFile=${JETTY_BASE}/dcae-dt/logback-spring.xml"
+
+cd /root/chef-solo
+chef-solo -c solo.rb -E ${ENVNAME}
 
 status=$?
-if [ $status != 0 ]; then
+if [[ ${status} != 0 ]]; then
   echo "[ERROR] Problem detected while running chef. Aborting !"
   exit 1
 fi
 
-# Execute Jetty
 cd /var/lib/jetty
 /docker-entrypoint.sh &
 
 while true; do sleep 2; done
-