diff options
author | Stone, Avi (as206k) <as206k@att.com> | 2018-05-23 11:21:11 +0300 |
---|---|---|
committer | Stone, Avi (as206k) <as206k@att.com> | 2018-05-23 11:30:13 +0300 |
commit | 3e4c18770957b55e2f80da32c3a32caa908f1386 (patch) | |
tree | 8a94c656300e75e38febfe9826ad36fc54fe14f5 /dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators | |
parent | da9db1b89e8c9199da4791a2ccd26d1628120a08 (diff) |
Upgrade dt-be-main
Update sources for dcae-dt-be-main to latest version
Change-Id: I3d58a2dc32611c0ca90f1c97e1294a17d5748623
Issue-ID: SDC-1359
Signed-off-by: Stone, Avi (as206k) <as206k@att.com>
Diffstat (limited to 'dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators')
10 files changed, 138 insertions, 16 deletions
diff --git a/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/ClearActionValidator.java b/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/ClearActionValidator.java new file mode 100644 index 0000000..8be49b5 --- /dev/null +++ b/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/ClearActionValidator.java @@ -0,0 +1,27 @@ +package org.onap.sdc.dcae.rule.editor.validators; + +import org.onap.sdc.dcae.composition.restmodels.ruleeditor.UnaryFieldAction; +import org.onap.sdc.dcae.errormng.ActionStatus; +import org.onap.sdc.dcae.errormng.ErrConfMgr; +import org.onap.sdc.dcae.errormng.ResponseFormat; + +import java.util.List; + +public class ClearActionValidator implements IRuleElementValidator<UnaryFieldAction> { + + private static ClearActionValidator clearActionValidator = new ClearActionValidator(); + + public static ClearActionValidator getInstance() { + return clearActionValidator; + } + + private ClearActionValidator(){} + + public boolean validate(UnaryFieldAction action, List<ResponseFormat> errors) { + if(action.getFromValues().isEmpty()) { + errors.add(ErrConfMgr.INSTANCE.getResponseFormat(ActionStatus.MISSING_ACTION_FIELD, null, "from", action.getActionType(), action.strippedTarget())); + return false; + } + return true; + } +} diff --git a/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/ConcatActionValidator.java b/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/ConcatActionValidator.java index 965c898..956ac51 100644 --- a/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/ConcatActionValidator.java +++ b/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/ConcatActionValidator.java @@ -1,6 +1,6 @@ package org.onap.sdc.dcae.rule.editor.validators; -import org.onap.sdc.dcae.composition.restmodels.ruleeditor.BaseAction; +import org.onap.sdc.dcae.composition.restmodels.ruleeditor.BaseCopyAction; import org.onap.sdc.dcae.errormng.ActionStatus; import org.onap.sdc.dcae.errormng.ErrConfMgr; import org.onap.sdc.dcae.errormng.ResponseFormat; @@ -8,7 +8,7 @@ import org.onap.sdc.dcae.rule.editor.utils.ValidationUtils; import java.util.List; -public class ConcatActionValidator extends ActionValidator<BaseAction> { +public class ConcatActionValidator extends CopyActionValidator<BaseCopyAction> { private static ConcatActionValidator concatActionValidator = new ConcatActionValidator(); @@ -19,7 +19,7 @@ public class ConcatActionValidator extends ActionValidator<BaseAction> { private ConcatActionValidator(){} @Override - protected boolean validateFromValue(BaseAction action, List<ResponseFormat> errors) { + protected boolean validateFromValue(BaseCopyAction action, List<ResponseFormat> errors) { if(!ValidationUtils.validateNotEmpty(action.getFromValue()) || 2 > action.getFromValues().size()) { errors.add(ErrConfMgr.INSTANCE.getResponseFormat(ActionStatus.MISSING_CONCAT_VALUE, null, action.getTarget())); return false; diff --git a/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/ActionValidator.java b/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/CopyActionValidator.java index 3eb0eb5..74102a6 100644 --- a/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/ActionValidator.java +++ b/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/CopyActionValidator.java @@ -1,6 +1,6 @@ package org.onap.sdc.dcae.rule.editor.validators; -import org.onap.sdc.dcae.composition.restmodels.ruleeditor.BaseAction; +import org.onap.sdc.dcae.composition.restmodels.ruleeditor.BaseCopyAction; import org.onap.sdc.dcae.errormng.ActionStatus; import org.onap.sdc.dcae.errormng.ErrConfMgr; import org.onap.sdc.dcae.errormng.ResponseFormat; @@ -8,15 +8,15 @@ import org.onap.sdc.dcae.rule.editor.utils.ValidationUtils; import java.util.List; -public class ActionValidator<A extends BaseAction> implements IRuleElementValidator<A> { +public class CopyActionValidator<A extends BaseCopyAction> implements IRuleElementValidator<A> { - private static ActionValidator actionValidator = new ActionValidator(); + private static CopyActionValidator copyActionValidator = new CopyActionValidator(); - public static ActionValidator getInstance() { - return actionValidator; + public static CopyActionValidator getInstance() { + return copyActionValidator; } - ActionValidator(){} + CopyActionValidator(){} public boolean validate(A action, List<ResponseFormat> errors) { diff --git a/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/DateFormatterValidator.java b/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/DateFormatterValidator.java index d5ec0fc..19af40c 100644 --- a/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/DateFormatterValidator.java +++ b/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/DateFormatterValidator.java @@ -8,7 +8,7 @@ import org.onap.sdc.dcae.rule.editor.utils.ValidationUtils; import java.util.List; -public class DateFormatterValidator extends ActionValidator<DateFormatterAction> { +public class DateFormatterValidator extends CopyActionValidator<DateFormatterAction> { private static DateFormatterValidator dateFormatterValidator = new DateFormatterValidator(); public static DateFormatterValidator getInstance() { diff --git a/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/IRuleElementValidator.java b/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/IRuleElementValidator.java index dd1eaf4..cdcf5b2 100644 --- a/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/IRuleElementValidator.java +++ b/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/IRuleElementValidator.java @@ -1,9 +1,13 @@ package org.onap.sdc.dcae.rule.editor.validators; +import org.onap.sdc.common.onaplog.OnapLoggerError; import org.onap.sdc.dcae.errormng.ResponseFormat; import java.util.List; public interface IRuleElementValidator <T> { + + OnapLoggerError errLogger = OnapLoggerError.getInstance(); + boolean validate(T element, List<ResponseFormat> errors); } diff --git a/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/LogEventValidator.java b/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/LogEventValidator.java new file mode 100644 index 0000000..1bbf07a --- /dev/null +++ b/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/LogEventValidator.java @@ -0,0 +1,28 @@ +package org.onap.sdc.dcae.rule.editor.validators; + +import org.onap.sdc.dcae.composition.restmodels.ruleeditor.LogEventAction; +import org.onap.sdc.dcae.errormng.ActionStatus; +import org.onap.sdc.dcae.errormng.ErrConfMgr; +import org.onap.sdc.dcae.errormng.ResponseFormat; +import org.onap.sdc.dcae.rule.editor.utils.ValidationUtils; + +import java.util.List; + +public class LogEventValidator implements IRuleElementValidator<LogEventAction> { + + private static LogEventValidator logEventValidator = new LogEventValidator(); + + public static LogEventValidator getInstance() { + return logEventValidator; + } + + LogEventValidator(){} + + public boolean validate(LogEventAction action, List<ResponseFormat> errors) { + if(!ValidationUtils.validateNotEmpty(action.getTitle())){ + errors.add(ErrConfMgr.INSTANCE.getResponseFormat(ActionStatus.MISSING_ACTION_FIELD, null, "title", action.getActionType(), action.strippedTarget())); + return false; + } + return true; + } +} diff --git a/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/LogTextValidator.java b/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/LogTextValidator.java new file mode 100644 index 0000000..711692f --- /dev/null +++ b/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/LogTextValidator.java @@ -0,0 +1,28 @@ +package org.onap.sdc.dcae.rule.editor.validators; + +import org.onap.sdc.dcae.composition.restmodels.ruleeditor.LogTextAction; +import org.onap.sdc.dcae.errormng.ActionStatus; +import org.onap.sdc.dcae.errormng.ErrConfMgr; +import org.onap.sdc.dcae.errormng.ResponseFormat; +import org.onap.sdc.dcae.rule.editor.utils.ValidationUtils; + +import java.util.List; + +public class LogTextValidator implements IRuleElementValidator<LogTextAction> { + + private static LogTextValidator logTextValidator = new LogTextValidator(); + + public static LogTextValidator getInstance() { + return logTextValidator; + } + + LogTextValidator(){} + + public boolean validate(LogTextAction action, List<ResponseFormat> errors) { + if(!ValidationUtils.validateNotEmpty(action.getText())){ + errors.add(ErrConfMgr.INSTANCE.getResponseFormat(ActionStatus.MISSING_ACTION_FIELD, null, "text", action.getActionType(), action.strippedTarget())); + return false; + } + return true; + } +} diff --git a/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/MapActionValidator.java b/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/MapActionValidator.java index 8cbcaa8..130e428 100644 --- a/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/MapActionValidator.java +++ b/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/MapActionValidator.java @@ -1,5 +1,6 @@ package org.onap.sdc.dcae.rule.editor.validators; +import org.onap.sdc.common.onaplog.Enums.LogLevel; import org.onap.sdc.dcae.composition.restmodels.ruleeditor.MapAction; import org.onap.sdc.dcae.errormng.ActionStatus; import org.onap.sdc.dcae.errormng.ErrConfMgr; @@ -9,7 +10,7 @@ import org.springframework.util.CollectionUtils; import java.util.List; -public class MapActionValidator extends ActionValidator<MapAction> { +public class MapActionValidator extends CopyActionValidator<MapAction> { private static MapActionValidator mapActionValidator = new MapActionValidator(); @@ -37,6 +38,7 @@ public class MapActionValidator extends ActionValidator<MapAction> { } } catch (IllegalStateException err) { valid = false; + errLogger.log(LogLevel.ERROR, this.getClass().getName(), "Map validation error: {}", err); errors.add(ErrConfMgr.INSTANCE.getResponseFormat(ActionStatus.DUPLICATE_KEY, null)); } } diff --git a/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/ReplaceActionValidator.java b/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/ReplaceActionValidator.java new file mode 100644 index 0000000..d9aea82 --- /dev/null +++ b/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/ReplaceActionValidator.java @@ -0,0 +1,37 @@ +package org.onap.sdc.dcae.rule.editor.validators; + +import org.onap.sdc.dcae.composition.restmodels.ruleeditor.ReplaceTextAction; +import org.onap.sdc.dcae.errormng.ActionStatus; +import org.onap.sdc.dcae.errormng.ErrConfMgr; +import org.onap.sdc.dcae.errormng.ResponseFormat; +import org.onap.sdc.dcae.rule.editor.utils.ValidationUtils; + +import java.util.List; + +public class ReplaceActionValidator implements IRuleElementValidator<ReplaceTextAction> { + + private static ReplaceActionValidator replaceActionValidator = new ReplaceActionValidator(); + + public static ReplaceActionValidator getInstance() { + return replaceActionValidator; + } + + private ReplaceActionValidator(){} + + public boolean validate(ReplaceTextAction action, List<ResponseFormat> errors) { + boolean valid = true; + if(!ValidationUtils.validateNotEmpty(action.getFromValue())) { + valid = false; + errors.add(ErrConfMgr.INSTANCE.getResponseFormat(ActionStatus.MISSING_ACTION_FIELD, null, "from", action.getActionType(), action.strippedTarget())); + } + if(!ValidationUtils.validateNotEmpty(action.getFind())) { + valid = false; + errors.add(ErrConfMgr.INSTANCE.getResponseFormat(ActionStatus.MISSING_ACTION_FIELD, null, "find", action.getActionType(), action.strippedTarget())); + } + if(!ValidationUtils.validateNotEmpty(action.getReplace())) { + valid = false; + errors.add(ErrConfMgr.INSTANCE.getResponseFormat(ActionStatus.MISSING_ACTION_FIELD, null, "replace", action.getActionType(), action.strippedTarget())); + } + return valid; + } +} diff --git a/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/RuleValidator.java b/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/RuleValidator.java index 371d1e9..e03ca8a 100644 --- a/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/RuleValidator.java +++ b/dcaedt_be/src/main/java/org/onap/sdc/dcae/rule/editor/validators/RuleValidator.java @@ -1,13 +1,9 @@ package org.onap.sdc.dcae.rule.editor.validators; -import org.onap.sdc.dcae.composition.restmodels.ruleeditor.ActionTypeEnum; -import org.onap.sdc.dcae.composition.restmodels.ruleeditor.BaseAction; -import org.onap.sdc.dcae.composition.restmodels.ruleeditor.BaseCondition; -import org.onap.sdc.dcae.composition.restmodels.ruleeditor.Rule; +import org.onap.sdc.dcae.composition.restmodels.ruleeditor.*; import org.onap.sdc.dcae.errormng.ActionStatus; import org.onap.sdc.dcae.errormng.ErrConfMgr; import org.onap.sdc.dcae.errormng.ResponseFormat; -import org.onap.sdc.dcae.errormng.ServiceException; import org.onap.sdc.dcae.rule.editor.enums.RuleEditorElementType; import org.onap.sdc.dcae.rule.editor.utils.ValidationUtils; import org.springframework.util.CollectionUtils; |