diff options
author | andre.schmid <andre.schmid@est.tech> | 2019-08-30 18:20:32 +0100 |
---|---|---|
committer | Oren Kleks <orenkle@amdocs.com> | 2019-10-24 06:15:28 +0000 |
commit | 78f88751aa64fb72fd6321346929bd1d94f716a9 (patch) | |
tree | 58cabd13dcfbad357729ef338c8e2dca3255f1fb /openecomp-be/lib/openecomp-tosca-lib/src/test/java/org | |
parent | 105ce0729d5333cc095ef5bd8104a6c5b90cc9f0 (diff) |
Fix and refactor manifest parsing
Fix a CMS signature reading expected token.
Fix the necessity of a empty line in the end of the manifest.
Implement CMS signature, Source checksum algorithm and digest reading.
Indicate the line number and content when a manifest error occurs.
Remove unnecessary recursive reading.
Centralize manifest tokens.
Improve tests by checking the expected error.
Document the code.
Change-Id: I7d12020d8922fc5d4c8d9f238557dfbcc0b65757
Issue-ID: SDC-2563
Signed-off-by: andre.schmid <andre.schmid@est.tech>
Diffstat (limited to 'openecomp-be/lib/openecomp-tosca-lib/src/test/java/org')
2 files changed, 436 insertions, 127 deletions
diff --git a/openecomp-be/lib/openecomp-tosca-lib/src/test/java/org/openecomp/sdc/tosca/csar/ManifestParsingTest.java b/openecomp-be/lib/openecomp-tosca-lib/src/test/java/org/openecomp/sdc/tosca/csar/ManifestParsingTest.java deleted file mode 100644 index b083cfad3a..0000000000 --- a/openecomp-be/lib/openecomp-tosca-lib/src/test/java/org/openecomp/sdc/tosca/csar/ManifestParsingTest.java +++ /dev/null @@ -1,127 +0,0 @@ -/* - * Copyright © 2016-2018 European Support Limited - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package org.openecomp.sdc.tosca.csar; - -import org.junit.Before; -import org.junit.Test; -import org.openecomp.sdc.be.datatypes.enums.ResourceTypeEnum; -import org.openecomp.sdc.common.errors.Messages; -import java.io.IOException; -import java.io.InputStream; -import java.util.Optional; - -import static junit.framework.TestCase.assertTrue; -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertFalse; - - -public class ManifestParsingTest { - - private Manifest manifest; - - @Before - public void setUp(){ - manifest = new SOL004ManifestOnboarding(); - } - - @Test - public void testSuccessfulParsing() throws IOException { - try (InputStream is = getClass() - .getResourceAsStream("/vspmanager.csar/manifest/ValidTosca.mf")) { - manifest.parse(is); - assertTrue(manifest.isValid()); - assertEquals(manifest.getMetadata().size(), 4); - assertEquals(manifest.getSources().size(), 5); - Optional<ResourceTypeEnum> resourceTypeEnum = manifest.getType(); - if(resourceTypeEnum.isPresent()){ - assertTrue(resourceTypeEnum.get() == ResourceTypeEnum.VF); - } - } - } - - @Test - public void testNoMetadataParsing() throws IOException { - try (InputStream is = getClass() - .getResourceAsStream("/vspmanager.csar/manifest/InvalidTosca1.mf")) { - manifest.parse(is); - assertFalse(manifest.isValid()); - assertTrue(manifest.getErrors().stream().anyMatch(error -> error - .contains(Messages.MANIFEST_INVALID_LINE.getErrorMessage().substring(0, 10)))); - } - } - - @Test - public void testBrokenMDParsing() throws IOException { - try (InputStream is = getClass() - .getResourceAsStream("/vspmanager.csar/manifest/InvalidTosca2.mf")) { - manifest.parse(is); - assertFalse(manifest.isValid()); - assertTrue(manifest.getErrors().stream().anyMatch(error -> error - .contains(Messages.MANIFEST_INVALID_LINE.getErrorMessage().substring(0, 10)))); - } - } - - @Test - public void testNoMetaParsing() throws IOException { - try (InputStream is = getClass() - .getResourceAsStream("/vspmanager.csar/manifest/InvalidTosca4.mf")) { - manifest.parse(is); - assertFalse(manifest.isValid()); - assertTrue(manifest.getErrors().stream().anyMatch(error -> error - .contains(Messages.MANIFEST_NO_METADATA.getErrorMessage().substring(0, 10)))); - } - } - - @Test - public void testSuccessfulNonManoParsing() throws IOException { - try (InputStream is = getClass() - .getResourceAsStream("/vspmanager.csar/manifest/ValidNonManoTosca.mf")) { - manifest.parse(is); - assertTrue(manifest.isValid()); - assertEquals(manifest.getMetadata().size(), 4); - assertEquals(manifest.getSources().size(), 5); - assertEquals(manifest.getNonManoSources().size(), 2); - } - } - - @Test - public void testFailfulNonManoParsing() throws IOException { - try (InputStream is = getClass() - .getResourceAsStream("/vspmanager.csar/manifest/InValidNonManoTosca.mf")) { - manifest.parse(is); - assertFalse(manifest.isValid()); - } - } - - @Test - public void testFailfulNonManoParsingWithGarbadge() throws IOException { - try (InputStream is = getClass() - .getResourceAsStream("/vspmanager.csar/manifest/InvalidTocsaNonManoGarbadgeAtEnd.mf")) { - manifest.parse(is); - assertFalse(manifest.isValid()); - } - } - - @Test - public void testParseManifestWithNoFile() throws IOException { - try (InputStream is = getClass() - .getResourceAsStream("/vspmanager.csar/manifest/SOME_WRONG_FILE")) { - manifest.parse(is); - assertFalse(manifest.isValid()); - } - } -} diff --git a/openecomp-be/lib/openecomp-tosca-lib/src/test/java/org/openecomp/sdc/tosca/csar/SOL004ManifestOnboardingTest.java b/openecomp-be/lib/openecomp-tosca-lib/src/test/java/org/openecomp/sdc/tosca/csar/SOL004ManifestOnboardingTest.java new file mode 100644 index 0000000000..7cb1511a32 --- /dev/null +++ b/openecomp-be/lib/openecomp-tosca-lib/src/test/java/org/openecomp/sdc/tosca/csar/SOL004ManifestOnboardingTest.java @@ -0,0 +1,436 @@ +/* + * Copyright © 2016-2018 European Support Limited + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.openecomp.sdc.tosca.csar; + +import static junit.framework.TestCase.assertSame; +import static org.hamcrest.Matchers.containsInAnyOrder; +import static org.hamcrest.Matchers.empty; +import static org.hamcrest.Matchers.equalTo; +import static org.hamcrest.Matchers.hasItem; +import static org.hamcrest.Matchers.hasSize; +import static org.hamcrest.core.Is.is; +import static org.junit.Assert.assertThat; + +import com.google.common.collect.ImmutableMap; +import java.io.IOException; +import java.io.InputStream; +import java.lang.reflect.InvocationTargetException; +import java.lang.reflect.Method; +import java.util.ArrayList; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Map.Entry; +import java.util.Optional; +import org.junit.Before; +import org.junit.Test; +import org.openecomp.sdc.be.datatypes.enums.ResourceTypeEnum; +import org.openecomp.sdc.common.errors.Messages; + +public class SOL004ManifestOnboardingTest { + + private Manifest manifest; + + @Before + public void setUp() { + manifest = new SOL004ManifestOnboarding(); + } + + @Test + public void testSuccessfulParsing() throws IOException { + try (final InputStream manifestAsStream = + getClass().getResourceAsStream("/vspmanager.csar/manifest/ValidTosca.mf")) { + manifest.parse(manifestAsStream); + assertValidManifest(4, 5, Collections.emptyMap(), ResourceTypeEnum.VF); + } + } + + @Test + public void testNoMetadataParsing() throws IOException { + try (final InputStream manifestAsStream = getClass() + .getResourceAsStream("/vspmanager.csar/manifest/invalid/no-metadata.mf")) { + manifest.parse(manifestAsStream); + final List<String> expectedErrorList = new ArrayList<>(); + expectedErrorList.add( + buildErrorMessage(3, "Source: MainServiceTemplate.yaml", Messages.MANIFEST_START_METADATA) + ); + assertInvalidManifest(expectedErrorList); + } + } + + @Test + public void testBrokenMDParsing() throws IOException { + try (final InputStream manifestAsStream = + getClass().getResourceAsStream("/vspmanager.csar/manifest/InvalidTosca2.mf")) { + manifest.parse(manifestAsStream); + final List<String> expectedErrorList = new ArrayList<>(); + expectedErrorList.add(Messages.MANIFEST_INVALID_LINE.formatMessage(9, "vnf_package_version: 1.0")); + assertInvalidManifest(expectedErrorList); + } + } + + @Test + public void testNoMetaParsing() throws IOException { + try (final InputStream manifestAsStream = getClass() + .getResourceAsStream("/vspmanager.csar/manifest/invalid/empty-metadata-with-source.mf")) { + manifest.parse(manifestAsStream); + final List<String> expectedErrorList = new ArrayList<>(); + expectedErrorList.add( + buildErrorMessage(4, "Source: MainServiceTemplate.yaml", + Messages.MANIFEST_METADATA_INVALID_ENTRY1, "Source: MainServiceTemplate.yaml") + ); + assertInvalidManifest(expectedErrorList); + } + } + + @Test + public void testSuccessfulNonManoParsing() throws IOException { + try (final InputStream manifestAsStream = getClass() + .getResourceAsStream("/vspmanager.csar/manifest/ValidNonManoTosca.mf")) { + manifest.parse(manifestAsStream); + assertValidManifest(4, 5, + ImmutableMap.of("foo_bar", 3, "prv.happy-nfv.cool", 3), ResourceTypeEnum.VF); + } + } + + @Test + public void testInvalidNonManoParsing() throws IOException { + try (final InputStream manifestAsStream = getClass() + .getResourceAsStream("/vspmanager.csar/manifest/InValidNonManoTosca.mf")) { + manifest.parse(manifestAsStream); + final List<String> errorList = Collections.singletonList( + buildErrorMessage(34, "vnf_product_name: Mock", Messages.MANIFEST_INVALID_NON_MANO_KEY, + "vnf_product_name") + ); + assertInvalidManifest(errorList); + } + } + + private String buildErrorMessage(final int lineNumber, final String line, final Messages message, + final Object... params) { + return Messages.MANIFEST_ERROR_WITH_LINE.formatMessage(message.formatMessage(params), lineNumber, line); + } + + @Test + public void testNonManoParsingWithGarbage() throws IOException { + try (final InputStream manifestAsStream = getClass() + .getResourceAsStream("/vspmanager.csar/manifest/InvalidToscaNonManoGarbageAtEnd.mf")) { + manifest.parse(manifestAsStream); + final List<String> errorList = Collections.singletonList( + Messages.MANIFEST_ERROR_WITH_LINE.formatMessage( + Messages.MANIFEST_INVALID_NON_MANO_KEY.formatMessage("some garbage"), + 34, "some garbage") + ); + assertInvalidManifest(errorList); + } + } + + @Test + public void testInvalidManifestFile() throws IOException { + try (final InputStream manifestAsStream = getClass() + .getResourceAsStream("/vspmanager.csar/manifest/SOME_WRONG_FILE")) { + manifest.parse(manifestAsStream); + assertInvalidManifest(Collections.singletonList(Messages.MANIFEST_PARSER_INTERNAL.getErrorMessage())); + } + } + + @Test + public void testManifestSigned() throws IOException { + try (final InputStream manifestAsStream = getClass() + .getResourceAsStream("/vspmanager.csar/manifest/valid/signed.mf")) { + manifest.parse(manifestAsStream); + assertValidManifest(4, 3, Collections.emptyMap(), ResourceTypeEnum.VF); + } + } + + @Test + public void testManifestSignedWithNonManoArtifacts() throws IOException { + try (final InputStream manifestAsStream = getClass() + .getResourceAsStream("/vspmanager.csar/manifest/valid/signed-with-non-mano.mf")) { + manifest.parse(manifestAsStream); + assertValidManifest(4, 3, ImmutableMap.of("foo_bar", 3), ResourceTypeEnum.VF); + manifest.getType().ifPresent(typeEnum -> assertSame(typeEnum, ResourceTypeEnum.VF)); + } + } + + @Test + public void testManifestWithPnf() throws IOException { + try (final InputStream manifestAsStream = getClass() + .getResourceAsStream("/vspmanager.csar/manifest/valid/metadata-pnfd.mf")) { + manifest.parse(manifestAsStream); + assertValidManifest(4, 3, new HashMap<>(), ResourceTypeEnum.PNF); + } + } + + @Test + public void testMetadataWithNoValue() throws IOException { + try (final InputStream manifestAsStream = getClass() + .getResourceAsStream("/vspmanager.csar/manifest/invalid/metadata-no-value.mf")) { + manifest.parse(manifestAsStream); + + final List<String> expectedErrorList = new ArrayList<>(); + expectedErrorList.add( + buildErrorMessage(3, "vnf_provider_id", Messages.MANIFEST_METADATA_INVALID_ENTRY1, "vnf_provider_id") + ); + assertInvalidManifest(expectedErrorList); + } + } + + @Test + public void testMetadataWithValueButNoEntry() throws IOException { + try (final InputStream manifestAsStream = getClass() + .getResourceAsStream("/vspmanager.csar/manifest/invalid/metadata-no-entry.mf")) { + manifest.parse(manifestAsStream); + + final List<String> expectedErrorList = new ArrayList<>(); + expectedErrorList.add( + buildErrorMessage(3, ": no-entry-value", Messages.MANIFEST_METADATA_INVALID_ENTRY1, ": no-entry-value") + ); + assertInvalidManifest(expectedErrorList); + } + } + + @Test + public void testMetadataWithIncorrectEntry() throws IOException { + try (final InputStream manifestAsStream = getClass() + .getResourceAsStream("/vspmanager.csar/manifest/invalid/metadata-incorrect-entry.mf")) { + manifest.parse(manifestAsStream); + final List<String> expectedErrorList = new ArrayList<>(); + expectedErrorList.add( + buildErrorMessage(4, "vnf_release_data_time: 2019-08-29T22:17:39.275281", + Messages.MANIFEST_METADATA_INVALID_ENTRY1, "vnf_release_data_time: 2019-08-29T22:17:39.275281") + ); + assertInvalidManifest(expectedErrorList); + } + } + + @Test + public void testMetadataWithMixedEntries() throws IOException { + try (final InputStream manifestAsStream = getClass() + .getResourceAsStream("/vspmanager.csar/manifest/invalid/metadata-mixed-entries.mf")) { + manifest.parse(manifestAsStream); + final List<String> expectedErrorList = new ArrayList<>(); + expectedErrorList.add(buildErrorMessage(6, "", Messages.MANIFEST_METADATA_UNEXPECTED_ENTRY_TYPE)); + assertInvalidManifest(expectedErrorList); + } + } + + @Test + public void testMetadataWithDuplicatedEntries() throws IOException { + try (final InputStream manifestAsStream = + getClass().getResourceAsStream("/vspmanager.csar/manifest/invalid/metadata-duplicated-entries.mf")) { + manifest.parse(manifestAsStream); + final List<String> expectedErrorList = new ArrayList<>(); + expectedErrorList.add( + buildErrorMessage(4, "vnf_product_name: vPP", Messages.MANIFEST_METADATA_DUPLICATED_ENTRY, + "vnf_product_name") + ); + assertInvalidManifest(expectedErrorList); + } + } + + @Test + public void testManifestNonManoKeyWithoutSources() throws IOException { + try (final InputStream manifestAsStream = + getClass().getResourceAsStream("/vspmanager.csar/manifest/invalid/non-mano-key-with-no-sources.mf")) { + manifest.parse(manifestAsStream); + final List<String> expectedErrorList = new ArrayList<>(); + expectedErrorList.add( + buildErrorMessage(11, "", Messages.MANIFEST_EMPTY_NON_MANO_KEY, + "foo_bar") + ); + assertInvalidManifest(expectedErrorList); + } + } + + @Test + public void testManifestNonManoKeyWithEmptySourceEntry() throws IOException { + try (final InputStream manifestAsStream = + getClass().getResourceAsStream("/vspmanager.csar/manifest/invalid/non-mano-key-with-empty-source.mf")) { + manifest.parse(manifestAsStream); + final List<String> expectedErrorList = new ArrayList<>(); + expectedErrorList.add( + buildErrorMessage(11, "Source:", Messages.MANIFEST_EMPTY_NON_MANO_SOURCE) + ); + assertInvalidManifest(expectedErrorList); + } + } + + @Test + public void testManifestWithEmptyMetadata() throws IOException { + try (final InputStream manifestAsStream = + getClass().getResourceAsStream("/vspmanager.csar/manifest/invalid/empty-metadata.mf")) { + manifest.parse(manifestAsStream); + final List<String> expectedErrorList = new ArrayList<>(); + expectedErrorList.add(buildErrorMessage(2, "", Messages.MANIFEST_NO_METADATA)); + assertInvalidManifest(expectedErrorList); + } + } + + @Test + public void testManifestSourceAlgorithmWithoutHash() throws IOException { + try (final InputStream manifestAsStream = + getClass().getResourceAsStream("/vspmanager.csar/manifest/invalid/source-algorithm-without-hash.mf")) { + manifest.parse(manifestAsStream); + final List<String> expectedErrorList = new ArrayList<>(); + expectedErrorList.add(buildErrorMessage(9, "", Messages.MANIFEST_EXPECTED_HASH_ENTRY)); + assertInvalidManifest(expectedErrorList); + } + } + + @Test + public void testManifestSourceHashWithoutAlgorithm() throws IOException { + try (final InputStream manifestAsStream = + getClass().getResourceAsStream("/vspmanager.csar/manifest/invalid/source-hash-without-algorithm.mf")) { + manifest.parse(manifestAsStream); + final List<String> expectedErrorList = new ArrayList<>(); + expectedErrorList.add(buildErrorMessage(8, "Hash: 3b119b37da5b76ec7c933168b21cedd8", Messages.MANIFEST_EXPECTED_ALGORITHM_BEFORE_HASH)); + assertInvalidManifest(expectedErrorList); + } + } + + @Test + public void testManifestSourceAlgorithmWithoutValue() throws IOException { + try (final InputStream manifestAsStream = + getClass().getResourceAsStream("/vspmanager.csar/manifest/invalid/source-algorithm-without-value.mf")) { + manifest.parse(manifestAsStream); + final List<String> expectedErrorList = new ArrayList<>(); + expectedErrorList.add(buildErrorMessage(8, "Algorithm:", Messages.MANIFEST_EXPECTED_ALGORITHM_VALUE)); + assertInvalidManifest(expectedErrorList); + } + } + + @Test + public void testManifestSourceHashWithoutValue() throws IOException { + try (final InputStream manifestAsStream = + getClass().getResourceAsStream("/vspmanager.csar/manifest/invalid/source-hash-without-value.mf")) { + manifest.parse(manifestAsStream); + final List<String> expectedErrorList = new ArrayList<>(); + expectedErrorList.add(buildErrorMessage(9, "Hash:", Messages.MANIFEST_EXPECTED_HASH_VALUE)); + assertInvalidManifest(expectedErrorList); + } + } + + @Test + public void testEmptyManifest() throws IOException { + try (final InputStream manifestAsStream = + getClass().getResourceAsStream("/vspmanager.csar/manifest/invalid/empty-manifest.mf")) { + manifest.parse(manifestAsStream); + final List<String> expectedErrorList = new ArrayList<>(); + expectedErrorList.add(Messages.MANIFEST_EMPTY.getErrorMessage()); + assertInvalidManifest(expectedErrorList); + } + } + + @Test + public void testManifestWithDuplicatedCmsSignature() throws IOException { + try (final InputStream manifestAsStream = + getClass().getResourceAsStream("/vspmanager.csar/manifest/invalid/double-signed.mf")) { + manifest.parse(manifestAsStream); + final List<String> expectedErrorList = new ArrayList<>(); + expectedErrorList + .add(buildErrorMessage(26, "-----BEGIN CMS-----", Messages.MANIFEST_DUPLICATED_CMS_SIGNATURE)); + assertInvalidManifest(expectedErrorList); + } + } + + + @Test + public void testGetEntry() throws NoSuchMethodException, InvocationTargetException, IllegalAccessException { + final Method getEntryMethod = AbstractOnboardingManifest.class.getDeclaredMethod("readEntryName", String.class); + getEntryMethod.setAccessible(true); + final Optional<String> noEntry = (Optional<String>) getEntryMethod.invoke(manifest, ":"); + assertThat("Entry should not be present", noEntry.isPresent(), is(false)); + + final Optional<String> blankEntry = (Optional<String>) getEntryMethod.invoke(manifest, " :"); + assertThat("Entry should not be present", blankEntry.isPresent(), is(false)); + + final Optional<String> noColon = (Optional<String>) getEntryMethod.invoke(manifest, "anyKeyWithoutColon "); + assertThat("Entry should not be present", noColon.isPresent(), is(false)); + + final Optional<String> blank = (Optional<String>) getEntryMethod.invoke(manifest, " "); + assertThat("Entry should not be present", blank.isPresent(), is(false)); + + final Optional<String> empty = (Optional<String>) getEntryMethod.invoke(manifest, ""); + assertThat("Entry should not be present", empty.isPresent(), is(false)); + + final Optional<String> nul1 = (Optional<String>) getEntryMethod.invoke(manifest, new Object[]{null}); + assertThat("Entry should not be present", nul1.isPresent(), is(false)); + + final Optional<String> entry = (Optional<String>) getEntryMethod + .invoke(manifest, " entry to test : : a value ::: test test: "); + assertThat("Entry should be present", entry.isPresent(), is(true)); + assertThat("Entry should be as expected", entry.get(), equalTo("entry to test")); + } + + @Test + public void testGetValue() throws NoSuchMethodException, InvocationTargetException, IllegalAccessException { + final Method getValueMethod = AbstractOnboardingManifest.class.getDeclaredMethod("readEntryValue", String.class); + getValueMethod.setAccessible(true); + final Optional<String> noValue = (Optional<String>) getValueMethod.invoke(manifest, ":"); + assertThat("Value should not be present", noValue.isPresent(), is(false)); + + final Optional<String> blankValue = (Optional<String>) getValueMethod.invoke(manifest, ": "); + assertThat("Value should not be present", blankValue.isPresent(), is(false)); + + final Optional<String> noColon = (Optional<String>) getValueMethod.invoke(manifest, "anyKeyWithoutColon "); + assertThat("Value should not be present", noColon.isPresent(), is(false)); + + final Optional<String> blank = (Optional<String>) getValueMethod.invoke(manifest, " "); + assertThat("Value should not be present", blank.isPresent(), is(false)); + + final Optional<String> empty = (Optional<String>) getValueMethod.invoke(manifest, ""); + assertThat("Value should not be present", empty.isPresent(), is(false)); + + final Optional<String> nul1 = (Optional<String>) getValueMethod.invoke(manifest, new Object[]{null}); + assertThat("Value should not be present", nul1.isPresent(), is(false)); + + final Optional<String> value = (Optional<String>) getValueMethod + .invoke(manifest, "attribute : : a value ::: test test: "); + assertThat("Value should be present", value.isPresent(), is(true)); + assertThat("Value should be as expected", value.get(), equalTo(": a value ::: test test:")); + } + + private void assertValidManifest(final int expectedMetadataSize, final int expectedSourcesSize, + final Map<String, Integer> expectedNonManoKeySize, + final ResourceTypeEnum resourceType) { + assertThat("Should have no errors", manifest.getErrors(), is(empty())); + assertThat("Should be valid", manifest.isValid(), is(true)); + assertThat("Metadata should have the expected size", + manifest.getMetadata().keySet(), hasSize(expectedMetadataSize)); + assertThat("Sources should have the expected size", manifest.getSources(), hasSize(expectedSourcesSize)); + assertThat("Non Mano Sources keys should have the expected size", + manifest.getNonManoSources().keySet(), hasSize(expectedNonManoKeySize.keySet().size())); + for (final Entry<String, Integer> nonManoKeyAndSize : expectedNonManoKeySize.entrySet()) { + final String nonManoKey = nonManoKeyAndSize.getKey(); + assertThat("Should contain expected Non Mano Sources key", + manifest.getNonManoSources().keySet(), hasItem(nonManoKey)); + assertThat(String.format("Non Mano Sources keys %s should have the expected sources size", nonManoKey), + manifest.getNonManoSources().get(nonManoKey).size(), equalTo(nonManoKeyAndSize.getValue())); + } + assertThat("Should have a type", manifest.getType().isPresent(), is(true)); + assertThat("Type should be as expected", manifest.getType().get(), equalTo(resourceType)); + } + + private void assertInvalidManifest(final List<String> expectedErrorList) { + assertThat("Should be invalid", manifest.isValid(), is(false)); + assertThat("Should have the expected error quantity", manifest.getErrors(), hasSize(expectedErrorList.size())); + assertThat("Should have expected errors", manifest.getErrors(), + containsInAnyOrder(expectedErrorList.toArray(new String[0]))); + } +} |