Fix 'Optional license in onboarding'-bug

Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Change-Id: I6b63629e834b8a5002372d6af59ae0a3a9460542
Issue-ID: SDC-3601

1 files changed, 10 insertions, 12 deletions

diff --git a/openecomp-be/lib/openecomp-sdc-vendor-license-lib/openecomp-sdc-vendor-license-core/src/test/java/org/openecomp/sdc/vendorlicense/dao/impl/zusammen/convertor/ElementToVLMGeneralConvertorTest.java b/openecomp-be/lib/openecomp-sdc-vendor-license-lib/openecomp-sdc-vendor-license-core/src/test/java/org/openecomp/sdc/vendorlicense/dao/impl/zusammen/convertor/ElementToVLMGeneralConvertorTest.java
index 45660a6854..9d9f002c9b 100644
--- a/openecomp-be/lib/openecomp-sdc-vendor-license-lib/openecomp-sdc-vendor-license-core/src/test/java/org/openecomp/sdc/vendorlicense/dao/impl/zusammen/convertor/ElementToVLMGeneralConvertorTest.java
+++ b/openecomp-be/lib/openecomp-sdc-vendor-license-lib/openecomp-sdc-vendor-license-core/src/test/java/org/openecomp/sdc/vendorlicense/dao/impl/zusammen/convertor/ElementToVLMGeneralConvertorTest.java
@@ -15,15 +15,16 @@
  */
 package org.openecomp.sdc.vendorlicense.dao.impl.zusammen.convertor;
 
-import static org.junit.Assert.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertEquals;
 
 import com.amdocs.zusammen.adaptor.inbound.api.types.item.ElementInfo;
 import com.amdocs.zusammen.adaptor.inbound.api.types.item.ZusammenElement;
 import com.amdocs.zusammen.datatypes.item.Info;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
+import org.openecomp.sdc.vendorlicense.dao.impl.zusammen.VendorLicenseModelDaoZusammenImpl;
 import org.openecomp.sdc.vendorlicense.dao.types.VendorLicenseModelEntity;
 
-public class ElementToVLMGeneralConvertorTest {
+class ElementToVLMGeneralConvertorTest {
 
     private static final String ENTITY_NAME = "entityTestName";
     private static final String ENTITY_DESCRIPTION = "entityTestDesc";
@@ -31,30 +32,27 @@ public class ElementToVLMGeneralConvertorTest {
     private ElementToVLMGeneralConvertor converter = new ElementToVLMGeneralConvertor();
 
     @Test
-    public void shouldConvertElementToVendorLicenseModelEntity() {
+    void shouldConvertElementToVendorLicenseModelEntity() {
         ZusammenElement elementToConvert = new ZusammenElement();
         Info info = new Info();
-        info.addProperty("name",ENTITY_NAME);
-        info.addProperty("description",ENTITY_DESCRIPTION);
+        info.addProperty(VendorLicenseModelDaoZusammenImpl.InfoPropertyName.NAME.name(), ENTITY_NAME);
+        info.addProperty(VendorLicenseModelDaoZusammenImpl.InfoPropertyName.DESCRIPTION.name(), ENTITY_DESCRIPTION);
         elementToConvert.setInfo(info);
         VendorLicenseModelEntity result = converter.convert(elementToConvert);
         assertEquals(ENTITY_NAME, result.getVendorName());
         assertEquals(ENTITY_DESCRIPTION, result.getDescription());
-
-
     }
 
     @Test
-    public void shouldConvertElementInfoToVendorLicenseModelEntity() {
+    void shouldConvertElementInfoToVendorLicenseModelEntity() {
         ElementInfo elementInfo = new ElementInfo();
         Info info = new Info();
-        info.addProperty("name",ENTITY_NAME);
-        info.addProperty("description",ENTITY_DESCRIPTION);
+        info.addProperty(VendorLicenseModelDaoZusammenImpl.InfoPropertyName.NAME.name(), ENTITY_NAME);
+        info.addProperty(VendorLicenseModelDaoZusammenImpl.InfoPropertyName.DESCRIPTION.name(), ENTITY_DESCRIPTION);
         elementInfo.setInfo(info);
         VendorLicenseModelEntity result = converter.convert(elementInfo);
         assertEquals(ENTITY_NAME, result.getVendorName());
         assertEquals(ENTITY_DESCRIPTION, result.getDescription());
     }
 
-
 }