Improved test coverage.

Reorganized some of the tests due to comments

Issue-ID: SDC-2238

Change-Id: I6b3bcc674c792f3c5c06e851a2cfe2d92eead07c
Signed-off-by: James Guistwite <jguistwite@iconectiv.com>

1 files changed, 0 insertions, 80 deletions

diff --git a/openecomp-be/lib/openecomp-sdc-externaltesting-lib/openecomp-sdc-externaltesting-impl/src/test/java/org/openecomp/core/externaltesting/impl/ConfigurationTests.java b/openecomp-be/lib/openecomp-sdc-externaltesting-lib/openecomp-sdc-externaltesting-impl/src/test/java/org/openecomp/core/externaltesting/impl/ConfigurationTests.java
deleted file mode 100644
index 05fc9e3938..0000000000
--- a/openecomp-be/lib/openecomp-sdc-externaltesting-lib/openecomp-sdc-externaltesting-impl/src/test/java/org/openecomp/core/externaltesting/impl/ConfigurationTests.java
+++ /dev/null
@@ -1,80 +0,0 @@
-/*
- * Copyright © 2019 iconectiv
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.openecomp.core.externaltesting.impl;
-
-import com.fasterxml.jackson.databind.ObjectMapper;
-import org.junit.Assert;
-import org.junit.Test;
-import org.onap.sdc.tosca.services.YamlUtil;
-import org.openecomp.core.externaltesting.api.ClientConfiguration;
-import org.openecomp.core.externaltesting.api.RemoteTestingEndpointDefinition;
-
-import java.io.File;
-import java.io.FileInputStream;
-import java.io.InputStream;
-
-public class ConfigurationTests {
-
-  @Test
-  public void testClientConfig() {
-    // a brain dead test of the setter and getter.
-    // future tests for more complex config to come.
-    ClientConfiguration cc = new ClientConfiguration();
-    cc.setEnabled(true);
-    Assert.assertTrue("client configuration setter", cc.isEnabled());
-    cc.setEnabled(false);
-    Assert.assertFalse("client configuration setter", cc.isEnabled());
-  }
-
-  @Test
-  public void testConfig() throws Exception {
-    try (InputStream fileInput = new FileInputStream(new File("src/test/data/externaltesting-configuration.yaml"))) {
-      YamlUtil yamlUtil = new YamlUtil();
-      Object raw = yamlUtil.yamlToMap(fileInput);
-      TestingAccessConfig accessConfig = new ObjectMapper().convertValue(raw, TestingAccessConfig.class);
-      Assert.assertNotNull("client config available", accessConfig.getClient());
-    }
-  }
-
-  @Test
-  public void testEndpointDefinition() {
-    RemoteTestingEndpointDefinition def = new RemoteTestingEndpointDefinition();
-    def.setId("vtp");
-    def.setEnabled(true);
-    def.setTitle("VTP");
-    def.setApiKey("FOOBARBAZ");
-    def.setUrl("http://example.com/vtptesting");
-    def.setScenarioFilter("c.*");
-
-    RemoteTestingEndpointDefinition def2 = new RemoteTestingEndpointDefinition();
-    def2.setId("vtp");
-    def2.setEnabled(true);
-    def2.setTitle("VTP");
-    def2.setUrl("http://example.com/vtptesting");
-    def2.setApiKey("FOOBARBAZ");
-    def2.setScenarioFilter("c.*");
-
-    Assert.assertEquals("code", "VTP", def.getTitle());
-    Assert.assertEquals("API keys equals", def.getApiKey(), def2.getApiKey());
-    Assert.assertEquals("code equals", def.getTitle(), def2.getTitle());
-    Assert.assertEquals("url equals", def.getUrl(), def2.getUrl());
-
-    boolean matches = def.getScenarioFilterPattern().matcher("certification").matches();
-    Assert.assertTrue("pattern", matches);
-
-  }
-}