summaryrefslogtreecommitdiffstats
path: root/openecomp-be/lib/openecomp-item-permissions-lib/openecomp-item-permissions-core
diff options
context:
space:
mode:
authorsiddharth0905 <siddharth.singh4@amdocs.com>2018-07-11 16:34:03 +0530
committersiddharth0905 <siddharth.singh4@amdocs.com>2018-07-12 14:37:11 +0530
commite8a916c229e23ce406cae7d480a201eb505e9261 (patch)
treeab03aeb8fba32137f8aa640ccc4743feaac98e1d /openecomp-be/lib/openecomp-item-permissions-lib/openecomp-item-permissions-core
parent04a245ef31b5deb0c1b415b89e22f64887e3a411 (diff)
Response changed
Error Response changed while collaboration changes Change-Id: I1e634c5da3b2bfb3cf385efe1a015bc3c2cd890f Issue-ID: SDC-1496 Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
Diffstat (limited to 'openecomp-be/lib/openecomp-item-permissions-lib/openecomp-item-permissions-core')
-rw-r--r--openecomp-be/lib/openecomp-item-permissions-lib/openecomp-item-permissions-core/src/main/java/org/openecomp/sdc/itempermissions/servlet/PermissionsFilter.java114
1 files changed, 67 insertions, 47 deletions
diff --git a/openecomp-be/lib/openecomp-item-permissions-lib/openecomp-item-permissions-core/src/main/java/org/openecomp/sdc/itempermissions/servlet/PermissionsFilter.java b/openecomp-be/lib/openecomp-item-permissions-lib/openecomp-item-permissions-core/src/main/java/org/openecomp/sdc/itempermissions/servlet/PermissionsFilter.java
index baafb4a9eb..30472d6e80 100644
--- a/openecomp-be/lib/openecomp-item-permissions-lib/openecomp-item-permissions-core/src/main/java/org/openecomp/sdc/itempermissions/servlet/PermissionsFilter.java
+++ b/openecomp-be/lib/openecomp-item-permissions-lib/openecomp-item-permissions-core/src/main/java/org/openecomp/sdc/itempermissions/servlet/PermissionsFilter.java
@@ -16,9 +16,7 @@
package org.openecomp.sdc.itempermissions.servlet;
-import org.openecomp.sdc.itempermissions.PermissionsServices;
-import org.openecomp.sdc.itempermissions.PermissionsServicesFactory;
-
+import java.io.IOException;
import javax.servlet.Filter;
import javax.servlet.FilterChain;
import javax.servlet.FilterConfig;
@@ -28,70 +26,92 @@ import javax.servlet.ServletResponse;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import javax.ws.rs.HttpMethod;
-import java.io.IOException;
+import javax.ws.rs.core.Response;
+
+import org.codehaus.jackson.map.ObjectMapper;
+import org.openecomp.sdc.common.errors.ErrorCode;
+import org.openecomp.sdc.common.errors.ErrorCodeAndMessage;
+import org.openecomp.sdc.common.errors.Messages;
+import org.openecomp.sdc.itempermissions.PermissionsServices;
+import org.openecomp.sdc.itempermissions.PermissionsServicesFactory;
+import org.openecomp.sdc.logging.api.Logger;
+import org.openecomp.sdc.logging.api.LoggerFactory;
/**
* Created by ayalaben on 6/27/2017.
*/
public class PermissionsFilter implements Filter {
- private final PermissionsServices permissionsServices;
- private static final String IRRELEVANT_REQUEST = "Irrelevant_Request";
- private static final String EDIT_ITEM = "Edit_Item";
+ private static final Logger LOGGER = LoggerFactory.getLogger(PermissionsFilter.class);
+ private final PermissionsServices permissionsServices;
+ private static final String IRRELEVANT_REQUEST = "Irrelevant_Request";
+ private static final String EDIT_ITEM = "Edit_Item";
- public PermissionsFilter() {
- this.permissionsServices = PermissionsServicesFactory.getInstance().createInterface();
- }
+ public PermissionsFilter() {
+ this.permissionsServices = PermissionsServicesFactory.getInstance().createInterface();
+ }
- @Override
- public void init(FilterConfig filterConfig) {
- // required by servlet API
- }
+ @Override
+ public void init(FilterConfig filterConfig) {
+ // required by servlet API
+ }
- @Override
- public void doFilter(ServletRequest servletRequest, ServletResponse servletResponse,
- FilterChain filterChain) throws IOException, ServletException {
+ @Override
+ public void doFilter(ServletRequest servletRequest, ServletResponse servletResponse, FilterChain filterChain)
+ throws IOException, ServletException {
- if ((servletRequest instanceof HttpServletRequest) &&
- isIrrelevant((HttpServletRequest) servletRequest, servletResponse)) {
- return;
+ if ((servletRequest instanceof HttpServletRequest)
+ && isRelevant((HttpServletRequest) servletRequest, servletResponse)) {
+ filterChain.doFilter(servletRequest, servletResponse);
+ }
}
- filterChain.doFilter(servletRequest, servletResponse);
- }
+ private boolean isRelevant(HttpServletRequest servletRequest, ServletResponse servletResponse) throws IOException {
+ String method = servletRequest.getMethod();
+ if (method.equals(HttpMethod.POST) || method.equals(HttpMethod.PUT) || method.equals(HttpMethod.DELETE)) {
- private boolean isIrrelevant(HttpServletRequest servletRequest, ServletResponse servletResponse) throws IOException {
+ String userId = servletRequest.getHeader("USER_ID");
+ String itemId = parseItemIdFromPath(servletRequest.getPathInfo());
+ if (!itemId.equals(IRRELEVANT_REQUEST) && !permissionsServices.isAllowed(itemId, userId, EDIT_ITEM)) {
+ ((HttpServletResponse) servletResponse).setStatus(HttpServletResponse.SC_FORBIDDEN);
+ servletResponse.getWriter().print(buildResponse(Response.Status.FORBIDDEN,
+ Messages.PERMISSIONS_ERROR.getErrorMessage(),
+ Messages.PERMISSIONS_ERROR.name()));
+ return false;
+ }
+ }
- String method = servletRequest.getMethod();
- if (method.equals(HttpMethod.POST) || method.equals(HttpMethod.PUT) || method.equals(HttpMethod.DELETE)) {
-
- String userId = servletRequest.getHeader("USER_ID");
- String itemId = parseItemIdFromPath(servletRequest.getPathInfo());
+ return true;
+ }
- if (!itemId.equals(IRRELEVANT_REQUEST) && !permissionsServices.isAllowed(itemId,userId,EDIT_ITEM)) {
- ((HttpServletResponse) servletResponse).setStatus(HttpServletResponse.SC_FORBIDDEN);
- servletResponse.getWriter().print("Permissions Error. The user does not have " +
- "permission to perform" +
- " this action.");
- return true;
+ private String parseItemIdFromPath(String pathInfo) {
+ String[] tokens = pathInfo.split("/");
+ if (tokens.length < 4) {
+ return IRRELEVANT_REQUEST;
+ } else {
+ return tokens[3];
}
}
- return false;
- }
+ @Override
+ public void destroy() {
+ // required by serlvet API
+ }
- private String parseItemIdFromPath(String pathInfo) {
- String[] tokens = pathInfo.split("/");
- if (tokens.length < 4) {
- return IRRELEVANT_REQUEST;
- } else {
- return tokens[3];
+ private String buildResponse(Response.Status status, String message, String id) {
+ ErrorCode errorCode = new ErrorCode.ErrorCodeBuilder()
+ .withId(id)
+ .withMessage(message).build();
+ return objectToJsonString(new ErrorCodeAndMessage(status, errorCode));
}
- }
- @Override
- public void destroy() {
- // required by serlvet API
- }
+ private String objectToJsonString(Object obj) {
+ try {
+ return new ObjectMapper().writerWithDefaultPrettyPrinter().writeValueAsString(obj);
+ } catch (Exception e) {
+ LOGGER.error(e.getMessage(), e);
+ return "An internal error has occurred. Please contact support.";
+ }
+ }
}