summaryrefslogtreecommitdiffstats
path: root/openecomp-be/api/openecomp-sdc-rest-webapp/notifications-rest
diff options
context:
space:
mode:
authorBartosz Gardziejewski <bartosz.gardziejewski@nokia.com>2019-08-20 15:53:19 +0200
committerBartosz Gardziejewski <bartosz.gardziejewski@nokia.com>2019-08-21 14:35:38 +0200
commit7962fe55692954548da260f31528dfc434f17755 (patch)
tree675513195ae04fbdd0eafd058e816c184acbe50e /openecomp-be/api/openecomp-sdc-rest-webapp/notifications-rest
parent4d8b50e2a87095d737db72f454f7520ff97f4ec5 (diff)
increasing test coverage in openecomp-be api
Issue-ID: SDC-2326 Signed-off-by: Bartosz Gardziejewski <bartosz.gardziejewski@nokia.com> Change-Id: I93cc5183190fcbada2349b18f14fbec9c28f1ae5
Diffstat (limited to 'openecomp-be/api/openecomp-sdc-rest-webapp/notifications-rest')
-rw-r--r--openecomp-be/api/openecomp-sdc-rest-webapp/notifications-rest/notifications-rest-types/pom.xml8
-rw-r--r--openecomp-be/api/openecomp-sdc-rest-webapp/notifications-rest/notifications-rest-types/src/test/java/org/openecomp/sdcrests/notifications/types/NotificationEntityDtoTest.java64
-rw-r--r--openecomp-be/api/openecomp-sdc-rest-webapp/notifications-rest/notifications-rest-types/src/test/java/org/openecomp/sdcrests/notifications/types/NotificationsStatusDtoTest.java38
-rw-r--r--openecomp-be/api/openecomp-sdc-rest-webapp/notifications-rest/notifications-rest-types/src/test/java/org/openecomp/sdcrests/notifications/types/UpdateNotificationResponseStatusTest.java99
4 files changed, 208 insertions, 1 deletions
diff --git a/openecomp-be/api/openecomp-sdc-rest-webapp/notifications-rest/notifications-rest-types/pom.xml b/openecomp-be/api/openecomp-sdc-rest-webapp/notifications-rest/notifications-rest-types/pom.xml
index 76b6fcfbbc..03ff748e4c 100644
--- a/openecomp-be/api/openecomp-sdc-rest-webapp/notifications-rest/notifications-rest-types/pom.xml
+++ b/openecomp-be/api/openecomp-sdc-rest-webapp/notifications-rest/notifications-rest-types/pom.xml
@@ -9,6 +9,12 @@
<artifactId>openecomp-sdc-datatypes-lib</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-api</artifactId>
+ <version>5.3.1</version>
+ <scope>test</scope>
+ </dependency>
</dependencies>
<parent>
@@ -20,4 +26,4 @@
<artifactId>notifications-rest-types</artifactId>
-</project> \ No newline at end of file
+</project>
diff --git a/openecomp-be/api/openecomp-sdc-rest-webapp/notifications-rest/notifications-rest-types/src/test/java/org/openecomp/sdcrests/notifications/types/NotificationEntityDtoTest.java b/openecomp-be/api/openecomp-sdc-rest-webapp/notifications-rest/notifications-rest-types/src/test/java/org/openecomp/sdcrests/notifications/types/NotificationEntityDtoTest.java
new file mode 100644
index 0000000000..e9e2bee613
--- /dev/null
+++ b/openecomp-be/api/openecomp-sdc-rest-webapp/notifications-rest/notifications-rest-types/src/test/java/org/openecomp/sdcrests/notifications/types/NotificationEntityDtoTest.java
@@ -0,0 +1,64 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * SDC
+ * ================================================================================
+ * Copyright (C) 2019 Nokia. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.openecomp.sdcrests.notifications.types;
+
+import org.junit.jupiter.api.Test;
+
+import java.util.Collections;
+import java.util.Map;
+import java.util.UUID;
+
+import static com.google.code.beanmatchers.BeanMatchers.hasValidBeanConstructor;
+import static com.google.code.beanmatchers.BeanMatchers.hasValidGettersAndSetters;
+import static org.hamcrest.CoreMatchers.allOf;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+class NotificationEntityDtoTest {
+ @Test
+ void testBean() {
+ assertThat(NotificationEntityDto.class, allOf(
+ hasValidBeanConstructor(),
+ hasValidGettersAndSetters()
+ ));
+ }
+ @Test
+ void validateArgConstructors() {
+
+ final boolean read = false;
+ final UUID eventId = new UUID(10,20);
+ final String eventType = "testType";
+ final Map<String, Object> eventAttributes = Collections.singletonMap("testKey","testValue");
+ NotificationEntityDto notificationEntityDto = new NotificationEntityDto(read,eventId,eventType,eventAttributes);
+ assertEquals(notificationEntityDto.isRead(), read);
+ assertEquals(notificationEntityDto.getEventId(), eventId);
+ assertEquals(notificationEntityDto.getEventType(), eventType);
+ assertEquals(notificationEntityDto.getEventAttributes(), eventAttributes);
+
+ final String dataTime = "10-10-2019";
+ notificationEntityDto = new NotificationEntityDto(read, eventId, eventType, eventAttributes, dataTime);
+ assertEquals(notificationEntityDto.isRead(), read);
+ assertEquals(notificationEntityDto.getEventId(), eventId);
+ assertEquals(notificationEntityDto.getEventType(), eventType);
+ assertEquals(notificationEntityDto.getEventAttributes(), eventAttributes);
+ assertEquals(notificationEntityDto.getDateTime(), dataTime);
+ }
+}
diff --git a/openecomp-be/api/openecomp-sdc-rest-webapp/notifications-rest/notifications-rest-types/src/test/java/org/openecomp/sdcrests/notifications/types/NotificationsStatusDtoTest.java b/openecomp-be/api/openecomp-sdc-rest-webapp/notifications-rest/notifications-rest-types/src/test/java/org/openecomp/sdcrests/notifications/types/NotificationsStatusDtoTest.java
new file mode 100644
index 0000000000..fe236f33ce
--- /dev/null
+++ b/openecomp-be/api/openecomp-sdc-rest-webapp/notifications-rest/notifications-rest-types/src/test/java/org/openecomp/sdcrests/notifications/types/NotificationsStatusDtoTest.java
@@ -0,0 +1,38 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * SDC
+ * ================================================================================
+ * Copyright (C) 2019 Nokia. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.openecomp.sdcrests.notifications.types;
+
+import org.junit.jupiter.api.Test;
+
+import static com.google.code.beanmatchers.BeanMatchers.hasValidBeanConstructor;
+import static com.google.code.beanmatchers.BeanMatchers.hasValidGettersAndSetters;
+import static org.hamcrest.CoreMatchers.allOf;
+import static org.hamcrest.MatcherAssert.assertThat;
+
+class NotificationsStatusDtoTest {
+ @Test
+ void testBean() {
+ assertThat(NotificationsStatusDto.class, allOf(
+ hasValidBeanConstructor(),
+ hasValidGettersAndSetters()
+ ));
+ }
+}
diff --git a/openecomp-be/api/openecomp-sdc-rest-webapp/notifications-rest/notifications-rest-types/src/test/java/org/openecomp/sdcrests/notifications/types/UpdateNotificationResponseStatusTest.java b/openecomp-be/api/openecomp-sdc-rest-webapp/notifications-rest/notifications-rest-types/src/test/java/org/openecomp/sdcrests/notifications/types/UpdateNotificationResponseStatusTest.java
new file mode 100644
index 0000000000..20d23fbf7e
--- /dev/null
+++ b/openecomp-be/api/openecomp-sdc-rest-webapp/notifications-rest/notifications-rest-types/src/test/java/org/openecomp/sdcrests/notifications/types/UpdateNotificationResponseStatusTest.java
@@ -0,0 +1,99 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * SDC
+ * ================================================================================
+ * Copyright (C) 2019 Nokia. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.openecomp.sdcrests.notifications.types;
+
+import org.junit.jupiter.api.Test;
+import org.openecomp.sdc.datatypes.error.ErrorLevel;
+import org.openecomp.sdc.datatypes.error.ErrorMessage;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+
+import static com.google.code.beanmatchers.BeanMatchers.hasValidBeanConstructor;
+import static com.google.code.beanmatchers.BeanMatchers.hasValidGettersAndSetters;
+import static org.hamcrest.CoreMatchers.allOf;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.jupiter.api.Assertions.assertArrayEquals;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+public class UpdateNotificationResponseStatusTest {
+ @Test
+ void testBean() {
+ assertThat(UpdateNotificationResponseStatus.class, allOf(
+ hasValidBeanConstructor(),
+ hasValidGettersAndSetters()
+ ));
+ }
+ @Test
+ void validateAddStructureErrorCorrectlyAddsOneError() {
+ UpdateNotificationResponseStatus updateNotificationResponseStatus = new UpdateNotificationResponseStatus();
+
+ assertTrue(updateNotificationResponseStatus.getErrors().isEmpty());
+ final String notificationId = "testId";
+ final ErrorMessage testError = new ErrorMessage(ErrorLevel.ERROR,"test Error");
+ updateNotificationResponseStatus.addStructureError(notificationId, testError);
+
+ assertFalse(updateNotificationResponseStatus.getErrors().isEmpty());
+ assertEquals(updateNotificationResponseStatus.getErrors().size(),1);
+ assertEquals(updateNotificationResponseStatus.getErrors().get(notificationId).size(),1);
+ assertEquals(updateNotificationResponseStatus.getErrors().get(notificationId).get(0),testError);
+ }
+ @Test
+ void validateAddStructureErrorCorrectlyAddsTwoErrorsToOneKey() {
+ UpdateNotificationResponseStatus updateNotificationResponseStatus = new UpdateNotificationResponseStatus();
+
+ assertTrue(updateNotificationResponseStatus.getErrors().isEmpty());
+ final String notificationId = "testId";
+ final ErrorMessage testError01 = new ErrorMessage(ErrorLevel.ERROR,"test Error01");
+ final ErrorMessage testError02 = new ErrorMessage(ErrorLevel.ERROR,"test Error02");
+ final List<ErrorMessage > testErrorsList = new ArrayList<>();
+ Collections.addAll(testErrorsList,testError01,testError02);
+ updateNotificationResponseStatus.addStructureError(notificationId, testError01);
+ updateNotificationResponseStatus.addStructureError(notificationId, testError02);
+
+ assertFalse(updateNotificationResponseStatus.getErrors().isEmpty());
+ assertEquals(updateNotificationResponseStatus.getErrors().size(),1);
+ assertEquals(updateNotificationResponseStatus.getErrors().get(notificationId).size(),2);
+ assertArrayEquals(updateNotificationResponseStatus.getErrors().get(notificationId).toArray(), testErrorsList.toArray());
+ }
+ @Test
+ void validateAddStructureErrorCorrectlyAddsTwoErrorsToTwoKeys() {
+ UpdateNotificationResponseStatus updateNotificationResponseStatus = new UpdateNotificationResponseStatus();
+
+ assertTrue(updateNotificationResponseStatus.getErrors().isEmpty());
+ final String notificationId01 = "testId01";
+ final ErrorMessage testError01 = new ErrorMessage(ErrorLevel.ERROR,"test Error01");
+ final String notificationId02 = "testId02";
+ final ErrorMessage testError02 = new ErrorMessage(ErrorLevel.ERROR,"test Error02");
+ updateNotificationResponseStatus.addStructureError(notificationId01, testError01);
+ updateNotificationResponseStatus.addStructureError(notificationId02, testError02);
+
+ assertFalse(updateNotificationResponseStatus.getErrors().isEmpty());
+ assertEquals(updateNotificationResponseStatus.getErrors().size(),2);
+ assertEquals(updateNotificationResponseStatus.getErrors().get(notificationId01).size(),1);
+ assertEquals(updateNotificationResponseStatus.getErrors().get(notificationId01).get(0), testError01);
+ assertEquals(updateNotificationResponseStatus.getErrors().get(notificationId02).size(),1);
+ assertEquals(updateNotificationResponseStatus.getErrors().get(notificationId02).get(0), testError02);
+ }
+}