adding flow tests for vlan tagging validation

Issue-ID: SDC-994
Change-Id: I04c1fd0e10f36681b4a5752900d2e2be67579c4a
Signed-off-by: katy.rotman <katy.rotman@amdocs.com>

10 files changed, 105 insertions, 0 deletions

diff --git a/openecomp-bdd/features/TOSCA/VirtualMachineInterfaceValidation-positive.feature b/openecomp-bdd/features/TOSCA/VirtualMachineInterfaceValidation-positive.feature
new file mode 100644
index 0000000000..1cbd48ff42
--- /dev/null
+++ b/openecomp-bdd/features/TOSCA/VirtualMachineInterfaceValidation-positive.feature
@@ -0,0 +1,14 @@
+Feature: Tosca Validation Flow
+
+  Background: Init
+    Given I want to create a VLM
+    Given I want to set all Togglz to be "true"
+
+  Scenario: No Validations Errors
+    When I want to create a VSP with onboarding type "NetworkPackage"
+
+    Then I want to upload a NetworkPackage for this VSP from path "resources/uploads/vlan-tagging-positive.zip"
+    And I want to process the NetworkPackage file for this VSP
+    And I want to print the context data
+
+    Then I want to check property "errors['nested.yml'][0].level" does not exist
diff --git a/openecomp-bdd/features/TOSCA/VirtualMachineInterfaceValidationGuideline3violations.feature b/openecomp-bdd/features/TOSCA/VirtualMachineInterfaceValidationGuideline3violations.feature
new file mode 100644
index 0000000000..46979f2596
--- /dev/null
+++ b/openecomp-bdd/features/TOSCA/VirtualMachineInterfaceValidationGuideline3violations.feature
@@ -0,0 +1,31 @@
+Feature: Tosca Validation Flow
+
+  Background: Init
+    Given I want to create a VLM
+    Given I want to set all Togglz to be "true"
+
+  Scenario: Test Validation Error
+    When I want to create a VSP with onboarding type "NetworkPackage"
+
+    Then I want to upload a NetworkPackage for this VSP from path "resources/uploads/all-violations.zip"
+    And I want to process the NetworkPackage file for this VSP
+    And I want to print the context data
+
+    Then I want to check property "errors['main.yml'][4].level" for value "ERROR"
+    Then I want to check property "errors['main.yml'][4].message" for value:
+    """
+  ERROR: [VlAN_G1]: VLAN Resource will not be translated as the VLAN Sub-interface [test_Vlan1] is not modeled as resource group
+    """
+
+
+    Then I want to check property "errors['main.yml'][5].level" for value "ERROR"
+    Then I want to check property "errors['main.yml'][5].message" for value:
+    """
+    ERROR: [VlAN_G2]: There should not be any Compute Server Node, Port, Parent Port in nested file [main.yml]
+"""
+
+    Then I want to check property "errors['main.yml'][6].level" for value "WARNING"
+    Then I want to check property "errors['main.yml'][6].message" for value:
+    """
+  WARNING: [VlAN_G3]: Network role associated with VLAN Sub-interface id[test_Vlan1] is not following the naming convention
+    """
\ No newline at end of file
diff --git a/openecomp-bdd/features/TOSCA/VirtualMachineInterfaceValidationHeatResourceMissingProperties.feature b/openecomp-bdd/features/TOSCA/VirtualMachineInterfaceValidationHeatResourceMissingProperties.feature
new file mode 100644
index 0000000000..df1699cf9f
--- /dev/null
+++ b/openecomp-bdd/features/TOSCA/VirtualMachineInterfaceValidationHeatResourceMissingProperties.feature
@@ -0,0 +1,31 @@
+Feature: Tosca Validation Flow
+
+  Background: Init
+    Given I want to create a VLM
+    Given I want to set all Togglz to be "true"
+
+  Scenario: Missing Refs Element Validation Error
+    When I want to create a VSP with onboarding type "NetworkPackage"
+
+    Then I want to upload a NetworkPackage for this VSP from path "resources/uploads/refs_missing.zip"
+    And I want to process the NetworkPackage file for this VSP
+    And I want to print the context data
+
+    Then I want to check property "errors['nested.yml'][0].level" for value "WARNING"
+    Then I want to check property "errors['nested.yml'][0].message" for value:
+    """
+    WARNING: [VLAN2]: Parent port property virtual_machine_interface_refs is missing in VLAN Resource ID [template_Vlan_2]
+    """
+
+  Scenario: Missing Tag Validation Error
+    When I want to create a VSP with onboarding type "NetworkPackage"
+
+    Then I want to upload a NetworkPackage for this VSP from path "resources/uploads/tag_missing.zip"
+    And I want to process the NetworkPackage file for this VSP
+    And I want to print the context data
+
+    Then I want to check property "errors['nested.yml'][0].level" for value "WARNING"
+    Then I want to check property "errors['nested.yml'][0].message" for value:
+    """
+    WARNING: [VLAN2]: VLAN Tag property virtual_machine_interface_properties_sub_interface_vlan_tag is missing in VLAN Resource ID [template_Vlan_2]
+    """
\ No newline at end of file
diff --git a/openecomp-bdd/features/TOSCA/VirtualMachineInterfaceValidationHeatResourceMultipleParents.feature b/openecomp-bdd/features/TOSCA/VirtualMachineInterfaceValidationHeatResourceMultipleParents.feature
new file mode 100644
index 0000000000..b702fd089d
--- /dev/null
+++ b/openecomp-bdd/features/TOSCA/VirtualMachineInterfaceValidationHeatResourceMultipleParents.feature
@@ -0,0 +1,18 @@
+Feature: Tosca Validation Flow
+
+  Background: Init
+    Given I want to create a VLM
+    Given I want to set all Togglz to be "true"
+
+  Scenario: Test Validation Error
+    When I want to create a VSP with onboarding type "NetworkPackage"
+
+    Then I want to upload a NetworkPackage for this VSP from path "resources/uploads/multiple-parents.zip"
+    And I want to process the NetworkPackage file for this VSP
+    And I want to print the context data
+
+    Then I want to check property "errors['nested.yml'][0].level" for value "ERROR"
+    Then I want to check property "errors['nested.yml'][0].message" for value:
+    """
+    ERROR: [VLAN1]: More than one parent port found, there should be only one parent port for a VLAN sub-interface ID [template_Vlan_2]
+    """
\ No newline at end of file
diff --git a/openecomp-bdd/resources/uploads/all-violations.zip b/openecomp-bdd/resources/uploads/all-violations.zip
new file mode 100644
index 0000000000..d86c7a7ee3
--- /dev/null
+++ b/openecomp-bdd/resources/uploads/all-violations.zip
diff --git a/openecomp-bdd/resources/uploads/multiple-parents.zip b/openecomp-bdd/resources/uploads/multiple-parents.zip
new file mode 100644
index 0000000000..64d579ca2e
--- /dev/null
+++ b/openecomp-bdd/resources/uploads/multiple-parents.zip
diff --git a/openecomp-bdd/resources/uploads/refs_missing.zip b/openecomp-bdd/resources/uploads/refs_missing.zip
new file mode 100644
index 0000000000..3aec1382fc
--- /dev/null
+++ b/openecomp-bdd/resources/uploads/refs_missing.zip
diff --git a/openecomp-bdd/resources/uploads/tag_missing.zip b/openecomp-bdd/resources/uploads/tag_missing.zip
new file mode 100644
index 0000000000..84b0d8ef3e
--- /dev/null
+++ b/openecomp-bdd/resources/uploads/tag_missing.zip
diff --git a/openecomp-bdd/resources/uploads/vlan-tagging-positive.zip b/openecomp-bdd/resources/uploads/vlan-tagging-positive.zip
new file mode 100644
index 0000000000..22e66af340
--- /dev/null
+++ b/openecomp-bdd/resources/uploads/vlan-tagging-positive.zip
diff --git a/openecomp-bdd/stepDefinitions/General_Steps.js b/openecomp-bdd/stepDefinitions/General_Steps.js
index 13c03f7848..b9ea72f78d 100644
--- a/openecomp-bdd/stepDefinitions/General_Steps.js
+++ b/openecomp-bdd/stepDefinitions/General_Steps.js
@@ -86,6 +86,17 @@ Then('I want to check property {string} for value {string}', function(string, st
 });
 /**
  * @module ResponseData
+ * @description Will check the output data for a property and a value. property can be a path
+ * (example: results[0].id). Supports comparison to a long String by allowing a line break
+ * @exampleFile VirtualMachineInterfaceValidationHeatResourceMissingProperties.feature
+ * @step I want to check property {string} for value {string}
+ **/
+
+Then('I want to check property {string} for value:', function(string, docString)  {
+	assert.equal(_.get(this.context.responseData, string), docString.trim());
+});
+/**
+ * @module ResponseData
  * @description Will check the output data for a property and a integer. property can be a path (example: results[0].id)
  * @exampleFile Example_ResponseData_CheckAndManipulation.feature
  * @step I want to check property {string} for value {int}