diff options
author | franciscovila <javier.paradela.vila@est.tech> | 2022-06-30 16:06:54 +0100 |
---|---|---|
committer | Michael Morris <michael.morris@est.tech> | 2022-07-18 12:05:51 +0000 |
commit | 4e4ec8e9c21acf7f9210aaebf8f13a60542737fc (patch) | |
tree | 15723af4fb7d6ca044be596ce1100ad19767bc3f /catalog-model/src/main/java | |
parent | ee8876059c520d97bf068734b25a02365d7fe1ea (diff) |
Allow set values in properties of type timestamp
Issue-ID: SDC-4080
Signed-off-by: franciscovila <javier.paradela.vila@est.tech>
Change-Id: I4c03e660e64118a388beb1d0db3527f9a1427c3f
Diffstat (limited to 'catalog-model/src/main/java')
-rw-r--r-- | catalog-model/src/main/java/org/openecomp/sdc/be/model/tosca/ToscaType.java | 8 | ||||
-rw-r--r-- | catalog-model/src/main/java/org/openecomp/sdc/be/model/tosca/validators/TimestampValidator.java | 77 |
2 files changed, 79 insertions, 6 deletions
diff --git a/catalog-model/src/main/java/org/openecomp/sdc/be/model/tosca/ToscaType.java b/catalog-model/src/main/java/org/openecomp/sdc/be/model/tosca/ToscaType.java index 98ca5d02ab..85758707b8 100644 --- a/catalog-model/src/main/java/org/openecomp/sdc/be/model/tosca/ToscaType.java +++ b/catalog-model/src/main/java/org/openecomp/sdc/be/model/tosca/ToscaType.java @@ -31,6 +31,7 @@ import lombok.AllArgsConstructor; import lombok.Getter; import org.openecomp.sdc.be.model.tosca.constraints.ConstraintUtil; import org.openecomp.sdc.be.model.tosca.constraints.exception.ConstraintValueDoNotMatchPropertyTypeException; +import org.openecomp.sdc.be.model.tosca.validators.TimestampValidator; /** * The primitive type that TOSCA YAML supports. @@ -107,12 +108,7 @@ public enum ToscaType { case SCALAR_UNIT_FREQUENCY: return true; case TIMESTAMP: - try { - new SimpleDateFormat("MMM dd, yyyy hh:mm:ss a", Locale.US).parse(value); - return true; - } catch (ParseException e) { - return false; - } + return TimestampValidator.getInstance().isValid(value, null); case VERSION: return VersionUtil.isValid(value); case LIST: diff --git a/catalog-model/src/main/java/org/openecomp/sdc/be/model/tosca/validators/TimestampValidator.java b/catalog-model/src/main/java/org/openecomp/sdc/be/model/tosca/validators/TimestampValidator.java new file mode 100644 index 0000000000..f7b368d8cb --- /dev/null +++ b/catalog-model/src/main/java/org/openecomp/sdc/be/model/tosca/validators/TimestampValidator.java @@ -0,0 +1,77 @@ +/* + * ============LICENSE_START======================================================= + * Copyright (C) 2022 Nordix Foundation + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + * SPDX-License-Identifier: Apache-2.0 + * ============LICENSE_END========================================================= + * + * + */ +package org.openecomp.sdc.be.model.tosca.validators; + +import lombok.AccessLevel; +import lombok.NoArgsConstructor; +import org.openecomp.sdc.be.model.DataTypeDefinition; +import org.openecomp.sdc.common.log.wrappers.Logger; + +import java.time.format.DateTimeFormatter; +import java.time.format.DateTimeFormatterBuilder; +import java.time.format.DateTimeParseException; +import java.util.Map; + +@NoArgsConstructor(access = AccessLevel.PRIVATE) +public class TimestampValidator implements PropertyTypeValidator { + + private static final Logger log = Logger.getLogger(TimestampValidator.class.getName()); + + private static TimestampValidator timestampValidator = new TimestampValidator(); + + public static TimestampValidator getInstance() { + return timestampValidator; + } + + @Override + public boolean isValid(String value, String innerType, Map<String, DataTypeDefinition> allDataTypes) { + if (value == null || value.isEmpty()) { + return true; + } + boolean isValid = true; + DateTimeFormatter dateFormatter = new DateTimeFormatterBuilder() + .appendOptional(DateTimeFormatter.ISO_DATE_TIME) + .appendOptional(DateTimeFormatter.ofPattern("yyyy-MM-dd H:mm:ss.SS")) + .appendOptional(DateTimeFormatter.ofPattern("yyyy-MM-dd")) + .optionalStart() + .appendOffset("+HH", "0000") + .optionalEnd() + .optionalStart() + .appendLiteral(" ") + .appendOffset("+H", "0000") + .optionalEnd() + .toFormatter(); + try { + dateFormatter.parse(value); + } catch (DateTimeParseException e) { + isValid = false; + } + if (!isValid && log.isDebugEnabled()) { + log.debug("parameter Timestamp value {} is not valid.", value); + } + return isValid; + } + + @Override + public boolean isValid(String value, String innerType) { + return isValid(value, innerType, null); + } +} |