aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorisaac.manuelraj <isaac.manuelraj@huawei.com>2018-11-13 10:56:11 +0530
committerTal Gitelman <tal.gitelman@att.com>2018-11-19 16:08:08 +0000
commitb220964f137064633fb2a9412aad180ee6702c9d (patch)
tree84aebc5fc7b29f3e25414c1f791d5178344ee2f0
parente9552d06e0733e9bdf3a5868427097a49851c7a6 (diff)
Add new test cases for uncovered lines of code.
Added new test cases on top of existing test class. Issue-ID: SDC-1774 Change-Id: I1fd38f14ef7fbfc6ddf478852c0dfd35a27607fa Signed-off-by: isaac.manuelraj <isaac.manuelraj@huawei.com>
-rw-r--r--catalog-be/src/test/java/org/openecomp/sdc/be/components/impl/AttributeBusinessLogicTest.java400
1 files changed, 387 insertions, 13 deletions
diff --git a/catalog-be/src/test/java/org/openecomp/sdc/be/components/impl/AttributeBusinessLogicTest.java b/catalog-be/src/test/java/org/openecomp/sdc/be/components/impl/AttributeBusinessLogicTest.java
index 630f41f905..88918de1a3 100644
--- a/catalog-be/src/test/java/org/openecomp/sdc/be/components/impl/AttributeBusinessLogicTest.java
+++ b/catalog-be/src/test/java/org/openecomp/sdc/be/components/impl/AttributeBusinessLogicTest.java
@@ -1,10 +1,33 @@
package org.openecomp.sdc.be.components.impl;
+import java.lang.reflect.Field;
+import java.util.ArrayList;
+import java.util.HashMap;
import java.util.List;
+import java.util.Map;
+import junit.framework.Assert;
+import org.junit.Before;
import org.junit.Test;
-import org.openecomp.sdc.be.model.PropertyDefinition;
+import org.mockito.Mockito;
+import org.openecomp.sdc.be.components.validation.UserValidations;
+import org.openecomp.sdc.be.dao.jsongraph.TitanDao;
+import org.openecomp.sdc.be.dao.titan.TitanOperationStatus;
+import org.openecomp.sdc.be.impl.ComponentsUtils;
+import org.openecomp.sdc.be.model.*;
+import org.openecomp.sdc.be.model.cache.ApplicationDataTypeCache;
+import org.openecomp.sdc.be.model.jsontitan.operations.ToscaOperationFacade;
+import org.openecomp.sdc.be.model.operations.api.IGraphLockOperation;
+import org.openecomp.sdc.be.model.operations.api.StorageOperationStatus;
+import org.openecomp.sdc.be.model.operations.impl.PropertyOperation;
+import org.openecomp.sdc.be.model.operations.utils.ComponentValidationUtils;
+import org.openecomp.sdc.be.model.tosca.ToscaPropertyType;
import org.openecomp.sdc.exception.ResponseFormat;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.anyObject;
+import static org.mockito.ArgumentMatchers.anyString;
+import static org.mockito.Mockito.doNothing;
+import static org.mockito.Mockito.when;
import fj.data.Either;
@@ -15,7 +38,53 @@ public class AttributeBusinessLogicTest {
return new AttributeBusinessLogic();
}
-
+ UserValidations userValidations = Mockito.mock(UserValidations.class);
+ ComponentsUtils componentsUtils = Mockito.mock(ComponentsUtils.class);
+ TitanDao titanDao = Mockito.mock(TitanDao.class);
+ ToscaOperationFacade toscaOperationFacade = Mockito.mock(ToscaOperationFacade.class);
+ ApplicationDataTypeCache applicationDataTypeCache = Mockito.mock(ApplicationDataTypeCache.class);
+ PropertyOperation propertyOperation = Mockito.mock(PropertyOperation.class);
+ Field baseBusinessLogic;
+ Field baseBusinessLogic1;
+ Field baseBusinessLogic2;
+ Field baseBusinessLogic3;
+ AttributeBusinessLogic attributeBusinessLogic=createTestSubject();
+ IGraphLockOperation igraphLockOperation = Mockito.mock(IGraphLockOperation.class);
+
+
+ @Before
+ public void setup() throws Exception{
+
+ baseBusinessLogic = attributeBusinessLogic.getClass().getSuperclass().getDeclaredField("graphLockOperation");
+ baseBusinessLogic.setAccessible(true);
+ baseBusinessLogic.set(attributeBusinessLogic, igraphLockOperation);
+
+ baseBusinessLogic1 = attributeBusinessLogic.getClass().getSuperclass().getDeclaredField("userValidations");
+ baseBusinessLogic1.setAccessible(true);
+ baseBusinessLogic1.set(attributeBusinessLogic, userValidations);
+
+ baseBusinessLogic2 = attributeBusinessLogic.getClass().getSuperclass().getDeclaredField("componentsUtils");
+ baseBusinessLogic2.setAccessible(true);
+ baseBusinessLogic2.set(attributeBusinessLogic, componentsUtils);
+
+ baseBusinessLogic3 = attributeBusinessLogic.getClass().getSuperclass().getDeclaredField("titanDao");
+ baseBusinessLogic3.setAccessible(true);
+ baseBusinessLogic3.set(attributeBusinessLogic, titanDao);
+
+ baseBusinessLogic = attributeBusinessLogic.getClass().getSuperclass().getDeclaredField("toscaOperationFacade");
+ baseBusinessLogic.setAccessible(true);
+ baseBusinessLogic.set(attributeBusinessLogic, toscaOperationFacade);
+
+ baseBusinessLogic = attributeBusinessLogic.getClass().getSuperclass().getDeclaredField("applicationDataTypeCache");
+ baseBusinessLogic.setAccessible(true);
+ baseBusinessLogic.set(attributeBusinessLogic, applicationDataTypeCache);
+
+ baseBusinessLogic = attributeBusinessLogic.getClass().getSuperclass().getDeclaredField("propertyOperation");
+ baseBusinessLogic.setAccessible(true);
+ baseBusinessLogic.set(attributeBusinessLogic, propertyOperation);
+ }
+
+
@Test
public void testCreateAttribute() throws Exception {
AttributeBusinessLogic testSubject;
@@ -28,19 +97,19 @@ public class AttributeBusinessLogicTest {
testSubject = createTestSubject();
}
-
+
@Test
public void testIsAttributeExist() throws Exception {
- AttributeBusinessLogic testSubject;List<PropertyDefinition> attributes = null;
- String resourceUid = "";
- String propertyName = "";
- boolean result;
-
- // test 1
- testSubject=createTestSubject();attributes = null;
+ AttributeBusinessLogic testSubject;List<PropertyDefinition> attributes = null;
+ String resourceUid = "";
+ String propertyName = "";
+ boolean result;
+
+ // test 1
+ testSubject=createTestSubject();attributes = null;
}
-
+
@Test
public void testGetAttribute() throws Exception {
AttributeBusinessLogic testSubject;
@@ -53,7 +122,7 @@ public class AttributeBusinessLogicTest {
testSubject = createTestSubject();
}
-
+
@Test
public void testUpdateAttribute() throws Exception {
AttributeBusinessLogic testSubject;
@@ -67,7 +136,7 @@ public class AttributeBusinessLogicTest {
testSubject = createTestSubject();
}
-
+
@Test
public void testDeleteAttribute() throws Exception {
AttributeBusinessLogic testSubject;
@@ -79,4 +148,309 @@ public class AttributeBusinessLogicTest {
// default test
testSubject = createTestSubject();
}
+
+
+ @Test
+ public void createAttribute_lockfail() throws Exception {
+ Either<PropertyDefinition, ResponseFormat> response;
+ PropertyDefinition prop= new PropertyDefinition();
+
+ response = attributeBusinessLogic.createAttribute("RES01", prop, "USR01");
+
+ Assert.assertEquals(true,response.isRight());
+
+ }
+
+ @Test
+ public void createAttribute_Success() throws Exception {
+
+ Component resource= new Resource();
+ resource.setLifecycleState(LifecycleStateEnum.NOT_CERTIFIED_CHECKOUT);
+ resource.setIsDeleted(false);
+ resource.setLastUpdaterUserId("USR01");
+
+ PropertyDefinition prop= new PropertyDefinition();
+ prop.setType(ToscaPropertyType.STRING.getType());
+
+ when(igraphLockOperation.lockComponent(any(),any())).thenReturn(StorageOperationStatus.OK);
+
+ //Either<Component, StorageOperationStatus> toscastatus=Either.right(StorageOperationStatus.INVALID_PROPERTY);
+ Either<Component, StorageOperationStatus> toscastatus=Either.left(resource);
+ when(toscaOperationFacade.getToscaElement("RES01")).thenReturn(toscastatus);
+ PropertyDefinition propertyDefinition = new PropertyDefinition();
+ Either<PropertyDefinition, StorageOperationStatus> either = Either.left(propertyDefinition);
+ when(toscaOperationFacade.addAttributeOfResource(anyObject(),anyObject())).thenReturn(either);
+
+ when(propertyOperation.isPropertyTypeValid(anyObject())).thenReturn(true);
+
+ Map<String,DataTypeDefinition> data=new HashMap<>();
+ data.put("ONE",new DataTypeDefinition());
+ Either<Map<String, DataTypeDefinition>, TitanOperationStatus> allDataTypes = Either.left(data);
+ when(applicationDataTypeCache.getAll()).thenReturn(allDataTypes);
+
+ when(propertyOperation.isPropertyDefaultValueValid(anyObject(),anyObject())).thenReturn(true);
+ Either<PropertyDefinition, ResponseFormat> response;
+
+ response = attributeBusinessLogic.createAttribute("RES01", prop, "USR01");
+
+ Assert.assertEquals(true,response.isLeft());
+
+ }
+
+ @Test
+ public void createAttribute_failtogettoscaelement() throws Exception {
+
+ Component resource= new Resource();
+ resource.setLifecycleState(LifecycleStateEnum.NOT_CERTIFIED_CHECKOUT);
+ resource.setIsDeleted(false);
+ resource.setLastUpdaterUserId("USR01");
+
+ when(igraphLockOperation.lockComponent(any(),any())).thenReturn(StorageOperationStatus.OK);
+
+ Either<PropertyDefinition, ResponseFormat> response;
+ PropertyDefinition prop= new PropertyDefinition();
+
+ baseBusinessLogic = attributeBusinessLogic.getClass().getSuperclass().getDeclaredField("toscaOperationFacade");
+ baseBusinessLogic.setAccessible(true);
+ baseBusinessLogic.set(attributeBusinessLogic, toscaOperationFacade);
+ //Either<Component, StorageOperationStatus> toscastatus=Either.right(StorageOperationStatus.INVALID_PROPERTY);
+ Either<Component, StorageOperationStatus> toscastatus=Either.right(StorageOperationStatus.GENERAL_ERROR);
+ when(toscaOperationFacade.getToscaElement("RES01")).thenReturn(toscastatus);
+
+ response = attributeBusinessLogic.createAttribute("RES01", prop, "USR01");
+
+ Assert.assertEquals(true,response.isRight());
+
+ }
+
+ @Test
+ public void createAttribute_componentvalidationfails() throws Exception {
+
+ Component resource= new Resource();
+ resource.setLifecycleState(LifecycleStateEnum.CERTIFIED);
+ resource.setIsDeleted(false);
+ resource.setLastUpdaterUserId("USR02");
+
+ when(igraphLockOperation.lockComponent(any(),any())).thenReturn(StorageOperationStatus.OK);
+
+ Either<PropertyDefinition, ResponseFormat> response;
+ PropertyDefinition prop= new PropertyDefinition();
+
+ //Either<Component, StorageOperationStatus> toscastatus=Either.right(StorageOperationStatus.INVALID_PROPERTY);
+ Either<Component, StorageOperationStatus> toscastatus=Either.left(resource);
+ when(toscaOperationFacade.getToscaElement("RES01")).thenReturn(toscastatus);
+
+ response = attributeBusinessLogic.createAttribute("RES01", prop, "USR01");
+
+ Assert.assertEquals(true,response.isRight());
+
+ }
+
+ @Test
+ public void createAttribute_componentalreadyexist_fails() throws Exception {
+
+ Either<PropertyDefinition, ResponseFormat> response;
+ PropertyDefinition prop= new PropertyDefinition();
+ prop.setName("RES01");
+ prop.setParentUniqueId("RES01");
+
+ List<PropertyDefinition> attributes = new ArrayList<>();
+ attributes.add(prop);
+
+ Component resource= new Resource();
+ resource.setLifecycleState(LifecycleStateEnum.NOT_CERTIFIED_CHECKOUT);
+ resource.setIsDeleted(false);
+ resource.setLastUpdaterUserId("USR01");
+ ((Resource) resource).setAttributes(attributes);
+
+ when(igraphLockOperation.lockComponent(any(),any())).thenReturn(StorageOperationStatus.OK);
+
+ //Either<Component, StorageOperationStatus> toscastatus=Either.right(StorageOperationStatus.INVALID_PROPERTY);
+ Either<Component, StorageOperationStatus> toscastatus=Either.left(resource);
+ when(toscaOperationFacade.getToscaElement("RES01")).thenReturn(toscastatus);
+
+ response = attributeBusinessLogic.createAttribute("RES01", prop, "USR01");
+
+ Assert.assertEquals(true,response.isRight());
+
+ }
+
+
+ @Test
+ public void createAttribute_addresourcetostoragefails() throws Exception {
+
+ Component resource= new Resource();
+ resource.setLifecycleState(LifecycleStateEnum.NOT_CERTIFIED_CHECKOUT);
+ resource.setIsDeleted(false);
+ resource.setLastUpdaterUserId("USR01");
+
+ PropertyDefinition prop= new PropertyDefinition();
+ prop.setType(ToscaPropertyType.STRING.getType());
+
+ IGraphLockOperation igraphLockOperation = Mockito.mock(IGraphLockOperation.class);
+ when(igraphLockOperation.lockComponent(any(),any())).thenReturn(StorageOperationStatus.OK);
+
+ //Either<Component, StorageOperationStatus> toscastatus=Either.right(StorageOperationStatus.INVALID_PROPERTY);
+ Either<Component, StorageOperationStatus> toscastatus=Either.left(resource);
+ when(toscaOperationFacade.getToscaElement("RES01")).thenReturn(toscastatus);
+ PropertyDefinition propertyDefinition = new PropertyDefinition();
+ Either<PropertyDefinition, StorageOperationStatus> either = Either.right(StorageOperationStatus.CONNECTION_FAILURE);
+ when(toscaOperationFacade.addAttributeOfResource(anyObject(),anyObject())).thenReturn(either);
+
+ when(propertyOperation.isPropertyTypeValid(anyObject())).thenReturn(true);
+
+ Map<String,DataTypeDefinition> data=new HashMap<>();
+ data.put("ONE",new DataTypeDefinition());
+ Either<Map<String, DataTypeDefinition>, TitanOperationStatus> allDataTypes = Either.left(data);
+ when(applicationDataTypeCache.getAll()).thenReturn(allDataTypes);
+
+ when(propertyOperation.isPropertyDefaultValueValid(anyObject(),anyObject())).thenReturn(true);
+ Either<PropertyDefinition, ResponseFormat> response;
+
+ response = attributeBusinessLogic.createAttribute("RES01", prop, "USR01");
+
+ Assert.assertEquals(true,response.isRight());
+
+ }
+
+ @Test
+ public void testgetAttribute_ATTRIBUTE_NOT_FOUND() throws Exception {
+ Either<PropertyDefinition, ResponseFormat> result;
+
+ Component resource= new Resource();
+ resource.setLifecycleState(LifecycleStateEnum.NOT_CERTIFIED_CHECKOUT);
+ resource.setIsDeleted(false);
+ resource.setLastUpdaterUserId("USR01");
+ Either<Component, StorageOperationStatus> toscastatus=Either.left(resource);
+ when(toscaOperationFacade.getToscaElement("RES01")).thenReturn(toscastatus);
+
+ result=attributeBusinessLogic.getAttribute("RES01","ATTR01", "USR01");
+ Assert.assertEquals(true,result.isRight());
+ }
+
+ @Test
+ public void testgetAttribute_success() throws Exception {
+ Either<PropertyDefinition, ResponseFormat> result;
+
+ Component resource= new Resource();
+ resource.setLifecycleState(LifecycleStateEnum.NOT_CERTIFIED_CHECKOUT);
+ resource.setIsDeleted(false);
+ resource.setLastUpdaterUserId("USR01");
+
+ PropertyDefinition prop= new PropertyDefinition();
+ prop.setUniqueId("ATTR01");
+ prop.setParentUniqueId("RES01");
+
+ List<PropertyDefinition> attr = new ArrayList<>();
+ attr.add(prop);
+
+ ((Resource) resource).setAttributes(attr);
+ Either<Component, StorageOperationStatus> toscastatus=Either.left(resource);
+ when(toscaOperationFacade.getToscaElement("RES01")).thenReturn(toscastatus);
+
+ result=attributeBusinessLogic.getAttribute("RES01","ATTR01", "USR01");
+ Assert.assertEquals(true,result.isLeft());
+ }
+
+ @Test
+ public void testgetAttribute_RESOURCE_NOT_FOUND() throws Exception {
+ Either<PropertyDefinition, ResponseFormat> result;
+
+ Either<Component, StorageOperationStatus> toscastatus=Either.right(StorageOperationStatus.PARENT_RESOURCE_NOT_FOUND);
+ when(toscaOperationFacade.getToscaElement("RES01")).thenReturn(toscastatus);
+
+ result=attributeBusinessLogic.getAttribute("RES01","ATTR01", "USR01");
+ Assert.assertEquals(true,result.isRight());
+ }
+
+ @Test
+ public void testdeleteAttribute_FAILED_TO_LOCK_COMPONENT() throws Exception {
+ Either<PropertyDefinition, ResponseFormat> result;
+
+ result=attributeBusinessLogic.deleteAttribute("RES01","ATTR01", "USR01");
+ Assert.assertEquals(true,result.isRight());
+ }
+
+ @Test
+ public void testdeleteAttribute_get_RESOURCE_from_DB_failed() throws Exception {
+ Either<PropertyDefinition, ResponseFormat> result;
+
+ Either<Component, StorageOperationStatus> toscastatus=Either.right(StorageOperationStatus.CONNECTION_FAILURE);
+ when(toscaOperationFacade.getToscaElement("RES01")).thenReturn(toscastatus);
+
+ result=attributeBusinessLogic.deleteAttribute("RES01","ATTR01", "USR01");
+ Assert.assertEquals(true,result.isRight());
+ }
+
+ @Test
+ public void testdeleteAttribute_get_RESOURCE_verification_failed() throws Exception {
+ Either<PropertyDefinition, ResponseFormat> result;
+
+
+ Component resource= new Resource();
+ resource.setLifecycleState(LifecycleStateEnum.NOT_CERTIFIED_CHECKOUT);
+ resource.setIsDeleted(true);
+ resource.setLastUpdaterUserId("USR01");
+
+
+ when(igraphLockOperation.lockComponent(any(),any())).thenReturn(StorageOperationStatus.OK);
+
+
+
+
+ Either<Component, StorageOperationStatus> toscastatus=Either.left(resource);
+ when(toscaOperationFacade.getToscaElement("RES01")).thenReturn(toscastatus);
+
+ result=attributeBusinessLogic.deleteAttribute("RES01","ATTR01", "USR01");
+ Assert.assertEquals(true,result.isRight());
+ }
+
+ @Test
+ public void testdeleteAttribute_nonexistingresource() throws Exception {
+ Either<PropertyDefinition, ResponseFormat> result;
+
+
+ Component resource= new Resource();
+ resource.setLifecycleState(LifecycleStateEnum.NOT_CERTIFIED_CHECKOUT);
+ resource.setIsDeleted(false);
+ resource.setLastUpdaterUserId("USR01");
+
+ when(igraphLockOperation.lockComponent(any(),any())).thenReturn(StorageOperationStatus.OK);
+
+ Either<Component, StorageOperationStatus> toscastatus=Either.left(resource);
+ when(toscaOperationFacade.getToscaElement("RES01")).thenReturn(toscastatus);
+
+ result=attributeBusinessLogic.deleteAttribute("RES01","ATTR01", "USR01");
+ Assert.assertEquals(true,result.isRight());
+ }
+
+ @Test
+ public void testdeleteAttribute_success() throws Exception {
+ Either<PropertyDefinition, ResponseFormat> result;
+
+
+ Component resource= new Resource();
+ resource.setLifecycleState(LifecycleStateEnum.NOT_CERTIFIED_CHECKOUT);
+ resource.setIsDeleted(false);
+ resource.setLastUpdaterUserId("USR01");
+
+
+ when(igraphLockOperation.lockComponent(any(),any())).thenReturn(StorageOperationStatus.OK);
+
+ Either<Component, StorageOperationStatus> toscastatus=Either.left(resource);
+ when(toscaOperationFacade.getToscaElement("RES01")).thenReturn(toscastatus);
+ when(toscaOperationFacade.deleteAttributeOfResource(any(),any())).thenReturn(StorageOperationStatus.OK);
+
+ PropertyDefinition prop= new PropertyDefinition();
+ prop.setUniqueId("ATTR01");
+ prop.setParentUniqueId("RES01");
+ List<PropertyDefinition> attributes = new ArrayList<>();
+ attributes.add(prop);
+ ((Resource) resource).setAttributes(attributes);
+
+ result=attributeBusinessLogic.deleteAttribute("RES01","ATTR01", "USR01");
+ Assert.assertEquals(true,result.isLeft());
+ }
+
+
} \ No newline at end of file