aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorm.kowalski3 <m.kowalski3@partner.samsung.com>2019-05-31 09:17:05 +0200
committerOren Kleks <orenkle@amdocs.com>2019-06-02 06:20:53 +0000
commit604f96f5154a475041efbfc7c9f4c428f210d030 (patch)
tree14f692497b907357f658a1e3653bcf038a1f26ec
parent7c62480edb52c829102cddd030384176bf16780b (diff)
Improve unit tests for EcompErrorConfiguration
Issue-ID: SDC-2327 Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com> Change-Id: I8ddaa70b02eeda837e5f74cd105a3e803d8652e6
-rw-r--r--common-app-api/src/test/java/org/openecomp/sdc/common/config/EcompErrorConfigurationTest.java143
1 files changed, 94 insertions, 49 deletions
diff --git a/common-app-api/src/test/java/org/openecomp/sdc/common/config/EcompErrorConfigurationTest.java b/common-app-api/src/test/java/org/openecomp/sdc/common/config/EcompErrorConfigurationTest.java
index 60e088ecbb..e2a9258ef2 100644
--- a/common-app-api/src/test/java/org/openecomp/sdc/common/config/EcompErrorConfigurationTest.java
+++ b/common-app-api/src/test/java/org/openecomp/sdc/common/config/EcompErrorConfigurationTest.java
@@ -1,58 +1,103 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * SDC
+ * ================================================================================
+ * Modifications Copyright (c) 2019 Samsung
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END============================================
+ * ===================================================================
+ *
+ */
+
package org.openecomp.sdc.common.config;
-import org.junit.Test;
+import static org.hamcrest.core.StringContains.containsString;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertThat;
+import java.util.HashMap;
+import org.junit.Before;
+import org.junit.Test;
import java.util.Map;
+import org.openecomp.sdc.be.config.ConfigurationManager;
+import org.openecomp.sdc.common.api.ConfigurationSource;
+import org.openecomp.sdc.common.impl.ExternalConfiguration;
+import org.openecomp.sdc.common.impl.FSConfigurationSource;
public class EcompErrorConfigurationTest {
- private EcompErrorConfiguration createTestSubject() {
- return new EcompErrorConfiguration();
- }
-
-
- @Test
- public void testGetErrors() throws Exception {
- EcompErrorConfiguration testSubject;
- Map<String, EcompErrorInfo> result;
-
- // default test
- testSubject = createTestSubject();
- result = testSubject.getErrors();
- }
-
-
-
- @Test
- public void testGetEcompErrorInfo() throws Exception {
- EcompErrorConfiguration testSubject;
- String key = "";
- EcompErrorInfo result;
-
- // default test
- testSubject = createTestSubject();
- result = testSubject.getEcompErrorInfo(key);
- }
-
-
-
- @Test
- public void testToString() throws Exception {
- EcompErrorConfiguration testSubject;
- String result;
-
- // default test
- testSubject = createTestSubject();
- result = testSubject.toString();
- }
-
-
- @Test
- public void testMain() throws Exception {
- String[] args = new String[] { "" };
-
- // default test
- EcompErrorConfiguration.main(args);
- }
+ private EcompErrorConfiguration ecompErrorConfiguration;
+
+ private ConfigurationManager configurationManager;
+
+ @Before
+ public void loadEcompErrorConfiguration() {
+ String appConfigDir = "src/test/resources/config/common";
+ ConfigurationSource configurationSource =
+ new FSConfigurationSource(ExternalConfiguration.getChangeListener(), appConfigDir);
+ configurationManager = new ConfigurationManager(configurationSource);
+ ecompErrorConfiguration = configurationManager.getEcompErrorConfiguration();
+ }
+
+ @Test
+ public void testGetErrors() {
+ //when
+ Map<String, EcompErrorInfo> result = ecompErrorConfiguration.getErrors();
+ //then
+ assertEquals(result.size(), 3);
+ }
+
+ @Test
+ public void testGetEcompErrorInfo() {
+ //when
+ EcompErrorInfo clonedEcompErrorInfo = ecompErrorConfiguration.getEcompErrorInfo("BeRestApiGeneralError");
+ //then
+ assertEquals("SYSTEM_ERROR", clonedEcompErrorInfo.getType());
+ assertEquals("ASDC_4000", clonedEcompErrorInfo.getCode());
+ assertEquals("ERROR", clonedEcompErrorInfo.getSeverity());
+ assertEquals("Unexpected error during BE REST API execution", clonedEcompErrorInfo.getDescription());
+ assertEquals("CRITICAL", clonedEcompErrorInfo.getAlarmSeverity());
+ }
+
+ @Test
+ public void testToString() throws Exception {
+ //when
+ String result = ecompErrorConfiguration.toString();
+ //then
+ assertThat(result, containsString(
+ "EcompErrorConfiguration [errors={BeRestApiGeneralError=org.openecomp.sdc.common.config.EcompErrorInfo@"));
+ }
+
+ @Test
+ public void testValidateEcompoErrorInfo() {
+ //given
+ EcompErrorInfo ecompErrorInfo = ecompErrorConfiguration.getEcompErrorInfo("BeInitializationError");
+ Map<String, EcompErrorInfo> errors = new HashMap<>();
+ errors.put("BeInitializationError", ecompErrorInfo);
+ //when
+ ecompErrorConfiguration.setErrors(errors);
+ //then
+ assertEquals(ecompErrorConfiguration.getErrors(), errors);
+ }
+
+ @Test
+ public void testMain() throws Exception {
+ String[] args = new String[] {""};
+
+ // default test
+ EcompErrorConfiguration.main(args);
+ }
+
} \ No newline at end of file