aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authoreschcam <cameron.scholes@est.tech>2022-12-22 11:48:23 +0000
committerVasyl Razinkov <vasyl.razinkov@est.tech>2023-01-27 19:00:39 +0000
commitc73286d46edcc14ed4a44f218660716a6c01977d (patch)
tree4d4811d44ec8eeac028378aa5720fa00d98ff9b5
parent3c98f0d836a3dcd9e1fbbd6dd98f4fb43be41d0a (diff)
Fix 5 critical SonarCloud bugs
Bugs taken from SonarCloud Change-Id: Ie03e63a0ad4da7358a591c22ee2acf0c8cd97598 Issue-ID: SDC-3529 Signed-off-by: eschcam <cameron.scholes@est.tech>
-rw-r--r--catalog-ui/src/app/ng2/components/logic/service-dependencies/service-dependencies.component.less4
-rw-r--r--catalog-ui/src/app/ng2/components/ui/modal/modal.component.less2
-rw-r--r--catalog-ui/src/app/ng2/components/ui/tabs/tabs.component.less2
-rw-r--r--catalog-ui/src/app/ng2/pages/attributes-outputs/attributes-outputs.page.component.less9
-rw-r--r--catalog-ui/src/app/ng2/pages/properties-assignment/properties-assignment.page.component.less11
5 files changed, 15 insertions, 13 deletions
diff --git a/catalog-ui/src/app/ng2/components/logic/service-dependencies/service-dependencies.component.less b/catalog-ui/src/app/ng2/components/logic/service-dependencies/service-dependencies.component.less
index 1772170163..38effe8417 100644
--- a/catalog-ui/src/app/ng2/components/logic/service-dependencies/service-dependencies.component.less
+++ b/catalog-ui/src/app/ng2/components/logic/service-dependencies/service-dependencies.component.less
@@ -27,7 +27,7 @@
height: 24px
}
- loader {
+ .loader {
top: 20px;
}
}
@@ -124,4 +124,4 @@
position: absolute;
top: 10px;
cursor: pointer;
-} \ No newline at end of file
+}
diff --git a/catalog-ui/src/app/ng2/components/ui/modal/modal.component.less b/catalog-ui/src/app/ng2/components/ui/modal/modal.component.less
index 03b2a70667..7adb0e4a01 100644
--- a/catalog-ui/src/app/ng2/components/ui/modal/modal.component.less
+++ b/catalog-ui/src/app/ng2/components/ui/modal/modal.component.less
@@ -1,7 +1,7 @@
@import '../../../../../assets/styles/variables';
@import '../../../../../assets/styles/mixins';
@import '../../../../../assets/styles/sprite-old';
-/deep/ modal {
+/deep/ .modal {
display: none;
}
diff --git a/catalog-ui/src/app/ng2/components/ui/tabs/tabs.component.less b/catalog-ui/src/app/ng2/components/ui/tabs/tabs.component.less
index f7b18b1cc8..db60be5371 100644
--- a/catalog-ui/src/app/ng2/components/ui/tabs/tabs.component.less
+++ b/catalog-ui/src/app/ng2/components/ui/tabs/tabs.component.less
@@ -1,6 +1,6 @@
@import '../../../../../assets/styles/variables';
-tab {
+.tab {
height: 100%;
}
diff --git a/catalog-ui/src/app/ng2/pages/attributes-outputs/attributes-outputs.page.component.less b/catalog-ui/src/app/ng2/pages/attributes-outputs/attributes-outputs.page.component.less
index 386d243976..10955425a4 100644
--- a/catalog-ui/src/app/ng2/pages/attributes-outputs/attributes-outputs.page.component.less
+++ b/catalog-ui/src/app/ng2/pages/attributes-outputs/attributes-outputs.page.component.less
@@ -17,12 +17,6 @@
height: 100%;
}
-/deep/ tabs {
- display: flex;
- flex-direction: column;
- height: 100%;
-}
-
.attributes-outputs-page {
height: 100%;
font-family: @font-opensans-regular;
@@ -39,6 +33,9 @@
min-width: 930px;
/deep/ .tabs {
+ display: flex;
+ flex-direction: row;
+ height: 100%;
width: 33%;
text-align: center;
}
diff --git a/catalog-ui/src/app/ng2/pages/properties-assignment/properties-assignment.page.component.less b/catalog-ui/src/app/ng2/pages/properties-assignment/properties-assignment.page.component.less
index 1c627588a2..31c5a720bd 100644
--- a/catalog-ui/src/app/ng2/pages/properties-assignment/properties-assignment.page.component.less
+++ b/catalog-ui/src/app/ng2/pages/properties-assignment/properties-assignment.page.component.less
@@ -11,8 +11,10 @@
@ng2-title-font-size:16px;
@ng2-text-font-size: 14px;
-:host { display:block; height: 100%; }
-/deep/ tabs {display:flex; flex-direction:column; height:100%; }
+:host {
+ display:block;
+ height: 100%;
+}
.properties-assignment-page {
height: 100%;
@@ -32,6 +34,9 @@
/deep/ .tabs {
width:18%;
text-align:center;
+ display:flex;
+ flex-direction:row;
+ height:100%;
}
/deep/ .tab {
@@ -99,7 +104,7 @@
}
}
-
+
.clear-filter{
cursor: pointer;
color:#009fdb;