diff options
author | 2018-08-02 11:35:54 +0900 | |
---|---|---|
committer | 2018-08-02 11:36:55 +0900 | |
commit | b306c6e8d29bac7566e71ef0a37152686828c3a4 (patch) | |
tree | d0d8cb61d53c7f28beb3fbb3652ca9f63118e54e | |
parent | 67daf691099cbd800bba37266873eafb4c034a91 (diff) |
NPE and other code smells reported by sonar
Issue-ID: VID-278
Change-Id: Ib06ff30a0cc4e9d361a87b791513c8d38a09294a
Signed-off-by: Arindam Mondal <arind.mondal@samsung.com>
6 files changed, 11 insertions, 7 deletions
diff --git a/vid-app-common/src/main/java/org/onap/vid/aai/AaiResponseTranslator.java b/vid-app-common/src/main/java/org/onap/vid/aai/AaiResponseTranslator.java index 6f503799..c7a98a8c 100644 --- a/vid-app-common/src/main/java/org/onap/vid/aai/AaiResponseTranslator.java +++ b/vid-app-common/src/main/java/org/onap/vid/aai/AaiResponseTranslator.java @@ -61,7 +61,7 @@ public class AaiResponseTranslator { final String errorMessage = aaiResponse.getErrorMessage(); return Optional.of(new PortMirroringConfigDataError( "Got " + aaiResponse.getHttpCode() + " from aai", - errorMessage != null ? errorMessage.toString() : null) + errorMessage != null ? errorMessage : null) ); } else { return Optional.empty(); diff --git a/vid-app-common/src/main/java/org/onap/vid/aai/SubscriberListWithFilterData.java b/vid-app-common/src/main/java/org/onap/vid/aai/SubscriberListWithFilterData.java index d7f9ad87..aab9fc6b 100644 --- a/vid-app-common/src/main/java/org/onap/vid/aai/SubscriberListWithFilterData.java +++ b/vid-app-common/src/main/java/org/onap/vid/aai/SubscriberListWithFilterData.java @@ -13,7 +13,7 @@ import java.util.List; public class SubscriberListWithFilterData { public SubscriberListWithFilterData(SubscriberList subscriberList, RoleValidator roleValidator){ - List<Subscriber> subscribers = subscriberList != null ? subscriberList.customer : new ArrayList<Subscriber>(); + List<Subscriber> subscribers = subscriberList != null ? subscriberList.customer : new ArrayList<>(); List<SubscriberWithFilter> subscribersWithFilter = new ArrayList<>(); for (Subscriber subscriber :subscribers){ SubscriberWithFilter subscriberWithFilter = new SubscriberWithFilter(); diff --git a/vid-app-common/src/main/java/org/onap/vid/aai/model/AaiGetNetworkCollectionDetails/AaiGetNetworkCollectionDetailsHelper.java b/vid-app-common/src/main/java/org/onap/vid/aai/model/AaiGetNetworkCollectionDetails/AaiGetNetworkCollectionDetailsHelper.java index 2d3cfb91..cb3e548d 100644 --- a/vid-app-common/src/main/java/org/onap/vid/aai/model/AaiGetNetworkCollectionDetails/AaiGetNetworkCollectionDetailsHelper.java +++ b/vid-app-common/src/main/java/org/onap/vid/aai/model/AaiGetNetworkCollectionDetails/AaiGetNetworkCollectionDetailsHelper.java @@ -14,7 +14,7 @@ public class AaiGetNetworkCollectionDetailsHelper { @JsonProperty("results") private List<Object> results = null; @JsonIgnore - private Map<String, Object> additionalProperties = new HashMap<String, Object>(); + private Map<String, Object> additionalProperties = new HashMap<>(); @JsonProperty("results") public List<Object> getResults() { diff --git a/vid-app-common/src/main/java/org/onap/vid/aai/model/AaiGetPnfResponse.java b/vid-app-common/src/main/java/org/onap/vid/aai/model/AaiGetPnfResponse.java index cd8cca8f..fa9fe935 100644 --- a/vid-app-common/src/main/java/org/onap/vid/aai/model/AaiGetPnfResponse.java +++ b/vid-app-common/src/main/java/org/onap/vid/aai/model/AaiGetPnfResponse.java @@ -20,7 +20,7 @@ public class AaiGetPnfResponse { @JsonProperty("results") public List<PnfResult> results = null; @JsonIgnore - private Map<String, Object> additionalProperties = new HashMap<String, Object>(); + private Map<String, Object> additionalProperties = new HashMap<>(); @JsonAnyGetter public Map<String, Object> getAdditionalProperties() { diff --git a/vid-app-common/src/main/java/org/onap/vid/dao/FnAppDoaImpl.java b/vid-app-common/src/main/java/org/onap/vid/dao/FnAppDoaImpl.java index 964c7e13..65fc5217 100644 --- a/vid-app-common/src/main/java/org/onap/vid/dao/FnAppDoaImpl.java +++ b/vid-app-common/src/main/java/org/onap/vid/dao/FnAppDoaImpl.java @@ -60,8 +60,9 @@ public class FnAppDoaImpl { if( url!=null && username!=null && password!=null ){ con = DriverManager.getConnection(url, username, password); } - - System.out.println("Connection Successful"); + + logger.info("Connection Successful"); + return con; } diff --git a/vid-app-common/src/main/java/org/onap/vid/services/CsvServiceImpl.java b/vid-app-common/src/main/java/org/onap/vid/services/CsvServiceImpl.java index 6f5f4f73..c34bf4e6 100644 --- a/vid-app-common/src/main/java/org/onap/vid/services/CsvServiceImpl.java +++ b/vid-app-common/src/main/java/org/onap/vid/services/CsvServiceImpl.java @@ -177,7 +177,10 @@ public class CsvServiceImpl implements CsvService{ currentJson.put(new JSONObject().put(key, values)); } else { JSONObject lastItem = lastItemInArray(currentJson); - lastItem.put(key, values); + if(lastItem != null){ + lastItem.put(key, values); + } + } } } |