diff options
Diffstat (limited to 'ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration')
8 files changed, 144 insertions, 207 deletions
diff --git a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/controller/NotebookController.java b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/controller/NotebookController.java index d5f4288d..406acd80 100644 --- a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/controller/NotebookController.java +++ b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/controller/NotebookController.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,12 +37,7 @@ */ package org.onap.portalsdk.rnotebookintegration.controller; -import javax.servlet.http.HttpServletRequest; - import org.onap.portalsdk.core.controller.RestrictedBaseController; -import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate; -import org.onap.portalsdk.core.service.UserProfileService; -import org.springframework.beans.factory.annotation.Autowired; import org.springframework.stereotype.Controller; import org.springframework.web.bind.annotation.RequestMapping; import org.springframework.web.bind.annotation.RequestMethod; @@ -53,16 +48,8 @@ import org.springframework.web.servlet.ModelAndView; public class NotebookController extends RestrictedBaseController{ @RequestMapping(value = {"/notebook" }, method = RequestMethod.GET) - public ModelAndView noteBook(HttpServletRequest request) { - - try { - - } catch (Exception e) { - - - } + public ModelAndView noteBook() { return new ModelAndView(getViewName()); } - } diff --git a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/controller/NotebookTestController.java b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/controller/NotebookTestController.java index 973f8d05..e4da0ae3 100644 --- a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/controller/NotebookTestController.java +++ b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/controller/NotebookTestController.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -36,11 +36,8 @@ * ECOMP is a trademark and service mark of AT&T Intellectual Property. */ - package org.onap.portalsdk.rnotebookintegration.controller; -import javax.servlet.http.HttpServletRequest; - import org.onap.portalsdk.core.controller.RestrictedBaseController; import org.springframework.stereotype.Controller; import org.springframework.web.bind.annotation.RequestMapping; @@ -48,13 +45,12 @@ import org.springframework.web.bind.annotation.RequestMethod; import org.springframework.web.servlet.ModelAndView; @Controller -@RequestMapping("/") -public class NotebookTestController extends RestrictedBaseController{ - - @RequestMapping(value = {"/nbooktest" }, method = RequestMethod.GET) - public ModelAndView noteBook(HttpServletRequest request) { +@RequestMapping("/") +public class NotebookTestController extends RestrictedBaseController { + + @RequestMapping(value = { "/nbooktest" }, method = RequestMethod.GET) + public ModelAndView noteBook() { return new ModelAndView(getViewName()); } - - + } diff --git a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/controller/RNoteBookController.java b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/controller/RNoteBookController.java index 9a178450..37e7c4de 100644 --- a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/controller/RNoteBookController.java +++ b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/controller/RNoteBookController.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,82 +37,58 @@ */ package org.onap.portalsdk.rnotebookintegration.controller; -import java.util.HashMap; - -import javax.servlet.http.HttpServletRequest; -import javax.servlet.http.HttpServletResponse; - -import org.hibernate.validator.internal.util.privilegedactions.GetMethodFromPropertyName; -import org.onap.portalsdk.core.controller.RestrictedBaseController; import org.onap.portalsdk.core.controller.RestrictedRESTfulBaseController; -import org.onap.portalsdk.core.domain.User; -import org.onap.portalsdk.core.restful.domain.EcompUser; -import org.onap.portalsdk.core.util.SystemProperties; +import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate; import org.onap.portalsdk.core.web.support.JsonMessage; -import org.onap.portalsdk.core.web.support.UserUtils; import org.onap.portalsdk.rnotebookintegration.exception.RNotebookIntegrationException; import org.onap.portalsdk.rnotebookintegration.service.RNoteBookIntegrationService; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.http.HttpStatus; import org.springframework.http.ResponseEntity; import org.springframework.stereotype.Controller; -import org.springframework.web.bind.annotation.RequestBody; import org.springframework.web.bind.annotation.RequestMapping; import org.springframework.web.bind.annotation.RequestMethod; import org.springframework.web.bind.annotation.ResponseBody; -import com.fasterxml.jackson.databind.DeserializationFeature; -import com.fasterxml.jackson.databind.JsonNode; -import com.fasterxml.jackson.databind.ObjectMapper; - @Controller @RequestMapping("/rNotebook/") - public class RNoteBookController extends RestrictedRESTfulBaseController { - + + private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(RNoteBookController.class); + @Autowired private RNoteBookIntegrationService rNoteBookIntegrationService; - - public RNoteBookIntegrationService getrNoteBookIntegrationService() { return rNoteBookIntegrationService; } - - - public void setrNoteBookIntegrationService( - RNoteBookIntegrationService rNoteBookIntegrationService) { + public void setrNoteBookIntegrationService(RNoteBookIntegrationService rNoteBookIntegrationService) { this.rNoteBookIntegrationService = rNoteBookIntegrationService; } - - @RequestMapping(value = { "authCr" }, method = RequestMethod.GET, produces = "application/json") - public @ResponseBody ResponseEntity<String> getRNotebookCredentials (String token) throws Exception { - //ObjectMapper mapper = new ObjectMapper(); - //mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false); - //JsonNode root = mapper.readTree(request.getReader()); - //String token = root.get("authenticationToken").textValue(); - + @ResponseBody + public ResponseEntity<String> getRNotebookCredentials(String token) { String returnJSON = ""; - try{ + try { returnJSON = this.getrNoteBookIntegrationService().getRNotebookCredentials(token); - } catch(RNotebookIntegrationException re){ - if (re.getErrorCode().equals(RNotebookIntegrationException.ERROR_CODE_TOKEN_EXPIRED)){ - return new ResponseEntity<String>(JsonMessage.buildJsonResponse(false, re.getMessage()), HttpStatus.BAD_REQUEST); + } catch (RNotebookIntegrationException re) { + logger.error(EELFLoggerDelegate.errorLogger, "getRNotebookCredentials failed 1", re); + if (re.getErrorCode().equals(RNotebookIntegrationException.ERROR_CODE_TOKEN_EXPIRED)) { + return new ResponseEntity<>(JsonMessage.buildJsonResponse(false, re.getMessage()), + HttpStatus.BAD_REQUEST); + } else { + return new ResponseEntity<>(JsonMessage.buildJsonResponse(false, re.getMessage()), + HttpStatus.BAD_REQUEST); } - else { - return new ResponseEntity<String>(JsonMessage.buildJsonResponse(false, re.getMessage()), HttpStatus.BAD_REQUEST); - } - } - catch (Exception e){ - return new ResponseEntity<String>(JsonMessage.buildJsonResponse(false, e.getMessage()), HttpStatus.BAD_REQUEST); + } catch (Exception e) { + logger.error(EELFLoggerDelegate.errorLogger, "getRNotebookCredentials failed 2", e); + return new ResponseEntity<>(JsonMessage.buildJsonResponse(false, e.getMessage()), + HttpStatus.BAD_REQUEST); } - - return new ResponseEntity<String>(returnJSON, HttpStatus.OK); - + + return new ResponseEntity<>(returnJSON, HttpStatus.OK); } - - + } diff --git a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/controller/RNoteBookFEController.java b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/controller/RNoteBookFEController.java index 0268284c..4cad5b39 100644 --- a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/controller/RNoteBookFEController.java +++ b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/controller/RNoteBookFEController.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -46,6 +46,7 @@ import javax.servlet.http.HttpServletResponse; import org.json.JSONObject; import org.onap.portalsdk.core.controller.RestrictedBaseController; import org.onap.portalsdk.core.domain.User; +import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate; import org.onap.portalsdk.core.restful.domain.EcompUser; import org.onap.portalsdk.core.util.SystemProperties; import org.onap.portalsdk.core.web.support.UserUtils; @@ -63,69 +64,55 @@ import org.springframework.web.bind.annotation.ResponseBody; @Controller @RequestMapping("/rNotebookFE/") public class RNoteBookFEController extends RestrictedBaseController { + + private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(RNoteBookController.class); + @Autowired private RNoteBookIntegrationService rNoteBookIntegrationService; - - public RNoteBookIntegrationService getrNoteBookIntegrationService() { return rNoteBookIntegrationService; } - - - public void setrNoteBookIntegrationService( - RNoteBookIntegrationService rNoteBookIntegrationService) { + public void setrNoteBookIntegrationService(RNoteBookIntegrationService rNoteBookIntegrationService) { this.rNoteBookIntegrationService = rNoteBookIntegrationService; } - + @RequestMapping(value = { "authCr" }, method = RequestMethod.POST, produces = "application/json") - public @ResponseBody ResponseEntity<String> saveRNotebookCredentials (@RequestBody String notebookId, HttpServletRequest request, - HttpServletResponse response) throws Exception { - //ObjectMapper mapper = new ObjectMapper(); - //mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false); - //JsonNode root = mapper.readTree(request.getReader()); - //String token = root.get("authenticationToken").textValue(); - System.out.println("Notebook id "+notebookId); - System.out.println("Query parameters "+request.getParameter("qparams")); + @ResponseBody + public ResponseEntity<String> saveRNotebookCredentials(@RequestBody String notebookId, HttpServletRequest request, + HttpServletResponse response) { + logger.debug(EELFLoggerDelegate.debugLogger, "saveRNotebookCredentials: Notebook id {}", notebookId); + logger.debug(EELFLoggerDelegate.debugLogger, "saveRNotebookCredentials: Query parameters {}", request.getParameter("qparams")); String retUrl = ""; - try{ - + try { User user = UserUtils.getUserSession(request); - user = (User) this.getDataAccessService().getDomainObject(User.class, user.getId(), null); - - EcompUser ecUser =UserUtils.convertToEcompUser(user); - - HashMap<String, String> map = new HashMap<String, String>(); - JSONObject jObject = new JSONObject(request.getParameter("qparams")); - Iterator<?> keys = jObject.keys(); - - while( keys.hasNext() ){ - String key = (String)keys.next(); - String value = jObject.getString(key); - map.put(key, value); - - } - - System.out.println("json : "+jObject); - System.out.println("map : "+map); - - // String token = this.getrNoteBookIntegrationService().saveRNotebookCredentials(notebookId, ecUser, new HashMap<String, String>()); - String token = this.getrNoteBookIntegrationService().saveRNotebookCredentials(notebookId, ecUser, map); - - String guard = SystemProperties.getProperty("guard_notebook_url"); - + user = (User) getDataAccessService().getDomainObject(User.class, user.getId(), null); + EcompUser ecUser = UserUtils.convertToEcompUser(user); + HashMap<String, String> map = new HashMap<>(); + JSONObject jObject = new JSONObject(request.getParameter("qparams")); + Iterator<?> keys = jObject.keys(); + while (keys.hasNext()) { + String key = (String) keys.next(); + String value = jObject.getString(key); + map.put(key, value); + } + logger.debug(EELFLoggerDelegate.debugLogger, "saveRNotebookCredentials: json {}", jObject); + logger.debug(EELFLoggerDelegate.debugLogger, "saveRNotebookCredentials: map {}", map); + String token = this.getrNoteBookIntegrationService().saveRNotebookCredentials(notebookId, ecUser, map); + final String guardNotebookUrl = "guard_notebook_url"; + if (!SystemProperties.containsProperty(guardNotebookUrl)) + throw new IllegalArgumentException("Failed to find property " + guardNotebookUrl); + String guard = SystemProperties.getProperty(guardNotebookUrl); retUrl = guard + "id=" + token; - - - } catch (RNotebookIntegrationException re){ - return new ResponseEntity<String>(re.getMessage(), HttpStatus.BAD_REQUEST); - } catch (Exception e){ - return new ResponseEntity<String>(e.getMessage(), HttpStatus.BAD_REQUEST); + } catch (RNotebookIntegrationException re) { + logger.error(EELFLoggerDelegate.errorLogger, "saveRNotebookCredentials failed 1", re); + return new ResponseEntity<>(re.getMessage(), HttpStatus.BAD_REQUEST); + } catch (Exception e) { + logger.error(EELFLoggerDelegate.errorLogger, "saveRNotebookCredentials failed 2", e); + return new ResponseEntity<>(e.getMessage(), HttpStatus.BAD_REQUEST); } - - return new ResponseEntity<String>(retUrl, HttpStatus.OK); - + return new ResponseEntity<>(retUrl, HttpStatus.OK); } } diff --git a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/domain/RNoteBookCredentials.java b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/domain/RNoteBookCredentials.java index 0744aab3..99d7085b 100644 --- a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/domain/RNoteBookCredentials.java +++ b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/domain/RNoteBookCredentials.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -40,7 +40,6 @@ package org.onap.portalsdk.rnotebookintegration.domain; import java.util.Date; import java.util.Map; -import org.onap.portalsdk.core.domain.User; import org.onap.portalsdk.core.domain.support.DomainVo; import org.onap.portalsdk.core.restful.domain.EcompUser; diff --git a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/exception/RNotebookIntegrationException.java b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/exception/RNotebookIntegrationException.java index ff576725..d4ae7352 100644 --- a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/exception/RNotebookIntegrationException.java +++ b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/exception/RNotebookIntegrationException.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -38,10 +38,18 @@ package org.onap.portalsdk.rnotebookintegration.exception; public class RNotebookIntegrationException extends Exception { + + private static final long serialVersionUID = -2930083784603307194L; + public static final String ERROR_CODE_TOKEN_EXPIRED = "ERROR_CODE_TOKEN_EXPIRED"; public static final String ERROR_CODE_TOKEN_INVALID = "ERROR_CODE_TOKEN_INVALID"; - String errorCode; + private final String errorCode; + + public RNotebookIntegrationException(Exception ex){ + super(ex); + this.errorCode = null; + } public RNotebookIntegrationException(String errorCodeStr){ super(errorCodeStr); @@ -52,8 +60,4 @@ public class RNotebookIntegrationException extends Exception { return errorCode; } - public void setErrorCode(String errorCode) { - this.errorCode = errorCode; - } - } diff --git a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/service/RNoteBookIntegrationService.java b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/service/RNoteBookIntegrationService.java index 11de7d25..15536c80 100644 --- a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/service/RNoteBookIntegrationService.java +++ b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/service/RNoteBookIntegrationService.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -43,7 +43,8 @@ import org.onap.portalsdk.core.restful.domain.EcompUser; import org.onap.portalsdk.rnotebookintegration.exception.RNotebookIntegrationException; public interface RNoteBookIntegrationService { - public String getRNotebookCredentials(String token) throws RNotebookIntegrationException, Exception; + + public String getRNotebookCredentials(String token) throws RNotebookIntegrationException; - public String saveRNotebookCredentials(String notebookId, EcompUser user, Map<String, String> params) throws RNotebookIntegrationException, Exception; + public String saveRNotebookCredentials(String notebookId, EcompUser user, Map<String, String> params) throws RNotebookIntegrationException; } diff --git a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/service/RNoteBookIntegrationServiceImpl.java b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/service/RNoteBookIntegrationServiceImpl.java index 8a21b71a..bac23706 100644 --- a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/service/RNoteBookIntegrationServiceImpl.java +++ b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/service/RNoteBookIntegrationServiceImpl.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,7 +37,6 @@ */ package org.onap.portalsdk.rnotebookintegration.service; -import java.security.SecureRandom; import java.util.Date; import java.util.HashMap; import java.util.Map; @@ -46,28 +45,27 @@ import java.util.UUID; import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate; import org.onap.portalsdk.core.restful.domain.EcompUser; import org.onap.portalsdk.core.service.DataAccessService; -import org.onap.portalsdk.core.web.support.UserUtils; import org.onap.portalsdk.rnotebookintegration.domain.RNoteBookCredentials; import org.onap.portalsdk.rnotebookintegration.exception.RNotebookIntegrationException; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.stereotype.Service; import org.springframework.transaction.annotation.Transactional; -import com.fasterxml.jackson.core.JsonParseException; -import com.fasterxml.jackson.databind.JsonMappingException; +import com.fasterxml.jackson.core.JsonProcessingException; import com.fasterxml.jackson.databind.ObjectMapper; @Service("RNoteBookIntegrationService") @Transactional public class RNoteBookIntegrationServiceImpl implements RNoteBookIntegrationService { - - private final long tokenTTL = 50000L; - - private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(RNoteBookIntegrationServiceImpl.class); - + + private static final EELFLoggerDelegate logger = EELFLoggerDelegate + .getLogger(RNoteBookIntegrationServiceImpl.class); + + private static final long TOKEN_TTL = 50000L; + @Autowired - private DataAccessService dataAccessService; - + private DataAccessService dataAccessService; + public DataAccessService getDataAccessService() { return dataAccessService; } @@ -75,89 +73,78 @@ public class RNoteBookIntegrationServiceImpl implements RNoteBookIntegrationServ public void setDataAccessService(DataAccessService dataAccessService) { this.dataAccessService = dataAccessService; } - + @Override - public String getRNotebookCredentials(String token) throws RNotebookIntegrationException, Exception { + public String getRNotebookCredentials(String token) throws RNotebookIntegrationException { String retString = ""; - - try{ - RNoteBookCredentials notebookCredentials = (RNoteBookCredentials) this.getDataAccessService().getDomainObject(RNoteBookCredentials.class, token, new HashMap<String, String>()); - if (notebookCredentials.getToken() == null || notebookCredentials.getToken().equals("")){ + + try { + RNoteBookCredentials notebookCredentials = (RNoteBookCredentials) this.getDataAccessService() + .getDomainObject(RNoteBookCredentials.class, token, new HashMap<String, String>()); + if (notebookCredentials.getToken() == null || "".equals(notebookCredentials.getToken())) { throw new RNotebookIntegrationException(RNotebookIntegrationException.ERROR_CODE_TOKEN_INVALID); } Date currDate = new Date(); - if ((currDate.getTime() - notebookCredentials.getCreatedDate().getTime() > tokenTTL) || (notebookCredentials.getTokenReadDate() != null)){ + if ((currDate.getTime() - notebookCredentials.getCreatedDate().getTime() > TOKEN_TTL) + || (notebookCredentials.getTokenReadDate() != null)) { throw new RNotebookIntegrationException(RNotebookIntegrationException.ERROR_CODE_TOKEN_EXPIRED); } ObjectMapper mapper = new ObjectMapper(); - - try{ + + try { EcompUser userInfo = mapper.readValue(notebookCredentials.getUserString(), EcompUser.class); - notebookCredentials.setUserInfo(userInfo); - } catch(JsonMappingException me){ - logger.error("error converting string to user. from JSON" + me.getMessage()); - } catch(JsonParseException pe){ - logger.error("error converting string to user. from JSON" + pe.getMessage()); + notebookCredentials.setUserInfo(userInfo); + } catch (JsonProcessingException me) { + logger.error(EELFLoggerDelegate.errorLogger, "error converting string to user. from JSON", me); } - - try{ - Map<String, String> params = mapper.readValue(notebookCredentials.getParametersString(), HashMap.class); + + try { + Map<String, String> params = mapper.readValue(notebookCredentials.getParametersString(), Map.class); notebookCredentials.setParameters(params); - } catch(JsonMappingException me){ - logger.error("error converting string to parameters. from JSON" + me.getMessage()); - } catch(JsonParseException pe){ - logger.error("error converting string to parameters. from JSON" + pe.getMessage()); + } catch (JsonProcessingException me) { + logger.error(EELFLoggerDelegate.errorLogger, "error converting string to parameters. from JSON", me); } - - //expiring the token - try{ + + // expiring the token + try { notebookCredentials.setTokenReadDate(new Date()); this.getDataAccessService().saveDomainObject(notebookCredentials, null); - } catch(Exception e){ - logger.info("Error while expiring the token"); - logger.error(e.getMessage()); - throw new Exception(); + } catch (Exception e) { + logger.error(EELFLoggerDelegate.errorLogger, "Error while expiring the token", e); + throw new RNotebookIntegrationException(e); } - //notebookCredentials.setUserString(null); retString = mapper.writeValueAsString(notebookCredentials); - } catch(RNotebookIntegrationException re){ - logger.error(re.getMessage()); + } catch (RNotebookIntegrationException re) { + logger.error(EELFLoggerDelegate.errorLogger, "getRNotebookCredentials failed", re); throw re; - } catch(Exception e){ - logger.info("Error while parsing the rcloud notebook credentials"); - logger.error(e.getMessage()); - throw new Exception(); + } catch (Exception e) { + logger.error(EELFLoggerDelegate.errorLogger, "Error while parsing the rcloud notebook credentials", e); + throw new RNotebookIntegrationException(e); } - - return retString; + + return retString; } - + @Override - public String saveRNotebookCredentials(String notebookId, EcompUser user, Map<String, String> params) throws RNotebookIntegrationException, Exception { - + public String saveRNotebookCredentials(String notebookId, EcompUser user, Map<String, String> params) + throws RNotebookIntegrationException { + String token = ""; - try{ + try { token = UUID.randomUUID().toString(); - ObjectMapper mapper = new ObjectMapper(); - ; RNoteBookCredentials rc = new RNoteBookCredentials(); rc.setToken(token); rc.setCreatedDate(new Date()); rc.setNotebookID(notebookId); rc.setParametersString(mapper.writeValueAsString(params)); rc.setUserString(mapper.writeValueAsString(user)); - this.getDataAccessService().saveDomainObject(rc, null); - - } catch(Exception e){ - logger.info("Error while parsing the rcloud notebook credentials"); - logger.error(e.getMessage()); - throw new Exception(); + } catch (Exception e) { + logger.error(EELFLoggerDelegate.errorLogger, "Error while parsing the rcloud notebook credentials", e); + throw new RNotebookIntegrationException(e); } - - return token; + return token; } - } |