summaryrefslogtreecommitdiffstats
path: root/ecomp-sdk/epsdk-logger
diff options
context:
space:
mode:
authorIndrijeet kumar <indriku1@in.ibm.com>2020-05-21 11:23:08 +0530
committerIndrijeet kumar <indriku1@in.ibm.com>2020-05-21 11:23:14 +0530
commit91bd8f3aff7086af5d8f15046532f4499079d6d8 (patch)
tree1eb70b30ed62ca3b2c861e5612d6517a116b4f8d /ecomp-sdk/epsdk-logger
parent2053ff0eaa2e4d1efcdb56a953af7c631757369e (diff)
reduced code smells in some components
reduced code smells in some components Issue-ID: PORTAL-813 Change-Id: I9a003165d260fd332e2e5199525412aeeb9fff05 Signed-off-by: Indrijeet Kumar <indriku1@in.ibm.com>
Diffstat (limited to 'ecomp-sdk/epsdk-logger')
-rw-r--r--ecomp-sdk/epsdk-logger/src/main/java/org/onap/portalsdk/core/logging/format/ErrorCodesEnum.java1
-rw-r--r--ecomp-sdk/epsdk-logger/src/main/java/org/onap/portalsdk/core/logging/logic/EELFLoggerDelegate.java7
-rw-r--r--ecomp-sdk/epsdk-logger/src/main/java/org/onap/portalsdk/core/logging/logic/LoggerProperties.java4
3 files changed, 1 insertions, 11 deletions
diff --git a/ecomp-sdk/epsdk-logger/src/main/java/org/onap/portalsdk/core/logging/format/ErrorCodesEnum.java b/ecomp-sdk/epsdk-logger/src/main/java/org/onap/portalsdk/core/logging/format/ErrorCodesEnum.java
index 6f473efe..c05c2dc8 100644
--- a/ecomp-sdk/epsdk-logger/src/main/java/org/onap/portalsdk/core/logging/format/ErrorCodesEnum.java
+++ b/ecomp-sdk/epsdk-logger/src/main/java/org/onap/portalsdk/core/logging/format/ErrorCodesEnum.java
@@ -38,7 +38,6 @@
package org.onap.portalsdk.core.logging.format;
import com.att.eelf.i18n.EELFResolvableErrorEnum;
-//import com.att.eelf.i18n.EELFResourceManager;
public enum ErrorCodesEnum implements EELFResolvableErrorEnum {
BERESTAPIAUTHENTICATIONERROR, BEHTTPCONNECTIONERROR_ONE_ARGUMENT, BEUEBAUTHENTICATIONERROR_ONE_ARGUMENT,
diff --git a/ecomp-sdk/epsdk-logger/src/main/java/org/onap/portalsdk/core/logging/logic/EELFLoggerDelegate.java b/ecomp-sdk/epsdk-logger/src/main/java/org/onap/portalsdk/core/logging/logic/EELFLoggerDelegate.java
index e59a0cc0..901c6737 100644
--- a/ecomp-sdk/epsdk-logger/src/main/java/org/onap/portalsdk/core/logging/logic/EELFLoggerDelegate.java
+++ b/ecomp-sdk/epsdk-logger/src/main/java/org/onap/portalsdk/core/logging/logic/EELFLoggerDelegate.java
@@ -65,17 +65,12 @@ import com.att.eelf.configuration.SLF4jWrapper;
public class EELFLoggerDelegate extends SLF4jWrapper implements EELFLogger {
-
- //public static final EELFLogger errorLogger = EELFManager.getInstance().getErrorLogger();
public static final EELFLogger errorLogger = EELFManager.getInstance().getLogger("EELFError");
public static final EELFLogger metricsLogger = EELFManager.getInstance().getLogger("EELFMetrics");
public static final EELFLogger auditLogger = EELFManager.getInstance().getLogger("EELFAudit");
public static final EELFLogger applicationLogger = EELFManager.getInstance().getApplicationLogger();
- //public static final EELFLogger auditLogger = EELFManager.getInstance().getAuditLogger();
- //public static final EELFLogger metricsLogger = EELFManager.getInstance().getMetricsLogger();
public static final EELFLogger debugLogger = EELFManager.getInstance().getDebugLogger();
- // DateTime Format according to the ECOMP Application Logging Guidelines.
- private static final SimpleDateFormat ecompLogDateFormat = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSSXXX");
+ private static final SimpleDateFormat ecompLogDateFormat = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSSXXX");
private String className;
diff --git a/ecomp-sdk/epsdk-logger/src/main/java/org/onap/portalsdk/core/logging/logic/LoggerProperties.java b/ecomp-sdk/epsdk-logger/src/main/java/org/onap/portalsdk/core/logging/logic/LoggerProperties.java
index e5af757a..abd98b19 100644
--- a/ecomp-sdk/epsdk-logger/src/main/java/org/onap/portalsdk/core/logging/logic/LoggerProperties.java
+++ b/ecomp-sdk/epsdk-logger/src/main/java/org/onap/portalsdk/core/logging/logic/LoggerProperties.java
@@ -78,8 +78,6 @@ public class LoggerProperties {
private static String propertyFileName = "logger.properties";
private static final Object lockObject = new Object();
-
-// private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(LoggerProperties.class);
/**
* Gets the property value for the specified key. If a value is found, leading
@@ -95,11 +93,9 @@ public class LoggerProperties {
synchronized (lockObject) {
try {
if (!initialize()) {
-// logger.error(EELFLoggerDelegate.errorLogger, "Failed to read property file " + propertyFileName);
return null;
}
} catch (IOException e) {
-// logger.error(EELFLoggerDelegate.errorLogger, "Failed to read property file " + propertyFileName ,e);
return null;
}
}