summaryrefslogtreecommitdiffstats
path: root/ecomp-sdk/epsdk-domain/src
diff options
context:
space:
mode:
authorIndrijeet kumar <indriku1@in.ibm.com>2020-05-21 17:15:15 +0530
committerIndrijeet kumar <indriku1@in.ibm.com>2020-05-21 17:15:21 +0530
commit8629492fa5d8d4643f8e88c0ae3a4240590aacf6 (patch)
treef921bdffda36b559d61a913cffede942b97a52f0 /ecomp-sdk/epsdk-domain/src
parent2053ff0eaa2e4d1efcdb56a953af7c631757369e (diff)
removed code smells in some components
removed code smells in some components Issue-ID: PORTAL-813 Change-Id: Ib8e1deaddbbd58d41a839c505a3e9875b1046297 Signed-off-by: Indrijeet Kumar <indriku1@in.ibm.com>
Diffstat (limited to 'ecomp-sdk/epsdk-domain/src')
-rw-r--r--ecomp-sdk/epsdk-domain/src/main/java/org/onap/portalsdk/core/domain/support/Container.java1
-rw-r--r--ecomp-sdk/epsdk-domain/src/main/java/org/onap/portalsdk/core/domain/support/DomainVo.java3
-rw-r--r--ecomp-sdk/epsdk-domain/src/main/java/org/onap/portalsdk/core/domain/support/Layout.java1
3 files changed, 1 insertions, 4 deletions
diff --git a/ecomp-sdk/epsdk-domain/src/main/java/org/onap/portalsdk/core/domain/support/Container.java b/ecomp-sdk/epsdk-domain/src/main/java/org/onap/portalsdk/core/domain/support/Container.java
index 1c122491..65026a9c 100644
--- a/ecomp-sdk/epsdk-domain/src/main/java/org/onap/portalsdk/core/domain/support/Container.java
+++ b/ecomp-sdk/epsdk-domain/src/main/java/org/onap/portalsdk/core/domain/support/Container.java
@@ -294,7 +294,6 @@ public class Container {
ysum += elementRowCol.get(String.valueOf(k) + String.valueOf(j)).computeSize().getHeight();
}
p.y = i * interEleH + ysum + this.getP().getY() + interEleToContainerH;
- // containerCoord.add(c,p);
xsum += c.computeSize().getWidth();
c.setP(p);
diff --git a/ecomp-sdk/epsdk-domain/src/main/java/org/onap/portalsdk/core/domain/support/DomainVo.java b/ecomp-sdk/epsdk-domain/src/main/java/org/onap/portalsdk/core/domain/support/DomainVo.java
index d2f41c90..223bb141 100644
--- a/ecomp-sdk/epsdk-domain/src/main/java/org/onap/portalsdk/core/domain/support/DomainVo.java
+++ b/ecomp-sdk/epsdk-domain/src/main/java/org/onap/portalsdk/core/domain/support/DomainVo.java
@@ -52,7 +52,6 @@ import org.onap.portalsdk.core.domain.FusionVo;
public class DomainVo extends FusionVo implements Serializable, Cloneable, Comparable {
// TODO: Remove after the EELFLoggerImpl
-// private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(DomainVo.class);
private static final long serialVersionUID = 1L;
protected Long id;
@@ -159,7 +158,7 @@ public class DomainVo extends FusionVo implements Serializable, Cloneable, Compa
} catch (Exception e) {
-// TODO: Remove after the EELFLoggerImpl logger.error(EELFLoggerDelegate.errorLogger, "copy failed", e);
+// TODO: Remove after the EELFLoggerImpl
e.printStackTrace();
}
diff --git a/ecomp-sdk/epsdk-domain/src/main/java/org/onap/portalsdk/core/domain/support/Layout.java b/ecomp-sdk/epsdk-domain/src/main/java/org/onap/portalsdk/core/domain/support/Layout.java
index 33a347de..7b1a5c42 100644
--- a/ecomp-sdk/epsdk-domain/src/main/java/org/onap/portalsdk/core/domain/support/Layout.java
+++ b/ecomp-sdk/epsdk-domain/src/main/java/org/onap/portalsdk/core/domain/support/Layout.java
@@ -627,7 +627,6 @@ public class Layout {
double newX = 0.0;
if (i + 1 < domainstoUpd.size())
newX = domainstoUpd.get(i + 1).getP().getX();
- // d.setDomainToLayoutWd(domainstoUpd.get(i+1).getP().getX());
else
newX = domainstoUpd.get(i).getP().getX() + 38;