Adjust code for Sonar issues

Made non-functional updates to address static code analysis issues.
Update license header with simple double-quote characters.

Issue: PORTAL-72, PORTAL-90
Change-Id: Ic2c330daea07d721f0e6b350ebf03da97073f7ce
Signed-off-by: Christopher Lott (cl778h) <clott@research.att.com>

1 files changed, 10 insertions, 10 deletions

diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/UserAppId.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/UserAppId.java
index a9ec9760..d1fac039 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/UserAppId.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/UserAppId.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -80,26 +80,26 @@ public class UserAppId implements java.io.Serializable {
 		this.role = role;
 	}
 
+	@Override
 	public boolean equals(Object other) {
-		if ((this == other))
+		if (this == other)
 			return true;
-		if ((other == null))
+		if (other == null)
 			return false;
 		if (!(other instanceof UserAppId))
 			return false;
 		UserAppId castOther = (UserAppId) other;
 
-		return (this.getUserId() == castOther.getUserId())
-				&& (this.getApp().getId() == castOther.getApp().getId())
+		return (this.getUserId() == castOther.getUserId()) && (this.getApp().getId() == castOther.getApp().getId())
 				&& (this.getRole().getId() == castOther.getRole().getId());
 	}
 
+	@Override
 	public int hashCode() {
 		int result = 17;
-
-		result = 37 * result + (int) (this.getUserId()==null ? 0 : this.getUserId().intValue());
-		result = 37 * result + (int) (this.getApp().getId()==null ? 0 : this.getApp().getId().intValue());
-		result = 37 * result + (int) (this.getRole().getId()==null ? 0 : this.getRole().getId().intValue());
+		result = 37 * result + (int) (this.getUserId() == null ? 0 : this.getUserId().intValue());
+		result = 37 * result + (int) (this.getApp().getId() == null ? 0 : this.getApp().getId().intValue());
+		result = 37 * result + (int) (this.getRole().getId() == null ? 0 : this.getRole().getId().intValue());
 		return result;
 	}