Veracode vulnerabilities - Removed jsp files, commented in js/html

files, commented console.log in ts files

Change-Id: Ib88a33d0577c7c704d7e7c419641a530017e3650
Issue-ID: PORTAL-899
Signed-off-by: krutbhat@att.com

6 files changed, 38 insertions, 38 deletions

diff --git a/ecomp-sdk/epsdk-app-overlay/src/main/webapp/ngapp/src/app/pages/admin/role-functions/new-role-function/new-role-function.component.ts b/ecomp-sdk/epsdk-app-overlay/src/main/webapp/ngapp/src/app/pages/admin/role-functions/new-role-function/new-role-function.component.ts
index 82d353d1..d0be5145 100644
--- a/ecomp-sdk/epsdk-app-overlay/src/main/webapp/ngapp/src/app/pages/admin/role-functions/new-role-function/new-role-function.component.ts
+++ b/ecomp-sdk/epsdk-app-overlay/src/main/webapp/ngapp/src/app/pages/admin/role-functions/new-role-function/new-role-function.component.ts
@@ -136,11 +136,11 @@ export class NewRoleFunctionComponent implements OnInit {
         
         if (!exists && this.roleFunction.name.trim() != '' && this.roleFunction.code.trim() != '') {
           var postData = this.roleFunction;
-          console.log("saveRoleFunction post data :: ",postData);
+          //console.log("saveRoleFunction post data :: ",postData);
           this.adminService.saveRoleFunction(JSON.stringify(postData))
           .subscribe(_data => {
             this.showSpinner = false;
-            console.log("saveRoleFunction response",_data);
+            //console.log("saveRoleFunction response",_data);
             if (this.editRoleFunction) {
               this.editRoleFunction.name = this.roleFunction.name;
               this.passBackRoleFunctionPopup.emit(this.editRoleFunction);
@@ -153,7 +153,7 @@ export class NewRoleFunctionComponent implements OnInit {
               this.openConfirmationModal('Success', "Role function created successfully.");
             }  
           }, error =>{
-            console.log(error);
+            //console.log(error);
             this.showSpinner = false;
             this.openConfirmationModal('Error', error.message);
           });
diff --git a/ecomp-sdk/epsdk-app-overlay/src/main/webapp/ngapp/src/app/pages/admin/role-functions/role-functions.component.ts b/ecomp-sdk/epsdk-app-overlay/src/main/webapp/ngapp/src/app/pages/admin/role-functions/role-functions.component.ts
index 7170df50..118225d2 100644
--- a/ecomp-sdk/epsdk-app-overlay/src/main/webapp/ngapp/src/app/pages/admin/role-functions/role-functions.component.ts
+++ b/ecomp-sdk/epsdk-app-overlay/src/main/webapp/ngapp/src/app/pages/admin/role-functions/role-functions.component.ts
@@ -105,7 +105,7 @@ export class RoleFunctionsComponent implements OnInit {
       this.result = JSON.parse(response.data);
       this.availableRoleFunctions = this.result.availableRoleFunctions;
       this.tableData = JSON.parse(this.result.availableRoleFunctions);
-      console.log("Table data : ", this.tableData);
+      //console.log("Table data : ", this.tableData);
       this.columns.push(new Column("name", "Name", ColumnTypes.TEXT, true, null));
       this.columns.push(new Column("code", "Code", ColumnTypes.TEXT, true, null));
       this.columns.push(new Column("type", "Type", ColumnTypes.RADIO, true, this.typeOptions));
diff --git a/ecomp-sdk/epsdk-app-overlay/src/main/webapp/ngapp/src/app/pages/admin/role-functions/role-functions.service.ts b/ecomp-sdk/epsdk-app-overlay/src/main/webapp/ngapp/src/app/pages/admin/role-functions/role-functions.service.ts
index b0595361..bd44a63d 100644
--- a/ecomp-sdk/epsdk-app-overlay/src/main/webapp/ngapp/src/app/pages/admin/role-functions/role-functions.service.ts
+++ b/ecomp-sdk/epsdk-app-overlay/src/main/webapp/ngapp/src/app/pages/admin/role-functions/role-functions.service.ts
@@ -21,14 +21,14 @@ export class RoleFunctionsService implements RdpCrudInterface {
   constructor(private adminService: AdminService) { }
 
   add(data: any) {
-    console.log("Add method is getting called from RoleFunctionService data:: ", data);
+    //console.log("Add method is getting called from RoleFunctionService data:: ", data);
   }
 
 
   update(data: any): any {
     console.log("Update method is getting called from RoleFunctionService data:: ", data);
     return this.adminService.saveRoleFunction(data).subscribe(response => {
-      console.log("Success Response ", response);
+      //console.log("Success Response ", response);
       this.statusResponse.next("200");
     }, error => {
       console.log("Error ", error);
@@ -36,9 +36,9 @@ export class RoleFunctionsService implements RdpCrudInterface {
   }
 
   delete(data: any) {
-    console.log("Delete method is getting called from RoleFunctionService data::>> " + JSON.stringify(data));
+    //console.log("Delete method is getting called from RoleFunctionService data::>> " + JSON.stringify(data));
     this.adminService.deleteRoleFunction(data).subscribe(response => {
-      console.log("Repsonse : ", response);
+      //console.log("Repsonse : ", response);
       this.statusResponse.next("200");
 
     })
@@ -50,7 +50,7 @@ export class RoleFunctionsService implements RdpCrudInterface {
     response.subscribe(res => {
       editedData = res;
       let data = JSON.parse(JSON.parse(editedData.data).availableRoleFunctions);
-      console.log("Get Method called : ", data);
+      //console.log("Get Method called : ", data);
       this.updatedData.next(data);
     })
   }
diff --git a/ecomp-sdk/epsdk-app-overlay/src/main/webapp/ngapp/src/app/pages/analytics/Report_List/Report/security/security.component.ts b/ecomp-sdk/epsdk-app-overlay/src/main/webapp/ngapp/src/app/pages/analytics/Report_List/Report/security/security.component.ts
index b7e14bc6..6c994723 100644
--- a/ecomp-sdk/epsdk-app-overlay/src/main/webapp/ngapp/src/app/pages/analytics/Report_List/Report/security/security.component.ts
+++ b/ecomp-sdk/epsdk-app-overlay/src/main/webapp/ngapp/src/app/pages/analytics/Report_List/Report/security/security.component.ts
@@ -71,7 +71,7 @@ export class SecurityComponent implements OnInit {
     .subscribe((responseSecurityInfo) => {
       this.reportSecurityInfo = responseSecurityInfo;
 
-      console.log(this.reportSecurityInfo);
+      //console.log(this.reportSecurityInfo);
 
       this.reportOwnerId = this.reportSecurityInfo["ownerId"];
 
@@ -107,7 +107,7 @@ export class SecurityComponent implements OnInit {
     .subscribe((responseUserList) => {
       this.reportUserList = responseUserList;
 
-      console.log(this.reportUserList);
+      //console.log(this.reportUserList);
 
       for(let ru=0; ru<this.reportUserList.length; ru++)
       {
@@ -132,7 +132,7 @@ export class SecurityComponent implements OnInit {
     .subscribe((responseSecurityRoles) => {
       this.reportSecurityRoles = responseSecurityRoles;
 
-      console.log(this.reportSecurityRoles);
+      //console.log(this.reportSecurityRoles);
 
       for(let sr=0; sr<this.reportSecurityRoles.length; sr++)
       {
@@ -145,13 +145,13 @@ export class SecurityComponent implements OnInit {
           this.addRoleEditAccessArr[sr] = true;
         }
       }
-      console.log(this.reportSecurityRoles);
+      //console.log(this.reportSecurityRoles);
 
       this._securityService.getReportRoleList()
     .subscribe((responseRoleList) => {
       this.reportRoleList = responseRoleList;
 
-      console.log(this.reportRoleList);
+      //console.log(this.reportRoleList);
 
       for(let m=0; m<this.reportSecurityRoles.length; m++)
       {
@@ -194,7 +194,7 @@ export class SecurityComponent implements OnInit {
       }
     }
 
-    console.log(reportUserId);
+    //console.log(reportUserId);
 
     this._securityService.addReportUser(reportUserId)
     .subscribe((responseAddUser) => {
@@ -204,7 +204,7 @@ export class SecurityComponent implements OnInit {
     .subscribe((responseUserList) => {
       this.reportUserList = responseUserList;
 
-      console.log(this.reportUserList);
+      //console.log(this.reportUserList);
 
       this.showUserListSpinner = false;
       });
@@ -227,7 +227,7 @@ export class SecurityComponent implements OnInit {
       }
     }
 
-    console.log(reportUserId);
+    //console.log(reportUserId);
 
     this._securityService.removeReportUser(reportUserId)
     .subscribe((responseRemoveUser) => {
@@ -237,7 +237,7 @@ export class SecurityComponent implements OnInit {
     .subscribe((responseUserList) => {
       this.reportUserList = responseUserList;
 
-      console.log(this.reportUserList);
+      //console.log(this.reportUserList);
 
       this.showUserListSpinner = false;
       });
@@ -248,8 +248,8 @@ export class SecurityComponent implements OnInit {
 
   addUserEditAccess(reportUserId : string, reportUserIndex : number)
   {
-    console.log(reportUserId, reportUserIndex);
-    console.log(this.userEditAccessArr);
+    //console.log(reportUserId, reportUserIndex);
+    //console.log(this.userEditAccessArr);
     let readOnly="";
 
    if(this.userEditAccessArr[reportUserIndex] === true)
@@ -273,7 +273,7 @@ export class SecurityComponent implements OnInit {
     let roleId;
     this.showRoleListSpinner = true;
 
-    console.log(this.reportRoleList);
+    //console.log(this.reportRoleList);
 
     for(let ro=0; ro<this.reportRoleList.length; ro++)
     {
@@ -283,7 +283,7 @@ export class SecurityComponent implements OnInit {
       }
     }
 
-    console.log(roleId);
+    //console.log(roleId);
 
     this._securityService.addReportRole(roleId)
     .subscribe((addRoleResponse) => {
@@ -292,13 +292,13 @@ export class SecurityComponent implements OnInit {
     .subscribe((responseSecurityRoles) => {
       this.reportSecurityRoles = responseSecurityRoles;
 
-      console.log(this.reportSecurityRoles);
+      //console.log(this.reportSecurityRoles);
 
       this._securityService.getReportRoleList()
     .subscribe((responseRoleList) => {
       this.reportRoleList = responseRoleList;
 
-      console.log(this.reportRoleList);
+      //console.log(this.reportRoleList);
 
       for(let m=0; m<this.reportSecurityRoles.length; m++)
       {
@@ -338,13 +338,13 @@ export class SecurityComponent implements OnInit {
     .subscribe((responseSecurityRoles) => {
       this.reportSecurityRoles = responseSecurityRoles;
 
-      console.log(this.reportSecurityRoles);
+      //console.log(this.reportSecurityRoles);
 
       this._securityService.getReportRoleList()
     .subscribe((responseRoleList) => {
       this.reportRoleList = responseRoleList;
 
-      console.log(this.reportRoleList);
+      //console.log(this.reportRoleList);
 
       for(let m=0; m<this.reportSecurityRoles.length; m++)
       {
@@ -366,7 +366,7 @@ export class SecurityComponent implements OnInit {
 
   addRoleEditAccess(roleId : string, roleIndex : number)
   {
-    console.log(this.addRoleEditAccessArr);
+    //console.log(this.addRoleEditAccessArr);
     let readOnly = "";
 
     if(this.addRoleEditAccessArr[roleIndex] === true)
@@ -391,7 +391,7 @@ export class SecurityComponent implements OnInit {
     this.fetchCnt = 0;
     let finalPostObj = new Object();
 
-    // console.log(this.reportOwnerList);
+    // //console.log(this.reportOwnerList);
     for(let kl=0; kl<this.reportOwnerList.length; kl++)
     {
       if(this.reportOwnerList[kl]["name"] == this.reportOwner)
@@ -408,7 +408,7 @@ export class SecurityComponent implements OnInit {
     {
       finalPostObj["isPublic"] = "false";
     }
-    // console.log(finalPostObj);
+     //console.log(finalPostObj);
 
     this._securityService.saveSecurityTabInfo(finalPostObj)
     .subscribe((responseFinalPost) => {
@@ -420,13 +420,13 @@ export class SecurityComponent implements OnInit {
     .subscribe((responseOwnerList) => {
       this.reportOwnerList = responseOwnerList;
 
-      console.log(this.reportOwnerList);
+      //console.log(this.reportOwnerList);
 
       this._securityService.getReportSecurityInfo()
     .subscribe((responseSecurityInfo) => {
       this.reportSecurityInfo = responseSecurityInfo;
 
-      console.log(this.reportSecurityInfo);
+      //console.log(this.reportSecurityInfo);
 
       this.reportOwnerId = this.reportSecurityInfo["ownerId"];
 
@@ -462,7 +462,7 @@ export class SecurityComponent implements OnInit {
     .subscribe((responseUserList) => {
       this.reportUserList = responseUserList;
 
-      console.log(this.reportUserList);
+      //console.log(this.reportUserList);
 
       for(let ru=0; ru<this.reportUserList.length; ru++)
       {
@@ -487,7 +487,7 @@ export class SecurityComponent implements OnInit {
     .subscribe((responseSecurityRoles) => {
       this.reportSecurityRoles = responseSecurityRoles;
 
-      console.log(this.reportSecurityRoles);
+      //console.log(this.reportSecurityRoles);
 
       for(let sr=0; sr<this.reportSecurityRoles.length; sr++)
       {
@@ -500,13 +500,13 @@ export class SecurityComponent implements OnInit {
           this.addRoleEditAccessArr[sr] = true;
         }
       }
-      console.log(this.reportSecurityRoles);
+      //console.log(this.reportSecurityRoles);
 
       this._securityService.getReportRoleList()
     .subscribe((responseRoleList) => {
       this.reportRoleList = responseRoleList;
 
-      console.log(this.reportRoleList);
+      //console.log(this.reportRoleList);
 
       for(let m=0; m<this.reportSecurityRoles.length; m++)
       {
diff --git a/ecomp-sdk/epsdk-app-overlay/src/main/webapp/ngapp/src/app/pages/analytics/Report_List/Report/sql/sql.component.ts b/ecomp-sdk/epsdk-app-overlay/src/main/webapp/ngapp/src/app/pages/analytics/Report_List/Report/sql/sql.component.ts
index f8aa1ab6..62c7d7a4 100644
--- a/ecomp-sdk/epsdk-app-overlay/src/main/webapp/ngapp/src/app/pages/analytics/Report_List/Report/sql/sql.component.ts
+++ b/ecomp-sdk/epsdk-app-overlay/src/main/webapp/ngapp/src/app/pages/analytics/Report_List/Report/sql/sql.component.ts
@@ -135,7 +135,7 @@ export class SQLComponent implements OnInit {
             } else {
                 this._http.get(environment.baseUrl + 'report/wizard/retrieve_def_tab_wise_data/InSession')
                     .subscribe((response) => {
-                        console.log(response);
+                       // console.log(response);
                         this._router.navigate(['v2/reports', 'Edit', response['reportId']]);
                     });
             }
diff --git a/ecomp-sdk/epsdk-app-overlay/src/main/webapp/ngapp/src/app/pages/ext/profile/self/self.component.ts b/ecomp-sdk/epsdk-app-overlay/src/main/webapp/ngapp/src/app/pages/ext/profile/self/self.component.ts
index 61b2a343..7396b23c 100644
--- a/ecomp-sdk/epsdk-app-overlay/src/main/webapp/ngapp/src/app/pages/ext/profile/self/self.component.ts
+++ b/ecomp-sdk/epsdk-app-overlay/src/main/webapp/ngapp/src/app/pages/ext/profile/self/self.component.ts
@@ -103,7 +103,7 @@ export class SelfComponent implements OnInit {
 
   ngOnInit() {
     this.profileId = "";
-    console.log("ngOnInit called ",this.profileId);
+    //console.log("ngOnInit called ",this.profileId);
     if(this.route.snapshot.queryParams['profile_id']){
       this.profileId = this.route.snapshot.queryParams['profile_id'];
     }
@@ -155,7 +155,7 @@ export class SelfComponent implements OnInit {
 
     this.profileId = this.profile.id;
     this.ociavailableRoles = this.profile.roles;
-    console.log("Profile specific roles : ", this.ociavailableRoles);
+    //console.log("Profile specific roles : ", this.ociavailableRoles);
     this.ociTimeZones = JSON.parse(this.result.timeZones);
     this.ociCountries = JSON.parse(this.result.countries);
     this.stateList = JSON.parse(this.result.stateList);