Added Junits & AAF attributes Support

Issue-ID: PORTAL-136

Includes JUNITS, AAF attributes support


Change-Id: Id4cc9f64268017665d7245d0a10369c9b498ba2f
Signed-off-by: Kotta, Shireesha (sk434m) <sk434m@att.com>

2 files changed, 34 insertions, 33 deletions

diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/service/OnBoardingApiServiceImpl.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/service/OnBoardingApiServiceImpl.java
index bfd0fc89..f19a14b6 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/service/OnBoardingApiServiceImpl.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/service/OnBoardingApiServiceImpl.java
@@ -108,6 +108,7 @@ public class OnBoardingApiServiceImpl implements IPortalRestAPIService, IPortalR
 			.getProperty(PortalApiConstants.ROLE_ACCESS_CENTRALIZED);
 	
 	private static final String isCentralized = "remote";
+	private static String portalApiVersion = "/v1";
 	
 	public OnBoardingApiServiceImpl() {
 		// Defend against null-pointer exception during server startup
@@ -229,11 +230,12 @@ public class OnBoardingApiServiceImpl implements IPortalRestAPIService, IPortalR
 		try {
 			if (logger.isDebugEnabled())
 				logger.debug(EELFLoggerDelegate.debugLogger, "## REST API ## loginId: {}", loginId);
-			
+
 			User user = null;
-			if(isCentralized.equals(isAccessCentralized)){
-			   String responseString = restApiRequestBuilder.getViaREST("/user/" + loginId, true, loginId);
-			   user = userService.userMapper(responseString);
+			if (isCentralized.equals(isAccessCentralized)) {
+				String responseString = restApiRequestBuilder.getViaREST(portalApiVersion+"/user/" + loginId, true,
+						loginId);
+				user = userService.userMapper(responseString);
 			}
 			else{
 			   user = userProfileService.getUserByLoginId(loginId);
@@ -359,30 +361,30 @@ public class OnBoardingApiServiceImpl implements IPortalRestAPIService, IPortalR
 			logger.debug(EELFLoggerDelegate.debugLogger, "## REST API ## loginId: {}", loginId);
 		List<EcompRole> ecompRoles = new ArrayList<EcompRole>();
 		try {
-			
-			if(isCentralized.equals(isAccessCentralized)){
+
+			if (isCentralized.equals(isAccessCentralized)) {
 				User user = null;
-					String responseString = restApiRequestBuilder.getViaREST("/user/" + loginId, true, loginId);
-					user = userService.userMapper(responseString);
-					SortedSet<Role> currentRoles = null;
-					if (user != null) {
-						currentRoles = user.getRoles();
-						if (currentRoles != null)
-							for (Role role : currentRoles)
-								ecompRoles.add(UserUtils.convertToEcompRole(role));
-					}
-			}
-			else{
-			User user = userProfileService.getUserByLoginId(loginId);
-			SortedSet<Role> currentRoles = null;
-			if (user != null) {
-				currentRoles = user.getRoles();
-				currentRoles.removeIf(role -> (role.getActive() == false));
-				if (currentRoles != null)
-					for (Role role : currentRoles)
-						ecompRoles.add(UserUtils.convertToEcompRole(role));
+				String responseString = restApiRequestBuilder.getViaREST(portalApiVersion+"/user/" + loginId, true,
+						loginId);
+				user = userService.userMapper(responseString);
+				SortedSet<Role> currentRoles = null;
+				if (user != null) {
+					currentRoles = user.getRoles();
+					if (currentRoles != null)
+						for (Role role : currentRoles)
+							ecompRoles.add(UserUtils.convertToEcompRole(role));
+				}
+			} else {
+				User user = userProfileService.getUserByLoginId(loginId);
+				SortedSet<Role> currentRoles = null;
+				if (user != null) {
+					currentRoles = user.getRoles();
+					currentRoles.removeIf(role -> (role.getActive() == false));
+					if (currentRoles != null)
+						for (Role role : currentRoles)
+							ecompRoles.add(UserUtils.convertToEcompRole(role));
+				}
 			}
-		}	
 			return ecompRoles;
 		} catch (Exception e) {
 			String response = "OnboardingApiService.getUserRoles failed";
diff --git a/ecomp-sdk/epsdk-app-common/src/test/java/org/onap/portalapp/service/OnBoardingApiServiceImplTest.java b/ecomp-sdk/epsdk-app-common/src/test/java/org/onap/portalapp/service/OnBoardingApiServiceImplTest.java
index 39b61b40..98ea0f8f 100644
--- a/ecomp-sdk/epsdk-app-common/src/test/java/org/onap/portalapp/service/OnBoardingApiServiceImplTest.java
+++ b/ecomp-sdk/epsdk-app-common/src/test/java/org/onap/portalapp/service/OnBoardingApiServiceImplTest.java
@@ -39,7 +39,6 @@ package org.onap.portalapp.service;
 
 import java.io.IOException;
 import java.util.ArrayList;
-import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
@@ -129,7 +128,7 @@ public class OnBoardingApiServiceImplTest {
 		Assert.assertTrue(true);
 	}
 
-	@Test(expected = PortalAPIException.class)
+	@Test(expected = org.onap.portalsdk.core.onboarding.exception.PortalAPIException.class)
 	public void pushUserExceptionTest() throws Exception {
 		PowerMockito.mockStatic(PortalApiProperties.class);
 		Mockito.when(PortalApiProperties.getProperty(PortalApiConstants.ROLE_ACCESS_CENTRALIZED)).thenReturn("remote");
@@ -173,7 +172,7 @@ public class OnBoardingApiServiceImplTest {
 		Mockito.when(PortalApiProperties.getProperty(PortalApiConstants.ROLE_ACCESS_CENTRALIZED)).thenReturn("remote");
 
 		String responseString = "Response";
-		Mockito.when(restApiRequestBuilder.getViaREST("/user/" + loginId, true, loginId)).thenReturn(responseString);
+		Mockito.when(restApiRequestBuilder.getViaREST("/v1/user/" + loginId, true, loginId)).thenReturn(responseString);
 		Mockito.when(userService.userMapper(responseString)).thenReturn(new User());
 
 		OnBoardingApiServiceImpl onBoardingApiServiceImpl = new OnBoardingApiServiceImpl();
@@ -201,7 +200,7 @@ public class OnBoardingApiServiceImplTest {
 		PowerMockito.mockStatic(PortalApiProperties.class);
 		Mockito.when(PortalApiProperties.getProperty(PortalApiConstants.ROLE_ACCESS_CENTRALIZED)).thenReturn("local");
 		String responseString = "Response";
-		Mockito.when(restApiRequestBuilder.getViaREST("/user/" + loginId, true, loginId)).thenThrow(IOException.class);
+		Mockito.when(restApiRequestBuilder.getViaREST("/v1/user/" + loginId, true, loginId)).thenThrow(IOException.class);
 		Mockito.when(userService.userMapper(responseString)).thenReturn(null);
 
 		OnBoardingApiServiceImpl onBoardingApiServiceImpl = new OnBoardingApiServiceImpl();
@@ -320,7 +319,7 @@ public class OnBoardingApiServiceImplTest {
 	public void getUserRolesTest() throws Exception {
 		String loginId = "123";
 		String responseString = "Response";
-		Mockito.when(restApiRequestBuilder.getViaREST("/user/" + loginId, true, loginId)).thenReturn(responseString);
+		Mockito.when(restApiRequestBuilder.getViaREST("/v1/user/" + loginId, true, loginId)).thenReturn(responseString);
 		User user = new User();
 		SortedSet<Role> currentRoles = new TreeSet<>();
 		Role role = new Role();
@@ -333,10 +332,10 @@ public class OnBoardingApiServiceImplTest {
 		Assert.assertNotNull(ecompRoles);
 	}
 
-	@Test(expected = PortalAPIException.class)
+	@Test(expected = org.onap.portalsdk.core.onboarding.exception.PortalAPIException.class)
 	public void getUserRolesExceptionTest() throws Exception {
 		String loginId = "123";
-		Mockito.when(restApiRequestBuilder.getViaREST("/user/" + loginId, true, loginId)).thenThrow(IOException.class);
+		Mockito.when(restApiRequestBuilder.getViaREST("/v1/user/" + loginId, true, loginId)).thenThrow(IOException.class);
 		OnBoardingApiServiceImpl onBoardingApiServiceImpl = new OnBoardingApiServiceImpl();
 		onBoardingApiServiceImpl.getUserRoles(loginId);
 	}