Merge "Fix sonar issues in LogRegistry"

1 files changed, 6 insertions, 11 deletions

diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/scheduler/LogRegistry.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/scheduler/LogRegistry.java
index 5c80b916..93c814d0 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/scheduler/LogRegistry.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/scheduler/LogRegistry.java
@@ -52,24 +52,19 @@ import org.springframework.stereotype.Component;
 @DependsOn({ "systemProperties" })
 public class LogRegistry extends CronRegistry {
 
-	private static final String groupName = "AppGroup";
-	private static final String jobName = "LogJob";
-	private static final String triggerName = "LogTrigger";
+	private static final String GROUP_NAME = "AppGroup";
+	private static final String JOB_NAME = "LogJob";
+	private static final String TRIGGER_NAME = "LogTrigger";
 
-	// @Autowired
-	// private SystemProperties systemProperties;
-
-	// @Bean
 	public JobDetailFactoryBean jobDetailFactoryBean() {
-		Map<String, Object> map = new HashMap<String, Object>();
+		Map<String, Object> map = new HashMap<>();
 		map.put("units", "bytes");
-		return jobDetailFactoryBean(groupName, jobName, LogJob.class, map);
+		return jobDetailFactoryBean(GROUP_NAME, JOB_NAME, LogJob.class, map);
 	}
 
-	// @Bean
 	public CronTriggerFactoryBean cronTriggerFactoryBean() throws ParseException {
 		// "0 * * * * ? *
-		return cronTriggerFactoryBean(groupName, triggerName, SystemProperties.getProperty(SystemProperties.LOG_CRON));
+		return cronTriggerFactoryBean(GROUP_NAME, TRIGGER_NAME, SystemProperties.getProperty(SystemProperties.LOG_CRON));
 	}
 
 }