diff options
| author |   Rupinder <rupinsi1@in.ibm.com> | 2020-04-03 13:53:12 +0530 |
|---|---|---|
| committer | Rupinder <rupinsi1@in.ibm.com> | 2020-04-03 13:55:16 +0530 |
| commit | 61e8fa6d7f81967e9f73c73dc3bd69da8222cd69 (patch) | |
| tree | e84eb4ed59999475075dbd46ce0be63ac6608ba5 /ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/ReportDefinition.java | |
| parent | 4957ffcc47d239309c798ee4172c5840d7d89e13 (diff) | |
removed code smells
Improved code quality by removing code smells
Issue-ID: PORTAL-865
Change-Id: Ic68e75d36672a9b51800853c0ac485e9bb603d3b
Signed-off-by: Rupinder<rupinsi1@in.ibm.com>
Diffstat (limited to 'ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/ReportDefinition.java')
| -rw-r--r-- | ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/ReportDefinition.java | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/ReportDefinition.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/ReportDefinition.java index 96e8804f..e51913e4 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/ReportDefinition.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/ReportDefinition.java @@ -853,7 +853,8 @@ public class ReportDefinition extends ReportWrapper implements Serializable { break; } } - if(flag == 1) return javascriptItemType; + if(flag == 1) + return javascriptItemType; else { javascriptItemType = objFactory.createJavascriptItemType(); getJavascriptList().getJavascriptItem().add(javascriptItemType); @@ -1357,7 +1358,8 @@ public class ReportDefinition extends ReportWrapper implements Serializable { String extracted = null; nextToken = getNextCYMBALSQLParseToken(sql,true); while (nextToken.length() > 0) { - if (lastToken == null) lastToken = nextToken; + if (lastToken == null) + lastToken = nextToken; if( lastToken.toUpperCase().startsWith("DO DISPLAY")) { re = Pattern.compile("each(.*)\\[.(.*?)\\]"); //\\[(.*?)\\] @@ -1503,7 +1505,8 @@ public class ReportDefinition extends ReportWrapper implements Serializable { String extracted = null; nextToken = getNextCYMBALSQLParseToken(sql,true); while (nextToken.length() > 0) { - if (lastToken == null) lastToken = nextToken; + if (lastToken == null) + lastToken = nextToken; if( lastToken.toUpperCase().startsWith("DO DISPLAY")) { re = Pattern.compile("each(.*)\\[.(.*?)\\]"); //\\[(.*?)\\] |