summaryrefslogtreecommitdiffstats
path: root/ecomp-portal-BE-common
AgeCommit message (Collapse)AuthorFilesLines
2019-05-30XSS Vulnerability fix in AppsControllerExternalRequestDominik Mizyn8-30/+210
@SafeHtml annotation is used to fix this problem. This patch also fix some minor issues: * isAuxRESTfulCall() method delete. Method was nowhere used. * '.length() == 0' changed to '.isEmpty()' Issue-ID: PORTAL-604 Change-Id: Ib7091622081f507812654b50275ad7ac4c97bfc3 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-05-30Sonar issue: Correct this "&" to "&&" in MicroserviceServiceImplDominik Mizyn1-25/+22
This patch also fix some minor issues: * 'fori' loop replaced with 'foreach' * Sonar issue: Replace the type specification in this constructor call with the diamond operator ("<>"). * redundant 'throws'. Exception will never throw * unnecessary temporary local variable Issue-ID: PORTAL-603 Change-Id: If23afb9f4a10f0ad06c712cb95a38b54dc5cd089 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-05-30XSS Vulnerability fix in MicroserviceControllerDominik Mizyn4-67/+112
@SafeHtml annotation is used to fix this problem. This commit also fix: * redundant local variable issue * sonar issue: Replace the type specification in this constructor call with the diamond operator ("<>"). * performance issue - String concatenation argument as argument to 'StringBuilder.append()' call * redundant cast * redundant 'throws Exception'. 'Exception' is never thrown * access static member via instance reference * unused declarations Issue-ID: PORTAL-602 Change-Id: Id92fe2d9cfe239474403f611f3d5d0170acf63cc Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-05-30XSS Vulnerability fix in DashboardSearchResultControllerDominik Mizyn6-58/+270
@SafeHtml annotation is used to fix this problem. New class 'SecureString' must be added to project to valid incoming Strings from '@RequestParam String incoming String' pom.xml file update. This patch also fix: * remove unnecessary semicolon * Sonar issue: Replace the type specification in this constructor call with the diamond operator ("<>") Issue-ID: PORTAL-601 Change-Id: Id214b6e65f0c486141679fd23725a7fb66443acd Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-05-30Fix sonar issue: Override "equals(Object obj)"Dominik Mizyn2-1/+27
This commit provide equals method for CentralV2UserApp and test for this method. Issue-ID: PORTAL-599 Change-Id: Ied44c680032831ec6a02211f658ec16f0aad8f4a Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-05-28Removed user password from portal's profile APIr.bogacki1-2/+6
ONAP Portal allowed to retrieve password of currently active user via "/portalApi/loggedinUser" endpoint. Prefilled "Login Password" field has been changed to "*****" and password is not send anymore to the frontend. Only after change of this default value password will be updated. Confirm Password field has been removed from the UI. In the future password change could be additionally also checked on the backend side to verify current password before updating it. Issue-ID: OJSI-65 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Reviewed-by: Krzysztof Opasiak <k.opasiak@samsung.com> Acked-by: Manoop Talasila <talasila@research.att.com> Change-Id: I00b7713557247d211927c437f31f118095ad0726
2019-05-02Fix Sonar Bugs NullPointersk.kazak4-96/+137
Fix Sonar bugs - potential NullPointerException in portal-BE-common: ExternalAppsRestfulController and ApplicationRestClientServiceImpl Changed Tests for updated method in ExternalAppsRestfulController Added new test Formatted according to ONAP formatting guidelines Change-Id: I7c0587127e32ba3f06a138a0b4b2526fa10ea1f6 Issue-ID: PORTAL-556 Signed-off-by: k.kazak <k.kazak@samsung.com>
2019-05-02Merge "Fix no name language option bug"Manoop Talasila1-11/+27
2019-04-30Merge "Fix Sonar Bugs NullPointers"Manoop Talasila6-39/+111
2019-04-30Fix no name language option bugshentao9991-11/+27
Change-Id: I0bfc185ea41324d040ffa23c831bbbaa8f51ef3c Issue-ID: PORTAL-566 Signed-off-by: shentao999 <shentao@chinamobile.com>
2019-04-29Fix Sonar Bugs NullPointersk.kazak6-39/+111
Fix Sonar bugs - potential NullPointerException Remove unused code Add/Update Tests for updated methods Change-Id: Iaf28a0ee5f6507da1caf4b497e2d73bf35bc0b58 Issue-ID: PORTAL-556 Signed-off-by: k.kazak <k.kazak@samsung.com>
2019-04-29Fix no reaction bug about changing language optionguochuyicmri3-16/+17
Change-Id: Ie1f75224d0cc70a87e77f5c357ed6e34b0cb3220 Issue-ID: PORTAL-565 Signed-off-by: shentao999 <shentao@chinamobile.com>
2019-04-24Use all available information in audit log outputPawel Wieczorek1-1/+1
Comment is now also appended to the audit log. Issue-ID: PORTAL-553 Change-Id: Ia30d6f61b04131d4456dfc55575b1f7678e26967 Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2019-04-19Sonar fix too mnay method paramArindam Mondal4-3828/+3872
+) Reduced too many method param ++) Code format Issue-ID: PORTAL-561 Change-Id: I2c27344477b318ab0f1a77442579be459c3597fd Signed-off-by: Arindam Mondal <arind.mondal@samsung.com>
2019-04-02Add multi-language APIs into BE-commonshentao99910-3/+302
Change-Id: Ia9fddbe81bb2eb8d3e0786fcc81f0469ed45bfa0 Issue-ID: PORTAL-376 Signed-off-by: shentao999 <shentao@chinamobile.com>
2019-03-20CADI AAF Integration and merging the codehb123f48-1523/+2530
Issue-ID: PORTAL-319 CADI AAF Integration and code merge Change-Id: I6e44f3b2741858d8d403b77a49ec9a0153084801 Signed-off-by: hb123f <hbindu@research.att.com>
2019-02-07Merge "Fixed sonar issue of EPFusionBaseController.java"Manoop Talasila1-0/+1
2019-02-07Merge "Sonar Issue Fix - PORTAL-487"Manoop Talasila1-7/+6
2019-02-07Merge "PORTAL-491 - EPFusionBaseController.java"Manoop Talasila1-1/+1
2019-02-07Merge "PORTAL-492 - EPFusionBaseController.java"Manoop Talasila1-0/+1
2019-02-07Merge "PORTAL-493 - EPFusionBaseController.java"Manoop Talasila1-1/+1
2019-02-07Merge "PORTAL-494 - EPFusionBaseController.java"Manoop Talasila1-1/+1
2019-02-07Merge "PORTAL-495 - EPFusionBaseController.java"Manoop Talasila1-1/+1
2019-02-07Merge "PORTAL-496 - EPFusionBaseController.java"Manoop Talasila1-1/+3
2019-01-18Fixed sonar issue of EPFusionBaseController.javaDriptaroop Das1-0/+3
Add the "@Override" annotation above this method signature - EPFusionBaseController.java Issue-ID: PORTAL-489 Change-Id: I5f2cd71b51eea207548ecd449b8324fae28964da Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
2019-01-03Issue-Remove the declaration of thrown exceptionDriptaroop Das1-1/+3
Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body. Issue-ID: PORTAL-501 Change-Id: I9724782aeab6151e6a143e674e123c62e34870e8 Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
2018-12-05PORTAL-496 - EPFusionBaseController.javaDriptaroop Das1-1/+3
Replace the type specification in this constructor call with the diamond operator ("<>") - EPFusionBaseController.java Issue-ID: PORTAL-496 Change-Id: I3f4e044623e4e771cf9beeb7e402aba9c384dae1 Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
2018-12-05PORTAL-495 - EPFusionBaseController.javaDriptaroop Das1-1/+3
Replace the type specification in this constructor call with the diamond operator ("<>") - EPFusionBaseController.java Issue-ID: PORTAL-495 Change-Id: Ib6fd08376f7e7afb26fa8d945f6829a8a308342a Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
2018-12-05PORTAL-494 - EPFusionBaseController.javaDriptaroop Das1-1/+3
Replace the type specification in this constructor call with the diamond operator ("<>") - EPFusionBaseController.java Issue-ID: PORTAL-494 Change-Id: I84110eb8722070b8df0e75ef60549e7b79a5a422 Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
2018-12-05PORTAL-493 - EPFusionBaseController.javaDriptaroop Das1-1/+3
Replace the type specification in this constructor call with the diamond operator ("<>") - EPFusionBaseController.java Issue-ID: PORTAL-493 Change-Id: Id7f022d4cf8f0279a533167912f5d690330b010e Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
2018-12-05PORTAL-492 - EPFusionBaseController.javaDriptaroop Das1-0/+3
Add the "@Override" annotation above this method signature - EPFusionBaseController.java Issue-ID: PORTAL-492 Change-Id: I19a3dae680f279d8ea43ed77546b81428449f15c Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
2018-12-05PORTAL-491 - EPFusionBaseController.javaDriptaroop Das1-1/+3
Replace the type specification in this constructor call with the diamond operator ("<>") - EPFusionBaseController.java Issue-ID: PORTAL-491 Change-Id: I57976f175272272151726b3db0ff7da97a8f17e6 Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
2018-12-05Sonar Issue Fix - PORTAL-487Driptaroop Das1-7/+6
Remove this unused import 'org.springframework.beans.BeansException'.(NotificationCleanupConfig.java) Issue-ID: PORTAL-487 Change-Id: If0b80b12e874fba887836f408d3eb8cad0f5b6a7 Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
2018-11-08Fixed license text.Kishore Reddy, Gujja (kg811t)1-16/+0
Issue-ID: PORTAL-460 Change-Id: Ic36e7be4f723ba79e9af6acbb6eec4e1739c9d02 Signed-off-by: Kishore Reddy, Gujja (kg811t) <kishore.reddy.gujja@att.com>
2018-10-17ExtAccessRolesServiceImpl.classKishore Reddy, Gujja (kg811t)1-53/+1
Issue-ID: PORTAL-389 Fixed AAF sync roles to onap portal Change-Id: Ib75dd1aded3e3519662f61bbfd726cc2ddfc4af1 Signed-off-by: Kishore Reddy, Gujja (kg811t) <kishore.reddy.gujja@att.com>
2018-10-12ExtAccessRolesServiceImpl.class and sql2.3.0Kishore Reddy, Gujja (kg811t)1-3/+1
Issue-ID: PORTAL-389 Fixed AAF sync roles to onap portal Change-Id: Ibd36737deda72fe7c6984c89001d72ca1a5126c5 Signed-off-by: Kishore Reddy, Gujja (kg811t) <kishore.reddy.gujja@att.com>
2018-10-09Merge "added a test in CustomLogginFilterTest.java"Manoop Talasila1-31/+43
2018-10-09Merge "Add roles to user"Manoop Talasila6-283/+150
2018-10-09Add roles to userKotta, Shireesha (sk434m)6-283/+150
Issue-ID: PORTAL-432 add roles to user when the app is centralized Change-Id: I46a782be24ea1804597dc7205bf98170731ffe4d Signed-off-by: Kotta, Shireesha (sk434m) <shireesha.kotta@att.com>
2018-10-09Merge "test equality in EPUserAppRolesRequestTest.java"Manoop Talasila1-40/+160
2018-10-09Merge "test added MusicCookieCsrfTokenRepository.java"Manoop Talasila1-0/+71
2018-10-09Merge "test cases for the remaining lines of equal method"Manoop Talasila1-21/+39
2018-10-09Merge "test covered for comparetTo method in EPUser.java"Manoop Talasila1-103/+110
2018-10-09Merge "added test cases in EPRoleTest.java"Manoop Talasila1-53/+65
2018-10-04test added MusicCookieCsrfTokenRepository.javaasgar1-0/+71
Change-Id: I9791e63f64aa6e37a422d878c45274a39e3afdf2 Issue-ID: PORTAL-428 Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
2018-10-03search user changesKishore Reddy, Gujja (kg811t)1-1/+1
Issue-ID: PORTAL-386 failed to create user with special char in login_id Change-Id: I613daa21efed9f6f137bd817a1a8aa2f9669cee8 Signed-off-by: Kishore Reddy, Gujja (kg811t) <kishore.reddy.gujja@att.com>
2018-10-03added a test in CustomLogginFilterTest.javaasgar1-31/+43
Change-Id: Ib801f9ab42486d51fa64b6575124e5668a48c853 Issue-ID: PORTAL-427 Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
2018-10-03test equality in EPUserAppRolesRequestTest.javaasgar1-40/+160
Change-Id: Ib8e9ff486af57ee03c7f47749d7a040c5ae9d4a0 Issue-ID: PORTAL-426 Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
2018-10-01Merge "test cases added for PortalRestResponse.java"Manoop Talasila1-0/+74
2018-09-28test covered for comparetTo method in EPUser.javaasgar1-103/+110
Change-Id: I7a171068a878f4500af0996d0a7123d2472fef18 Issue-ID: PORTAL-413 Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>