summaryrefslogtreecommitdiffstats
path: root/ecomp-portal-BE-common/src/test
AgeCommit message (Collapse)AuthorFilesLines
2019-06-18Merge "Fix sql injection vulnerability"Sunder Tattavarada1-2/+6
2019-06-18Merge "Fix sql injection vulnerability"Sunder Tattavarada1-2/+4
2019-06-18Merge "Fix sql injection vulnerability"Sunder Tattavarada1-1/+6
2019-06-18WebAnalyticsExtAppController sonar issuesDominik Mizyn1-2/+2
- Rename this local variable to match the regular expression - Make this anonymous inner class a lambda. - Immediately return this expression instead of assigning it to the temporary variable "response". - Move the "" string literal on the left side of this string comparison. - Replace the type specification in this constructor call with the diamond operator ("<>"). Issue-ID: PORTAL-648 Change-Id: I1666d94dccbbe8aa835ea9a443a9973a245353f4 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-18AppWithRolesForUser sonar security issueDominik Mizyn2-3/+3
I used Lombok annotation to provide accessors. Issue-ID: PORTAL-645 Change-Id: Iad852434f30b81535398913df162fa8f4bd1ecff Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-17Merge "Application Onboarding page changes "Lorraine Welch7-46/+310
2019-06-17Application Onboarding page changes Kotta, Shireesha (sk434m)7-46/+310
Issue-ID: PORTAL-644 Application Onboarding page changes , DB scripts Change-Id: Id689e15f5abd56192420e6761440659531108ab4 Signed-off-by: Kotta, Shireesha (sk434m) <sk434m@att.com>
2019-06-17Merge "Sonar: Reduce cyclomatic complexity"Sunder Tattavarada1-7/+9
2019-06-17Fix sql injection vulnerabilityDominik Orliński1-2/+6
Use a variable binding instead of concatenation. Change test 'getAppRolesForNonCentralizedPartnerAppTest'. Issue-ID: OJSI-174 Signed-off-by: Dominik Orliński <d.orlinski@samsung.com> Change-Id: I676ed349746cdabf320027dd27a0c16949fff6d8
2019-06-17Fix sql injection vulnerabilityDominik Orliński1-2/+4
Use a variable binding instead of concatenation. Change test 'getAppRolesForNonCentralizedPartnerAppTest'. Issue-ID: OJSI-174 Signed-off-by: Dominik Orliński <d.orlinski@samsung.com> Change-Id: I45895dc7665ff17394e602cbccf875e4e91b5ce1
2019-06-17Fix sql injection vulnerabilityDominik Orliński1-1/+6
Use a variable binding instead of concatenation. Change test 'getAppRolesForNonCentralizedPartnerAppTest'. Issue-ID: OJSI-174 Signed-off-by: Dominik Orliński <d.orlinski@samsung.com> Change-Id: I5cb7561e4b2b781834bd4f2ec36dee58b4738bf2
2019-06-14Merge "Custom data validator"Sunder Tattavarada1-0/+98
2019-06-14Merge "XSS Vulnerability fix in TicketEventController"Sunder Tattavarada1-0/+12
2019-06-14Merge "XSS Vulnerability fix in RoleManageController"Sunder Tattavarada1-0/+79
2019-06-14Merge "Fix sql injection vulnerability"Sunder Tattavarada1-0/+26
2019-06-05Custom data validatorDominik Mizyn1-0/+98
By creating custom data validator we can reduce code duplications. Issue-ID: OJSI-15 Change-Id: I39decf1d6ded559322c4445f0956fad2a159878d Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-05-31XSS Vulnerability fix in TicketEventControllerDominik Mizyn1-0/+12
@SafeHtml and SecureString used to fix this issue; Issue-ID: OJSI-209 Change-Id: I588872839696c824135bab88c100b31c23d960ba Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-05-31XSS Vulnerability fix in RoleManageControllerDominik Mizyn1-0/+79
@SafeHtml and SecureString used to secure this class Issue-ID: OJSI-208 Change-Id: Ie01799933add3419cacf0fc716ce2da6da0a2853 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-05-30XSS Vulnerability fix in AppsControllerExternalRequestDominik Mizyn1-0/+80
@SafeHtml annotation is used to fix this problem. This patch also fix some minor issues: * isAuxRESTfulCall() method delete. Method was nowhere used. * '.length() == 0' changed to '.isEmpty()' Issue-ID: PORTAL-604 Change-Id: Ib7091622081f507812654b50275ad7ac4c97bfc3 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-05-30XSS Vulnerability fix in MicroserviceControllerDominik Mizyn1-39/+58
@SafeHtml annotation is used to fix this problem. This commit also fix: * redundant local variable issue * sonar issue: Replace the type specification in this constructor call with the diamond operator ("<>"). * performance issue - String concatenation argument as argument to 'StringBuilder.append()' call * redundant cast * redundant 'throws Exception'. 'Exception' is never thrown * access static member via instance reference * unused declarations Issue-ID: PORTAL-602 Change-Id: Id92fe2d9cfe239474403f611f3d5d0170acf63cc Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-05-30XSS Vulnerability fix in DashboardSearchResultControllerDominik Mizyn1-28/+114
@SafeHtml annotation is used to fix this problem. New class 'SecureString' must be added to project to valid incoming Strings from '@RequestParam String incoming String' pom.xml file update. This patch also fix: * remove unnecessary semicolon * Sonar issue: Replace the type specification in this constructor call with the diamond operator ("<>") Issue-ID: PORTAL-601 Change-Id: Id214b6e65f0c486141679fd23725a7fb66443acd Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-05-30Fix sonar issue: Override "equals(Object obj)"Dominik Mizyn1-0/+12
This commit provide equals method for CentralV2UserApp and test for this method. Issue-ID: PORTAL-599 Change-Id: Ied44c680032831ec6a02211f658ec16f0aad8f4a Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-05-30Fix sql injection vulnerabilityDominik Orliński1-0/+26
Use a variable binding instead of concatenation. Add new test for function 'createLocalUserIfNecessary'. Issue-ID: OJSI-174 Change-Id: Iddd65893bb2cb16c90d4f8db59816fdf261874bc Signed-off-by: Dominik Orliński <d.orlinski@samsung.com>
2019-05-29Sonar: Reduce cyclomatic complexityDominik Mizyn1-7/+9
Reduce the number of conditional operators for equals(). Improve testEquals() to better cover this method. This patch also: * immediately returns expression instead of assigning it to the temporary variable "str", * adds the "@Override" annotation above equals() method signature. Issue-ID: PORTAL-595 Change-Id: I15f600acce873eb3f22cc405d06a50890c7e87c3 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-05-02Fix Sonar Bugs NullPointersk.kazak2-88/+123
Fix Sonar bugs - potential NullPointerException in portal-BE-common: ExternalAppsRestfulController and ApplicationRestClientServiceImpl Changed Tests for updated method in ExternalAppsRestfulController Added new test Formatted according to ONAP formatting guidelines Change-Id: I7c0587127e32ba3f06a138a0b4b2526fa10ea1f6 Issue-ID: PORTAL-556 Signed-off-by: k.kazak <k.kazak@samsung.com>
2019-04-29Fix Sonar Bugs NullPointersk.kazak3-1/+78
Fix Sonar bugs - potential NullPointerException Remove unused code Add/Update Tests for updated methods Change-Id: Iaf28a0ee5f6507da1caf4b497e2d73bf35bc0b58 Issue-ID: PORTAL-556 Signed-off-by: k.kazak <k.kazak@samsung.com>
2019-04-19Sonar fix too mnay method paramArindam Mondal2-42/+42
+) Reduced too many method param ++) Code format Issue-ID: PORTAL-561 Change-Id: I2c27344477b318ab0f1a77442579be459c3597fd Signed-off-by: Arindam Mondal <arind.mondal@samsung.com>
2019-03-20CADI AAF Integration and merging the codehb123f16-363/+446
Issue-ID: PORTAL-319 CADI AAF Integration and code merge Change-Id: I6e44f3b2741858d8d403b77a49ec9a0153084801 Signed-off-by: hb123f <hbindu@research.att.com>
2018-10-09Merge "added a test in CustomLogginFilterTest.java"Manoop Talasila1-31/+43
2018-10-09Merge "Add roles to user"Manoop Talasila2-46/+2
2018-10-09Add roles to userKotta, Shireesha (sk434m)2-46/+2
Issue-ID: PORTAL-432 add roles to user when the app is centralized Change-Id: I46a782be24ea1804597dc7205bf98170731ffe4d Signed-off-by: Kotta, Shireesha (sk434m) <shireesha.kotta@att.com>
2018-10-09Merge "test equality in EPUserAppRolesRequestTest.java"Manoop Talasila1-40/+160
2018-10-09Merge "test added MusicCookieCsrfTokenRepository.java"Manoop Talasila1-0/+71
2018-10-09Merge "test cases for the remaining lines of equal method"Manoop Talasila1-21/+39
2018-10-09Merge "test covered for comparetTo method in EPUser.java"Manoop Talasila1-103/+110
2018-10-09Merge "added test cases in EPRoleTest.java"Manoop Talasila1-53/+65
2018-10-04test added MusicCookieCsrfTokenRepository.javaasgar1-0/+71
Change-Id: I9791e63f64aa6e37a422d878c45274a39e3afdf2 Issue-ID: PORTAL-428 Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
2018-10-03added a test in CustomLogginFilterTest.javaasgar1-31/+43
Change-Id: Ib801f9ab42486d51fa64b6575124e5668a48c853 Issue-ID: PORTAL-427 Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
2018-10-03test equality in EPUserAppRolesRequestTest.javaasgar1-40/+160
Change-Id: Ib8e9ff486af57ee03c7f47749d7a040c5ae9d4a0 Issue-ID: PORTAL-426 Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
2018-10-01Merge "test cases added for PortalRestResponse.java"Manoop Talasila1-0/+74
2018-09-28test covered for comparetTo method in EPUser.javaasgar1-103/+110
Change-Id: I7a171068a878f4500af0996d0a7123d2472fef18 Issue-ID: PORTAL-413 Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
2018-09-28added test cases in EPRoleTest.javaasgar1-53/+65
Change-Id: Ib50643fa9d07948b5bd5815b126c937397dc4454 Issue-ID: PORTAL-411 Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
2018-09-27test cases for the remaining lines of equal methodasgar1-21/+39
Change-Id: Ia96a9ee1f4f7cd286202f7abeefc0548227fa79a Issue-ID: PORTAL-409 Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
2018-09-26test cases added for PortalRestResponse.javaasgar1-0/+74
Change-Id: I974be70db1b036be3eea57cfaf1359d1bfea9407 Issue-ID: PORTAL-404 Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
2018-09-26equals method covered in EPUserApp.javaasgar1-72/+116
Change-Id: Ib804ca53a4c308a3c2710acc2efdd351d103047a Issue-ID: PORTAL-403 Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
2018-07-30JUnits for coveragesa282w42-335/+2949
Issue-ID: PORTAL-273 JUnits for sonar coverage Change-Id: Icb88d8563164281d29877bbc2de9c8f1f780aa0c Signed-off-by: sa282w <sa282w@att.com>
2018-06-27JUnits for coverageHima Elisetty48-333/+8330
Issue-ID: PORTAL-273 JUnits for sonar coverage Change-Id: Ibfa06dcbc7809d9d2598af4ba31dd8c88943aa20 Signed-off-by: Hima Elisetty <hb123f@att.com>
2018-06-21Music health check apissa282w3-0/+305
Issue-ID: PORTAL-291, PORTAL-307 Included the music changes, other changes from 2.3 branch to be included in master, added JUnits to the new classes and updated the document with the API version changes. Change-Id: I7b4c54be49317264afbdcb8d8ae3f20395bf0e1f Signed-off-by: sa282w <sa282w@att.com>
2018-05-25Bulk upload changes and music health check apisKishore Reddy, Gujja (kg811t)19-229/+1605
Issue-ID: PORTAL-290, PORTAL-291 Bulk upload changes and music health check apis Change-Id: I63d289d75420658ff4a14385a5106838fa8c32b2 Signed-off-by: Kishore Reddy, Gujja (kg811t) <kg811t@research.att.com>
2018-04-19Replace ecomp referencesHima Elisetty151-151/+151
Issue-ID: PORTAL-19 Remove ecomp trademark Change-Id: I76311f2ab10b2c0d406415ea2f922d1aad993e21 Signed-off-by: Hima Elisetty <hbindu@research.att.com>