summaryrefslogtreecommitdiffstats
path: root/ecomp-portal-BE-common/src/test
AgeCommit message (Collapse)AuthorFilesLines
2019-07-22Merge "XSS Vulnerability fix in DashboardController"Manoop Talasila1-15/+85
2019-07-22Merge "XSS Vulnerability fix in ↵Manoop Talasila2-118/+270
ExternalAccessRolesControllerDashboardController"
2019-07-22Merge "XSS Vulnerability fix in AuxApiRequestMapperController"Manoop Talasila1-2/+228
2019-07-22Merge "XSS Vulnerability fix in SharedContextRestController"Manoop Talasila1-18/+81
2019-07-22Merge "XSS Vulnerability fix in WidgetsController"Manoop Talasila1-4/+47
2019-07-22Merge "XSS Vulnerability fix in AuditLogController"Manoop Talasila1-1/+1
2019-07-22Merge "XSS Vulnerability fix in AppContactUsController"Manoop Talasila1-1/+33
2019-07-15XSS Vulnerability fix in DashboardControllerDominik Mizyn1-15/+85
Custom data validator used to fix this issue. Issue-ID: OJSI-15 Change-Id: I84bfb81e5d87f80211d46d1141cbf8e4075660fe Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-07-15XSS Vulnerability fix in ExternalAccessRolesControllerDashboardControllerDominik Mizyn2-118/+270
Custom data validator used to fix this issue. Issue-ID: OJSI-15 Change-Id: I9a978846ffc50d840a676b994aa4fb89248b5372 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-07-15XSS Vulnerability fix in AuxApiRequestMapperControllerDominik Mizyn1-2/+228
Custom data validotor is used to valid incoming data. Issue-ID: OJSI-15 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com> Change-Id: I1b2a1fe0fcb6278a7b12017479243009142c2cbd
2019-07-12XSS Vulnerability fix in SharedContextRestControllerDominik Mizyn1-18/+81
Custom data validator used to secure this class Issue-ID: OJSI-15 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com> Change-Id: I231731b9deb60310b698d70179cddd471cffd7fb
2019-07-12XSS Vulnerability fix in WidgetsControllerDominik Mizyn1-4/+47
Custom data validator used to fix this issue. Issue-ID: OJSI-15 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com> Change-Id: I0113097b2118656780f4f9bca8b4ee99e85b6f6d
2019-07-12XSS Vulnerability fix in AuditLogControllerDominik Mizyn1-1/+1
Custom data validator used to fix this issue. Issue-ID: OJSI-15 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com> Change-Id: Iafaca1806cf7106b91efdfd9cb40132020b114f2
2019-07-12XSS Vulnerability fix in AppContactUsControllerDominik Mizyn1-1/+33
Custom data validator used to fix this issue. Issue-ID: OJSI-15 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com> Change-Id: Ie8df4df552cfe53e3839c7021284f0226ea56a39
2019-07-12XSS Vulnerability fix in AppsControllerDominik Mizyn1-4/+69
Custom XSS filter used to fix thisa issue. DataValidator upgrade to single instance of ValidatorFactory; Issue-ID: OJSI-15 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com> Change-Id: I7222cfb84e1e5bb240619aac9c7bca85d215229a
2019-07-10Revert "Fix sql injection vulnerability"Krzysztof Opasiak1-3/+1
This reverts commit 941133a42bad6a1d73c63913a950d1e4bc814fde. This is required because this commit breaks the portal unit test due to some other changes that happen between verify job and merge of that commit. Issue-ID: OJSI-174 Change-Id: Ieb53f8ba23e2b1b05c67ec4d7d51c6d5107cfb87 Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
2019-07-09Merge "FunctionalMenuRole class DB constraints"Manoop Talasila1-9/+9
2019-07-09Merge "CommonWidget class DB constraints"Manoop Talasila1-4/+4
2019-07-09Merge "XSS Vulnerability fix in PortalAdminController"Sunder Tattavarada1-8/+27
2019-07-08Merge "Fix sql injection vulnerability"Sunder Tattavarada1-1/+3
2019-07-05XSS Vulnerability fix in PortalAdminControllerDominik Mizyn1-8/+27
Custom data validator used to fix this issue. Issue-ID: OJSI-15 Change-Id: I224887d31e4e2d7301544194ef44ba38e66e047d Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-19Fix sql injection vulnerabilityDominik Orliński1-1/+3
Use a variable binding instead of concatenation. Change test 'getAppRolesForNonCentralizedPartnerAppTest'. Issue-ID: OJSI-174 Signed-off-by: Dominik Orliński <d.orlinski@samsung.com> Change-Id: Ia75da49ed582836a47b5fdcddab62fbe02e36e72
2019-06-18Merge "Fix sql injection vulnerability"Sunder Tattavarada1-2/+6
2019-06-18Merge "Fix sql injection vulnerability"Sunder Tattavarada1-2/+4
2019-06-18Merge "Fix sql injection vulnerability"Sunder Tattavarada1-1/+6
2019-06-18WebAnalyticsExtAppController sonar issuesDominik Mizyn1-2/+2
- Rename this local variable to match the regular expression - Make this anonymous inner class a lambda. - Immediately return this expression instead of assigning it to the temporary variable "response". - Move the "" string literal on the left side of this string comparison. - Replace the type specification in this constructor call with the diamond operator ("<>"). Issue-ID: PORTAL-648 Change-Id: I1666d94dccbbe8aa835ea9a443a9973a245353f4 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-18AppWithRolesForUser sonar security issueDominik Mizyn2-3/+3
I used Lombok annotation to provide accessors. Issue-ID: PORTAL-645 Change-Id: Iad852434f30b81535398913df162fa8f4bd1ecff Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-18FunctionalMenuRole class DB constraintsDominik Mizyn1-9/+9
Java Bean Validation SR 380 annotations added to classes Getter, Setter, hashCode, equals changed to lombok annotation Issue-ID: PORTAL-642 Change-Id: I666b0245add8e97f490d991701f548c0cd128cb6 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-18CommonWidget class DB constraintsDominik Mizyn1-4/+4
Java Bean Validation SR 380 annotations added to classes Issue-ID: PORTAL-637 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com> Change-Id: I64741f835deb8aed14ad8d716d21bb4c1901b55f
2019-06-17Merge "Application Onboarding page changes "Lorraine Welch7-46/+310
2019-06-17Application Onboarding page changes Kotta, Shireesha (sk434m)7-46/+310
Issue-ID: PORTAL-644 Application Onboarding page changes , DB scripts Change-Id: Id689e15f5abd56192420e6761440659531108ab4 Signed-off-by: Kotta, Shireesha (sk434m) <sk434m@att.com>
2019-06-17Merge "Sonar: Reduce cyclomatic complexity"Sunder Tattavarada1-7/+9
2019-06-17Fix sql injection vulnerabilityDominik Orliński1-2/+6
Use a variable binding instead of concatenation. Change test 'getAppRolesForNonCentralizedPartnerAppTest'. Issue-ID: OJSI-174 Signed-off-by: Dominik Orliński <d.orlinski@samsung.com> Change-Id: I676ed349746cdabf320027dd27a0c16949fff6d8
2019-06-17Fix sql injection vulnerabilityDominik Orliński1-2/+4
Use a variable binding instead of concatenation. Change test 'getAppRolesForNonCentralizedPartnerAppTest'. Issue-ID: OJSI-174 Signed-off-by: Dominik Orliński <d.orlinski@samsung.com> Change-Id: I45895dc7665ff17394e602cbccf875e4e91b5ce1
2019-06-17Fix sql injection vulnerabilityDominik Orliński1-1/+6
Use a variable binding instead of concatenation. Change test 'getAppRolesForNonCentralizedPartnerAppTest'. Issue-ID: OJSI-174 Signed-off-by: Dominik Orliński <d.orlinski@samsung.com> Change-Id: I5cb7561e4b2b781834bd4f2ec36dee58b4738bf2
2019-06-14Merge "Custom data validator"Sunder Tattavarada1-0/+98
2019-06-14Merge "XSS Vulnerability fix in TicketEventController"Sunder Tattavarada1-0/+12
2019-06-14Merge "XSS Vulnerability fix in RoleManageController"Sunder Tattavarada1-0/+79
2019-06-14Merge "Fix sql injection vulnerability"Sunder Tattavarada1-0/+26
2019-06-05Custom data validatorDominik Mizyn1-0/+98
By creating custom data validator we can reduce code duplications. Issue-ID: OJSI-15 Change-Id: I39decf1d6ded559322c4445f0956fad2a159878d Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-05-31XSS Vulnerability fix in TicketEventControllerDominik Mizyn1-0/+12
@SafeHtml and SecureString used to fix this issue; Issue-ID: OJSI-209 Change-Id: I588872839696c824135bab88c100b31c23d960ba Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-05-31XSS Vulnerability fix in RoleManageControllerDominik Mizyn1-0/+79
@SafeHtml and SecureString used to secure this class Issue-ID: OJSI-208 Change-Id: Ie01799933add3419cacf0fc716ce2da6da0a2853 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-05-30XSS Vulnerability fix in AppsControllerExternalRequestDominik Mizyn1-0/+80
@SafeHtml annotation is used to fix this problem. This patch also fix some minor issues: * isAuxRESTfulCall() method delete. Method was nowhere used. * '.length() == 0' changed to '.isEmpty()' Issue-ID: PORTAL-604 Change-Id: Ib7091622081f507812654b50275ad7ac4c97bfc3 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-05-30XSS Vulnerability fix in MicroserviceControllerDominik Mizyn1-39/+58
@SafeHtml annotation is used to fix this problem. This commit also fix: * redundant local variable issue * sonar issue: Replace the type specification in this constructor call with the diamond operator ("<>"). * performance issue - String concatenation argument as argument to 'StringBuilder.append()' call * redundant cast * redundant 'throws Exception'. 'Exception' is never thrown * access static member via instance reference * unused declarations Issue-ID: PORTAL-602 Change-Id: Id92fe2d9cfe239474403f611f3d5d0170acf63cc Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-05-30XSS Vulnerability fix in DashboardSearchResultControllerDominik Mizyn1-28/+114
@SafeHtml annotation is used to fix this problem. New class 'SecureString' must be added to project to valid incoming Strings from '@RequestParam String incoming String' pom.xml file update. This patch also fix: * remove unnecessary semicolon * Sonar issue: Replace the type specification in this constructor call with the diamond operator ("<>") Issue-ID: PORTAL-601 Change-Id: Id214b6e65f0c486141679fd23725a7fb66443acd Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-05-30Fix sonar issue: Override "equals(Object obj)"Dominik Mizyn1-0/+12
This commit provide equals method for CentralV2UserApp and test for this method. Issue-ID: PORTAL-599 Change-Id: Ied44c680032831ec6a02211f658ec16f0aad8f4a Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-05-30Fix sql injection vulnerabilityDominik Orliński1-0/+26
Use a variable binding instead of concatenation. Add new test for function 'createLocalUserIfNecessary'. Issue-ID: OJSI-174 Change-Id: Iddd65893bb2cb16c90d4f8db59816fdf261874bc Signed-off-by: Dominik Orliński <d.orlinski@samsung.com>
2019-05-29Sonar: Reduce cyclomatic complexityDominik Mizyn1-7/+9
Reduce the number of conditional operators for equals(). Improve testEquals() to better cover this method. This patch also: * immediately returns expression instead of assigning it to the temporary variable "str", * adds the "@Override" annotation above equals() method signature. Issue-ID: PORTAL-595 Change-Id: I15f600acce873eb3f22cc405d06a50890c7e87c3 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-05-02Fix Sonar Bugs NullPointersk.kazak2-88/+123
Fix Sonar bugs - potential NullPointerException in portal-BE-common: ExternalAppsRestfulController and ApplicationRestClientServiceImpl Changed Tests for updated method in ExternalAppsRestfulController Added new test Formatted according to ONAP formatting guidelines Change-Id: I7c0587127e32ba3f06a138a0b4b2526fa10ea1f6 Issue-ID: PORTAL-556 Signed-off-by: k.kazak <k.kazak@samsung.com>
2019-04-29Fix Sonar Bugs NullPointersk.kazak3-1/+78
Fix Sonar bugs - potential NullPointerException Remove unused code Add/Update Tests for updated methods Change-Id: Iaf28a0ee5f6507da1caf4b497e2d73bf35bc0b58 Issue-ID: PORTAL-556 Signed-off-by: k.kazak <k.kazak@samsung.com>