summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-06-25Fix sql injection vulnerabilityDominik Orliński1-2/+6
Use a variable binding instead of concatenation. Issue-ID: OJSI-174 Signed-off-by: Dominik Orliński <d.orlinski@samsung.com> Change-Id: I9dcec677ee9edd0d274a486af37eb950d8e828cf
2019-06-25Fix sql injection vulnerabilityDominik Orliński1-1/+4
Use a variable binding instead of concatenation. Issue-ID: OJSI-174 Signed-off-by: Dominik Orliński <d.orlinski@samsung.com> Change-Id: I8d72c819004f05fbbf464cde73b405f2028c7bb6
2019-06-21PeerBroadcastSocket sonar issues fix and code refactorDominik Mizyn1-39/+16
Sonar issues fix and code refactor. Session data save moved to another method. Rest of code don't really do anything. Issue-ID: PORTAL-624 Change-Id: I53b36377f2d2645d8c24ad2384959f0599e07303 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-21ONAPWelcomeController sonar issue fixDominik Mizyn1-11/+4
String viewName and getter/setter can be romoved from his class. ONAPWelcomeController Overrides this field 1 to 1. Issue-ID: PORTAL-652 Change-Id: Idbb41f52a63c6ea681f6ba7753991d766849e3a2 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-21ONAPLoginController sonar issues fix.Dominik Mizyn1-16/+21
Sonar issues fix plus @Autowired in constructor not in fields. Issue-ID: PORTAL-651 Change-Id: I99329b986877d040c6fdda9daf42a5c501a39605 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-21SimpleLoginStrategy sonar issues fixDominik Mizyn1-16/+18
"Either remove or fill this block of code." "Move the "" string literal on the left side of this string comparison." "Define and throw a dedicated exception instead of using a generic one." Issue-ID: PORTAL-650 Change-Id: I92018287a6f585020f0ae6f042b1bb1de84a5e14 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-21OpenIdConnectLoginStrategy sonar issues fixDominik Mizyn1-7/+4
Redundant suppression("rawtypes") removed. Sonar issue: Move the "" string literal on the left side of this string comparison. Define and throw a dedicated exception instead of using a generic one. Issue-ID: PORTAL-649 Change-Id: Ia2c80ad4848c22c94a2db731425250784d382841 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-19Fix sql injection vulnerabilityDominik Orliński1-6/+5
Use a variable binding instead of concatenation. Issue-ID: OJSI-174 Signed-off-by: Dominik Orliński <d.orlinski@samsung.com> Change-Id: I0574e882e4d500408b6a6bab8986822669cba5d4
2019-06-19Fix sql injection vulnerabilityDominik Orliński2-3/+6
Use a variable binding instead of concatenation. Change test 'getAppRolesForNonCentralizedPartnerAppTest'. Issue-ID: OJSI-174 Signed-off-by: Dominik Orliński <d.orlinski@samsung.com> Change-Id: Ia75da49ed582836a47b5fdcddab62fbe02e36e72
2019-06-18Merge "Fix sql injection vulnerability"Sunder Tattavarada2-4/+12
2019-06-18Merge "Fix sql injection vulnerability"Sunder Tattavarada2-3/+8
2019-06-18Merge "Fix sql injection vulnerability"Sunder Tattavarada2-3/+12
2019-06-18WebAnalyticsExtAppController sonar issuesDominik Mizyn2-62/+32
- Rename this local variable to match the regular expression - Make this anonymous inner class a lambda. - Immediately return this expression instead of assigning it to the temporary variable "response". - Move the "" string literal on the left side of this string comparison. - Replace the type specification in this constructor call with the diamond operator ("<>"). Issue-ID: PORTAL-648 Change-Id: I1666d94dccbbe8aa835ea9a443a9973a245353f4 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-18HealthMonitor sonar issuesDominik Mizyn2-124/+85
Remove this unused "numIntervalsClusterNotHealthy" local variable. Use "Long.parseLong" for this string-to-long conversion. Make the enclosing method "static" or remove this set. Change this instance-reference to a static reference. Remove the literal "false" boolean value. This block of commented-out lines of code should be removed. Add the "@Override" annotation above this method signature Issue-ID: PORTAL-647 Change-Id: I1880177f0906e6267807bbb9c0b7a81651e3c020 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-18EPLdapService sonar issue fixDominik Mizyn1-1/+1
Annotate the interface with the @FunctionalInterface annotation. Issue-ID: PORTAL-646 Change-Id: Idc6c70b9edaed73024721a3bc8c91796a0df9183 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-18AppWithRolesForUser sonar security issueDominik Mizyn5-85/+45
I used Lombok annotation to provide accessors. Issue-ID: PORTAL-645 Change-Id: Iad852434f30b81535398913df162fa8f4bd1ecff Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-18SharedContext class DB constraintsDominik Mizyn1-116/+25
Java Bean Validation SR 380 annotations added to classes Getter, Setter changed to lombok annotation Issue-ID: PORTAL-643 Change-Id: I690665b97e431de50750d5a497afcf0cc2efa065 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-18FunctionalMenuRole class DB constraintsDominik Mizyn2-78/+29
Java Bean Validation SR 380 annotations added to classes Getter, Setter, hashCode, equals changed to lombok annotation Issue-ID: PORTAL-642 Change-Id: I666b0245add8e97f490d991701f548c0cd128cb6 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-18PortalAdmin class DB constraintsDominik Mizyn1-32/+14
Java Bean Validation SR 380 annotations added to classes Getter/Setter changed into lombok annotation Issue-ID: PORTAL-641 Change-Id: I98909f4a82372f110aa42452476fb85c9bccbf3a Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-18FavoritesFunctionalMenuItemJson class DB constraintsDominik Mizyn1-6/+8
Java Bean Validation SR 380 annotations added to classes Issue-ID: PORTAL-640 Change-Id: I5080e848de12669db9cdd24afe86510dcd82c3e2 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-18EpNotificationItem class DB constraintsDominik Mizyn1-242/+38
Java Bean Validation SR 380 annotations added to classes Unnecessary getter/setter, hashCode/equals changed to lombok annotation Issue-ID: PORTAL-639 Change-Id: I58a6c734446fa10499feb7e4f1cef57dfd9e66b0 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-18EpRoleNotificationItem class DB constraintsDominik Mizyn1-41/+12
Java Bean Validation SR 380 annotations added to classes Issue-ID: PORTAL-638 Change-Id: I035ad9703f25cc87567700f66c3649ca53aee2df Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-18CommonWidget class DB constraintsDominik Mizyn3-71/+22
Java Bean Validation SR 380 annotations added to classes Issue-ID: PORTAL-637 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com> Change-Id: I64741f835deb8aed14ad8d716d21bb4c1901b55f
2019-06-17Merge "PortalAdminUserRole class DB constraints"Sunder Tattavarada1-0/+4
2019-06-17Merge "MicroserviceParameter class DB constraints"Sunder Tattavarada1-32/+13
2019-06-17Merge "MicroserviceDataApp class DB constraints"Sunder Tattavarada1-72/+26
2019-06-17Merge "Application Onboarding page changes "Lorraine Welch60-4442/+6550
2019-06-17Application Onboarding page changes Kotta, Shireesha (sk434m)60-4442/+6550
Issue-ID: PORTAL-644 Application Onboarding page changes , DB scripts Change-Id: Id689e15f5abd56192420e6761440659531108ab4 Signed-off-by: Kotta, Shireesha (sk434m) <sk434m@att.com>
2019-06-17Merge "Sonar: Reduce cyclomatic complexity"Sunder Tattavarada2-14/+31
2019-06-17Fix sql injection vulnerabilityDominik Orliński2-4/+12
Use a variable binding instead of concatenation. Change test 'getAppRolesForNonCentralizedPartnerAppTest'. Issue-ID: OJSI-174 Signed-off-by: Dominik Orliński <d.orlinski@samsung.com> Change-Id: I676ed349746cdabf320027dd27a0c16949fff6d8
2019-06-17Fix sql injection vulnerabilityDominik Orliński2-3/+8
Use a variable binding instead of concatenation. Change test 'getAppRolesForNonCentralizedPartnerAppTest'. Issue-ID: OJSI-174 Signed-off-by: Dominik Orliński <d.orlinski@samsung.com> Change-Id: I45895dc7665ff17394e602cbccf875e4e91b5ce1
2019-06-17Fix sql injection vulnerabilityDominik Orliński2-3/+12
Use a variable binding instead of concatenation. Change test 'getAppRolesForNonCentralizedPartnerAppTest'. Issue-ID: OJSI-174 Signed-off-by: Dominik Orliński <d.orlinski@samsung.com> Change-Id: I5cb7561e4b2b781834bd4f2ec36dee58b4738bf2
2019-06-14Merge "WidgetFileApp class DB constraints"Sunder Tattavarada1-56/+13
2019-06-14Merge "FavoritesFunctionalMenuItem class DB constraints"Sunder Tattavarada1-0/+3
2019-06-14Merge "WidgetCatalog class DB constraints"Sunder Tattavarada1-72/+21
2019-06-14Merge "Change default character to utf8 for portal db"Sunder Tattavarada2-2/+3
2019-06-14Merge "Sonar critical fixes in MicroserviceServiceImpl"Sunder Tattavarada1-0/+2
2019-06-14Merge "Sonar fix: make "dateFormat" an instance variable"Sunder Tattavarada8-83/+126
2019-06-14Merge "Sonar critical fixes in EPAppCommonServiceImpl"Sunder Tattavarada1-6/+7
2019-06-14Merge "RoleApp class DB constraints"Sunder Tattavarada3-126/+28
2019-06-14Merge "App class DB constraints"Sunder Tattavarada1-1/+9
2019-06-14Merge "FunctionalMenuItem DB constraints fix"Sunder Tattavarada2-8/+15
2019-06-14Merge "FunctionalMenuItem DB constraints add"Sunder Tattavarada2-13/+47
2019-06-14Merge "XSS Vulnerability fix in DashboardSearchResultController"Sunder Tattavarada2-11/+143
2019-06-14Merge "Custom data validator"Sunder Tattavarada3-3/+164
2019-06-14Merge "XSS Vulnerability fix in TicketEventController"Sunder Tattavarada2-1/+31
2019-06-14Merge "XSS Vulnerability fix in RoleManageController"Sunder Tattavarada3-1/+127
2019-06-14Merge "Fix sql injection vulnerability"Sunder Tattavarada2-3/+34
2019-06-14Merge "XSS Vulnerability fix in AppsOSController"Sunder Tattavarada2-3/+32
2019-06-14Merge "XSS Vulnerability fix in AppsControllerExternalRequest"Sunder Tattavarada8-30/+210