summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-06-21PeerBroadcastSocket sonar issues fix and code refactorDominik Mizyn1-39/+16
Sonar issues fix and code refactor. Session data save moved to another method. Rest of code don't really do anything. Issue-ID: PORTAL-624 Change-Id: I53b36377f2d2645d8c24ad2384959f0599e07303 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-21ONAPWelcomeController sonar issue fixDominik Mizyn1-11/+4
String viewName and getter/setter can be romoved from his class. ONAPWelcomeController Overrides this field 1 to 1. Issue-ID: PORTAL-652 Change-Id: Idbb41f52a63c6ea681f6ba7753991d766849e3a2 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-21ONAPLoginController sonar issues fix.Dominik Mizyn1-16/+21
Sonar issues fix plus @Autowired in constructor not in fields. Issue-ID: PORTAL-651 Change-Id: I99329b986877d040c6fdda9daf42a5c501a39605 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-21SimpleLoginStrategy sonar issues fixDominik Mizyn1-16/+18
"Either remove or fill this block of code." "Move the "" string literal on the left side of this string comparison." "Define and throw a dedicated exception instead of using a generic one." Issue-ID: PORTAL-650 Change-Id: I92018287a6f585020f0ae6f042b1bb1de84a5e14 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-21OpenIdConnectLoginStrategy sonar issues fixDominik Mizyn1-7/+4
Redundant suppression("rawtypes") removed. Sonar issue: Move the "" string literal on the left side of this string comparison. Define and throw a dedicated exception instead of using a generic one. Issue-ID: PORTAL-649 Change-Id: Ia2c80ad4848c22c94a2db731425250784d382841 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-18Merge "Fix sql injection vulnerability"Sunder Tattavarada2-4/+12
2019-06-18Merge "Fix sql injection vulnerability"Sunder Tattavarada2-3/+8
2019-06-18Merge "Fix sql injection vulnerability"Sunder Tattavarada2-3/+12
2019-06-18WebAnalyticsExtAppController sonar issuesDominik Mizyn2-62/+32
- Rename this local variable to match the regular expression - Make this anonymous inner class a lambda. - Immediately return this expression instead of assigning it to the temporary variable "response". - Move the "" string literal on the left side of this string comparison. - Replace the type specification in this constructor call with the diamond operator ("<>"). Issue-ID: PORTAL-648 Change-Id: I1666d94dccbbe8aa835ea9a443a9973a245353f4 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-18HealthMonitor sonar issuesDominik Mizyn2-124/+85
Remove this unused "numIntervalsClusterNotHealthy" local variable. Use "Long.parseLong" for this string-to-long conversion. Make the enclosing method "static" or remove this set. Change this instance-reference to a static reference. Remove the literal "false" boolean value. This block of commented-out lines of code should be removed. Add the "@Override" annotation above this method signature Issue-ID: PORTAL-647 Change-Id: I1880177f0906e6267807bbb9c0b7a81651e3c020 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-18EPLdapService sonar issue fixDominik Mizyn1-1/+1
Annotate the interface with the @FunctionalInterface annotation. Issue-ID: PORTAL-646 Change-Id: Idc6c70b9edaed73024721a3bc8c91796a0df9183 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-18AppWithRolesForUser sonar security issueDominik Mizyn5-85/+45
I used Lombok annotation to provide accessors. Issue-ID: PORTAL-645 Change-Id: Iad852434f30b81535398913df162fa8f4bd1ecff Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-17Merge "PortalAdminUserRole class DB constraints"Sunder Tattavarada1-0/+4
2019-06-17Merge "MicroserviceParameter class DB constraints"Sunder Tattavarada1-32/+13
2019-06-17Merge "MicroserviceDataApp class DB constraints"Sunder Tattavarada1-72/+26
2019-06-17Merge "Application Onboarding page changes "Lorraine Welch60-4442/+6550
2019-06-17Application Onboarding page changes Kotta, Shireesha (sk434m)60-4442/+6550
Issue-ID: PORTAL-644 Application Onboarding page changes , DB scripts Change-Id: Id689e15f5abd56192420e6761440659531108ab4 Signed-off-by: Kotta, Shireesha (sk434m) <sk434m@att.com>
2019-06-17Merge "Sonar: Reduce cyclomatic complexity"Sunder Tattavarada2-14/+31
2019-06-17Fix sql injection vulnerabilityDominik Orliński2-4/+12
Use a variable binding instead of concatenation. Change test 'getAppRolesForNonCentralizedPartnerAppTest'. Issue-ID: OJSI-174 Signed-off-by: Dominik Orliński <d.orlinski@samsung.com> Change-Id: I676ed349746cdabf320027dd27a0c16949fff6d8
2019-06-17Fix sql injection vulnerabilityDominik Orliński2-3/+8
Use a variable binding instead of concatenation. Change test 'getAppRolesForNonCentralizedPartnerAppTest'. Issue-ID: OJSI-174 Signed-off-by: Dominik Orliński <d.orlinski@samsung.com> Change-Id: I45895dc7665ff17394e602cbccf875e4e91b5ce1
2019-06-17Fix sql injection vulnerabilityDominik Orliński2-3/+12
Use a variable binding instead of concatenation. Change test 'getAppRolesForNonCentralizedPartnerAppTest'. Issue-ID: OJSI-174 Signed-off-by: Dominik Orliński <d.orlinski@samsung.com> Change-Id: I5cb7561e4b2b781834bd4f2ec36dee58b4738bf2
2019-06-14Merge "WidgetFileApp class DB constraints"Sunder Tattavarada1-56/+13
2019-06-14Merge "FavoritesFunctionalMenuItem class DB constraints"Sunder Tattavarada1-0/+3
2019-06-14Merge "WidgetCatalog class DB constraints"Sunder Tattavarada1-72/+21
2019-06-14Merge "Change default character to utf8 for portal db"Sunder Tattavarada2-2/+3
2019-06-14Merge "Sonar critical fixes in MicroserviceServiceImpl"Sunder Tattavarada1-0/+2
2019-06-14Merge "Sonar fix: make "dateFormat" an instance variable"Sunder Tattavarada8-83/+126
2019-06-14Merge "Sonar critical fixes in EPAppCommonServiceImpl"Sunder Tattavarada1-6/+7
2019-06-14Merge "RoleApp class DB constraints"Sunder Tattavarada3-126/+28
2019-06-14Merge "App class DB constraints"Sunder Tattavarada1-1/+9
2019-06-14Merge "FunctionalMenuItem DB constraints fix"Sunder Tattavarada2-8/+15
2019-06-14Merge "FunctionalMenuItem DB constraints add"Sunder Tattavarada2-13/+47
2019-06-14Merge "XSS Vulnerability fix in DashboardSearchResultController"Sunder Tattavarada2-11/+143
2019-06-14Merge "Custom data validator"Sunder Tattavarada3-3/+164
2019-06-14Merge "XSS Vulnerability fix in TicketEventController"Sunder Tattavarada2-1/+31
2019-06-14Merge "XSS Vulnerability fix in RoleManageController"Sunder Tattavarada3-1/+127
2019-06-14Merge "Fix sql injection vulnerability"Sunder Tattavarada2-3/+34
2019-06-14Merge "XSS Vulnerability fix in AppsOSController"Sunder Tattavarada2-3/+32
2019-06-14Merge "XSS Vulnerability fix in AppsControllerExternalRequest"Sunder Tattavarada8-30/+210
2019-06-14Merge "Sonar issue: Correct this "&" to "&&" in MicroserviceServiceImpl"Sunder Tattavarada1-25/+22
2019-06-14Merge "XSS Vulnerability fix in MicroserviceController"Sunder Tattavarada4-67/+112
2019-06-14Merge "XSS Vulnerability fix in DashboardSearchResultController"Sunder Tattavarada6-58/+270
2019-06-14PortalAdminUserRole class DB constraintsDominik Mizyn1-0/+4
Java Bean Validation SR 380 annotations added to classes Issue-ID: PORTAL-636 Change-Id: I8fb4f50e672e17b9e169303eb09255fe57288b45 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-14MicroserviceParameter class DB constraintsDominik Mizyn1-32/+13
Java Bean Validation SR 380 annotations added to classes Issue-ID: PORTAL-635 Change-Id: Idcca0d46d1779d5fae874aff38cfd7f59f73c9b0 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-14MicroserviceDataApp class DB constraintsDominik Mizyn1-72/+26
Java Bean Validation SR 380 annotations added to classes Issue-ID: PORTAL-634 Change-Id: Ife3b0116b986d52fd17612937b2a74fa76062ed9 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-14WidgetFileApp class DB constraintsDominik Mizyn1-56/+13
Java Bean Validation SR 380 annotations added to classes Issue-ID: PORTAL-633 Change-Id: Id7b45dedafe2e5f9e799a93d219baef46c88d124 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-14FavoritesFunctionalMenuItem class DB constraintsDominik Mizyn1-0/+3
Java Bean Validation SR 380 annotations added to classes Issue-ID: PORTAL-632 Change-Id: Ia7c2f4ad0aa5cc85db73142d0fecd46da535c3d9 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-13Merge "Fix sonar issue: Override "equals(Object obj)""Sunder Tattavarada2-1/+27
2019-06-13WidgetCatalog class DB constraintsDominik Mizyn1-72/+21
Java Bean Validation SR 380 annotations added to classes Plains getter/setter converted to lombok annotation Issue-ID: PORTAL-630 Change-Id: Id866ec4bc0dc428adfbb7cdc64fe15f7faf837f7 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
2019-06-13RoleApp class DB constraintsDominik Mizyn3-126/+28
Java Bean Validation SR 380 annotations added to classes Lombod added to widget-ms Plains getter/setter converted to lombok annotation Issue-ID: PORTAL-629 Change-Id: I31639672510994412149ed8be92cb8e1b022f646 Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>