diff options
| author |   r.bogacki <r.bogacki@samsung.com> | 2019-05-22 12:27:53 +0200 |
|---|---|---|
| committer |   Krzysztof Opasiak <k.opasiak@samsung.com> | 2019-05-28 12:52:07 +0200 |
| commit | f9a1944a4b3cda8d9708087902a52baa40c0e2ea (patch) | |
| tree | f9c64b2bbdb124f0c0acea0b13c86ba3ae8d85ef /ecomp-portal-FE-os/client | |
| parent | 5260297bb0fdd7ca1640b45a4c9b96b7fd158a1e (diff) | |
Removed user password from portal's profile API
ONAP Portal allowed to retrieve password of currently active user via
"/portalApi/loggedinUser" endpoint. Prefilled "Login Password" field
has been changed to "*****" and password is not send anymore to the
frontend. Only after change of this default value
password will be updated. Confirm Password field has been removed
from the UI. In the future password change could be additionally also
checked on the backend side to verify current password
before updating it.
Issue-ID: OJSI-65
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Reviewed-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Acked-by: Manoop Talasila <talasila@research.att.com>
Change-Id: I00b7713557247d211927c437f31f118095ad0726
Diffstat (limited to 'ecomp-portal-FE-os/client')
2 files changed, 1 insertions, 11 deletions
diff --git a/ecomp-portal-FE-os/client/src/views/header/profile-edit-dialogs/profile-edit.controller.js b/ecomp-portal-FE-os/client/src/views/header/profile-edit-dialogs/profile-edit.controller.js index 385697fa..597f9b37 100644 --- a/ecomp-portal-FE-os/client/src/views/header/profile-edit-dialogs/profile-edit.controller.js +++ b/ecomp-portal-FE-os/client/src/views/header/profile-edit-dialogs/profile-edit.controller.js @@ -45,7 +45,6 @@ this.email =''; this.loginId =''; this.loginPwd =''; - this.confirmLoginPwd='' this.isLoading = false; let getUser = () => { this.isLoading = true; @@ -75,14 +74,10 @@ loginId :this.loginId, loginPassword :this.loginPwd } - if (this.firstName =='' || this.lastName == '' || this.email == '' || this.loginId =='' || this.loginPwd ==''|| this.confirmLoginPwd ==''){ + if (this.firstName =='' || this.lastName == '' || this.email == '' || this.loginId =='' || this.loginPwd ==''){ var warningMsg = "Please enter a value for all fields marked with *."; confirmBoxService.showInformation(warningMsg).then(isConfirmed => {return;}); return; - } else if (this.loginPwd != this.confirmLoginPwd) { - var warningMsg = "Passwords do not match, please try again."; - confirmBoxService.showInformation(warningMsg).then(isConfirmed => {return;}); - return; } else { // check password length complexity. var warningMsg = adminsService.isComplexPassword(this.loginPwd); diff --git a/ecomp-portal-FE-os/client/src/views/header/profile-edit-dialogs/profile-edit.modal.html b/ecomp-portal-FE-os/client/src/views/header/profile-edit-dialogs/profile-edit.modal.html index 79c85a18..2ccb03c6 100644 --- a/ecomp-portal-FE-os/client/src/views/header/profile-edit-dialogs/profile-edit.modal.html +++ b/ecomp-portal-FE-os/client/src/views/header/profile-edit-dialogs/profile-edit.modal.html @@ -67,11 +67,6 @@ <div class="">*Login Password</div> <input type="password" ng-model="profileDetail.loginPwd" /> </div> - <div class="profile-edit-div"> - <div class="">*Confirm Login Password</div> - <input type="password" - ng-model="profileDetail.confirmLoginPwd" /> - </div> </div> </div> <div class="dialog-control"> |