summaryrefslogtreecommitdiffstats
path: root/ecomp-portal-BE-common
diff options
context:
space:
mode:
authorSunder Tattavarada <statta@research.att.com>2020-04-29 19:39:33 +0000
committerGerrit Code Review <gerrit@onap.org>2020-04-29 19:39:33 +0000
commit884a4ec238b7ef68e209addea9890d9c166cb702 (patch)
treed58e6d2520593561e610aac680650c81b6653a03 /ecomp-portal-BE-common
parent013c0393a92ef0c1475a97a112a78cd9ff1b5fc4 (diff)
parent1581eace8ad6ec086c20d55034462dbf5010699e (diff)
Merge "Sonar - Major blocker issue fix"
Diffstat (limited to 'ecomp-portal-BE-common')
-rw-r--r--ecomp-portal-BE-common/src/main/java/org/onap/portalapp/portal/controller/RolesApprovalSystemController.java4
1 files changed, 2 insertions, 2 deletions
diff --git a/ecomp-portal-BE-common/src/main/java/org/onap/portalapp/portal/controller/RolesApprovalSystemController.java b/ecomp-portal-BE-common/src/main/java/org/onap/portalapp/portal/controller/RolesApprovalSystemController.java
index 5562caac..487cc4d5 100644
--- a/ecomp-portal-BE-common/src/main/java/org/onap/portalapp/portal/controller/RolesApprovalSystemController.java
+++ b/ecomp-portal-BE-common/src/main/java/org/onap/portalapp/portal/controller/RolesApprovalSystemController.java
@@ -219,9 +219,9 @@ public class RolesApprovalSystemController implements BasicAuthenticationControl
* If any field is missing.
*/
private void validateExtSystemUser(ExternalSystemUser extSysUser, boolean rolesRequired) throws Exception {
- if (extSysUser.getLoginId() == null || extSysUser.getLoginId() == "")
+ if (extSysUser.getLoginId() == null || extSysUser.getLoginId().equals(""))
throw new Exception("Request has no login ID");
- if (extSysUser.getApplicationName() == null || extSysUser.getApplicationName() == "")
+ if (extSysUser.getApplicationName() == null || extSysUser.getApplicationName().equals(""))
throw new Exception("Request has no application name");
if (extSysUser.getMyloginrequestId() == null)
throw new Exception("Request has no request ID");