Age | Commit message (Collapse) | Author | Files | Lines |
|
Issue-ID: POLICY-2695
Change-Id: I7be4fdd72aad0ab794a0d5a6919afec5998dad09
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Replaced try/catch blocks in policy/xacml-pdp with assertj assertions
Issue-ID: POLICY-2451
Change-Id: I3e6947a61e0000561c7053a1cdede9ae5825e5ca
Signed-off-by: waynedunican <wayne.dunican@est.tech>
|
|
Somehow missed this sonar issue in one line of code:
- invoke only one method in a junit lambda
Issue-ID: POLICY-2681
Change-Id: I03a6708e0d3ed2a43577a63d0f3cdfc9bd76c8d8
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Addressed issues reported due to updates to the sonar rules:
- invoke only one method in a junit lambda
- complete the assertion
- use assertThat().exists(), canRead(), etc.
Issue-ID: POLICY-2681
Change-Id: I2935f4d0295244ab3b11a57a3bc401c64b695fd1
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2188
Change-Id: I64a115240a71e5014db9cfb66747887e156afb50
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
|
|
Deleted Dbao and replaced it with the shared class in policy-models.
Also had to update the queries and the persistence.xml accordingly.
Issue-ID: POLICY-2581
Change-Id: I59dfa2f37c272796ccebc0f578c9f4e8e1b9c8ab
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
The default provider has been changed to gson, so the provider property
no longer has to be set.
Issue-ID: POLICY-1527
Change-Id: I21f5a3af2bc1d7fc10dc41f58e6e62a04f4bda77
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
Change the CLC policy logic to match the udpate Operations History DB
rules. Now if a record has outcome = Started, it is considered
to be in progress. Else it is considered to be complete.
Issue-ID: POLICY-2583
Change-Id: If3f626bfec2d0656e43a26929107f68ff27af020
Signed-off-by: pramod.jamkhedkar <pramod@research.att.com>
|
|
Queries to the operationshistory table will degrade substantially
as more records are added to the DB.
The Dbao class should be moved to policy-models, but for now
we'll just update it in both places (i.e., drools-apps and xacml-pdp).
Issue-ID: POLICY-2581
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: Icc4529e56968ceda4d9b63a8ccea6ba219250506
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Change-Id: I4e2a3a7a89eb3e59111c0a2bff70624d9f987abb
Issue-ID: POLICY-2514
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Change-Id: I753851b22200de1f69489d13a283832c469fab22
Issue-ID: POLICY-2514
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Changed the path of coordination directive by removing src/main/resources
Issue-ID: POLICY-2573
Change-Id: I46613e50ef464e0a61e0f177008520575c391c00
Signed-off-by: pramod.jamkhedkar <pramod@research.att.com>
|
|
Issue-ID: POLICY-2573
Change-Id: I0fd392cb7027c56bb8fd4a6d9a0b3fd558dba495
Signed-off-by: pramod.jamkhedkar <pramod@research.att.com>
|
|
Change CLC granularity from target level to CL level. Remove the target
matching for the db query at PIP level.
Issue-ID: POLICY-2573
Change-Id: If9ba1a4d22c3b8bc5dfce0632f7037ad085f6ea6
Signed-off-by: pramod.jamkhedkar <pramod@research.att.com>
|
|
The last change wasn't quite right, this has multiple AndOf's under
a single AnyOf. Multiple AnyOf's are treated as AND's, but what we
really want is a set of OR's.
Issue-ID: POLICY-2490
Change-Id: I7336643302ccf7982c91a9c082d17bcf0adb4ac8
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Per this review: https://gerrit.onap.org/r/c/policy/models/+/107250
Issue-ID: POLICY-2538
Change-Id: I0b7711c1adc73295092996cd3a1ec7979fd2b4ba
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2378
Change-Id: I542884aed2acbef7e1c7e431f209ea61108e2048
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
The blacklist entries should be treated as an or (AnyOf) vs
an and (AllOf).
Issue-ID: POLICY-2490
Change-Id: Id4eb823e18c59d84d4ca28b13f6a09794d36365f
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Use policy/common map double converter to ensure integers saved
in policy content do not get converted to doubles.
Issue-ID: POLICY-2486
Change-Id: I887c6b5c337e2594c425b645af4b2668d06715bd
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
To support 5G slicing use cases, we will support any policy type
that derives from onap.policies.optimization
Similar in functionality to monitoring
Issue-ID: POLICY-2460
Change-Id: I48b071a64b917cea44eb64149539875ba33e2ef5
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2378
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I819c9a356ca09e9baf75662bb6cd574540f41206
|
|
Minor fix to use "operation" vs "recipe" in the guard
request.
parent, common and models are released.
Issue-ID: POLICY-2378
Change-Id: I4c5005c08fef2e184ce2dccefdef0c2c2ea2dc08
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
The XACML github was released with a new method to allow
context factories and PIP engines to release any handles
before releasing the PDP engine. This review includes
that artifact and adds tests to support it.
In addition, added more tests to get code coverage over
90% for both PIPs in ONAP.
Some cleanup in the Matchable types based on last review.
Issue-ID: POLICY-2242
Change-Id: I312f06380ff4d2e16bcfd25b6d1f36ce5dd030e6
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
This solution is much cleaner than what is in StdMatchableTranslator.
Over 90% code coverage on it - utilizes a callback to retrieve DataType
and PolicyTypes. Support for missing timestamp TOSCA type. Also can
do a better job differentiating between a property contained in the policy
vs a schema.
Changed StdMatchableTranslator to utilize these classes. And removed the
old spaghetti.
Added some JUnit coverage for ToscaPolicyTranslatorUtils.
Removed duplicate code in the XACML Native Exception classes.
Issue-ID: POLICY-2242
Change-Id: I18f898d9e65f6da28e3b27517d40f8d389de18a0
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Adds support for PolicySetType specifically for Native policies. When/If
the other applications change to support they can easily do so.
Adding some more code coverage for Native application and translator.
Issue-ID: POLICY-2433
Change-Id: I463ca9f04928d759624a2176598b463057d386bd
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Fix spelling error and add code cover >95% for the
XacmlPolicyUtils.
Issue-ID: POLICY-2242
Change-Id: I21f239e6bd42073ff84883d04f2b8bee1466b8e0
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Throw exceptions when requests cannot be created and return
error information back. Consolidated some code to avoid sonar
duplication issues.
Companion review to https://gerrit.onap.org/r/c/policy/models/+/103548
Issue-ID: POLICY-2242
Change-Id: Ic873af933dab82e3aeef6335f55939666be20385
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
These did not show up locally - sonarqube must have a new
version or rules to pick these up.
Issue-ID: POLICY-2242
Change-Id: I3df5aee84f696cde6b07c68913bbd55e95c8ba3b
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Removed duplicate code from operations history classes.
added code coverage to other classes.
cleared sonar in main for args
Issue-ID: POLICY-2242
Change-Id: Ief548c96a180c132a3f17681d9cbc018c62e42ac
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Cleaned up some code to remove unnecessary branches. Add more
test cases specifically for query parameters.
Coverage should be above 90% for this repo.
Issue-ID: POLICY-2242
Change-Id: I20a75aacd75f9b8c87abb47e88b81ab8f2d30626
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Fix a NPE bug and add more code coverage.
Also is missing returning of context details for subscriber policies.
This code is a bit ad-hoc and there is a separate JIRA POLICY-2147 to
support re-factoring this codebase.
Added scanning for advice to be returned. For optimization, because of
the need for some changes in XACML github dependency, we are stuck with
a little narly code to get it to fully work. POLICY-2417 is created to
address this in Guilen.
Upgraded to released XACML artifact - this has been tested locally for
a few weeks with naming, guard and this optimzation code. It removed
Jackson in lieu of Json, cleaned up some security fixes, upgraded
dependencies, and added more code coverage.
Issue-ID: POLICY-2066
Change-Id: I3cae99de265c815200ec2ce71e471338772bdb5b
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Because the new TOSCA compliant policy types support required
fields, we can simplify the guard translator to utilize Match
in the target vs the previous complicated Condition usage.
Added test coverage to bump above 90% specifically for the
guard and coordination code.
Added a sonar exclusion for the test module.
Issue-ID: POLICY-2244
Change-Id: Ia90d117bd7b86d28a2268fd5ab8315dce7bf0c12
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2182
Change-Id: Ife38e989aeda445c9fc2531bb92426f2d28bb818
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
|
|
Added a new native application to the service loader framework
Added a new translator for the native application
Added custom serialization providers for xacml+json and xacml+xml
Added a new endpoint for native xacml decision api
Added a new api provider function to handle the native xacml api calls
Added corresponding junit tests
Issue-ID: POLICY-2182
Change-Id: I30fa4637612c324d543f9952386cf1a27a52d76c
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
Added policies for SON and PCI to support each blocking the other, with test cases and appropriate requests
Issue-ID: POLICY-2163
Change-Id: I8153f9cd973a7cd6824fcd6c9787628a74148d46
Signed-off-by: pramod.jamkhedkar <pramod@research.att.com>
|
|
To keep in step with policy/parent upgrades.
Issue-ID: POLICY-2381
Change-Id: Ic25821bcf410e2fdf261abd155eb21030c509aa1
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
With the new changes to models/api, the full policy template will
be retrieved along with inherited policy types and datatypes.
Changed api caller to return tosca template instead of individual
policy type so all policy types and data types are available.
Changed stdmatchabletranslator to be able to flexibly go deep with
list/map of datatypes of attributes. NOTE: This should be re-factored
at a later date as its a bit messy.
The naming application was used to test this code, but it was determined
by the CCSDK team that they will not do filtering this release. Instead,
switched to combined results policy type to return the full policy type.
Issue-ID: POLICY-1740
Change-Id: Ieb4e46e7fb2c639a1155be3bc07f5587c4f7b09a
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Sub-modules under sub-modules need to set the path to
ensure a single jacoco-ut.exec file is produced and
appended to.
This doesn't seem to affect the results, but I'd like
to be consistent.
Issue-ID: POLICY-2321
Change-Id: Ia2223df55ce0f4be6e81fa61bf7df711e12ad760
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-1596
Change-Id: I00164ea17eb9d547b45c01e5f46f7aaf0f9a25e2
Signed-off-by: HOCKLA <ah999m@att.com>
|
|
Adding support for a preliminary request to pull subscriber details.
The returned decision adds scope attributes for the original request.
Fixed some checkstyle issues due to new checkstyle requirements.
Issue-ID: POLICY-2066
Change-Id: Ief02d896ce33e4864bb20e9185b0d0f5eb254bfd
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Requires changes to StdMatchableTranslator to go deeper when
searching for matchable attributes.
NOTE: will re-visit the StdMatchableTranslator at a later date
in order to support more robust Policy Types. And document best
practices for defining matchables.
Issue-ID: POLICY-1740
Change-Id: I291cf1c2e6eba0a677a3312dd11f0e56178a805b
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Companion review to https://gerrit.onap.org/r/c/policy/models/+/99288
The policy types for optimization were refactored, so the xacml
optimization application tests need to accomodate that.
Issue-ID: POLICY-2066
Change-Id: Ibc03b0652e771175a2fa38f5c3a3d81c7e371147
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Missing assertions in JUnit test cases.
Use replace vs replaceAll
Swapping arguments
Issue-ID: POLICY-2079
Change-Id: I5accd462eab3d4f6b3321e375d4ba1084caf4b8c
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
|
|
Issue-ID: POLICY-2223
Change-Id: I1a7a1b4083ff74ca86455e1ab6ae7f96b8c04d35
Signed-off-by: Ali Hockla <ah999m@att.com>
|
|
|
|
Needed to add more obligations, which make it easier to
scan through obligations and be able to pull information
about the policy.
Adding weight as an obligation for Optimization policies in
order to implement "closest match" algorithm.
Moved Obligation to a support class.
Added JUnit code coverage on the translator classes.
Split some methods up to reduce complexity via sonar.
Issue-ID: POLICY-2066
Change-Id: Ibb13d2dc0a63ab2a6d585b0697a0c1d129fa8f7b
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|