Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
Issue-ID: POLICY-3696
Change-Id: If5e83b9ab94f62fa8063e565f9dd1daf8d9880b2
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-3696
Change-Id: I892219ee37f689eaa250142d0a1e6610a8b227ff
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-3587
Change-Id: I4e912da513ba8ecaf4bdc71659b7b273c0aaab05
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
|
|
Adds new method to return attributes in a decision, which
can be configurable.
By default it is turned off which ensures that the current
functionality is maintained for our client applications.
Enhanced the JUnits for the applications to ensure that no
extra information is passed, thus maintaining backward
compatibility.
Issue-ID: POLICY-2865
Change-Id: Ia533e5462c0cb475cb1f72f34e95f128d6c52678
Signed-off-by: Pamela Dragosh <pd1248@att.com>
|
|
Replaced generic BusTopicParams with more specific RestClientParameters.
Also modified code to pass the HttpClient around instead of passing the
client parameters around.
Issue-ID: POLICY-3456
Change-Id: Ic07b710645eeab696e6df0a015171578ad08ca83
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Adds the exclusions parameter to exclude applications
that are in the java classpath. This allows overriding
default packaged applications with another that can
support new policy types and/or modify existing
functionality.
Issue-ID: POLICY-3326
Change-Id: Iaad8d26fc4122ad17226ad1e83b72c9f284e6ebd
Signed-off-by: Pamela Dragosh <pd1248@att.com>
|
|
Also:
- changed a few fields to private/protected.
- swwapped out gson for coder
Issue-ID: POLICY-3400
Change-Id: I9a4dba939b77078f78583ada00af182b1a7d95c5
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Application and common code in xacml-pdp is meant to be
available for developers to re-use and/or extend as desired.
Private methods are unnecessary at this time, but could be
re-visited in a later release.
For Honolulu, simply moving to protected to keep functionality
the same. Possibly for Istanbul we can make more changes to
support mixing of ONAP application with custom applications
during runtime.
Issue-ID: POLICY-3305
Change-Id: I6db23bda3c81fdbbf86e39cc2cd2e706d8bee63d
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
(cherry picked from commit 8e0aa0ffa5cef537de1c841acf38300832c52a56)
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
The new version of checkstyle identified new issues. Fixed those.
Issue-ID: POLICY-3288
Change-Id: I334e9eb67c9270c4e53b2fb34e576b8bfbf8ec8b
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Fixed sonars:
- use "var"
Issue-ID: POLICY-3288
Change-Id: If4f685e0d645f6d6fbdd2cdb86c6b67336f6839a
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Now that the bean validator uses the serialized field name in its error
messages, updated the junits to use the serialized names, too.
Issue-ID: POLICY-3333
Change-Id: I017aa654480baef06f2869116d4b5264bb32c721
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Instead of having code to validate various values, created POJOs to
represent the decoded data so that bean validation annotations could be
used instead.
Didn't see any obvious ways to use annotations in the Optimization code,
but did notice a bug (passed role instead of provisions). Extracted a
common method which fixed the bug as a side-effect.
Issue-ID: POLICY-2418
Change-Id: I9ef589086fc8f7f66810b66405fbf302d7570e5a
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Fixed:
- use "var" instead of actual type
Issue-ID: POLICY-3285
Change-Id: Id17142d1f2e3e5f9dfbffcb96aff7fe76321a56b
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
HTTP client parameters should be based on BusTopicParams instead of
RestServerParameters, modified the policyApiParameters.
Issue-ID: POLICY-3147
Change-Id: I73aa34bec3ab7e27e7a3474260f411ed55b6f933
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-3126
Change-Id: Ic20b00aa1f2eaac0272792809a059a851bfbfffc
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-3105
Change-Id: I9fd03ff6a405b127c1eabbfe301f3b9ea8327aad
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-3127
Change-Id: I586fc25f730b708d047999706fd74d6b965bb130
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-3088
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I42c32bbb1ef6e275b8b3a0693492c7e4e61dd6eb
|
|
Windows doesn't like file names containing ":". Added code to replace
":" with "_", but only when the JVM is run on a Windows OS.
Issue-ID: POLICY-3085
Change-Id: I1d3b6819bf564571eddda69e4c5fbd2bb807a3aa
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Fix a couple of sonars introduced by the PdpType review.
Also creation of a target directory below the xacml-pdp directory.
Issue-ID: POLICY-3071
Change-Id: I9fe325d0a75970fbe3d42be36906013c1fc2ecb9
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Switched to using the new Time Extensions released in XACML
from github v3.0. Added more thorough tests for it as well as
the flexibility of specifying the current time etc.
More syntax checking on the inputs from the policy.
Issue-ID: POLICY-2810
Change-Id: I1b4ec885c706e37949e5dabe14c63b0d7456cd4f
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
The category is wrong, and will not work. So fixing this bug first before
working in the changes for use new Time Extensions. I may make it all configurable.
Issue-ID: POLICY-2810
Change-Id: I4a338242dd4ec35f9b45fa1f46609dea93e286a1
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
The dependency upgrades in policy-parent caused some new sonars. In
particular, initMocks() has been deprecated - replaced with calls to the
Mockito Runner. Also removed unnecessary when() calls.
Issue-ID: POLICY-2912
Change-Id: If386bd282635067a20045f2626af0cf5be49bc0e
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Updated properties to work with the new version of eclipselink.
Issue-ID: POLICY-3005
Change-Id: I88091a90387e235ef5c168de7a3275056327d83e
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Point to the newly release 3.0, which is JDK11 compatible and
contains the latest time extensions. Simple ensuring that nothing
is broken on our end.
Issue-ID: POLICY-2810
Change-Id: Ic2fed1b57574ebd1b9eaaa19c19578a42ade5483
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
The policy models tosca classes ToscaPolicyIdentifier and
ToscaPolicyIdentifierOptVersion can be used to identify any TOSCA
concept, not just TOSCA policies so they are renamed to
ToscaConceptIdentifier and ToscaCinceptIdentifierOptVersion
respectively.
The class ToscaPolicyTypeIdentifier is redundant and is replaced by
ToscaConceptIdentifier.
Issue-ID: POLICY-2900
Change-Id: Id614bbed34ed8897e7e882b70147b98ffe90bf57
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Eclipse generates java errors if a package name contains "native" as a
component OR if the path to a java source file contains "native".
Renamed the "native" directories back to "nativ" to fix the errors.
Issue-ID: POLICY-2900
Change-Id: Id718e69ae59e8fdbad72ad42347264766312a5ad
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
xacml-pdp expects the property map to exist in all policies, even if it
is sometimes empty. Now, the propperty map can be null. The code is
updated to cope with a null property map.
Issue-ID: POLICY-2900
Change-Id: Ie31a2770aff1435a1d1064512d0c2fa2088d3183
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
S5993 Change the visibility of this constructor to "protected".
Issue-ID: POLICY-2912
Change-Id: I2fd9fcd3162c8bf28ba0315939ef259356f442db
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
The TOSCA class ToscaEntityType is renamed to ToscaSchemaDefinition
becasue keys as well as entities can have schemas, so the class has more
usages than just for entity schemas.
Issue-ID: POLICY-2900
Change-Id: I7a1a3a1262078c47eeea1820538ecb6153f5e652
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Bumping minor version now that guilin branch has been created.
Also repointed to snapshot versions for dependencies.
Issue-ID: POLICY-2875
Change-Id: I145f638d6409f92cf916b08ace10a159d5e52c73
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2869
Change-Id: If8e944fce44ca0b613da9f92f4516049994fff86
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2839
Change-Id: I78bf1cebb31c3c3c48d214fa755892b9a3a58323
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Initially, just moving the applicationName and actions as protected
fields got rid of the sonar issue. I included also the supportedPolicyTypes
also. But that triggered another sonar duplicate code, so I had to rename
a few private fields to rid that. Seems like a very sensitive sonar detection
that results in kludgy code.
Issue-ID: POLICY-2681
Change-Id: Ie79a95786cdb80381cbce4b182e9e66a2776e0dd
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Addressed the following sonar issues:
- extract common test method
- too many assertions in a test method
Issue-ID: POLICY-2681
Change-Id: I7438be8286d52cd8479c66542fc785b27448972b
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Changed the artifact IDs of the xacml-pdp applications so they won't
clash with other jar file names.
Issue-ID: POLICY-2848
Change-Id: I844aaf6b2c4d81e52716d840b3a784873c6ce121
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2550
Change-Id: I05d9af99401991ea867e7ab8d697692c9020b3b7
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Issue-ID: POLICY-2789
Change-Id: I3f2c877874e5fbcd0520b811c984fa8d14b05435
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Add new generic match application to XACML PDP. This app
will allow ONAP users to design their own matchable policy
types and use StdMatchableTranslator out-of-the box without
any modification. Fills the gap left behind since "configure"
via the Monitoring can support StdCombinedResultsTranslator,
but the Optimization policy types have a specific "closest
match" algorithm tied to them. Gives flexibility.
removed unused import
Issue-ID: POLICY-2596
Change-Id: I0aebae706fb9634e7bb13d78eff0ccc1ae4d752f
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Actually, this does not need to have any specific monitoring
policy type designated because since Frankfurt we added the
feature to support onap.monitoring.*
Issue-ID: POLICY-2772
Change-Id: Ief24550c3e90b7a54ad3c1c381330580ca738798
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Fixing too much complexity for GuardPolicyRequest by breaking
it up into methods.
Added more code coverage to guard translator.
Added missing code coverage for coordination guard, it was below
66% and there were some trivial fixes that were needed. Seems that
a test resource was never really used, or perhaps got omitted in a
previous review.
Issue-ID: POLICY-2590
Change-Id: I1be4ff166e6c43c1c4ea54fdf7e761e22adcaa2d
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
* Added new Policy Guard filter Policy type.
* Enhanced translator tests to ensure bad filter policies
are detected.
* Added new filter application test to ensure new guard
propertly creates xacml policies.
Issue-ID: POLICY-2590
Change-Id: Ifc047a33084ce45b67be98a61f660d7a8c9d8615
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2695
Change-Id: I7be4fdd72aad0ab794a0d5a6919afec5998dad09
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Replaced try/catch blocks in policy/xacml-pdp with assertj assertions
Issue-ID: POLICY-2451
Change-Id: I3e6947a61e0000561c7053a1cdede9ae5825e5ca
Signed-off-by: waynedunican <wayne.dunican@est.tech>
|
|
Somehow missed this sonar issue in one line of code:
- invoke only one method in a junit lambda
Issue-ID: POLICY-2681
Change-Id: I03a6708e0d3ed2a43577a63d0f3cdfc9bd76c8d8
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Addressed issues reported due to updates to the sonar rules:
- invoke only one method in a junit lambda
- complete the assertion
- use assertThat().exists(), canRead(), etc.
Issue-ID: POLICY-2681
Change-Id: I2935f4d0295244ab3b11a57a3bc401c64b695fd1
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2188
Change-Id: I64a115240a71e5014db9cfb66747887e156afb50
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
|