Age | Commit message (Collapse) | Author | Files | Lines |
|
Issue-ID: POLICY-2869
Change-Id: If8e944fce44ca0b613da9f92f4516049994fff86
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2839
Change-Id: I78bf1cebb31c3c3c48d214fa755892b9a3a58323
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Initially, just moving the applicationName and actions as protected
fields got rid of the sonar issue. I included also the supportedPolicyTypes
also. But that triggered another sonar duplicate code, so I had to rename
a few private fields to rid that. Seems like a very sensitive sonar detection
that results in kludgy code.
Issue-ID: POLICY-2681
Change-Id: Ie79a95786cdb80381cbce4b182e9e66a2776e0dd
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Changed the artifact IDs of the xacml-pdp applications so they won't
clash with other jar file names.
Issue-ID: POLICY-2848
Change-Id: I844aaf6b2c4d81e52716d840b3a784873c6ce121
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2789
Change-Id: I3f2c877874e5fbcd0520b811c984fa8d14b05435
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Actually, this does not need to have any specific monitoring
policy type designated because since Frankfurt we added the
feature to support onap.monitoring.*
Issue-ID: POLICY-2772
Change-Id: Ief24550c3e90b7a54ad3c1c381330580ca738798
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2695
Change-Id: I7be4fdd72aad0ab794a0d5a6919afec5998dad09
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Addressed issues reported due to updates to the sonar rules:
- invoke only one method in a junit lambda
- complete the assertion
- use assertThat().exists(), canRead(), etc.
Issue-ID: POLICY-2681
Change-Id: I2935f4d0295244ab3b11a57a3bc401c64b695fd1
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2188
Change-Id: I64a115240a71e5014db9cfb66747887e156afb50
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
Change-Id: I4e2a3a7a89eb3e59111c0a2bff70624d9f987abb
Issue-ID: POLICY-2514
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Change-Id: I753851b22200de1f69489d13a283832c469fab22
Issue-ID: POLICY-2514
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Per this review: https://gerrit.onap.org/r/c/policy/models/+/107250
Issue-ID: POLICY-2538
Change-Id: I0b7711c1adc73295092996cd3a1ec7979fd2b4ba
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2378
Change-Id: I542884aed2acbef7e1c7e431f209ea61108e2048
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2378
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I819c9a356ca09e9baf75662bb6cd574540f41206
|
|
Throw exceptions when requests cannot be created and return
error information back. Consolidated some code to avoid sonar
duplication issues.
Companion review to https://gerrit.onap.org/r/c/policy/models/+/103548
Issue-ID: POLICY-2242
Change-Id: Ic873af933dab82e3aeef6335f55939666be20385
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Cleaned up some code to remove unnecessary branches. Add more
test cases specifically for query parameters.
Coverage should be above 90% for this repo.
Issue-ID: POLICY-2242
Change-Id: I20a75aacd75f9b8c87abb47e88b81ab8f2d30626
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
To keep in step with policy/parent upgrades.
Issue-ID: POLICY-2381
Change-Id: Ic25821bcf410e2fdf261abd155eb21030c509aa1
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-1596
Change-Id: I00164ea17eb9d547b45c01e5f46f7aaf0f9a25e2
Signed-off-by: HOCKLA <ah999m@att.com>
|
|
Issue-ID: POLICY-2223
Change-Id: I1a7a1b4083ff74ca86455e1ab6ae7f96b8c04d35
Signed-off-by: Ali Hockla <ah999m@att.com>
|
|
|
|
Issue-ID: POLICY-2126
Change-Id: I2a4907bb61651d9cfe2793e69404d9ccbe41ccd8
Signed-off-by: HOCKLA <ah999m@att.com>
|
|
There is duplicate code for some common translation of policy
decision responses and for scanning obligations.
Removed some TODO items (left others because I want to look
at them more closely).
Stored System.lineSeparator into a static var so that I can
remove some unnecessary ifs. There's still one left that I
am not worried about.
Gson as a static variable.
Issue-ID: POLICY-2066
Change-Id: I9c8162d5ad1c5f884be347dd94631fa74ca76f85
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
decision results
Issue-ID: POLICY-2126
Change-Id: I18d50a8746ede792ec9507ab98125383c5914ba1
Signed-off-by: HOCKLA <ah999m@att.com>
|
|
Issue-ID: POLICY-2090
Change-Id: Id688e305f878f56e374e6bd9047d9d6c75fbe0c6
Signed-off-by: Ali Hockla <ah999m@att.com>
|
|
Change-Id: I6ca46b3bbc9529c6fef5a332b224a4de69e3cdef
Issue-ID: POLICY-2045
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Utilize's Jim's helper class to pull from API policy types
definitions so that Xacml PDP can determine which properties
are "matchable".
Override initialize to set translator parameters.
Utilize the metadata section of ToscaProperties to store
the matchable field.
Updated Matchable Request to be dynamic with respect to the
incoming resource attributes.
Stored the policy types as JSON.
Issue-ID: POLICY-1899
Change-Id: Icff3605495b0a34ebfcdfa54346095ce2d8468a4
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Change-Id: I2770d2803c79b5eb72b69bb6aa4a1da43a0f6a0b
Issue-ID: POLICY-1965
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Change-Id: I7c7c89e8b4367bbc2ea7a97e403eb253e955a9a5
Issue-ID: POLICY-1074
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Wrong attribute id was being used. Added info logging statement
to assist in debugging. Added JUnit to support this.
Issue-ID: POLICY-1843
Change-Id: I11d83574f91751804a45281d2e0c9cd3150e30eb
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Released 2.1.0
Issue-ID: POLICY-1737
Change-Id: Ieb3015e9373a9a71a71f2811cbc6db9315d58109
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Change-Id: I231fa4c077db75d426278f6f718876bb2c76a8db
Issue-ID: POLICY-1747
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Released 2.0.1
Issue-ID: POLICY-1700
Change-Id: Idc1d8602b276c9ad3199c57723dd053fb1dd48a3
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Missing for this use case is the monitoring policy type
for the 5G OOF PCI use case.
Updated name to follow convention.
Issue-ID: POLICY-1779
Change-Id: I88c6c235288b9090161338695a2a55e5b1900b98
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Released so bumping to next patch
Issue-ID: POLICY-1630
Change-Id: Ib91063848e1a757b0a251052ce8ec61dace85d88
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
For Dublin, hard code these so they are available to
pdp group.
Issue-ID: POLICY-1705
Change-Id: I705f2fc01864458e3d8ef569d24e51e0d565aed6
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
* Adding in the statistics for decisions and errors.
* Cleaned up sonar issues and added code coverage.
* Sped up JUnit tests
* Fix JUnit issues with not finding application path
* Fix TestDecision not finding persistence.xml
* Fix for lingering statistics from previous runs. That
needs to be addressed at a later time.
* Changed persistence to use properties for configuration
of database rather than hard coding the persistence.xml
* Fix for Josh's comment to use else-if
* Changed to use apache Pair
* Added blacklist guard policy
Issue-ID: POLICY-1440
Change-Id: I56af8c3dcc82463f7381f1eaea7f1440b76200bd
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
|
|
Refactor code to support multiple pip engines.
Add pip engine for outcome.
Modify LegacyGuardTranslator to use coordination translator's
convertPolicy function when processing coordination guard.
This version of convertPolicy intentionally uses string
replacement on template-like xacml coordination guard to
enable future support for API-based creation of new coordination
guard types.
Bug fixes and code cleanup.
* Unused imports, sonar problems.
* Consolidation of getAttribute method
* Only use TypedQuery for Pips
Issue-ID: POLICY-1471
Change-Id: I4e9365b7f23bee96cf438dad44feda97c65f6ecc
Signed-off-by: Joshua Reich <jreich@research.att.com>
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Added changes to handle incoming udpate for deploying or undeploying the
policies by comparing both sets. STill need to add support for removing
the policies and getting the deployed ToscaPolicyIdentifiers for
PdpStatus response.
* PLD - added functionality to unload policies in the applications and
* PLD - added map of loaded policies
* Mike - made change to address Jim's and Joshua's comments
* Mike - Made change to use mapLoadedPolicies to get deployed policies
from the applications
* Mike - made change to assembly.xml to add support for apps directory.
Change-Id: If7d119197171b68b905b7fd0f2b5be6cf6f609e7
Issue-ID: POLICY-1451
Signed-off-by: Michael Mokry <michael.mokry@att.com>
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
1. Added PDPUpdate listener
2. Added PDPUpdate Publisher
3. Added code to handle PdpUpdate messages and load policies being
deployed
4. Modified Activator to register listener
5. Provided placeholder code to get policies from pdpx for return
PdpStatus response to the PAP
6. Other minor modifications
7. Fix XacmlPdpApplicationManager to only load policy if supports
policy type.
8. Checkstyle fixes
9. Updated applications to support loadPolicy(ToscaPolicy) and
all the translators, JUnit tests.
10. Consolidated some duplicate code in the applications. Can probably
do more in that area.
11. Fixed bug in Properties not really having a copy constructor.
Change-Id: Ic29ad426061cbdb79c1339314667bb8ff8decb88
Issue-ID: POLICY-1451
Signed-off-by: Michael Mokry <michael.mokry@att.com>
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Tests a decision upon startup. This also updates the use of
ToscaPolicyTypeIdentifier for all the applications.
Very basic packaging for applications and their properties.
Added cleaning of unused imports to remove sonar issues.
Added production persistence.xml file to guard application.
Not sure if we need a copy in the application/common resource
directory.
Issue-ID: POLICY-1440
Change-Id: If96eef5a9e0a7c6cc5461c0bdb6f0cd708cc41bb
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Created Optimization application and created a translator
for it. The translator makes an assumption that OOF wants
to query on policyScope and policyType properties.
Rearranged some of the test code for re-usability.
Guard policies are now creating for frequency limiter
and min max. Probably could use some clean up.
Upgraded to xacml 2.0.1 to include a fix for handling
null attribute values.
Added some code to test missing values.
Issue-ID: POLICY-1273
Change-Id: Ia3dbfa992bbe0cbb5aa294c38aa2aff430a3230a
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Instead of applications implementing the converter, use a
protected abstract class that implements common code.
Newer applications could re-use existing application, and
shared code can be put into the base translator class.
Fixed sonar issue and changed guard xml.
Removed Converter and made translator into an implementation
class that is an object in the Application Provider.
Issue-ID: POLICY-1273
Change-Id: I9b48cbcdaf80d6d2ef19ef53e4b7cd4830e7e7b2
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Fixed some small sonar issues. Some of the others will be
taken care of when we implement things.
Issue-ID: POLICY-1602
Change-Id: I745962feaf00904c39b2e80e00bcc565f51dc8fd
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Added new Policy Finder Factory that ONAP will use and
got the code working with new policy/models (see other
review which will have to be merged first).
Added some new conversion methods to convert from a
Xacml request to an Onap request.
Added some property methods for XACML Properties objects
and JUnit tests.
Started filling in some Guard application details and
combining code.
Issue-ID: POLICY-1602
Change-Id: I5235b74f3b036dcf05779b655a03ac290d594354
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Upgrde to xacml v2.0.0 release artifact.
Some re-arrangement of classes. New class to support a
common dictionary among the monitoring applications. I
may move it to a common under the main since some of the
values are shareable.
Created application service provider, so the XACML
main knows what policy types are pre-loaded and can
report them back to the PAP.
struggled with cucumber, which does not create
TemporaryFolder although the documentation says its
supported.
Added a new Policy Finder specific to ONAP which does
quicker job to load policies.
Issue-ID: POLICY-1273
Change-Id: I4af15a64da3b42d48f29809710421b1649625adc
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
This sets the foundation for building the XACML PDP
engine that supports Decisions for onap.Monitoring
policy types.
Mostly stubbed code for now, will most likely get
re-arranged.
Put in the cucumber basics, but no implementation yet.
Need policy/parent to be merged before this will pass.
* Fixed checkstyle license date
Issue-ID: POLICY-1273
Change-Id: Ifb455065316fd3ec0a025b5833b334ee72f65adc
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|