Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
Issue-ID: POLICY-3696
Change-Id: If5e83b9ab94f62fa8063e565f9dd1daf8d9880b2
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-3696
Change-Id: I892219ee37f689eaa250142d0a1e6610a8b227ff
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-3587
Change-Id: I4e912da513ba8ecaf4bdc71659b7b273c0aaab05
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
|
|
Adds new method to return attributes in a decision, which
can be configurable.
By default it is turned off which ensures that the current
functionality is maintained for our client applications.
Enhanced the JUnits for the applications to ensure that no
extra information is passed, thus maintaining backward
compatibility.
Issue-ID: POLICY-2865
Change-Id: Ia533e5462c0cb475cb1f72f34e95f128d6c52678
Signed-off-by: Pamela Dragosh <pd1248@att.com>
|
|
Replaced generic BusTopicParams with more specific RestClientParameters.
Also modified code to pass the HttpClient around instead of passing the
client parameters around.
Issue-ID: POLICY-3456
Change-Id: Ic07b710645eeab696e6df0a015171578ad08ca83
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Also:
- changed a few fields to private/protected.
- swwapped out gson for coder
Issue-ID: POLICY-3400
Change-Id: I9a4dba939b77078f78583ada00af182b1a7d95c5
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Application and common code in xacml-pdp is meant to be
available for developers to re-use and/or extend as desired.
Private methods are unnecessary at this time, but could be
re-visited in a later release.
For Honolulu, simply moving to protected to keep functionality
the same. Possibly for Istanbul we can make more changes to
support mixing of ONAP application with custom applications
during runtime.
Issue-ID: POLICY-3305
Change-Id: I6db23bda3c81fdbbf86e39cc2cd2e706d8bee63d
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
(cherry picked from commit 8e0aa0ffa5cef537de1c841acf38300832c52a56)
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
The new version of checkstyle identified new issues. Fixed those.
Issue-ID: POLICY-3288
Change-Id: I334e9eb67c9270c4e53b2fb34e576b8bfbf8ec8b
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Fixed sonars:
- use "var"
Issue-ID: POLICY-3288
Change-Id: If4f685e0d645f6d6fbdd2cdb86c6b67336f6839a
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Instead of having code to validate various values, created POJOs to
represent the decoded data so that bean validation annotations could be
used instead.
Didn't see any obvious ways to use annotations in the Optimization code,
but did notice a bug (passed role instead of provisions). Extracted a
common method which fixed the bug as a side-effect.
Issue-ID: POLICY-2418
Change-Id: I9ef589086fc8f7f66810b66405fbf302d7570e5a
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Fixed:
- use "var" instead of actual type
Issue-ID: POLICY-3285
Change-Id: Id17142d1f2e3e5f9dfbffcb96aff7fe76321a56b
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
HTTP client parameters should be based on BusTopicParams instead of
RestServerParameters, modified the policyApiParameters.
Issue-ID: POLICY-3147
Change-Id: I73aa34bec3ab7e27e7a3474260f411ed55b6f933
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-3105
Change-Id: I9fd03ff6a405b127c1eabbfe301f3b9ea8327aad
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-3127
Change-Id: I586fc25f730b708d047999706fd74d6b965bb130
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-3088
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I42c32bbb1ef6e275b8b3a0693492c7e4e61dd6eb
|
|
Windows doesn't like file names containing ":". Added code to replace
":" with "_", but only when the JVM is run on a Windows OS.
Issue-ID: POLICY-3085
Change-Id: I1d3b6819bf564571eddda69e4c5fbd2bb807a3aa
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Switched to using the new Time Extensions released in XACML
from github v3.0. Added more thorough tests for it as well as
the flexibility of specifying the current time etc.
More syntax checking on the inputs from the policy.
Issue-ID: POLICY-2810
Change-Id: I1b4ec885c706e37949e5dabe14c63b0d7456cd4f
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
The dependency upgrades in policy-parent caused some new sonars. In
particular, initMocks() has been deprecated - replaced with calls to the
Mockito Runner. Also removed unnecessary when() calls.
Issue-ID: POLICY-2912
Change-Id: If386bd282635067a20045f2626af0cf5be49bc0e
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Updated properties to work with the new version of eclipselink.
Issue-ID: POLICY-3005
Change-Id: I88091a90387e235ef5c168de7a3275056327d83e
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Point to the newly release 3.0, which is JDK11 compatible and
contains the latest time extensions. Simple ensuring that nothing
is broken on our end.
Issue-ID: POLICY-2810
Change-Id: Ic2fed1b57574ebd1b9eaaa19c19578a42ade5483
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
The policy models tosca classes ToscaPolicyIdentifier and
ToscaPolicyIdentifierOptVersion can be used to identify any TOSCA
concept, not just TOSCA policies so they are renamed to
ToscaConceptIdentifier and ToscaCinceptIdentifierOptVersion
respectively.
The class ToscaPolicyTypeIdentifier is redundant and is replaced by
ToscaConceptIdentifier.
Issue-ID: POLICY-2900
Change-Id: Id614bbed34ed8897e7e882b70147b98ffe90bf57
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
S5993 Change the visibility of this constructor to "protected".
Issue-ID: POLICY-2912
Change-Id: I2fd9fcd3162c8bf28ba0315939ef259356f442db
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
The TOSCA class ToscaEntityType is renamed to ToscaSchemaDefinition
becasue keys as well as entities can have schemas, so the class has more
usages than just for entity schemas.
Issue-ID: POLICY-2900
Change-Id: I7a1a3a1262078c47eeea1820538ecb6153f5e652
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Bumping minor version now that guilin branch has been created.
Also repointed to snapshot versions for dependencies.
Issue-ID: POLICY-2875
Change-Id: I145f638d6409f92cf916b08ace10a159d5e52c73
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2869
Change-Id: If8e944fce44ca0b613da9f92f4516049994fff86
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2839
Change-Id: I78bf1cebb31c3c3c48d214fa755892b9a3a58323
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Initially, just moving the applicationName and actions as protected
fields got rid of the sonar issue. I included also the supportedPolicyTypes
also. But that triggered another sonar duplicate code, so I had to rename
a few private fields to rid that. Seems like a very sensitive sonar detection
that results in kludgy code.
Issue-ID: POLICY-2681
Change-Id: Ie79a95786cdb80381cbce4b182e9e66a2776e0dd
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2550
Change-Id: I05d9af99401991ea867e7ab8d697692c9020b3b7
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Issue-ID: POLICY-2789
Change-Id: I3f2c877874e5fbcd0520b811c984fa8d14b05435
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2695
Change-Id: I7be4fdd72aad0ab794a0d5a6919afec5998dad09
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Replaced try/catch blocks in policy/xacml-pdp with assertj assertions
Issue-ID: POLICY-2451
Change-Id: I3e6947a61e0000561c7053a1cdede9ae5825e5ca
Signed-off-by: waynedunican <wayne.dunican@est.tech>
|
|
Somehow missed this sonar issue in one line of code:
- invoke only one method in a junit lambda
Issue-ID: POLICY-2681
Change-Id: I03a6708e0d3ed2a43577a63d0f3cdfc9bd76c8d8
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Addressed issues reported due to updates to the sonar rules:
- invoke only one method in a junit lambda
- complete the assertion
- use assertThat().exists(), canRead(), etc.
Issue-ID: POLICY-2681
Change-Id: I2935f4d0295244ab3b11a57a3bc401c64b695fd1
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2188
Change-Id: I64a115240a71e5014db9cfb66747887e156afb50
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
|
|
Deleted Dbao and replaced it with the shared class in policy-models.
Also had to update the queries and the persistence.xml accordingly.
Issue-ID: POLICY-2581
Change-Id: I59dfa2f37c272796ccebc0f578c9f4e8e1b9c8ab
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
The default provider has been changed to gson, so the provider property
no longer has to be set.
Issue-ID: POLICY-1527
Change-Id: I21f5a3af2bc1d7fc10dc41f58e6e62a04f4bda77
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
Change the CLC policy logic to match the udpate Operations History DB
rules. Now if a record has outcome = Started, it is considered
to be in progress. Else it is considered to be complete.
Issue-ID: POLICY-2583
Change-Id: If3f626bfec2d0656e43a26929107f68ff27af020
Signed-off-by: pramod.jamkhedkar <pramod@research.att.com>
|
|
Queries to the operationshistory table will degrade substantially
as more records are added to the DB.
The Dbao class should be moved to policy-models, but for now
we'll just update it in both places (i.e., drools-apps and xacml-pdp).
Issue-ID: POLICY-2581
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: Icc4529e56968ceda4d9b63a8ccea6ba219250506
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Change-Id: I4e2a3a7a89eb3e59111c0a2bff70624d9f987abb
Issue-ID: POLICY-2514
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Change-Id: I753851b22200de1f69489d13a283832c469fab22
Issue-ID: POLICY-2514
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Change CLC granularity from target level to CL level. Remove the target
matching for the db query at PIP level.
Issue-ID: POLICY-2573
Change-Id: If9ba1a4d22c3b8bc5dfce0632f7037ad085f6ea6
Signed-off-by: pramod.jamkhedkar <pramod@research.att.com>
|
|
Issue-ID: POLICY-2378
Change-Id: I542884aed2acbef7e1c7e431f209ea61108e2048
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Use policy/common map double converter to ensure integers saved
in policy content do not get converted to doubles.
Issue-ID: POLICY-2486
Change-Id: I887c6b5c337e2594c425b645af4b2668d06715bd
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2378
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I819c9a356ca09e9baf75662bb6cd574540f41206
|
|
The XACML github was released with a new method to allow
context factories and PIP engines to release any handles
before releasing the PDP engine. This review includes
that artifact and adds tests to support it.
In addition, added more tests to get code coverage over
90% for both PIPs in ONAP.
Some cleanup in the Matchable types based on last review.
Issue-ID: POLICY-2242
Change-Id: I312f06380ff4d2e16bcfd25b6d1f36ce5dd030e6
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
This solution is much cleaner than what is in StdMatchableTranslator.
Over 90% code coverage on it - utilizes a callback to retrieve DataType
and PolicyTypes. Support for missing timestamp TOSCA type. Also can
do a better job differentiating between a property contained in the policy
vs a schema.
Changed StdMatchableTranslator to utilize these classes. And removed the
old spaghetti.
Added some JUnit coverage for ToscaPolicyTranslatorUtils.
Removed duplicate code in the XACML Native Exception classes.
Issue-ID: POLICY-2242
Change-Id: I18f898d9e65f6da28e3b27517d40f8d389de18a0
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|