summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2021-06-24Use protected methods vs privatePamela Dragosh8-23/+24
Application and common code in xacml-pdp is meant to be available for developers to re-use and/or extend as desired. Private methods are unnecessary at this time, but could be re-visited in a later release. For Honolulu, simply moving to protected to keep functionality the same. Possibly for Istanbul we can make more changes to support mixing of ONAP application with custom applications during runtime. Issue-ID: POLICY-3305 Change-Id: I6db23bda3c81fdbbf86e39cc2cd2e706d8bee63d Signed-off-by: Pamela Dragosh <pdragosh@research.att.com> (cherry picked from commit 8e0aa0ffa5cef537de1c841acf38300832c52a56) Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2021-06-18Fix new checkstyle issues in xacml-pdpJim Hahn2-4/+4
The new version of checkstyle identified new issues. Fixed those. Issue-ID: POLICY-3288 Change-Id: I334e9eb67c9270c4e53b2fb34e576b8bfbf8ec8b Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-10Fix sonars in xacml-pdpJim Hahn2-2/+2
Fixed sonars: - use "var" Issue-ID: POLICY-3288 Change-Id: If4f685e0d645f6d6fbdd2cdb86c6b67336f6839a Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-01Update junits for bean validator field nameJim Hahn1-2/+2
Now that the bean validator uses the serialized field name in its error messages, updated the junits to use the serialized names, too. Issue-ID: POLICY-3333 Change-Id: I017aa654480baef06f2869116d4b5264bb32c721 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-05-27Replace validation code with annotationsJim Hahn8-262/+297
Instead of having code to validate various values, created POJOs to represent the decoded data so that bean validation annotations could be used instead. Didn't see any obvious ways to use annotations in the Optimization code, but did notice a bug (passed role instead of provisions). Extracted a common method which fixed the bug as a side-effect. Issue-ID: POLICY-2418 Change-Id: I9ef589086fc8f7f66810b66405fbf302d7570e5a Signed-off-by: Jim Hahn <jrh3@att.com>
2021-05-26Merge "Change indexes on Op History table"Ajith Sreekumar2-3/+9
2021-05-25Change indexes on Op History tableJim Hahn2-3/+9
This is the companion change to that made in policy-models. Per review comments: - added index to s3p sql script Issue-ID: POLICY-2874 Change-Id: Ic270b8da92be8b921b3a865ff1ce923af21faaab Signed-off-by: Jim Hahn <jrh3@att.com>
2021-05-25Support delta policy lists in xacml-pdpJim Hahn2-33/+112
Updated xacml-pdp to use the deploy & undeploy lists in the PDP-UPDATE message. Added more code coverage to the junit test class. Per review: - added logging for unexpected cases Issue-ID: POLICY-3188 Change-Id: I0f899abcd497f7eb711d4df358e455fd2d50e904 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-05-13Remove csit folder from policy/xacml-pdpRam Krishna Verma9-297/+0
The csit test files for all repos have been consolidated in policy/docker to maintain them at single place and allow us to trigger verify jobs in gerrit reviews. Issue-ID: POLICY-3257 Change-Id: I54e93a2b43de0e4b36ac74a5cd94eda741bad5fa Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-05-11Fix xacml-pdp csit test casesRam Krishna Verma1-12/+12
In the recent runs, it was found that get statitcs might take few seconds longer after the actual deployment of policies. So, increasing the "max" wait time for the test cases to 1 min. And it won't slow down the tests as the check will be made every 15 sec to verify if the assertions are passing. The moment they pass, it will move on. Issue-ID: POLICY-3257 Change-Id: I505c6e95e78a35b8bf1ee9921efbfcb4bd4874fb Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-05-07Refactor policy/xacml-pdp csit testsRam Krishna Verma1-129/+70
* Removed the deprecated methods. * Removed duplicated code. * Created method hierarchy to improve the readability. * Updated the assertions on various tests. Issue-ID: POLICY-3257 Change-Id: If9562b19e1a9b16ee0d5a5211a557b4f818f62c3 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-05-07Merge "Fix sonars in xacml-pdp"Pamela Dragosh39-244/+235
2021-05-06Fix sonars in xacml-pdpJim Hahn39-244/+235
Fixed: - use "var" instead of actual type Issue-ID: POLICY-3285 Change-Id: Id17142d1f2e3e5f9dfbffcb96aff7fe76321a56b Signed-off-by: Jim Hahn <jrh3@att.com>
2021-05-06Update tutorials to point to honolulu imagesPamela Dragosh2-12/+12
These should point to released images so that the user can perform the tutorial without any problems. They can certainly update the docker-compose.yml with whatever image they want. Issue-ID: POLICY-3292 Change-Id: I85b9bb90bb959d0f1078238344c4aa25ef2b2a35 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2021-04-29Remove GroupValidationResultJim Hahn4-93/+49
Removed GroupValidationResult, replacing it with BeanValidationResult. Modified the ParameterGroup subclasses to use BeanValidator, adding annotations where needed to trigger the validations that had been automatically performed by GroupValidationResult. Issue-ID: POLICY-2059 Change-Id: I039f761745316fea41d63bdc885584c9a9c2bc6e Signed-off-by: Jim Hahn <jrh3@att.com>
2021-04-07Use sh instead of ash in xacml-pdpJim Hahn2-4/+4
Issue-ID: POLICY-3160 Change-Id: I168a7d4630c487dd9d219f25383cd2f4fd781028 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-03-29Change pap deploy response code to 202 for jmeterjhh1-4/+4
Issue-ID: POLICY-3108 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I04ef297c2a7941dd2d174ce2ce95337c0776efa4
2021-03-19Delete keystores from xacmlJim Hahn3-4/+4
The Keystore is no longer needed in the tarball, as it is supplied externally by the CSITs and Helm charts. Deleted that file. Also modified the junits to use utils-test to generates keystores at runtime, thus deleted the junit keystore file, too. Issue-ID: POLICY-3143 Change-Id: If4966538452a16b22ea3a338eb9656a295641402 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-03-17Change RestServerParameters to BusTopicParamsJim Hahn33-136/+129
HTTP client parameters should be based on BusTopicParams instead of RestServerParameters, modified the policyApiParameters. Issue-ID: POLICY-3147 Change-Id: I73aa34bec3ab7e27e7a3474260f411ed55b6f933 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-03-16Update policy-keystore with newer certificatesjhh2-0/+0
Issue-ID: POLICY-3139 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Ia0c86441b1c95b45959be070015ea57f106d7002
2021-03-12Remove more unnecessary plugins from xacml-pdpJim Hahn1-44/+3
Issue-ID: POLICY-3126 Change-Id: Ic20b00aa1f2eaac0272792809a059a851bfbfffc Signed-off-by: Jim Hahn <jrh3@att.com>
2021-03-12Address plugin-not-found issuesJim Hahn1-31/+0
Removed references to archetype-packaging and lifecycle-mapping, where unnecessary due to pom inheritance. Issue-ID: POLICY-3126 Change-Id: Ic48a4482b44f40000549bacf9627894e608977a3 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-03-11Bump xacml-pdp 2.5.0-SNAPSHOTPamela Dragosh21-25/+25
Issue-ID: POLICY-3105 Change-Id: I9fd03ff6a405b127c1eabbfe301f3b9ea8327aad Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2021-03-10Merge "add a sleep 5 sec for robot"Jim Hahn1-0/+1
2021-03-10add a sleep 5 sec for robotTaka Cho1-0/+1
add a sleep time to ensure the deploypolicies received Issue-ID: POLICY-2895 Change-Id: Ib21fdfb54ab2fe550a359f04a82cb355b354026d Signed-off-by: Taka Cho <takamune.cho@att.com>
2021-03-09Bump xacml to 2.4.2-SNAPSHOTPamela Dragosh21-21/+21
Issue-ID: POLICY-3127 Change-Id: I586fc25f730b708d047999706fd74d6b965bb130 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2021-03-09Release xacml-pdp 2.4.1 dockerPamela Dragosh1-0/+8
Issue-ID: POLICY-3127 Change-Id: I1421920c16de5f9f9d8bf6208d022e4e4d987bfa Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2021-03-09Release xacml-pdp 2.4.1 mavenPamela Dragosh1-0/+5
Issue-ID: POLICY-3127 Change-Id: Iac7bb6264de5f5726926da94560d59a4c93ff16a Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2021-03-09Point to released models 2.4.1Pamela Dragosh1-1/+1
Issue-ID: POLICY-3127 Change-Id: I1c3255e15bff18185705465ebbfc0db6cc0b5f22 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2021-03-05modify filename and path for csit - xcamlTaka Cho1-1/+1
after doing a test in jenkins sandbox found some errors have to be fixed. Issue-ID: POLICY-2895 Change-Id: Iaa470749f62dbd7c2f90ef9c7367176c6e70aa05 Signed-off-by: Taka Cho <takamune.cho@att.com>
2021-02-26move xacml csit to xacml repoTaka Cho9-0/+355
move tests/plans to from csit repo to xacml repo Issue-ID: POLICY-2895 Change-Id: If8840f286c35136ae76314a6557cf186a9bf8a4a Signed-off-by: Taka Cho <takamune.cho@att.com>
2021-02-24Update info.yaml in xacml-pdpRam Krishna Verma1-2/+2
Issue-ID: POLICY-3028 Change-Id: Ib7719f80c7927bb9b803cc7e4ef50cfc9c7a0071 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-02-23bump poms to 2.4.1-SNAPSHOTjhh21-21/+21
Issue-ID: POLICY-3088 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I42c32bbb1ef6e275b8b3a0693492c7e4e61dd6eb
2021-02-23release 2.4.0 container imagejhh1-0/+8
Issue-ID: POLICY-3088 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I76189f2d4a7f95018ce99dab9fca5064c16eac14
2021-02-23maven release 2.4.0jhh1-0/+5
Issue-ID: POLICY-3088 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I24c82abf8ca5a769d20cbdb7dca9955f1896a0b7
2021-02-23use base policy-jre-alpine:2.2.1 imagejhh1-2/+2
Issue-ID: POLICY-3088 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I3eed92d8f3014580565efebdabb4464d9e38f13e Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2021-02-23versions: 1.8.0 common, 2.4.0 models, 3.3.0 parentjhh1-3/+3
Issue-ID: POLICY-3088 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I79a68a7e81040545bfdc1c4f738b85876a042da9 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2021-02-19Fix junit for "native" on WindowsJim Hahn1-2/+12
Windows doesn't like file names containing ":". Added code to replace ":" with "_", but only when the JVM is run on a Windows OS. Issue-ID: POLICY-3085 Change-Id: I1d3b6819bf564571eddda69e4c5fbd2bb807a3aa Signed-off-by: Jim Hahn <jrh3@att.com>
2021-02-18Fix sonars and target dirPamela Dragosh5-23/+21
Fix a couple of sonars introduced by the PdpType review. Also creation of a target directory below the xacml-pdp directory. Issue-ID: POLICY-3071 Change-Id: I9fe325d0a75970fbe3d42be36906013c1fc2ecb9 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2021-02-18Utilize time extensionsPamela Dragosh10-16/+379
Switched to using the new Time Extensions released in XACML from github v3.0. Added more thorough tests for it as well as the flexibility of specifying the current time etc. More syntax checking on the inputs from the policy. Issue-ID: POLICY-2810 Change-Id: I1b4ec885c706e37949e5dabe14c63b0d7456cd4f Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2021-02-17Fix wrong category for timeRangePamela Dragosh1-2/+2
The category is wrong, and will not work. So fixing this bug first before working in the changes for use new Time Extensions. I may make it all configurable. Issue-ID: POLICY-2810 Change-Id: I4a338242dd4ec35f9b45fa1f46609dea93e286a1 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2021-02-16Make xacml pdpType configurablePamela Dragosh15-24/+83
Adding code to enable the pdp type to be configurable. Issue-ID: POLICY-3071 Change-Id: I51c873f68bff1866c6b2e96958b6c33872aea2c8 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2021-02-11Fix sonars from dependency upgradeJim Hahn12-70/+50
The dependency upgrades in policy-parent caused some new sonars. In particular, initMocks() has been deprecated - replaced with calls to the Mockito Runner. Also removed unnecessary when() calls. Issue-ID: POLICY-2912 Change-Id: If386bd282635067a20045f2626af0cf5be49bc0e Signed-off-by: Jim Hahn <jrh3@att.com>
2021-02-10Upgrade dependenciesJim Hahn4-0/+4
Updated properties to work with the new version of eclipselink. Issue-ID: POLICY-3005 Change-Id: I88091a90387e235ef5c168de7a3275056327d83e Signed-off-by: Jim Hahn <jrh3@att.com>
2021-01-19Upgrade to xacml 3.0 github releasePamela Dragosh1-2/+2
Point to the newly release 3.0, which is JDK11 compatible and contains the latest time extensions. Simple ensuring that nothing is broken on our end. Issue-ID: POLICY-2810 Change-Id: Ic2fed1b57574ebd1b9eaaa19c19578a42ade5483 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2021-01-06Merge "Changed identifiers to concept identifiers"Ram Krishna Verma21-112/+130
2021-01-05use jre base 2.2.0 - xacmlTaka Cho1-1/+1
use jre base 2.2.0 Issue-ID: POLICY-2917 Change-Id: Id2683ff127fc1a290589e5295995f1d08481c50a Signed-off-by: Taka Cho <takamune.cho@att.com>
2021-01-04Changed identifiers to concept identifiersliamfallon21-112/+130
The policy models tosca classes ToscaPolicyIdentifier and ToscaPolicyIdentifierOptVersion can be used to identify any TOSCA concept, not just TOSCA policies so they are renamed to ToscaConceptIdentifier and ToscaCinceptIdentifierOptVersion respectively. The class ToscaPolicyTypeIdentifier is redundant and is replaced by ToscaConceptIdentifier. Issue-ID: POLICY-2900 Change-Id: Id614bbed34ed8897e7e882b70147b98ffe90bf57 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-12-23Fix directory renameJim Hahn3-0/+0
Eclipse generates java errors if a package name contains "native" as a component OR if the path to a java source file contains "native". Renamed the "native" directories back to "nativ" to fix the errors. Issue-ID: POLICY-2900 Change-Id: Id718e69ae59e8fdbad72ad42347264766312a5ad Signed-off-by: Jim Hahn <jrh3@att.com>
2020-12-21XACML to accept properties as nullliamfallon6-6/+32
xacml-pdp expects the property map to exist in all policies, even if it is sometimes empty. Now, the propperty map can be null. The code is updated to cope with a null property map. Issue-ID: POLICY-2900 Change-Id: Ie31a2770aff1435a1d1064512d0c2fa2088d3183 Signed-off-by: liamfallon <liam.fallon@est.tech>