summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-04-26Refactor xacml-pdp to remove various statics3.0.2-ONAPjh735824-899/+806
Refactored xacml-pdp to eliminate a number of static fields. Modified junit tests to allocate new ports for each test. Also modified XacmlPolicyUtilsTest to convert path names to match the file system so that the junit will work in OSs other than linux. Replaced logback.xml with a copy of the one from PAP to resolve some issues. Don't print entire message when discarding, as each PDP receives messages for ALL PDPs. Remove shutdown class from Main - just invoke this.shutdown() directly. Added additional comments to CommonRest. Also modified port test parameters. Change-Id: Id8bf7216cdcb59a1a2cb4cb957fa44f640315cfe Issue-ID: POLICY-1645 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-04-26Hardcode monitoring policy typesPamela Dragosh1-1/+9
For Dublin, hard code these so they are available to pdp group. Issue-ID: POLICY-1705 Change-Id: I705f2fc01864458e3d8ef569d24e51e0d565aed6 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-04-26Fix nullpointer issue in pdpx heartbeatMichael Mokry1-1/+1
1. Added a null check against XacmlPdpActivator.getCurrent() method to fix the following exception Exception in thread "Timer-0" java.lang.NullPointerException Change-Id: Ia6c7efc2bd317dd52e9e89dd4f9f59d9d66d0857 Issue-ID: POLICY-1703 Signed-off-by: Michael Mokry <michael.mokry@att.com>
2019-04-26Rebase image on policy-common-alpineDmitry Puzikov2-16/+5
Issue-ID: INT-1003 Change-Id: I671156732399a8cd6f4a68e29f35112b8aa7657f Signed-off-by: Dmitry Puzikov <dmitry.puzikov@tieto.com>
2019-04-25Fix xacml pdp registration issueMichael Mokry6-72/+70
1. Added appliesTo() check to state change and PDP update listeners. 2. Made changes to record the extracted pdpUpdate values. 3. Removed pdpState instance variable from heartbeat publisher 4. Split XacmlPdpMessage.updateInternalStatus() into two methods to handle PdpStateChange and PdpUpdate messages separately 5. Cleaned up unused imports Change-Id: I76c68d925e46d475c086bd5b86851ea44d821b28 Issue-ID: POLICY-1673 Signed-off-by: Michael Mokry <michael.mokry@att.com>
2019-04-16Merge "One year cert with new component names"Pamela Dragosh1-0/+0
2019-04-15One year cert with new component namesjhh1-0/+0
Change-Id: I3c3a9174b2d90b4139f9ab4e805f9a87bb6d5d39 Issue-ID: POLICY-1580 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2019-04-15Fix a couple of sonar issues one blockerMichael Mokry2-17/+15
1. fixed nullpointer blocker issue in CoordinationGuardTranslator.java 2. fixed "log or rethrow exception" critical issue 3. throw exceptions instead of returning null values Change-Id: I2d567fe566c6f761ec2699016c4a868f203c9a01 Issue-ID: POLICY-1451 Signed-off-by: Michael Mokry <michael.mokry@att.com> Signed-off-by: Joshua Reich <jreich@research.att.com>
2019-04-15Merge "DmaaP topic properties change for xacml-pdp"Jorge Hernandez1-7/+4
2019-04-15DmaaP topic properties change for xacml-pdpMichael Mokry1-7/+4
Updated the topic.properties file with proper dmaap properties and values Change-Id: I691374eeed28c1f6235956a3a27c04e860411c4f Issue-ID: POLICY-1451 Signed-off-by: Michael Mokry <michael.mokry@att.com>
2019-04-15Fix incorrect policy with time-in-rangePamela Dragosh4-7/+8
Changed policies to use Z vs -05:00 for timezone since we cannot guarantee the timezone the VM's run in. The test should be generalized. Fixed a sonar issue in the test I was using to debug this. Issue-ID: POLICY-1639 Change-Id: If3e52d199527a8a7e11c5fa994beb8fb886c93a6 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-04-12Add statistics and sonar cleanup and blacklistPamela Dragosh52-426/+730
* Adding in the statistics for decisions and errors. * Cleaned up sonar issues and added code coverage. * Sped up JUnit tests * Fix JUnit issues with not finding application path * Fix TestDecision not finding persistence.xml * Fix for lingering statistics from previous runs. That needs to be addressed at a later time. * Changed persistence to use properties for configuration of database rather than hard coding the persistence.xml * Fix for Josh's comment to use else-if * Changed to use apache Pair * Added blacklist guard policy Issue-ID: POLICY-1440 Change-Id: I56af8c3dcc82463f7381f1eaea7f1440b76200bd Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-04-12Merge "Add Control Loop Coordination policy."Pamela Dragosh31-466/+1543
2019-04-11Add Control Loop Coordination policy.Joshua Reich31-467/+1543
Refactor code to support multiple pip engines. Add pip engine for outcome. Modify LegacyGuardTranslator to use coordination translator's convertPolicy function when processing coordination guard. This version of convertPolicy intentionally uses string replacement on template-like xacml coordination guard to enable future support for API-based creation of new coordination guard types. Bug fixes and code cleanup. * Unused imports, sonar problems. * Consolidation of getAttribute method * Only use TypedQuery for Pips Issue-ID: POLICY-1471 Change-Id: I4e9365b7f23bee96cf438dad44feda97c65f6ecc Signed-off-by: Joshua Reich <jreich@research.att.com> Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-04-11Merge "Changes to handle PDPX deploy/undeploy"Pamela Dragosh10-22/+289
2019-04-11Changes to handle PDPX deploy/undeployMichael Mokry10-22/+289
Added changes to handle incoming udpate for deploying or undeploying the policies by comparing both sets. STill need to add support for removing the policies and getting the deployed ToscaPolicyIdentifiers for PdpStatus response. * PLD - added functionality to unload policies in the applications and * PLD - added map of loaded policies * Mike - made change to address Jim's and Joshua's comments * Mike - Made change to use mapLoadedPolicies to get deployed policies from the applications * Mike - made change to assembly.xml to add support for apps directory. Change-Id: If7d119197171b68b905b7fd0f2b5be6cf6f609e7 Issue-ID: POLICY-1451 Signed-off-by: Michael Mokry <michael.mokry@att.com> Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-04-11The final fix for xacml-pdp CSIT failureMichael Mokry1-0/+1
Bilal found the issue in assembly.xml, we needed to add properties to the <include> Change-Id: Icb84db76b8a4ab240e3ad9c562334dab116a118b Issue-ID: POLICY-1449 Signed-off-by: Michael Mokry <michael.mokry@att.com>
2019-04-11Fixing install script that is failing CSITMichael Mokry1-1/+2
1.) Made a change to address syntax error in script Change-Id: I671e533c7ba09f0a75f871f1a47b42cbe8a91b37 Issue-ID: POLICY-1449 Signed-off-by: Michael Mokry <michael.mokry@att.com>
2019-04-11Merge "XACML PDP DmaaP Deploy/UnDeploy Function"Pamela Dragosh26-826/+653
2019-04-11Fix the xacml-pdp CSIT failuresMichael Mokry1-3/+8
Looks like CSIT uses docker to install xacml-pdp so a change in OOM is not necessary to fix this problem. I took a look at the PAP script and found some small differenences and made those changes in xacml-pdp. I have not been able to successfully test this as I spent all night trying to figure out how to execute it in my VM with and without arguments. I added some debugger code in as well to get more information in the logs and see if the property file is actually being found. Change-Id: Ib6ca95edab4483aa4e65efca73a9f58342cc1ec0 Issue-ID: POLICY-1449 Signed-off-by: Michael Mokry <michael.mokry@att.com>
2019-04-10XACML PDP DmaaP Deploy/UnDeploy FunctionMichael Mokry26-826/+653
1. Added PDPUpdate listener 2. Added PDPUpdate Publisher 3. Added code to handle PdpUpdate messages and load policies being deployed 4. Modified Activator to register listener 5. Provided placeholder code to get policies from pdpx for return PdpStatus response to the PAP 6. Other minor modifications 7. Fix XacmlPdpApplicationManager to only load policy if supports policy type. 8. Checkstyle fixes 9. Updated applications to support loadPolicy(ToscaPolicy) and all the translators, JUnit tests. 10. Consolidated some duplicate code in the applications. Can probably do more in that area. 11. Fixed bug in Properties not really having a copy constructor. Change-Id: Ic29ad426061cbdb79c1339314667bb8ff8decb88 Issue-ID: POLICY-1451 Signed-off-by: Michael Mokry <michael.mokry@att.com> Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-04-10Merge "Test decision from main entry"Jorge Hernandez28-145/+451
2019-04-10Test decision from main entryPamela Dragosh28-145/+451
Tests a decision upon startup. This also updates the use of ToscaPolicyTypeIdentifier for all the applications. Very basic packaging for applications and their properties. Added cleaning of unused imports to remove sonar issues. Added production persistence.xml file to guard application. Not sure if we need a copy in the application/common resource directory. Issue-ID: POLICY-1440 Change-Id: If96eef5a9e0a7c6cc5461c0bdb6f0cd708cc41bb Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-04-08Adds basic performance tests for XACML PDPBilal A6-24/+423
Includes 1) Basic health check and stats performance test 2) Analysis script 3) Fixed https protocol in stability test Change-Id: I78a6daf3cae40daf4779ced515283abb19743e4b Issue-ID: POLICY-1461 Signed-off-by: Bilal A <bilal@research.att.com>
2019-04-05Xacml PDP Register/Unregister ChangesMichael Mokry21-99/+638
1) Modified activator - Extend and use ServiceManagerContainer - add topicSink and topicSource properties to TopicEndpoint manager 2) Added PAP registration class 3) Added PDP message formatting class 4) Added PDP State Change listener to listen for state change and send back PDP Status.. then start heartbeat if not started already 5) Added Heartbeat publisher code to send heartbeat status on periodic interval 6) UPDATE: Made changes to satisfy Jim's review comments 7) Added code to XacmlPdpApplicationManager to get supportedPolicyTypes 8) UPDATE: more changes to satisfy Jim's latest review comments 9) Fixed the failed Junits causing build failure 10) Made change to use NetworkUtil for getting PdpStatus name value per Jorge's comment Still need to in separate review: 1) Write Junits for new code Registration and heartbeat flow as I understand it: 1) PDP starts and sends initial status to PAP with PASSIVE state 2) PDP listens for State Change from the PAP 3) PDP sends updated Active state to the AP 4) PDP begins sending periodic heartbeat status to the PAP Change-Id: Iafa06ae3f1ee195c7da3710a12d9c095c5413ec2 Issue-ID: POLICY-1449 Signed-off-by: Michael Mokry <michael.mokry@att.com>
2019-04-04Tie XACML REST DecisionPamela Dragosh16-105/+456
Ties the decision API to the applications. Adds a static application manager class to manager the applications. Added applicationPath as a parameter to be supported in the Json parameter group. Issue-ID: POLICY-1440 Change-Id: I43cb44b3e308aadcf258fd987f3b53944c2edb72 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-04-01Adding guard PIPPamela Dragosh23-99/+955
Adding the PIP support into the translator to setup the count attribute as an attribute generated by PIP and not sent by calling application. Added JUnit for OperationsHistoryPipEngine. Issue-ID: POLICY-1471 Change-Id: I71773ee8ea0e6c02873506d973a604899383d4b5 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-03-26Fix comments and add debuggingPamela Dragosh7-55/+60
Added some fixes from previous review and some debugging for the JUnits. The merge failed in the JUnits and I could not see why. I think the wrong request was sent, but I'm not sure why the JUnits woulnd't fail locally or in the verify job. We need to do a lot of testing with these policy translations. Also fixed the guard policies to use correct VF Module Create recipe. Issue-ID: POLICY-1273 Change-Id: I813bcca92436d356c43da5613eab7ba7746a4e3d Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-03-25Adding optimization application finish guardPamela Dragosh38-595/+2881
Created Optimization application and created a translator for it. The translator makes an assumption that OOF wants to query on policyScope and policyType properties. Rearranged some of the test code for re-usability. Guard policies are now creating for frequency limiter and min max. Probably could use some clean up. Upgraded to xacml 2.0.1 to include a fix for handling null attribute values. Added some code to test missing values. Issue-ID: POLICY-1273 Change-Id: Ia3dbfa992bbe0cbb5aa294c38aa2aff430a3230a Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-03-21Reorder xacml 2.0.0 loadingPamela Dragosh2-11/+5
This dependency should only be in the applications area. Reordering may help ensure that the correct jackson is loaded for glassfish. Issue-ID: POLICY-1609 Change-Id: I727a5266204e8e2e5c35b7a326baff854b55e523 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-03-21Merge "Use Policy Translator abstract class"Jorge Hernandez17-592/+878
2019-03-20Merge "Fix sonar issues xacml pdp"Jorge Hernandez4-8/+10
2019-03-20Use Policy Translator abstract classPamela Dragosh17-592/+878
Instead of applications implementing the converter, use a protected abstract class that implements common code. Newer applications could re-use existing application, and shared code can be put into the base translator class. Fixed sonar issue and changed guard xml. Removed Converter and made translator into an implementation class that is an object in the Application Provider. Issue-ID: POLICY-1273 Change-Id: I9b48cbcdaf80d6d2ef19ef53e4b7cd4830e7e7b2 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-03-19Exclude jackson-annotationsPamela Dragosh1-0/+6
Jackson 2.9.8 databind references annotations 2.9.0. This seems to break jersey which needs an earlier annotations version. I think we can safely exclude Xacml for now. Issue-ID: POLICY-1609 Change-Id: I60b76e742412ffe36c83e58863902b35b23148fb Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-03-19Fix sonar issues xacml pdpPamela Dragosh4-8/+10
Fixed some small sonar issues. Some of the others will be taken care of when we implement things. Issue-ID: POLICY-1602 Change-Id: I745962feaf00904c39b2e80e00bcc565f51dc8fd Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-03-18Started with test decision JSON objects.Pamela Dragosh30-426/+1585
Added new Policy Finder Factory that ONAP will use and got the code working with new policy/models (see other review which will have to be merged first). Added some new conversion methods to convert from a Xacml request to an Onap request. Added some property methods for XACML Properties objects and JUnit tests. Started filling in some Guard application details and combining code. Issue-ID: POLICY-1602 Change-Id: I5235b74f3b036dcf05779b655a03ac290d594354 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-03-17Add NSS libraries to imagesJorge Hernandez1-2/+2
Alpine OpenJDK was updated 2 days ago (3/14), this upgrade seems to break java applications that depend on libnss*.so OS libraries, which seem are no longer installed with the jdk Change-Id: Iac67f7ff2e74f36369e8ce7b8ef91a940ae5c4d8 Issue-ID: POLICY-1604 Signed-off-by: Jorge Hernandez <jorge.hernandez-herrero@att.com>
2019-03-15Update INFO.yaml fileJessica Wagantall1-3/+26
Update missing information blocks and indentation to pass verify job. Change-Id: I302d33ba73fd583989d6a0f8f0b460329f83537e Issue-ID: CIMAN-134 Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
2019-03-15Monitoring policy creation foundationPamela Dragosh48-47/+2792
Upgrde to xacml v2.0.0 release artifact. Some re-arrangement of classes. New class to support a common dictionary among the monitoring applications. I may move it to a common under the main since some of the values are shareable. Created application service provider, so the XACML main knows what policy types are pre-loaded and can report them back to the PAP. struggled with cucumber, which does not create TemporaryFolder although the documentation says its supported. Added a new Policy Finder specific to ONAP which does quicker job to load policies. Issue-ID: POLICY-1273 Change-Id: I4af15a64da3b42d48f29809710421b1649625adc Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-03-11Added HTTPS and CADI/AAF Support for PDP-XMichael Mokry11-68/+445
- Yay I found the mysterious https issue that caused the junit to fail. Please don't laugh, it was a typo :) - Made changes per review comments 1) Added builder class for RestServer constructor 2) removed some try/catch blocks in junit 3) Other minor changes - More changes per review comments - Added changes per Ram's review comments (not lombrok yet) - Made changes for ONAP API CVS guidelines Change-Id: Ie1a6225459b3ce235cd73828ccddec04c690f5fd Issue-ID: POLICY-1436 Signed-off-by: Michael Mokry <michael.mokry@att.com>
2019-03-07Merge "Use Alpine as base docker image in xacml-pdp"Jorge Hernandez3-20/+13
2019-03-07Merge "Adds basic stability tests for XACML PDP"Jorge Hernandez5-0/+444
2019-03-07Use Alpine as base docker image in xacml-pdpshaoqiu3-20/+13
Issue-ID: POLICY-1554 Change-Id: Ia80f01317f2f224e55ddc18139ac49ca19883cd1 Signed-off-by: shaoqiu <tim.huang@est.tech>
2019-03-05Adds basic stability tests for XACML PDPBilal A5-0/+444
Includes 1) Basic health check test 2) Statistics API test Change-Id: I41156007dfb70702822d50f5bb32dbaae36bc610 Issue-ID: POLICY-1461 Signed-off-by: Bilal A <bilal@research.att.com>
2019-03-04Foundation for Monitoring DecisionsPamela Dragosh12-0/+530
This sets the foundation for building the XACML PDP engine that supports Decisions for onap.Monitoring policy types. Mostly stubbed code for now, will most likely get re-arranged. Put in the cucumber basics, but no implementation yet. Need policy/parent to be merged before this will pass. * Fixed checkstyle license date Issue-ID: POLICY-1273 Change-Id: Ifb455065316fd3ec0a025b5833b334ee72f65adc Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-03-01Change package name to fix docker image issueMichael Mokry1-1/+1
Change package name used in the policy-pdpx.sh for org.onap.policy.pdpx.main.startstop.Main Change-Id: Ibfc68827f8675ae447aa2797c8a0a42fc6c502d5 Issue-ID: POLICY-1436 Signed-off-by: Michael Mokry <michael.mokry@att.com>
2019-02-28Fix pdp-x docker image build problemsJorge Hernandez3-12/+4
Change-Id: I4023e4b5474b6ebb712179d134616f723e75432d Issue-ID: POLICY-1436 Signed-off-by: Jorge Hernandez <jorge.hernandez-herrero@att.com>
2019-02-28Update INFO.yaml Liam's emailPamela Dragosh1-1/+1
est.tech Issue-ID: POLICY-1556 Change-Id: Ic7098aba510ddb4c0673bc1525710540578b5174 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-02-26Stubbed endpoints for Decision API and swaggerMichael Mokry9-15/+120
Includes: 1) Decision API endpoint with Swagger annotations 2) Provider class for Decision added to new provider package 3) Moved other provider classes to provider package 4) Decision model class added to new model package Note: This is just a draft and still needs a lot of work, please do not merge. Thanks in advance for the review comments. Issue-ID: POLICY-1516 Change-Id: Id7414b6cb3eee1b877a0c11521babbef4938a68f Signed-off-by: Michael Mokry <michael.mokry@att.com>
2019-02-13Package and Create Docker Image for Xacml PDPMichael Mokry18-62/+729
- Creates docker image of policy xacml-pdp - Creates zip package of policy xacml-pdp - Also committed changes from Healthcheck/Statitics review that were allowed to be deferred Change-Id: Ia5fb72be05a30a341692453fe4ff32c7b112e861 Issue-ID: POLICY-1436 Signed-off-by: Michael Mokry <michael.mokry@att.com>