1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
|
/*-
* ============LICENSE_START=======================================================
* Copyright (C) 2021-2022 Bell Canada. All rights reserved.
* ================================================================================
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
* ============LICENSE_END=========================================================
*/
package org.onap.policy.pap.main.rest.e2e;
import static org.assertj.core.api.Assertions.assertThat;
import java.time.Instant;
import java.util.ArrayList;
import java.util.List;
import javax.ws.rs.client.Invocation;
import javax.ws.rs.core.GenericType;
import javax.ws.rs.core.Response;
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
import org.onap.policy.models.base.PfModelRuntimeException;
import org.onap.policy.models.pap.concepts.PolicyAudit;
import org.onap.policy.models.pap.concepts.PolicyAudit.AuditAction;
import org.onap.policy.models.tosca.authorative.concepts.ToscaConceptIdentifier;
import org.onap.policy.pap.main.repository.PolicyAuditRepository;
import org.onap.policy.pap.main.rest.PolicyAuditControllerV1;
import org.onap.policy.pap.main.service.PolicyAuditService;
import org.springframework.beans.factory.annotation.Autowired;
public class PolicyAuditTest extends End2EndBase {
private static final String TEST_GROUP = "testGroup";
private static final String TEST_PDP_TYPE = "testPdpType";
private static final ToscaConceptIdentifier POLICY_A = new ToscaConceptIdentifier("PolicyA", "1.0.0");
private static final ToscaConceptIdentifier POLICY_B = new ToscaConceptIdentifier("PolicyB", "2.0.0");
private static final String DEFAULT_USER = "TEST";
private static final String POLICY_AUDIT_ENDPOINT = "policies/audit";
private static final String URI_SEPERATOR = "/";
private static final String QUERY_PARAMS_INVALID = "?recordCount=5&startTime=2021-07-25T01:25:15";
private static final String QUERY_PARAMS_CORRECT = "?recordCount=5&startTime=1627219515&endTime=1627478715";
private static final String QUERY_PARAMS_INCORRECT = "?recordCount=5&startTime=1627478715&endTime=1627565115";
private static int NOT_FOUND_STATUS_CODE = 404;
private static int BAD_REQUEST_STATUS_CODE = 400;
private static final String BAD_REQUEST_MSG = "NumberFormatException For";
@Autowired
private PolicyAuditService policyAuditService;
@Autowired
private PolicyAuditRepository policyAuditRepository;
@Override
@Before
public void setUp() throws Exception {
super.setUp();
setupEnv();
}
/**
* Teardown after tests.
*/
@Override
@After
public void tearDown() {
policyAuditRepository.deleteAll();
super.tearDown();
}
private void setupEnv() {
List<PolicyAudit> recordList = new ArrayList<>();
Instant auditRecordTime = Instant.ofEpochSecond(1627392315L);
try {
PolicyAudit audit1 = PolicyAudit.builder().pdpGroup(TEST_GROUP).pdpType(TEST_PDP_TYPE)
.policy(POLICY_A).action(AuditAction.DEPLOYMENT)
.timestamp(auditRecordTime).user(DEFAULT_USER).build();
PolicyAudit audit2 = PolicyAudit.builder().pdpGroup(TEST_GROUP).pdpType(TEST_PDP_TYPE)
.policy(POLICY_B).action(AuditAction.UNDEPLOYMENT)
.timestamp(auditRecordTime).user(DEFAULT_USER).build();
recordList.add(audit1);
recordList.add(audit2);
policyAuditService.createAuditRecords(recordList);
} catch (Exception exp) {
throw new PfModelRuntimeException(Response.Status.BAD_REQUEST, exp.getMessage());
}
}
@Test
public void testGetAllAuditRecords() throws Exception {
String uri = POLICY_AUDIT_ENDPOINT;
sendAndValidateSuccess(uri, 2);
}
@Test
public void testGetAllAuditRecordsWithParams() throws Exception {
// try with correct dates in query, should result in 2 records
String uri = POLICY_AUDIT_ENDPOINT + QUERY_PARAMS_CORRECT;
sendAndValidateSuccess(uri, 2);
// try with incorrect dates in query, should result in 0 record
uri = POLICY_AUDIT_ENDPOINT + QUERY_PARAMS_INCORRECT;
sendAndValidateSuccess(uri, 0);
// try with invalid date format, should result in error
uri = POLICY_AUDIT_ENDPOINT + QUERY_PARAMS_INVALID;
sendAndValidateError(uri, BAD_REQUEST_MSG, BAD_REQUEST_STATUS_CODE);
}
@Test
public void testGetAuditRecordsByGroup() throws Exception {
String uri = POLICY_AUDIT_ENDPOINT + URI_SEPERATOR + TEST_GROUP;
sendAndValidateSuccess(uri, 2);
}
@Test
public void testGetAuditRecordsByGroupWithParams() throws Exception {
// try with correct dates in query, should result in 2 records
String uri = POLICY_AUDIT_ENDPOINT + URI_SEPERATOR + TEST_GROUP + QUERY_PARAMS_CORRECT;
sendAndValidateSuccess(uri, 2);
// try with incorrect dates in query, should result in error
uri = POLICY_AUDIT_ENDPOINT + URI_SEPERATOR + TEST_GROUP + QUERY_PARAMS_INCORRECT;
sendAndValidateError(uri, PolicyAuditControllerV1.NO_AUDIT_RECORD_FOUND, NOT_FOUND_STATUS_CODE);
// try with invalid date format, should result in error
uri = POLICY_AUDIT_ENDPOINT + URI_SEPERATOR + TEST_GROUP + QUERY_PARAMS_INVALID;
sendAndValidateError(uri, BAD_REQUEST_MSG, BAD_REQUEST_STATUS_CODE);
}
@Test
public void testGetAuditRecordsOfPolicyWithGroup() throws Exception {
String uri = POLICY_AUDIT_ENDPOINT + URI_SEPERATOR + TEST_GROUP + URI_SEPERATOR + POLICY_A.getName()
+ URI_SEPERATOR + POLICY_A.getVersion();
sendAndValidateSuccess(uri, 1);
}
@Test
public void testGetAuditRecordsOfPolicyWithGroupWithParams() throws Exception {
// try with correct dates in query, should result in 1 record
String uri = POLICY_AUDIT_ENDPOINT + URI_SEPERATOR + TEST_GROUP + URI_SEPERATOR + POLICY_A.getName()
+ URI_SEPERATOR + POLICY_A.getVersion() + QUERY_PARAMS_CORRECT;
sendAndValidateSuccess(uri, 1);
// try with incorrect dates in query, should result in error
uri = POLICY_AUDIT_ENDPOINT + URI_SEPERATOR + TEST_GROUP + URI_SEPERATOR + POLICY_A.getName()
+ URI_SEPERATOR + POLICY_A.getVersion() + QUERY_PARAMS_INCORRECT;
sendAndValidateError(uri, PolicyAuditControllerV1.NO_AUDIT_RECORD_FOUND, NOT_FOUND_STATUS_CODE);
// try with invalid date format, should result in error
uri = POLICY_AUDIT_ENDPOINT + URI_SEPERATOR + TEST_GROUP + URI_SEPERATOR + POLICY_A.getName() + URI_SEPERATOR
+ POLICY_A.getVersion() + QUERY_PARAMS_INVALID;
sendAndValidateError(uri, BAD_REQUEST_MSG, BAD_REQUEST_STATUS_CODE);
}
@Test
public void testGetAuditRecordsOfPolicyWithoutGroup() throws Exception {
String uri = POLICY_AUDIT_ENDPOINT + URI_SEPERATOR + POLICY_A.getName() + URI_SEPERATOR + POLICY_A.getVersion();
sendAndValidateSuccess(uri, 1);
}
@Test
public void testGetAuditRecordsOfPolicyWithoutGroupWithParams() throws Exception {
// try with correct dates in query, should result in 1 record
String uri = POLICY_AUDIT_ENDPOINT + URI_SEPERATOR + POLICY_A.getName() + URI_SEPERATOR + POLICY_A.getVersion()
+ QUERY_PARAMS_CORRECT;
sendAndValidateSuccess(uri, 1);
// try with incorrect dates in query, should result in error
uri = POLICY_AUDIT_ENDPOINT + URI_SEPERATOR + POLICY_A.getName() + URI_SEPERATOR + POLICY_A.getVersion()
+ QUERY_PARAMS_INCORRECT;
sendAndValidateError(uri, PolicyAuditControllerV1.NO_AUDIT_RECORD_FOUND, NOT_FOUND_STATUS_CODE);
// try with invalid date format, should result in error
uri = POLICY_AUDIT_ENDPOINT + URI_SEPERATOR + POLICY_A.getName() + URI_SEPERATOR
+ POLICY_A.getVersion() + QUERY_PARAMS_INVALID;
sendAndValidateError(uri, BAD_REQUEST_MSG, BAD_REQUEST_STATUS_CODE);
}
private void sendAndValidateSuccess(String uri, int count) throws Exception {
Invocation.Builder invocationBuilder = sendRequest(uri);
Response rawresp = invocationBuilder.get();
assertThat(rawresp.getStatus()).isEqualTo(Response.Status.OK.getStatusCode());
List<PolicyAudit> resp = rawresp.readEntity(new GenericType<List<PolicyAudit>>() {});
assertThat(resp).hasSize(count);
for (PolicyAudit audit : resp) {
if (audit.getAuditId() == 123L) {
assertThat(audit.getPdpGroup()).isEqualTo(TEST_GROUP);
assertThat(audit.getPdpType()).isEqualTo(TEST_PDP_TYPE);
assertThat(audit.getPolicy()).isEqualTo(POLICY_A);
assertThat(audit.getAction()).isEqualTo(AuditAction.DEPLOYMENT);
assertThat(audit.getUser()).isEqualTo(DEFAULT_USER);
} else if (audit.getAuditId() == 456L) {
assertThat(audit.getPdpGroup()).isEqualTo(TEST_GROUP);
assertThat(audit.getPdpType()).isEqualTo(TEST_PDP_TYPE);
assertThat(audit.getPolicy()).isEqualTo(POLICY_B);
assertThat(audit.getAction()).isEqualTo(AuditAction.UNDEPLOYMENT);
assertThat(audit.getUser()).isEqualTo(DEFAULT_USER);
}
}
}
private void sendAndValidateError(String uri, String errorMessage, int statusCode) throws Exception {
Invocation.Builder invocationBuilder = sendRequest(uri);
Response rawresp = invocationBuilder.get();
assertThat(rawresp.getStatus()).isEqualTo(statusCode);
String resp = rawresp.readEntity(String.class);
assertThat(resp).contains(errorMessage);
}
}
|
