aboutsummaryrefslogtreecommitdiffstats
path: root/main
AgeCommit message (Collapse)AuthorFilesLines
2021-02-12Fix sonars from dependency upgradeJim Hahn7-23/+22
The dependency upgrades in policy-parent caused some new sonars. In particular, initMocks() has been deprecated - replaced with calls to the Mockito Runner and one call to openMocks(). Issue-ID: POLICY-2911 Change-Id: I6f28af9af41a1e5c83dead2eabf580731ffb9526 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-02-10More sonars in papJim Hahn1-4/+4
Addressed the following issues: - don't use eq() with verify() Issue-ID: POLICY-2911 Change-Id: Idf08195e4e2fb74e5e0d0d30f31b9e630720f48f Signed-off-by: Jim Hahn <jrh3@att.com>
2021-02-07Make filters on TOSCA entities genericliamfallon2-55/+51
The classes PolicyTypeFilter and PolicyFilter only work on Policy types and policies. However they just filter on name/version/type/typeversion so there is no reason that the filters could not be applied to other entities. This commit adapts the PolicyTypeFilter to EntityFilter and PolicyFilter to TypedEntityFilter, so the filters can be applied to collections of any ToscaEntity class. Issue-ID: POLICY-2995 Change-Id: I7cc0ffa23fb12ab5b6e7617491dccd6f3289fa22 Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-01-15Make PAP statelessJim Hahn40-2774/+623
Removed old code that tracked the status using a cache. Modified the code to use the status found in the DB instead. Issue-ID: POLICY-2648 Change-Id: I4f1f5201eff7b3352631f50d67c40349ac7f2014 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-01-14Add class to manage policy deployment recordsJim Hahn4-0/+855
Issue-ID: POLICY-2648 Change-Id: Icbb9545e3df6942e6f9cf98689607c461f6c8cdd Signed-off-by: Jim Hahn <jrh3@att.com>
2021-01-13Add notification tracking classesJim Hahn6-0/+675
When PAP is made stateless, a new mechanism will be needed to track and generate notifications. Added some classes to facilitate that. Issue-ID: POLICY-2648 Change-Id: Ib7b707f68a557e7b306dfdd1c6e6e9abd4671ec1 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-01-05Changed identifiers to concept identifiersliamfallon37-294/+321
The policy models tosca classes ToscaPolicyIdentifier and ToscaPolicyIdentifierOptVersion can be used to identify any TOSCA concept, not just TOSCA policies so they are renamed to ToscaConceptIdentifier and ToscaCinceptIdentifierOptVersion respectively. The class ToscaPolicyTypeIdentifier is redundant and is replaced by ToscaConceptIdentifier. Issue-ID: POLICY-2900 Change-Id: I22bb3fdbaf2e237221a5c89afbf7898410603835 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-12-17Update persistence.xml with new TOSCA classesliamfallon2-12/+42
Issue-ID: POLICY-2900 Change-Id: I986074f69bef24ca894adc38eaf8b3ca4b4dc5a2 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-12-04Fixing sonar issues in policy-papa.sreekumar4-5/+9
Change-Id: I0f81906098c310aa5c437a2c06b708ae27560af8 Issue-ID: POLICY-2911 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2020-11-06Fix upcoming checkstyle issuesPamela Dragosh1-3/+3
When we upgrade to oparent, these will fail as oparent upgrades to 8.37 of puppycrawl which fixes a few bugs that should have flagged these previously. Issue-ID: POLICY-2887 Change-Id: I7c04f58c683d6eb0322232790e0561b464c1696a Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-10-27Bump pap master to 2.4.0-SNAPSHOTRam Krishna Verma1-1/+1
Issue-ID: POLICY-2875 Change-Id: Ibad95f08cb39adc285f9326dd1d590163ede5803 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-10-20Bump pap 2.3.4 SNAPSHOTPamela Dragosh1-1/+1
Issue-ID: POLICY-2869 Change-Id: I3696c9c6cae59124f0269f1d2619b22b134b882c Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-10-07Bump pap to 2.3.3 snapshotPamela Dragosh1-1/+1
Issue-ID: POLICY-2839 Change-Id: I37704935946a8c249e814bf4e515178528705cd6 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-10-06Remove legacy operational apex policy type from papRam Krishna Verma3-24/+28
The legacy operational policy type for apex has been removed in Guilin release. Removing it fron pdpGroup config in PAP. Issue-ID: POLICY-2857 Change-Id: Iddf2e6b6301dbab3addcbff4c806142f4cf8e6c6 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-09-30Fix new sonars in policy/papJim Hahn3-64/+67
Addressed the following sonar issues: - too many assertions in test method - extract common test method - replace this null literal by an "Optional" object Issue-ID: POLICY-2679 Change-Id: Ie80e5c5fdb94230a2773ea2931758cf54204ae86 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-09-24update default keystoresjhh1-0/+0
Issue-ID: POLICY-2827 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I95db673538947cccc39bb5a389ab3f544fa91af8
2020-09-08Bump pap to 2.3.2Jim Hahn1-1/+1
Issue-ID: POLICY-2789 Change-Id: Ie4d4df890c1faac0e09d78d3b0d0157d8ef95410 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-08-24Add Match Policy Type to default groupPamela Dragosh1-0/+4
Default group will now have match Policy Type. Issue-ID: POLICY-2596 Change-Id: I53c07b417097dc8250191e6ee8d043488b02562d Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-08-17Add new guard filter to defaultGroupPamela Dragosh1-0/+4
New guard filter should be advertised by pap. Issue-ID: POLICY-2590 Change-Id: I7652057d4d759e60c358ee9fad84a8c6a9af6898 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-08-14Using standard success/failure messages in PAPa.sreekumar2-9/+9
Change-Id: If4613c0fc6f940bc82cf616aba2ba9cc03e1b599 Issue-ID: POLICY-2754 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2020-08-10Merge "Changes to make PAP container crash with non zero exitCode"Pamela Dragosh2-34/+28
2020-08-10Changes to make PAP container crash with non zero exitCodea.sreekumar2-34/+28
Make the application to return exitCode as 1 when the main process terminates due to issues such as: 1) Any basic issue in the startup config file causing error and terminates the main process, for e.g. a wrong name in parameterGroup. 2) Wrong info specified for database connectivity, say wrong username. This doesn't impact a case where database isn't ready yet and PAP container comes up first, such waiting is already handled by initContainer in the oom chart. PAP pod waits for policy-mariadb pod to be ready first, then only the main process is started and comes to this point. 3) An invalid port number is specified and the rest server is not able to start. These are the some of the scenarios which already makes the main process of PAP to terminate, and in these cases, an exception is thrown now which returns the exitCode as 1. Change-Id: Ie48726bcb36d7304eb60807fbaabbee8245e9c70 Issue-ID: POLICY-2754 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2020-08-07Merge "Fail component health check if PDP is down"Jim Hahn4-14/+51
2020-08-07Fail component health check if PDP is downRam Krishna Verma4-14/+51
Changing the policy component health check to fail if the required PDP instances are down or not registered with PAP. The check is performed by comparing the "currentInstanceCount" & "desiredInstanceCount" fields of PdpSubGroup. Issue-ID: POLICY-2718 Change-Id: Iad1075d0812f4ef166dfed4f110eff4d9e5f995e Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-08-06Remove legacy operational policy from papRam Krishna Verma1-4/+0
Issue-ID: POLICY-2763 Change-Id: I9701a80cca10b9fd49d8060ecb6601097ca5824d Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-07-10Bump pap to 2.3.1-SNAPSHOTRam Krishna Verma1-1/+1
Issue-ID: POLICY-2695 Change-Id: I7f30fa9c89d7ad9ddc00644c170d8659f7ee3230 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-07-06Replace try/catch blocks with assertj - papwaynedunican1-34/+14
Replaced try/catch blocks in policy/pap test cases with assertj assertions Issue-ID: POLICY-2451 Change-Id: Ic963558e812b59d321e12fa87e7285732d6761e5 Signed-off-by: waynedunican <wayne.dunican@est.tech>
2020-06-30Fix more sonars in papJim Hahn1-3/+4
Somehow missed this sonar on one line of code: - remove useless assignments Apparently, sonar only complains about some useless assignments (perhaps those that do more than copy a constant). Fixed one about which it did not complain, which appeared immediately before the one about which it DID complain. At one point, sonar complained about creating ArrayLists without specifying the initial size (when it was known). It didn't complain about this one, but went ahead and fixed it anyway. Issue-ID: POLICY-2679 Change-Id: I270341195634416db1f8152a95a5822c8d505803 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-06-30Merge "Fix issues in pap for new sonar rules"Liam Fallon3-11/+15
2020-06-29Fix issues in pap for new sonar rulesJim Hahn3-11/+15
Addressed issues reported due to updates to the sonar rules: - invoke only one method in a junit lambda Issue-ID: POLICY-2679 Change-Id: I422856527b191a45b30a78bb8520f679ca2e7896 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-06-29Parallel execution of Client Health checkRam Krishna Verma3-44/+85
Issue-ID: POLICY-2390 Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca> Change-Id: I42f443c64bcf6652adb9795ee8e71e37d8fa8c71
2020-06-19Changes for Checkstyle 8.32 in policy-papa.sreekumar10-17/+1
Change-Id: I995515659a4b7837bb15120f9c50fa0fd1f5434c Issue-ID: POLICY-2188 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2020-06-18pap - sonar issue fixTaka Cho2-4/+6
replace by assertNotSame Issue-ID: POLICY-2616 Change-Id: I927dbd8c57654cd2d2ef6262d13d63c79ba9035f Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-17PAP should discard old PDP messagesJim Hahn7-12/+78
Modified PAP to discard any messages old than 10 minutes so that if PAP is unable to communicate with DMaaP and then suddently gets flooded, it will discard old messages. Updates per review comments - made the "max message age" configurable, with a default of 10 minutes Issue-ID: POLICY-2170 Change-Id: I541c03aabf29482af12a07f51eeb5888bbafbf31 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-06-11Switching logging of ToscaPolicyXXXIdentifiers to use new toString()RossC4-10/+13
Issue-ID: POLICY-2078 Change-Id: I035eceb45e76ef11df0e903b584fcf7f8eb63208 Signed-off-by: RossC <ross.carter@est.tech>
2020-05-20Bump pap master to 2.3.0-SNAPSHOTRam Krishna Verma1-1/+1
Issue-ID: POLICY-2514 Change-Id: Id780f9bc672cde633cf3d7d42b7c9f98fad0396f Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-05-20Bump pap to 2.2.4-SNAPSHOTRam Krishna Verma1-1/+1
Issue-ID: POLICY-2514 Change-Id: Iea5b6375975b0225d5b803cc2500adc46fc83804 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-05-04Eliminate spurious notifications from PAPJim Hahn4-51/+14
Tracked it down to the following sequence: - policies were deployed to the pdp - received a request to undeploy a policy - generated a notification for the formerly deployed policy - this should not have been generated - undeployed the policy - received a response from the pdp indicating the policy had been undeployed - generated a notification indicating the policy was undeployed Removed the code that generated a notification when a policy is initially moved from deployed to undeployed (or vice versa). Issue-ID: POLICY-2539 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: If175974b5fa5ccda6a1e1ab8fa1326b263bb8005
2020-04-29PAP should discard responses for old requestsJim Hahn3-6/+29
This is a more robust solution to the race condition previously identified with back-to-back deployment requests. The old fix has been rolled back and replaced with this fix. Issue-ID: POLICY-2527 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I2ea93f3a5eaac822abecf5d0745429b95712c861
2020-04-28Merge "PAP erroneously undeploying policies"Pamela Dragosh1-4/+7
2020-04-28PAP erroneously undeploying policiesJim Hahn1-4/+7
The problem appears to be a multi-threading type of issue: - PAP sends request to XACML - JMeter pushes the next deployment request into PAP - PAP receives response from XACML - based on request ID, the response is routed to the handler, but blocks while PAP processes the deployment request - PAP replaces old list of policies with new, and changes the request ID - PAP responds to JMeter - PAP handles XACML response, even though it's request ID no longer matches Modified PAP to no longer replace any messages that are at the head of the queue. Fixed the license. Issue-ID: POLICY-2527 Change-Id: I43218a7d0591649d761e17282189e51d5dbd26ed Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-28Merge "point to renamed sdnc naming policy in db config"Jim Hahn1-1/+1
2020-04-28point to renamed sdnc naming policy in db configjhh1-1/+1
Issue-ID: POLICY-2525 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Iea676911eaa7222949959ed0a7074b1260d8ce87
2020-04-24Point pap to new parentJim Hahn1-1/+1
Issue-ID: POLICY-2510 Change-Id: I7dae085491e10082f222404179554436beb81bf1 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-24Activating active group should be NOOPJim Hahn1-17/+2
Fixed the code so that if a request is made to activate a PDP Group that is already active, the group remains active. Issue-ID: POLICY-2522 Change-Id: I106332b1ce15fde8dbf0b3e72034fd11c250dc69 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-15Bump pap to 2.2.2-SNAPSHOTRam Krishna Verma1-1/+1
Issue-ID: POLICY-2378 Change-Id: I91483bc2ab270a6cce251a1b8e80b9767d956d89 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-04-09Remaining sonar issues in papJim Hahn2-3/+5
Addressed these remaining sonar issues: - main arg validation - TODO item regarding subgroup updates with no PDPs - after discussion, it was decided to not do this Issue-ID: POLICY-2305 Change-Id: Ib2b340d029679d6cd2b2a558318b25d38b830833 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-08Merge "Address sonar issues in PAP"Jim Hahn3-7/+14
2020-04-07Preload sdnc naming policy in xacml-pdpRam Krishna Verma1-1/+6
Adding sdnc naming policy to xacml subgroup in defaultGroup so that the policy can be auto deployed to the xacml-pdp after registration with PAP. Issue-ID: POLICY-2476 Change-Id: I355e7b5e56b9a6a7f0fda96a7b2dfd640b7bd930 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-04-07Address sonar issues in PAPJim Hahn3-7/+14
Addressed the following sonar issues in PAP: - do something with value returned by a method - use computeIfAbsent; chose to disable the sonar for this, as it would obfuscate the code - use RE2 instead of java.util Pattern Issue-ID: POLICY-2305 Change-Id: If5495d04248211179cd37419cb20fe7d227ab59c Signed-off-by: Jim Hahn <jrh3@att.com>