Age | Commit message (Collapse) | Author | Files | Lines |
|
Make the application to return exitCode as 1 when the main process
terminates due to issues such as:
1) Any basic issue in the startup config file causing error and
terminates the main process, for e.g. a wrong name in parameterGroup.
2) Wrong info specified for database connectivity, say wrong username.
This doesn't impact a case where database isn't ready yet and PAP
container comes up first, such waiting is already handled by
initContainer in the oom chart. PAP pod waits for policy-mariadb pod to
be ready first, then only the main process is started and comes to this
point.
3) An invalid port number is specified and the rest server is not able
to start.
These are the some of the scenarios which already makes the main process
of PAP to terminate, and in these cases, an exception is thrown now which
returns the exitCode as 1.
Change-Id: Ie48726bcb36d7304eb60807fbaabbee8245e9c70
Issue-ID: POLICY-2754
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
|
|
Changing the policy component health check to fail if the required
PDP instances are down or not registered with PAP.
The check is performed by comparing the "currentInstanceCount"
& "desiredInstanceCount" fields of PdpSubGroup.
Issue-ID: POLICY-2718
Change-Id: Iad1075d0812f4ef166dfed4f110eff4d9e5f995e
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Issue-ID: POLICY-2763
Change-Id: I9701a80cca10b9fd49d8060ecb6601097ca5824d
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Issue-ID: POLICY-2695
Change-Id: I7f30fa9c89d7ad9ddc00644c170d8659f7ee3230
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Replaced try/catch blocks in policy/pap test cases with assertj
assertions
Issue-ID: POLICY-2451
Change-Id: Ic963558e812b59d321e12fa87e7285732d6761e5
Signed-off-by: waynedunican <wayne.dunican@est.tech>
|
|
Somehow missed this sonar on one line of code:
- remove useless assignments
Apparently, sonar only complains about some useless assignments (perhaps
those that do more than copy a constant). Fixed one about which it did
not complain, which appeared immediately before the one about which it
DID complain.
At one point, sonar complained about creating ArrayLists without
specifying the initial size (when it was known). It didn't complain
about this one, but went ahead and fixed it anyway.
Issue-ID: POLICY-2679
Change-Id: I270341195634416db1f8152a95a5822c8d505803
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
Addressed issues reported due to updates to the sonar rules:
- invoke only one method in a junit lambda
Issue-ID: POLICY-2679
Change-Id: I422856527b191a45b30a78bb8520f679ca2e7896
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2390
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: I42f443c64bcf6652adb9795ee8e71e37d8fa8c71
|
|
Change-Id: I995515659a4b7837bb15120f9c50fa0fd1f5434c
Issue-ID: POLICY-2188
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
replace by assertNotSame
Issue-ID: POLICY-2616
Change-Id: I927dbd8c57654cd2d2ef6262d13d63c79ba9035f
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
Modified PAP to discard any messages old than 10 minutes so that
if PAP is unable to communicate with DMaaP and then suddently gets
flooded, it will discard old messages.
Updates per review comments
- made the "max message age" configurable, with a default of 10 minutes
Issue-ID: POLICY-2170
Change-Id: I541c03aabf29482af12a07f51eeb5888bbafbf31
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2078
Change-Id: I035eceb45e76ef11df0e903b584fcf7f8eb63208
Signed-off-by: RossC <ross.carter@est.tech>
|
|
Issue-ID: POLICY-2514
Change-Id: Id780f9bc672cde633cf3d7d42b7c9f98fad0396f
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Issue-ID: POLICY-2514
Change-Id: Iea5b6375975b0225d5b803cc2500adc46fc83804
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Tracked it down to the following sequence:
- policies were deployed to the pdp
- received a request to undeploy a policy
- generated a notification for the formerly deployed policy
- this should not have been generated
- undeployed the policy
- received a response from the pdp indicating the policy had
been undeployed
- generated a notification indicating the policy was undeployed
Removed the code that generated a notification when a policy is
initially moved from deployed to undeployed (or vice versa).
Issue-ID: POLICY-2539
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: If175974b5fa5ccda6a1e1ab8fa1326b263bb8005
|
|
This is a more robust solution to the race condition previously
identified with back-to-back deployment requests. The old fix has
been rolled back and replaced with this fix.
Issue-ID: POLICY-2527
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I2ea93f3a5eaac822abecf5d0745429b95712c861
|
|
|
|
The problem appears to be a multi-threading type of issue:
- PAP sends request to XACML
- JMeter pushes the next deployment request into PAP
- PAP receives response from XACML
- based on request ID, the response is routed to the handler,
but blocks while PAP processes the deployment request
- PAP replaces old list of policies with new, and changes the
request ID
- PAP responds to JMeter
- PAP handles XACML response, even though it's request ID no
longer matches
Modified PAP to no longer replace any messages that are at the
head of the queue.
Fixed the license.
Issue-ID: POLICY-2527
Change-Id: I43218a7d0591649d761e17282189e51d5dbd26ed
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
Issue-ID: POLICY-2525
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Iea676911eaa7222949959ed0a7074b1260d8ce87
|
|
Issue-ID: POLICY-2510
Change-Id: I7dae085491e10082f222404179554436beb81bf1
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Fixed the code so that if a request is made to activate a PDP Group
that is already active, the group remains active.
Issue-ID: POLICY-2522
Change-Id: I106332b1ce15fde8dbf0b3e72034fd11c250dc69
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2378
Change-Id: I91483bc2ab270a6cce251a1b8e80b9767d956d89
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Addressed these remaining sonar issues:
- main arg validation
- TODO item regarding subgroup updates with no PDPs
- after discussion, it was decided to not do this
Issue-ID: POLICY-2305
Change-Id: Ib2b340d029679d6cd2b2a558318b25d38b830833
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
Adding sdnc naming policy to xacml subgroup in defaultGroup so that the policy
can be auto deployed to the xacml-pdp after registration with PAP.
Issue-ID: POLICY-2476
Change-Id: I355e7b5e56b9a6a7f0fda96a7b2dfd640b7bd930
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Addressed the following sonar issues in PAP:
- do something with value returned by a method
- use computeIfAbsent; chose to disable the sonar for this,
as it would obfuscate the code
- use RE2 instead of java.util Pattern
Issue-ID: POLICY-2305
Change-Id: If5495d04248211179cd37419cb20fe7d227ab59c
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2472
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I1b57c9de5f5d2c4f374283487e56393c492110bd
|
|
Fix to ensure we support Policy Types for optimization.
Issue-ID: POLICY-2460
Change-Id: Ibfd6b7191fb441eb31d8f697ff4f320e2305264d
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2378
Change-Id: Ica314e9facad9ac45351d708505b566e37c1e347
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2271
Change-Id: Ib28a6f5321cc05b03994e180867461a631d40d75
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2378
Change-Id: I516da9f0ab9b704eaa0956ee735a7048d9167cc7
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2402
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I6386a6185089bfcc4358db2a0bdfe7a977b23992
|
|
Issue-ID: POLICY-2388
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I92d0fa515893ddf4182666201367e07e5408ef7a
|
|
New guard policy type
Issue-ID: POLICY-2243
Change-Id: Ide419148dda229537f7a736f37299edb891248ba
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-1689
Signed-off-by: huaxing <huaxing.jin@est.tech>
Change-Id: Ifda17a4486e1bce1ce0f523cc1984519b7fbc1aa
|
|
Policy models now throws an exception with a 404 code when policies are
not found. This change amends PAP to cope with this change.
Note: This change should be merged directly after the following
policy-models patch:
https://gerrit.onap.org/r/c/policy/models/+/101544
Issue-ID: POLICY-1402
Change-Id: Id38af4b2ad65797592c077e276861b962bc53ea2
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Change-Id: I0eccc6064eb0b49d84370104d1219074ec8bde71
Issue-ID: POLICY-2271
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Issue-ID: POLICY-2355
Change-Id: I91453c577dd07b4bc79b11b1a181da4319e99edf
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
apex-pdp"
|
|
Modified the code as follows:
Until all PDPs have responded (or been removed), no notifications for
their associated policies will be generated. However, once a response
has been received for every PDP, then a notification is generated.
For deployed policies, the notifications will continue to be generated
as PDPs move back and forth between the success and failed states, as
long as the policy is not undeployed.
For undeployed policies, on the other hand, no additional notifications
will be generated once all PDPs have successfully undeployed the policy.
However, until that point, like with deployed policies, notifications
will continue to be generated as PDPs move back and forth between the
success and failed states.
Added notification verifications in deploy and undeploy end-to-end tests.
Issue-ID: POLICY-2347
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I7d18dad1a7500e1efb7074e89ddaca4b1d368965
|
|
Change-Id: I4b8b66657e84fe1d86ffd7972ff5c183f6ea0f74
Issue-ID: POLICY-2147
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Change-Id: I14daaa3d56d3293095227e0e3121e4fd82425b68
Issue-ID: POLICY-2023
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
If a PDP's heart beats are missed, PAP silently removes the PDP
from the DB. Added a "logger" call.
Issue-ID: POLICY-2326
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I1189ef66ad5a47e88f8cae770bd1393cafeb2393
|
|
Issue-ID: POLICY-1593
Change-Id: I61be9364d09b520e30aeac6d825b6c84574790ac
Signed-off-by: HOCKLA <ah999m@att.com>
|
|
|
|
Issue-ID: POLICY-2303
Change-Id: Ide10256556a20e2ab3977ab2cfd876dd82e44390
Signed-off-by: Henry.Sun <henry.a.sun@est.tech>
|
|
Issue-ID: POLICY-1629
Signed-off-by: ning.xi <ning.xi@est.tech>
Change-Id: I104fc448d27a282c01e7f54db300f918374b8d07
|