aboutsummaryrefslogtreecommitdiffstats
path: root/main/src
AgeCommit message (Collapse)AuthorFilesLines
2020-06-11Switching logging of ToscaPolicyXXXIdentifiers to use new toString()RossC4-10/+13
Issue-ID: POLICY-2078 Change-Id: I035eceb45e76ef11df0e903b584fcf7f8eb63208 Signed-off-by: RossC <ross.carter@est.tech>
2020-05-04Eliminate spurious notifications from PAPJim Hahn4-51/+14
Tracked it down to the following sequence: - policies were deployed to the pdp - received a request to undeploy a policy - generated a notification for the formerly deployed policy - this should not have been generated - undeployed the policy - received a response from the pdp indicating the policy had been undeployed - generated a notification indicating the policy was undeployed Removed the code that generated a notification when a policy is initially moved from deployed to undeployed (or vice versa). Issue-ID: POLICY-2539 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: If175974b5fa5ccda6a1e1ab8fa1326b263bb8005
2020-04-29PAP should discard responses for old requestsJim Hahn3-6/+29
This is a more robust solution to the race condition previously identified with back-to-back deployment requests. The old fix has been rolled back and replaced with this fix. Issue-ID: POLICY-2527 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I2ea93f3a5eaac822abecf5d0745429b95712c861
2020-04-28Merge "PAP erroneously undeploying policies"Pamela Dragosh1-4/+7
2020-04-28PAP erroneously undeploying policiesJim Hahn1-4/+7
The problem appears to be a multi-threading type of issue: - PAP sends request to XACML - JMeter pushes the next deployment request into PAP - PAP receives response from XACML - based on request ID, the response is routed to the handler, but blocks while PAP processes the deployment request - PAP replaces old list of policies with new, and changes the request ID - PAP responds to JMeter - PAP handles XACML response, even though it's request ID no longer matches Modified PAP to no longer replace any messages that are at the head of the queue. Fixed the license. Issue-ID: POLICY-2527 Change-Id: I43218a7d0591649d761e17282189e51d5dbd26ed Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-28Merge "point to renamed sdnc naming policy in db config"Jim Hahn1-1/+1
2020-04-28point to renamed sdnc naming policy in db configjhh1-1/+1
Issue-ID: POLICY-2525 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Iea676911eaa7222949959ed0a7074b1260d8ce87
2020-04-24Activating active group should be NOOPJim Hahn1-17/+2
Fixed the code so that if a request is made to activate a PDP Group that is already active, the group remains active. Issue-ID: POLICY-2522 Change-Id: I106332b1ce15fde8dbf0b3e72034fd11c250dc69 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-09Remaining sonar issues in papJim Hahn2-3/+5
Addressed these remaining sonar issues: - main arg validation - TODO item regarding subgroup updates with no PDPs - after discussion, it was decided to not do this Issue-ID: POLICY-2305 Change-Id: Ib2b340d029679d6cd2b2a558318b25d38b830833 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-08Merge "Address sonar issues in PAP"Jim Hahn3-7/+14
2020-04-07Preload sdnc naming policy in xacml-pdpRam Krishna Verma1-1/+6
Adding sdnc naming policy to xacml subgroup in defaultGroup so that the policy can be auto deployed to the xacml-pdp after registration with PAP. Issue-ID: POLICY-2476 Change-Id: I355e7b5e56b9a6a7f0fda96a7b2dfd640b7bd930 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-04-07Address sonar issues in PAPJim Hahn3-7/+14
Addressed the following sonar issues in PAP: - do something with value returned by a method - use computeIfAbsent; chose to disable the sonar for this, as it would obfuscate the code - use RE2 instead of java.util Pattern Issue-ID: POLICY-2305 Change-Id: If5495d04248211179cd37419cb20fe7d227ab59c Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-06Add 'naming' policy type to defaultGroup tablejhh1-0/+4
Issue-ID: POLICY-2472 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I1b57c9de5f5d2c4f374283487e56393c492110bd
2020-04-01Add optimization.* to xacml subgroupPamela Dragosh1-0/+4
Fix to ensure we support Policy Types for optimization. Issue-ID: POLICY-2460 Change-Id: Ibfd6b7191fb441eb31d8f697ff4f320e2305264d Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-03-27Point to latest snapshotsPamela Dragosh1-1/+1
Issue-ID: POLICY-2378 Change-Id: Ica314e9facad9ac45351d708505b566e37c1e347 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-03-25Cleanup eclipse warningsPamela Dragosh3-21/+17
Issue-ID: POLICY-2271 Change-Id: Ib28a6f5321cc05b03994e180867461a631d40d75 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-03-17renew policy certs till 03/17/2021jhh1-0/+0
Issue-ID: POLICY-2402 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I6386a6185089bfcc4358db2a0bdfe7a977b23992
2020-03-12update policy types for droolsjhh1-1/+9
Issue-ID: POLICY-2388 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I92d0fa515893ddf4182666201367e07e5408ef7a
2020-03-06Modify pap db for new guardPamela Dragosh1-3/+3
New guard policy type Issue-ID: POLICY-2243 Change-Id: Ide419148dda229537f7a736f37299edb891248ba Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-02-28Add test cases for consolidated policy health checkhuaxing4-46/+352
Issue-ID: POLICY-1689 Signed-off-by: huaxing <huaxing.jin@est.tech> Change-Id: Ifda17a4486e1bce1ce0f523cc1984519b7fbc1aa
2020-02-12Update PAP for policy DB response changesliamfallon2-2/+12
Policy models now throws an exception with a 404 code when policies are not found. This change amends PAP to cope with this change. Note: This change should be merged directly after the following policy-models patch: https://gerrit.onap.org/r/c/policy/models/+/101544 Issue-ID: POLICY-1402 Change-Id: Id38af4b2ad65797592c077e276861b962bc53ea2 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-02-10Cleanup the sonar issues in PAPa.sreekumar10-50/+48
Change-Id: I0eccc6064eb0b49d84370104d1219074ec8bde71 Issue-ID: POLICY-2271 Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
2020-02-04Merge "Adding Tosca compliant operational policy type to defaultGroup for ↵Liam Fallon1-0/+4
apex-pdp"
2020-02-03Policy notifications appear to be reversedJim Hahn10-57/+501
Modified the code as follows: Until all PDPs have responded (or been removed), no notifications for their associated policies will be generated. However, once a response has been received for every PDP, then a notification is generated. For deployed policies, the notifications will continue to be generated as PDPs move back and forth between the success and failed states, as long as the policy is not undeployed. For undeployed policies, on the other hand, no additional notifications will be generated once all PDPs have successfully undeployed the policy. However, until that point, like with deployed policies, notifications will continue to be generated as PDPs move back and forth between the success and failed states. Added notification verifications in deploy and undeploy end-to-end tests. Issue-ID: POLICY-2347 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I7d18dad1a7500e1efb7074e89ddaca4b1d368965
2020-02-03Adding Tosca compliant operational policy type to defaultGroup for apex-pdpa.sreekumar1-0/+4
Change-Id: I4b8b66657e84fe1d86ffd7972ff5c183f6ea0f74 Issue-ID: POLICY-2147 Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
2020-01-23Handling supported policy type during PdpGroup Updatea.sreekumar3-41/+38
Change-Id: I14daaa3d56d3293095227e0e3121e4fd82425b68 Issue-ID: POLICY-2023 Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
2020-01-21Log message when a PDP's heart beats are missedJim Hahn1-1/+2
If a PDP's heart beats are missed, PAP silently removes the PDP from the DB. Added a "logger" call. Issue-ID: POLICY-2326 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I1189ef66ad5a47e88f8cae770bd1393cafeb2393
2020-01-14policy/pap jdk11 upgradesHOCKLA6-25/+26
Issue-ID: POLICY-1593 Change-Id: I61be9364d09b520e30aeac6d825b6c84574790ac Signed-off-by: HOCKLA <ah999m@att.com>
2020-01-10Merge "validate and save PdpStatistisc"Jim Hahn4-6/+182
2020-01-10validate and save PdpStatistiscHenry.Sun5-8/+188
Issue-ID: POLICY-2303 Change-Id: Ide10256556a20e2ab3977ab2cfd876dd82e44390 Signed-off-by: Henry.Sun <henry.a.sun@est.tech>
2020-01-09statistics rest api updatening.xi7-64/+435
Issue-ID: POLICY-1629 Signed-off-by: ning.xi <ning.xi@est.tech> Change-Id: I104fc448d27a282c01e7f54db300f918374b8d07
2020-01-09Changes related to persisiting data type of policy in dba.sreekumar2-5/+7
Change-Id: I09b373a511eaa20603d4d2de71a2a5a6bf652b3b Issue-ID: POLICY-2315 Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
2019-12-11consolidate Policy Health Check into PAPHengye12-7/+392
Issue-ID: POLICY-1689 Change-Id: I3b84094e217c8cda115efdbf3444e92f08013a7c Signed-off-by: Hengye <yehui.wang@est.tech>
2019-12-10Merge "Only update policies in PAP REST API"Pamela Dragosh14-634/+661
2019-12-09Only update policies in PAP REST APIJim Hahn14-634/+661
Modified the deploy controller and provider to only update the policies within a group, while leaving the other fields unchanged. Added delta operations so that only additions or deletions need be included instead of providing the complete list of policies. Change-Id: Id2b69dac15f97b8a898f459f8d3f09216fc3618e Issue-ID: POLICY-2274 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-12-08Change optimization types due to refactoringPamela Dragosh1-10/+10
Companion review to https://gerrit.onap.org/r/c/policy/models/+/99288 which changes the types for optimization. Issue-ID: POLICY-2066 Change-Id: I754a52a3971f0ad4d4e4118213a13123c44086cf Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-12-06Merge "Adding native policy types to defaultGroup"Pamela Dragosh1-0/+12
2019-12-06Adding native policy types to defaultGroupramverma1-0/+12
Adding the native policy types for drools, apex & xacml to the supportedPolicyTypes of the individual subGroups in the defaultGroup. So that native policies can be deployed in the pdps belonging to defaultGroup. Issue-ID: POLICY-2279 Change-Id: I8707dfd3a9af055e02d29752386160631d022d08 Signed-off-by: ramverma <ram.krishna.verma@est.tech>
2019-12-05Create PAP API to only create/update PdpGroupsa.sreekumar11-182/+1450
Create an API to create/update PdpGroups. Policies are not allowed to be deployed as part of PDPGroup create/update operation. There will be a separate API as part of POLICY-2274 to deploy policies into individual group/subgroups. Change-Id: I4e2cb43fefe08b22d6f70a1db7c026e83f0ebde0 Issue-ID: POLICY-2273 Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
2019-12-03Move deploy/undeploy REST classesJim Hahn18-25/+21
Moved classes from rest.depundep to rest, as they will no longer be specific to deploy/undeploy. Change-Id: Iea7c4e35fcd00ed83e678f7cd980e0aa9659f18e Issue-ID: POLICY-1866 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-11-22Update Pdp Group state per PAP APIJim Hahn2-0/+18
The PAP API can be used to update the state of a Pdp Group. However, the state wasn't being updated - fixed. Issue-ID: POLICY-2269 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I67fa3409424cfdb4b53b17e86f4cf354732d87e8
2019-11-22Re-register pdp if not found in DBramverma3-20/+62
During heartbeat processing, if the pdp instance is not found in the DB then registering the pdp again. So that it doesn't go out of sync. Added related test cases. Issue-ID: POLICY-2158 Change-Id: I557e2397536fd5b3a2783ec89d75ca0e43dcf9d0 Signed-off-by: ramverma <ram.krishna.verma@est.tech>
2019-11-21Merge "Undeploy policies when deploy fails"Jim Hahn14-13/+653
2019-11-21Merge "Adding pdpGroup to PdpRegistrationHandler"Jorge Hernandez4-69/+321
2019-11-21Adding pdpGroup to PdpRegistrationHandlerramverma4-69/+321
Adding pdpGroup as the matching condition for registration of Pdps. Removing the check of supported policy types in pdp heartbeat. Adding check of policies in pdp heartbeat. Adding comprehensive unit test coverage (98%) for the heartbeat listener. Issue-ID: POLICY-2231 Change-Id: I0fb961717c74656c5f1b6937b6c3a1410382a76e Signed-off-by: ramverma <ram.krishna.verma@est.tech>
2019-11-20Undeploy policies when deploy failsJim Hahn14-13/+653
Modified the code so that if a PDP fails to deploy one or more policies specified in a PDP-UPDATE message, PAP will undeploy those policies that failed to deploy to the PDP. This entails removing the policies from the Pdp Group(s), issuing new PDP-UPDATE requests, and updating the notification tracking data. Issue-ID: POLICY-2155 Change-Id: I1740282385b0fa804254ebdf57537ef0f3a7a4c8 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-11-20Merge "Preload wildcard supported type in PAP"Jim Hahn1-13/+1
2019-11-19Fixing issue where PdpRegistration message is treated as Heartbeat by PAPa.sreekumar1-1/+1
PDPs now sends PdpGroup also during registration. So, PAP treats them as normal hearbeat and not registration message, causing errors. Fixing this. This change will be updated by POLICY-2231 This should also fix the csit failures in the PDPs. Change-Id: Idf62839d175c6e392101e9c58627217a76473de9 Issue-ID: POLICY-2234 Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
2019-11-14Preload wildcard supported type in PAPJim Hahn1-13/+1
Removed the specific monitoring policy types and added the wild-card flavor to the list of policy types to be pre-loaded into the Default PDP Group. Issue-ID: POLICY-2224 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I108fe72c28bd20495e72bdaa517f7c7f80de3071
2019-11-07PAP should not deactivate PDPsJim Hahn2-102/+105
Modified the code so that it does not send a PASSIVE request to PDPs when they are fail, whether due to an inability to deploy a policy or due to a timeout. However, it still removes the PDP from the PDP Group, if a timeout occurs (but not due to a deployment failure). This review does not include any changes to undeploy failed policies; that will come in a later review. Issue-ID: POLICY-2155 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I15821d299bc3261478fd7fbb9ee62ea4a90123a4