summaryrefslogtreecommitdiffstats
path: root/main/src
AgeCommit message (Collapse)AuthorFilesLines
2023-02-27Fixed sonar issues in policy-papSuresh Charan4-16/+18
Reduced technical debt by fixing sonar issues Issue-ID: POLICY-4536 Change-Id: I3f4ff8cae7d22c5d2d062e98475592425e3c98c4 Signed-off-by: Suresh Charan <suresh.charan@bell.ca>
2023-02-02Replace Eclipselink with Hibernateliamfallon3-26/+38
Issue-ID: POLICY-4533 Change-Id: I8ba51dce05f537778a92547bceff6eb6d6099144 Signed-off-by: liamfallon <liam.fallon@est.tech>
2023-01-31Upgrade and clean up dependenciesliamfallon8-53/+60
- Upgrade Hibernate - Upgrade Mockito - Upgrade Mockserver - Remove Powermock (no longer supported) and replace with spring-test ReflectionTestUtils - Upgrade Spring Framework - Add spring-security to allow authentication on unit tests using MockMVC Minor clean-up - Replace deprecated authorization configuraiton on spring boot applications with SecurityFilterChain bean - Change @LocalPort include on tests to use test include rather than runtime include - Remove unused imports - Remove unused constants and variables - Add deprecation annotations where required Issue-ID: POLICY-4482 Change-Id: Ifcabd73e4130810ba2a99b842ffa4203836c0682 Signed-off-by: liamfallon <liam.fallon@est.tech>
2023-01-30Adding PAP contract testslapentafd2-1/+105
Adding Contract tests, verifying the stubbed implementation. Fixing name in application-stub.yaml Issue-ID: POLICY-4534 Change-Id: I03d8b37ba2f57aa03ee814924b4e52dd0c643772 Signed-off-by: lapentafd <francesco.lapenta@est.tech>
2023-01-25Server Stubs PAPlapentafd36-12/+792
Added "stub" profile with simple endpoint implementation Issue-ID: POLICY-4143 Change-Id: I8ad911f314e1d1428d05aa419f1322616d8ef835 Signed-off-by: lapentafd <francesco.lapenta@est.tech>
2023-01-17Use generated PAP interface for Swaggerlapentafd17-1280/+355
This commit removes the Swagger V2 annotations on the Rest Controllers in policy-pap. The OpeApi annotations (Swagger v3 annotations) are on a generated Java Interface. The code is changed so that the controller implements that interface. There are minimal code changes to the controller and the order of the parameters is switched in some cases. Issue-ID: POLICY-4404 Change-Id: I060709806a8e5bc04d9873c8d212a5c9fe13c4d4 Signed-off-by: lapentafd <francesco.lapenta@est.tech>
2022-12-18Upgrade the H2 database to the latest versionliamfallon3-4/+4
The latest verison of H2 does not allow colums called "user" or indexes using an underscore in their name. Issue-ID: POLICY-4488 Change-Id: I9ce7435b5dfa81daaf04e7f7a50f9db6582cdc0b Signed-off-by: liamfallon <liam.fallon@est.tech>
2022-12-12SLAs for async methodsadheli.tavares9-62/+216
- undeploy policy timing - deploy policy timing - unit tests for actuator endpoints Issue-ID: POLICY-4469 Change-Id: I3298888e59824347b8d2a57fb531c10f2f4ca125 Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
2022-12-08Replace SpringFox with SpringDoc in policy-papliamfallon7-11/+54
This commit: - Remove SpringFox - Adds SpringDoc - Enables the .../v3/api-docs endpoint Note that the Swagger annotations from the OpenAPI specification generated code need to be enabled so that the API specification is available over the ..../v3/api-docs endpoint. THis will be done in subsequent commits. Issue-ID: POLICY-4404 Change-Id: I42c1575a3ce76d9b3e753ad51f85df027d12b980 Signed-off-by: liamfallon <liam.fallon@est.tech>
2022-11-22Merge "Add OpenAPI Swagger 3 spec and API generation"Liam Fallon1-0/+3712
2022-11-17Add OpenAPI Swagger 3 spec and API generationliamfallon1-0/+3712
This commit adds the Policy/API OpenAPI (Swagger) document as a source document under source control. This OpenAPI document was generated from the existing SpringFox annotations in the source code, was uploaded to the online Swagger editor and was converted into OpenAPI 3.0 format. It was then manually edited to correct the return types and to match the input and putput types to our Java classes. The pom.xml is also amended to generate the API interface source doe in the target/generated-sources directory. The generated code does NOT replace the existing API code as yet. Issue-ID: POLICY-4431 Change-Id: Iee1cc6a122deffcd05728e8f34172f8d423ebcef Signed-off-by: liamfallon <liam.fallon@est.tech>
2022-11-17Topic names in PAP should be configurable from application.yamladheli.tavares35-261/+398
- for using Kafka instead of dmaap, topics names need to be lowercase - fix for unit/integration tests using default names and changed names for topics and group - fix for sonar lints found along the way Issue-ID: POLICY-4455 Change-Id: I89e9e6f7dbb07462f1ae497755965cb5a3f223a3 Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
2022-09-21Fix minor warnings in codeliamfallon2-7/+3
Issue-ID: POLICY-4045 Change-Id: I08c3cb1af3dbe2051dcbb0e2726906faff4a37b3 Signed-off-by: liamfallon <liam.fallon@est.tech>
2022-04-12Fix incorrect deployments counter on parallel executiona.sreekumar4-12/+41
Change-Id: I72bde10eae615e2c89ccc1a211c6385404b9b3c7 Issue-ID: POLICY-4088 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2022-04-04Fix incorrect url in PAP consolidated healthchecka.sreekumar1-1/+1
Change-Id: I0194483f371e1140ad56029c23b6f400df0dcbdc Issue-ID: POLICY-4068 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2022-03-21Fix build failure in paprameshiyer271-1/+1
policy-models changes for metadataSet db serialization causes test failure in pap. Issue-ID: POLICY-3934 Signed-off-by: zrrmmua <ramesh.murugan.iyer@est.tech> Change-Id: Ibc24e3a27e1cdd6111719651349888157fc31593
2022-03-10Fix PAP healthcheck response during failuresa.sreekumar2-3/+9
The healthcheck response that is returned by PAP is not inline with the actual healthreport. Even when the report has healthy:false, code:503, message:not alive the response code stays 200. This is fixed, this also makes the improved readiness probe in OOM to work properly with the healthcheck calls Change-Id: Ib208e0a84bce74157aacbcad61a11dcf900c7c94 Issue-ID: POLICY-4030 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2022-03-01Fix swagger and improve exception handlinga.sreekumar7-9/+87
1) Swagger was getting generated in a different format due to a serialization isue. It is fixed. 2) Improved exception handling by taking care of any exceptions that could occur in and around database operations. 3) AAF enabling/disabling was done using spring profiles. This is changed to using parameters, as it is more easier to configure in an OOM helm chart deployment Change-Id: If1bee01379ba5c4efac29822662896d8aa883fc8 Issue-ID: POLICY-3975 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2022-02-25Merge "Add support for populating metadataSet in PAP tosca policy"Liam Fallon6-5/+285
2022-02-23Add support for populating metadataSet in PAP tosca policyrameshiyer276-5/+285
MetadataSet fetched from the db and added to the policy metadata map with the key "metadataSet" before sending to PDPs Issue-ID: POLICY-3832 Signed-off-by: zrrmmua <ramesh.murugan.iyer@est.tech> Change-Id: I14064d82ba6877bd7560af7de7572b4813a98385
2022-02-23Adding deployment metrics to PAPa.sreekumar9-3/+88
Change-Id: I4b6a93045c1ddfd7fff037e7568b029e2e45b0b3 Issue-ID: POLICY-3757 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2022-02-17Use classes from policy/commonRam Krishna Verma5-149/+4
Use YamlHttpMessageConverter from policy/common. Use CustomImplicitNamingStrategy from policy/common. Fix few sonar issues. Issue-ID: POLICY-3931 Change-Id: I4720761cbf8da464ec57541f9b19f8d124503e17 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2022-02-15Fix issue with GeneratedValue in PfGeneratedIdKeya.sreekumar5-61/+39
Change-Id: If244237e4aa39e1f3184cab04ae7d5ad7e85e5fa Issue-ID: POLICY-3897 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2022-02-14Merge "Add yaml support to pap api's"Ajith Sreekumar5-11/+221
2022-02-11Improve PAP healthcheck api to verify DB connectivityPrakhar Pandey4-9/+52
This commit improves PAP healthcheck API to enable verification of PAP to DB connectivity. Issue-ID: POLICY-3763 Signed-off-by: Prakhar Pandey <prakhar.pandey@bell.ca> Change-Id: I14353572a00e68a89161bcffd2ec3476b4a4c303
2022-02-10Add yaml support to pap api'sRam Krishna Verma5-11/+221
Adding yaml support to pap rest api's. Along with related unit tests. Issue-ID: POLICY-3864 Change-Id: I43bdbbd4151bcae5dcf4752a9385b115efa947d3 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2022-02-10Move PAP database provider to spring boot defaulta.sreekumar66-2071/+1482
This review makes PAP talk to DB directly using the spring repositories instead of going to policy-models-provider. The models-provider methods that were just used by PAP (and not used anymore) will be removed in a different review. Also a bug identified with the usage of GeneratedValue in PfGeneratedIdKey (which is just used by PAP in statistics & audit) will also be fixed in a separate review as part of POLICY-3897. CSIT changes: https://gerrit.onap.org/r/c/policy/docker/+/127033 WIP OOM review: https://gerrit.onap.org/r/c/oom/+/127035 Change-Id: Idb13ba7eb2767cc718672b582a6518fcfc95320f Issue-ID: POLICY-3867 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2022-01-28Create spring repository layer for PAPa.sreekumar23-26/+2148
This review adds the spring repository and service layers to PAP. Once this is merged, the next work will be to actually use these spring boot based services to talk to the db directly, and not using policy-models-provider in PAP. Change-Id: Ib086b8b405020cb452e51d6359dd1a69d0000f74 Issue-ID: POLICY-3869 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2022-01-27Remove references to MariaDB from resource fileswaynedunican6-10/+116
Issue-ID: POLICY-2086 Change-Id: I891feb05d2e964ae8d4454d30672ffc77c1da555 Signed-off-by: Wayne Dunican <wayne.dunican@est.tech>
2022-01-07Adding totalPolicyDeployCounts updates to PapStasticsManagerisaac4-4/+54
Issue-ID: POLICY-3836 Signed-off-by: isaac <isaac.adorno@att.com> Change-Id: Ia4ed2595984f68bf75ca9dacb6aa76f04a306224
2021-12-14Migrate pap startup & controllers to spring boota.sreekumar61-1522/+1210
This commit migrates pap config, startup and controllers to spring boot. Change-Id: Icf91d728160a23db614dfba6b40ddccd2f6163a5 Issue-ID: POLICY-3754 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-11-03Rename username for PAP operations.adheli.tavares7-14/+14
Use an account other than healthcheck in PAP for provisioning of policies. Issue-ID: POLICY-2744 Change-Id: I897f7a4fffbac2d4bbd9cceb059bae1794753aa7 Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
2021-09-06Decrease eclipselink verbosity to warningjhh1-1/+1
Issue-ID: POLICY-3611 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Ia7e2ccba793bf7e0ee686c874b395ff728d68af3
2021-09-02Fix PAP PDP expiration timerJim Hahn8-12/+29
Added runtime exceptions to the "catch" clause so that the thread associated with the PDP expiration timer will not terminate. Also added to a few other "catch" clauses, particularly those in the REST controllers. Issue-ID: POLICY-3625 Change-Id: I9206121d3e9b91da593ae771e7586752b13949be Signed-off-by: Jim Hahn <jrh3@att.com>
2021-08-25Add dmaap connectivity check in papRam Krishna Verma5-8/+110
Add dmaap connectivity check in pap consolidated health check. Make a rest call to fetch all the topics. Verify POLICY-PDP-PAP topic is present. Issue-ID: POLICY-2896 Change-Id: Ide39c70999eaca61205225c95b904e3009d41408 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-08-23Fix junits broken by change in is-alive typeJim Hahn1-1/+3
Issue-ID: POLICY-3531 Change-Id: I1e66779f4ac05862649828e79914e902a99400d3 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-08-17Update Policy Components not to create tablesktimoney1-3/+3
Issue-ID: POLICY-3488 Change-Id: I945a19eb6bd7b943adaedc1ea836ec6030c9b001 Signed-off-by: ktimoney <kevin.timoney@est.tech>
2021-08-05Use lombok in papRam Krishna Verma3-41/+6
Issue-ID: POLICY-3399 Change-Id: I839f67ff02fdabcb4012a340f7a6a7528dc107e5 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-08-03Update query params in audit api'sRam Krishna Verma2-35/+35
Updating query params in audit api's to keep them in sync with statistics api's. Issue-ID: POLICY-3527 Change-Id: I096436930450c263835ff8852edd40655de4fb0d Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-07-30Add time ranges to PAP statistics APIJim Hahn2-37/+127
Issue-ID: POLICY-3511 Change-Id: Ifc91e4732b3574da37f55658b23faf8a9f8091f5 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-07-29Fix swagger tags in controllersRam Krishna Verma9-22/+22
Fixing the swagger tags in controllers to match with documents. Issue-ID: POLICY-3340 Change-Id: Ib30029cc4efa287348f5869f036b30cbab3db079 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-07-29Merge "Add datetime format to audit api's"Ajith Sreekumar2-68/+138
2021-07-28Add datetime format to audit api'sRam Krishna Verma2-68/+138
Adding datetime format to audit api's so that clients can send the request in one common format. Changed the format to epoch timestamp. Fixed review comments. Issue-ID: POLICY-3340 Change-Id: I613ac02154a3e521ae97f7ac2e6129f642164b3f Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-07-28Remove statistics record limits from PAPJim Hahn2-42/+17
policy/models statistics provider has now been enhanced to limit the record counts. Stripped the code from PAP, as it's no longer needed there. Also simplified the PAP statistics provider down to one query method, taking a filter. Issue-ID: POLICY-3511 Change-Id: I8a8797be191dc1f299b1c4084b0108a3ab89ff61 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-07-22Add apis for policy auditRam Krishna Verma6-1/+713
Adding api's to fetch policy audit records from db. This is as per the design documented here - https://wiki.onap.org/display/DW/PAP+REST+API+changes+for+Istanbul+release Issue-ID: POLICY-3340 Change-Id: Iff80ab695d17ec38d4fe8ab98c0b95048cbae448 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-07-19Use new RestClientParameters class in PAPJim Hahn4-14/+14
Replaced generic BusTopicParams with more specific RestClientParameters. Issue-ID: POLICY-3456 Change-Id: Ic1a3acca5b651730fc74332c2c5d5bc36bccb790 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-07-15Limit statistics record countJim Hahn2-21/+27
Modified PAP, for Honolulu only, to limit the number of statistics records retrieved from the DB. Also added the recordCount parameter to the REST APIs, because otherwise it would only return one record. Per review comments: - removed default value annotation; relying on the Provider code to change "0" to a reasonable default Issue-ID: POLICY-3485 Change-Id: Ib0820cfda95672f1bc6f879dfd2ac172e7b42f0d (cherry picked from commit 190b75c59bcc6f250446b627a96e4a12de52278f) Signed-off-by: Jim Hahn <jrh3@att.com>
2021-07-07Update pdp statistics to count deploy/undeploy separately.adheli.tavares2-0/+5
Issue-ID: POLICY-3383 Change-Id: Iec7875fb1fa6a4a360b8cfdff0b80f697a289de3 Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
2021-07-07Merge "Use separate subscription for heartbeats"Jim Hahn5-24/+61
2021-07-06Fix NPE in UpdateReq.reconfigure()Jim Hahn2-0/+15
While running CSIT to test heartbeat changes with multiple PAPs, observed an NPE in UpdateReq.reconfigure(). Modified the code to always use deployment lists instead of null lists. Issue-ID: POLICY-3460 Change-Id: I884e091817e88309330139a01d060e286bd42008 Signed-off-by: Jim Hahn <jrh3@att.com>