summaryrefslogtreecommitdiffstats
path: root/main/src
AgeCommit message (Collapse)AuthorFilesLines
2020-09-30Fix new sonars in policy/papJim Hahn3-64/+67
Addressed the following sonar issues: - too many assertions in test method - extract common test method - replace this null literal by an "Optional" object Issue-ID: POLICY-2679 Change-Id: Ie80e5c5fdb94230a2773ea2931758cf54204ae86 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-09-24update default keystoresjhh1-0/+0
Issue-ID: POLICY-2827 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I95db673538947cccc39bb5a389ab3f544fa91af8
2020-08-24Add Match Policy Type to default groupPamela Dragosh1-0/+4
Default group will now have match Policy Type. Issue-ID: POLICY-2596 Change-Id: I53c07b417097dc8250191e6ee8d043488b02562d Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-08-17Add new guard filter to defaultGroupPamela Dragosh1-0/+4
New guard filter should be advertised by pap. Issue-ID: POLICY-2590 Change-Id: I7652057d4d759e60c358ee9fad84a8c6a9af6898 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-08-14Using standard success/failure messages in PAPa.sreekumar2-9/+9
Change-Id: If4613c0fc6f940bc82cf616aba2ba9cc03e1b599 Issue-ID: POLICY-2754 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2020-08-10Merge "Changes to make PAP container crash with non zero exitCode"Pamela Dragosh2-34/+28
2020-08-10Changes to make PAP container crash with non zero exitCodea.sreekumar2-34/+28
Make the application to return exitCode as 1 when the main process terminates due to issues such as: 1) Any basic issue in the startup config file causing error and terminates the main process, for e.g. a wrong name in parameterGroup. 2) Wrong info specified for database connectivity, say wrong username. This doesn't impact a case where database isn't ready yet and PAP container comes up first, such waiting is already handled by initContainer in the oom chart. PAP pod waits for policy-mariadb pod to be ready first, then only the main process is started and comes to this point. 3) An invalid port number is specified and the rest server is not able to start. These are the some of the scenarios which already makes the main process of PAP to terminate, and in these cases, an exception is thrown now which returns the exitCode as 1. Change-Id: Ie48726bcb36d7304eb60807fbaabbee8245e9c70 Issue-ID: POLICY-2754 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2020-08-07Merge "Fail component health check if PDP is down"Jim Hahn4-14/+51
2020-08-07Fail component health check if PDP is downRam Krishna Verma4-14/+51
Changing the policy component health check to fail if the required PDP instances are down or not registered with PAP. The check is performed by comparing the "currentInstanceCount" & "desiredInstanceCount" fields of PdpSubGroup. Issue-ID: POLICY-2718 Change-Id: Iad1075d0812f4ef166dfed4f110eff4d9e5f995e Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-08-06Remove legacy operational policy from papRam Krishna Verma1-4/+0
Issue-ID: POLICY-2763 Change-Id: I9701a80cca10b9fd49d8060ecb6601097ca5824d Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-07-06Replace try/catch blocks with assertj - papwaynedunican1-34/+14
Replaced try/catch blocks in policy/pap test cases with assertj assertions Issue-ID: POLICY-2451 Change-Id: Ic963558e812b59d321e12fa87e7285732d6761e5 Signed-off-by: waynedunican <wayne.dunican@est.tech>
2020-06-30Fix more sonars in papJim Hahn1-3/+4
Somehow missed this sonar on one line of code: - remove useless assignments Apparently, sonar only complains about some useless assignments (perhaps those that do more than copy a constant). Fixed one about which it did not complain, which appeared immediately before the one about which it DID complain. At one point, sonar complained about creating ArrayLists without specifying the initial size (when it was known). It didn't complain about this one, but went ahead and fixed it anyway. Issue-ID: POLICY-2679 Change-Id: I270341195634416db1f8152a95a5822c8d505803 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-06-30Merge "Fix issues in pap for new sonar rules"Liam Fallon3-11/+15
2020-06-29Fix issues in pap for new sonar rulesJim Hahn3-11/+15
Addressed issues reported due to updates to the sonar rules: - invoke only one method in a junit lambda Issue-ID: POLICY-2679 Change-Id: I422856527b191a45b30a78bb8520f679ca2e7896 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-06-29Parallel execution of Client Health checkRam Krishna Verma3-44/+85
Issue-ID: POLICY-2390 Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca> Change-Id: I42f443c64bcf6652adb9795ee8e71e37d8fa8c71
2020-06-19Changes for Checkstyle 8.32 in policy-papa.sreekumar10-17/+1
Change-Id: I995515659a4b7837bb15120f9c50fa0fd1f5434c Issue-ID: POLICY-2188 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2020-06-18pap - sonar issue fixTaka Cho2-4/+6
replace by assertNotSame Issue-ID: POLICY-2616 Change-Id: I927dbd8c57654cd2d2ef6262d13d63c79ba9035f Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-17PAP should discard old PDP messagesJim Hahn7-12/+78
Modified PAP to discard any messages old than 10 minutes so that if PAP is unable to communicate with DMaaP and then suddently gets flooded, it will discard old messages. Updates per review comments - made the "max message age" configurable, with a default of 10 minutes Issue-ID: POLICY-2170 Change-Id: I541c03aabf29482af12a07f51eeb5888bbafbf31 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-06-11Switching logging of ToscaPolicyXXXIdentifiers to use new toString()RossC4-10/+13
Issue-ID: POLICY-2078 Change-Id: I035eceb45e76ef11df0e903b584fcf7f8eb63208 Signed-off-by: RossC <ross.carter@est.tech>
2020-05-04Eliminate spurious notifications from PAPJim Hahn4-51/+14
Tracked it down to the following sequence: - policies were deployed to the pdp - received a request to undeploy a policy - generated a notification for the formerly deployed policy - this should not have been generated - undeployed the policy - received a response from the pdp indicating the policy had been undeployed - generated a notification indicating the policy was undeployed Removed the code that generated a notification when a policy is initially moved from deployed to undeployed (or vice versa). Issue-ID: POLICY-2539 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: If175974b5fa5ccda6a1e1ab8fa1326b263bb8005
2020-04-29PAP should discard responses for old requestsJim Hahn3-6/+29
This is a more robust solution to the race condition previously identified with back-to-back deployment requests. The old fix has been rolled back and replaced with this fix. Issue-ID: POLICY-2527 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I2ea93f3a5eaac822abecf5d0745429b95712c861
2020-04-28Merge "PAP erroneously undeploying policies"Pamela Dragosh1-4/+7
2020-04-28PAP erroneously undeploying policiesJim Hahn1-4/+7
The problem appears to be a multi-threading type of issue: - PAP sends request to XACML - JMeter pushes the next deployment request into PAP - PAP receives response from XACML - based on request ID, the response is routed to the handler, but blocks while PAP processes the deployment request - PAP replaces old list of policies with new, and changes the request ID - PAP responds to JMeter - PAP handles XACML response, even though it's request ID no longer matches Modified PAP to no longer replace any messages that are at the head of the queue. Fixed the license. Issue-ID: POLICY-2527 Change-Id: I43218a7d0591649d761e17282189e51d5dbd26ed Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-28Merge "point to renamed sdnc naming policy in db config"Jim Hahn1-1/+1
2020-04-28point to renamed sdnc naming policy in db configjhh1-1/+1
Issue-ID: POLICY-2525 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Iea676911eaa7222949959ed0a7074b1260d8ce87
2020-04-24Activating active group should be NOOPJim Hahn1-17/+2
Fixed the code so that if a request is made to activate a PDP Group that is already active, the group remains active. Issue-ID: POLICY-2522 Change-Id: I106332b1ce15fde8dbf0b3e72034fd11c250dc69 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-09Remaining sonar issues in papJim Hahn2-3/+5
Addressed these remaining sonar issues: - main arg validation - TODO item regarding subgroup updates with no PDPs - after discussion, it was decided to not do this Issue-ID: POLICY-2305 Change-Id: Ib2b340d029679d6cd2b2a558318b25d38b830833 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-08Merge "Address sonar issues in PAP"Jim Hahn3-7/+14
2020-04-07Preload sdnc naming policy in xacml-pdpRam Krishna Verma1-1/+6
Adding sdnc naming policy to xacml subgroup in defaultGroup so that the policy can be auto deployed to the xacml-pdp after registration with PAP. Issue-ID: POLICY-2476 Change-Id: I355e7b5e56b9a6a7f0fda96a7b2dfd640b7bd930 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-04-07Address sonar issues in PAPJim Hahn3-7/+14
Addressed the following sonar issues in PAP: - do something with value returned by a method - use computeIfAbsent; chose to disable the sonar for this, as it would obfuscate the code - use RE2 instead of java.util Pattern Issue-ID: POLICY-2305 Change-Id: If5495d04248211179cd37419cb20fe7d227ab59c Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-06Add 'naming' policy type to defaultGroup tablejhh1-0/+4
Issue-ID: POLICY-2472 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I1b57c9de5f5d2c4f374283487e56393c492110bd
2020-04-01Add optimization.* to xacml subgroupPamela Dragosh1-0/+4
Fix to ensure we support Policy Types for optimization. Issue-ID: POLICY-2460 Change-Id: Ibfd6b7191fb441eb31d8f697ff4f320e2305264d Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-03-27Point to latest snapshotsPamela Dragosh1-1/+1
Issue-ID: POLICY-2378 Change-Id: Ica314e9facad9ac45351d708505b566e37c1e347 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-03-25Cleanup eclipse warningsPamela Dragosh3-21/+17
Issue-ID: POLICY-2271 Change-Id: Ib28a6f5321cc05b03994e180867461a631d40d75 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-03-17renew policy certs till 03/17/2021jhh1-0/+0
Issue-ID: POLICY-2402 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I6386a6185089bfcc4358db2a0bdfe7a977b23992
2020-03-12update policy types for droolsjhh1-1/+9
Issue-ID: POLICY-2388 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I92d0fa515893ddf4182666201367e07e5408ef7a
2020-03-06Modify pap db for new guardPamela Dragosh1-3/+3
New guard policy type Issue-ID: POLICY-2243 Change-Id: Ide419148dda229537f7a736f37299edb891248ba Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-02-28Add test cases for consolidated policy health checkhuaxing4-46/+352
Issue-ID: POLICY-1689 Signed-off-by: huaxing <huaxing.jin@est.tech> Change-Id: Ifda17a4486e1bce1ce0f523cc1984519b7fbc1aa
2020-02-12Update PAP for policy DB response changesliamfallon2-2/+12
Policy models now throws an exception with a 404 code when policies are not found. This change amends PAP to cope with this change. Note: This change should be merged directly after the following policy-models patch: https://gerrit.onap.org/r/c/policy/models/+/101544 Issue-ID: POLICY-1402 Change-Id: Id38af4b2ad65797592c077e276861b962bc53ea2 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-02-10Cleanup the sonar issues in PAPa.sreekumar10-50/+48
Change-Id: I0eccc6064eb0b49d84370104d1219074ec8bde71 Issue-ID: POLICY-2271 Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
2020-02-04Merge "Adding Tosca compliant operational policy type to defaultGroup for ↵Liam Fallon1-0/+4
apex-pdp"
2020-02-03Policy notifications appear to be reversedJim Hahn10-57/+501
Modified the code as follows: Until all PDPs have responded (or been removed), no notifications for their associated policies will be generated. However, once a response has been received for every PDP, then a notification is generated. For deployed policies, the notifications will continue to be generated as PDPs move back and forth between the success and failed states, as long as the policy is not undeployed. For undeployed policies, on the other hand, no additional notifications will be generated once all PDPs have successfully undeployed the policy. However, until that point, like with deployed policies, notifications will continue to be generated as PDPs move back and forth between the success and failed states. Added notification verifications in deploy and undeploy end-to-end tests. Issue-ID: POLICY-2347 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I7d18dad1a7500e1efb7074e89ddaca4b1d368965
2020-02-03Adding Tosca compliant operational policy type to defaultGroup for apex-pdpa.sreekumar1-0/+4
Change-Id: I4b8b66657e84fe1d86ffd7972ff5c183f6ea0f74 Issue-ID: POLICY-2147 Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
2020-01-23Handling supported policy type during PdpGroup Updatea.sreekumar3-41/+38
Change-Id: I14daaa3d56d3293095227e0e3121e4fd82425b68 Issue-ID: POLICY-2023 Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
2020-01-21Log message when a PDP's heart beats are missedJim Hahn1-1/+2
If a PDP's heart beats are missed, PAP silently removes the PDP from the DB. Added a "logger" call. Issue-ID: POLICY-2326 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I1189ef66ad5a47e88f8cae770bd1393cafeb2393
2020-01-14policy/pap jdk11 upgradesHOCKLA6-25/+26
Issue-ID: POLICY-1593 Change-Id: I61be9364d09b520e30aeac6d825b6c84574790ac Signed-off-by: HOCKLA <ah999m@att.com>
2020-01-10Merge "validate and save PdpStatistisc"Jim Hahn4-6/+182
2020-01-10validate and save PdpStatistiscHenry.Sun5-8/+188
Issue-ID: POLICY-2303 Change-Id: Ide10256556a20e2ab3977ab2cfd876dd82e44390 Signed-off-by: Henry.Sun <henry.a.sun@est.tech>
2020-01-09statistics rest api updatening.xi7-64/+435
Issue-ID: POLICY-1629 Signed-off-by: ning.xi <ning.xi@est.tech> Change-Id: I104fc448d27a282c01e7f54db300f918374b8d07
2020-01-09Changes related to persisiting data type of policy in dba.sreekumar2-5/+7
Change-Id: I09b373a511eaa20603d4d2de71a2a5a6bf652b3b Issue-ID: POLICY-2315 Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>