Age | Commit message (Collapse) | Author | Files | Lines |
|
Modified the code so that if a PDP fails to deploy one or more policies
specified in a PDP-UPDATE message, PAP will undeploy those policies that
failed to deploy to the PDP. This entails removing the policies from
the Pdp Group(s), issuing new PDP-UPDATE requests, and updating the
notification tracking data.
Issue-ID: POLICY-2155
Change-Id: I1740282385b0fa804254ebdf57537ef0f3a7a4c8
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
PDPs now sends PdpGroup also during registration. So, PAP treats them as
normal hearbeat and not registration message, causing errors.
Fixing this. This change will be updated by POLICY-2231
This should also fix the csit failures in the PDPs.
Change-Id: Idf62839d175c6e392101e9c58627217a76473de9
Issue-ID: POLICY-2234
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Removed the specific monitoring policy types and added the
wild-card flavor to the list of policy types to be pre-loaded
into the Default PDP Group.
Issue-ID: POLICY-2224
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I108fe72c28bd20495e72bdaa517f7c7f80de3071
|
|
Modified the code so that it does not send a PASSIVE request to
PDPs when they are fail, whether due to an inability to deploy a
policy or due to a timeout. However, it still removes the PDP from
the PDP Group, if a timeout occurs (but not due to a deployment
failure).
This review does not include any changes to undeploy failed policies;
that will come in a later review.
Issue-ID: POLICY-2155
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I15821d299bc3261478fd7fbb9ee62ea4a90123a4
|
|
Allow supported policy types to end with ".*", which causes the prefix
to be matched when new policies are deployed. This entailed updates
in three areas:
- when a subgroup is added via the group api
- when a subgroup is updated via the group api
- when a policy is deployed via the simple api
Issue-ID: POLICY-1636
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I4ae15971481ce5b2042b5d6fdfd16e11ad099c50
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
PAP handles outgoing requests using a complicated priority queue.
Simplified it significantly.
Change-Id: I9f49dfebd7bf323c5e81bc8ca3459913fa95c43d
Issue-ID: POLICY-2155
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
As part of this, added code to pre-load the deployed policy tracker
by reading the policies and groups from the DB.
Change-Id: Ifc6c787d114a3a7add4ea54acc1cc969d6c3ca1c
Issue-ID: POLICY-2024
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
The junit tests verified that the policy specified in the notifications,
but did not verify the policy type. Added additional tests.
Issue-ID: POLICY-2190
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: Iad2a06163f9dce3dff3753cddef98db9e9ad2eea
|
|
Updated existing PAP code to make use of new notification classes.
Change-Id: I4637ad92ac4f432f215cfc837e672c75074d88b5
Issue-ID: POLICY-1841
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Also modified the Publisher class to make it generic so that it
could be used to publish PdpMessage AND PolicyNotification.
Issue-ID: POLICY-1841
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I305de21a4ef84730f163af63446bafadab11a809
|
|
Issue-ID: POLICY-1841
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I7d6fe29707685e4711120b6a1e8448f25870a0ef
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
Issue-ID: POLICY-1841
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: Icf5616190a8c3da38e2a1e33122b47a78e729d08
|
|
Change-Id: Ife3ab77c0664101bbf32def5fb4d1a5ac194f459
Issue-ID: POLICY-1841
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Change-Id: I3e3d5c46bfa4f1d093e64b8be9a9720570e6000c
Issue-ID: POLICY-2085
Signed-off-by: jrh3 <jrh3@att.com>
|
|
This review adapts policy-pap for the change in the structure
of the toasca service template from a list of maps to a plain map.
There is only a change to one test file.
Issue-ID: POLICY-2047
Change-Id: Ieeeeb43d8f0300d075b3072b67f8d459def27ee7
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-1988
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I3e7d08621b6ac529f3517de8c2b910d2fa7c5151
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
Add a few more logging statements to the timer manager. Also
changed logger.debug() to logger.info().
Replaced map.computeIfPresent() with map.remove(), as it simplified
the relevant code block significantly.
Change-Id: I211e9f07bd6df6a01532b1ecabdde5ae1585cc18
Issue-ID: POLICY-1960
Signed-off-by: jrh3 <jrh3@att.com>
|
|
Issue-ID: POLICY-1953
Signed-off-by: jrh3 <jrh3@att.com>
Change-Id: I2bc56dfe2d5982d7dadb54311a94d6c6f95fa595
|
|
Issue-ID: POLICY-1953
Signed-off-by: jrh3 <jrh3@att.com>
Change-Id: I225dc5f03d867efe6167fd20781c9959af34e0e9
Signed-off-by: jrh3 <jrh3@att.com>
|
|
Issue-ID: POLICY-1652
Signed-off-by: jrh3 <jrh3@att.com>
Change-Id: If97c5667f52811cfb3bdf1f7c8caf763e6bfa3b6
Signed-off-by: jrh3 <jrh3@att.com>
|
|
Fixed breakages due to changes made in policy/common to satisfy
sonar.
Issue-ID: POLICY-1791
Signed-off-by: jrh3 <jrh3@att.com>
Change-Id: If8685462e1dd5cbbe58c329defff74ff2accf559
|
|
1) The properties in the topic.properties file is moved into overall
config json file and the topic.properties file is removed.
2) Common parameters such as RestServer and Topic related parameters
from policy-common is used.
Change-Id: I390bbe3cda101a69e7ce614404ecdfbf98598dd2
Issue-ID: POLICY-1744
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Changing ToStringTester from utils to utils-test.
Correcting the policy/common & policy/models version.
Change-Id: Ib0a14da17227f0f65004dc525a47f17519e25110
Issue-ID: POLICY-1746
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
|
|
|
|
Adding PdpGroup healthcheck REST API in PAP to return the health status
of all the Pdps registered with this PAP instance. The healthcheck
status will be based on the regular heartbeat coming from the pdps.
Change-Id: Ia0f1603b513bf62ce1df3058427dc6ccaf179cb3
Issue-ID: POLICY-1770
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
|
|
The policies listed in a "PDP Group Deploy" request may not have
fully qualified versions. Modified the code to replace the versions
in the request with fully qualified versions.
Also improved performance by avoiding look-ups of policies that
are already in the subgroup.
Change-Id: I37899c2b45228b97a80b7ef44f69694ba57e8f4a
Issue-ID: POLICY-1784
Signed-off-by: jrh3 <jrh3@att.com>
|
|
Replace string concatenation with "{}" place-holders in logging
statements.
Refactored PdpStatusMessageHandler and PdpGroupStateChangeProvider
to extract common/duplicate code block into PdpMessageGenerator.
Refactored selectPdpGroupsForRegistration() to reduce "cyclomatic complexity";
extracted selectPdpSubGroupsForRegistration from it.
Issue-ID: POLICY-1791
Signed-off-by: jrh3 <jrh3@att.com>
Change-Id: Ia0ebc1cf41cd2fa288130b4a58614a4983f47f8b
Signed-off-by: jrh3 <jrh3@att.com>
|
|
Added heart beat interval to the PDP-UPDATE message sent in response
to a heart beat message received from a PDP.
Added timers to detect missing heart beats and remove the PDP from
the DB - PdpTracker.
Modified current heart beat listener to update PdpTracker when a
heart beat is received.
Allow 3 missed heart beats instead of 2.
Change-Id: I81621fefbe494e0c4d6f0b9767b00b2a9dd398d8
Issue-ID: POLICY-1795
Signed-off-by: jrh3 <jrh3@att.com>
|
|
Modified the code to undeploy all versions of a policy if the
version is not specified.
Change-Id: Ic3815733b918e1cff8f381d54bceb710a35319b7
Issue-ID: POLICY-1782
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
PAP should not allow multiple versions of a policy to be deployed
to the same PDP. Modified the code to reject deployment requests
where a different version of the policy is already deployed. This
impacts both the PDP-Group-Deploy and the Simple-Deploy REST APIs.
Change-Id: I586b764951c20228d0d80ec8326869215e970fdf
Issue-ID: POLICY-1785
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
When a subgroup is deleted via the PDP Group create/update API,
any PDPs in the subgroup should have all of its policies undeployed.
In the process, refactored addOrUpdateSubGroups() out of updateGroup().
Change-Id: I0750802bfb133a655e38493a868744b512ca3fb4
Issue-ID: POLICY-1803
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Need this for the 5G OOF PCI Use Case.
Issue-ID: POLICY-1776
Change-Id: I86758174840d376d6003f5200f0deeb72c3e01d9
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
The PAP Undeploy CSIT was failing, because it was returning 400.
The code was counting PDP UPDATE requests to determine whether or
not the policy had been found. However, if a subgroup currently
has no PDPs assigned (as is the case with the CSIT), then there
will be no PDP UPDATEs, thus it will think that the policy was
not found and return 400. Modified the code to count updates to
the DB instead.
Change-Id: I80cdcc738e07c418e0a7184284e7a228e3a6014d
Issue-ID: POLICY-1758
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
When multiple policies are deployed to the same group in a single
request, and the policies have different policy types, only the
changes associated with the last policy are kept. Updated the
policy type lookup to use cached groups, when available.
This still needs a junit to verify the fix, but that can come
later.
Also added more logging.
Change-Id: Ieaf866da504b167c884bf53f88aa8cb9e9b5e32a
Issue-ID: POLICY-1761
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
When undeploying a policy, if a policy's type is found in
a group, but the policy is not, then PAP returns 200. It
should return an error instead.
Change-Id: I88273fdbd5d49095e8248ab9267cccc529af0ae0
Issue-ID: POLICY-1758
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Changing PAP initial db data to bring all the xacml supportedPolicyTypes
in one PdpGroup.
Change-Id: I9a0788c788bab470109b0f09fb631e7fbb90042e
Issue-ID: POLICY-1723
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
|
|
When a response is received by PAP from a PDP, the associated timer
(and listener) are not being cancelled. As a result, when the timer
later expired, PAP was re-sending the request. Modified the code to fix
this.
Change-Id: Id63f76622c01d286c169b618f8369b849ff31085
Issue-ID: POLICY-1715
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
1) Adding algorithm for improving Pdp registration. The flow is:
When a new Pdp comes for registration, PAP will shortlist a list of
PdpGroups based on the supportedPolicyTypes reported by PdpStatus
message and the supportedPolicyTypes in the PdpSubGroup.
Then PAP will find the PdpGroup which needs the Pdp most in two ways:
1) If there is a subgroup with no Pdp's then that takes the priority.
2) Otherwise the Pdp is allocated to the PdpGroup with highest
difference value of desiredInstanceCount - currentInstanceCount.
2) Changing the preconfigured TosaPolicyType for apex to avoid
interference with legacy operational policies of drools.
Change-Id: I77584c3c030bc27903c11689acaca33148e27e3c
Issue-ID: POLICY-1630
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
|
|
Extracted common code from "delete" controller.
Extracted common code from "deploy" controller.
Not sure if this will actually fix the sonar issue or not. If it's
really complaining about the code, then this should fix it. On
the other hand, if it's complaining about the annotations, then
I don't think there's a way around it.
Change-Id: I7c68393f3fc1b9719987d850582bd8ed335b9663
Issue-ID: POLICY-1711
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
When a group is created, PAP should verify that the "supported types"
exist in the DB.
Address potential sonar issue.
Address potential sonar issue in similar block of code.
Change-Id: Ib830550bc37d4ebe42c8782f3f874e463f3f51c2
Issue-ID: POLICY-1688
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Return 404 instead of 500 when items are not found. Bubble up other
HTTP error codes instead of changing them all to 500.
Change-Id: Ib614bb83f28cfb1ce2384679398f0a45058fc455
Issue-ID: POLICY-1686
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
Added test that checks sunny day scenarios for the PAP REST API.
Uses real PAP components for everything except DMaaP. PDPs are
simulated.
Change-Id: If2adc3b1523b477c3efd3eb83fb7a7b04f40fa24
Issue-ID: POLICY-1670
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
UpdateReq throws NPE if the policy list in the request or the
response is null.
Change-Id: I0d71d6ad4cc9b96315c3b3ba89af8e4d8f3f94e6
Issue-ID: POLICY-1669
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Add configurtion files that work with the DMaaP simulator.
Issue-ID: POLICY-1643
Change-Id: I8e387163ab190b9610669029720ccf7b9989cfdf
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Some required fields were missing from the subgroups in the
inital DB. Also added code to validate what is initially loaded into
the DB.
Change-Id: Iffa56a5a0dee833691d1bb7859b075c3b4d86595
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
|