Age | Commit message (Collapse) | Author | Files | Lines |
|
Reduced technical debt by fixing sonar issues
Issue-ID: POLICY-4536
Change-Id: I3f4ff8cae7d22c5d2d062e98475592425e3c98c4
Signed-off-by: Suresh Charan <suresh.charan@bell.ca>
|
|
Issue-ID: POLICY-4533
Change-Id: I8ba51dce05f537778a92547bceff6eb6d6099144
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
- Upgrade Hibernate
- Upgrade Mockito
- Upgrade Mockserver
- Remove Powermock (no longer supported) and replace with spring-test ReflectionTestUtils
- Upgrade Spring Framework
- Add spring-security to allow authentication on unit tests using MockMVC
Minor clean-up
- Replace deprecated authorization configuraiton on spring boot applications with SecurityFilterChain bean
- Change @LocalPort include on tests to use test include rather than runtime include
- Remove unused imports
- Remove unused constants and variables
- Add deprecation annotations where required
Issue-ID: POLICY-4482
Change-Id: Ifcabd73e4130810ba2a99b842ffa4203836c0682
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Adding Contract tests, verifying the stubbed implementation.
Fixing name in application-stub.yaml
Issue-ID: POLICY-4534
Change-Id: I03d8b37ba2f57aa03ee814924b4e52dd0c643772
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
|
|
Added "stub" profile with simple endpoint implementation
Issue-ID: POLICY-4143
Change-Id: I8ad911f314e1d1428d05aa419f1322616d8ef835
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
|
|
This commit removes the Swagger V2 annotations on the
Rest Controllers in policy-pap. The OpeApi annotations (Swagger
v3 annotations) are on a generated Java Interface. The code is changed
so that the controller implements that interface.
There are minimal code changes to the controller and the order of the
parameters is switched in some cases.
Issue-ID: POLICY-4404
Change-Id: I060709806a8e5bc04d9873c8d212a5c9fe13c4d4
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
|
|
The latest verison of H2 does not allow colums called "user" or indexes
using an underscore in their name.
Issue-ID: POLICY-4488
Change-Id: I9ce7435b5dfa81daaf04e7f7a50f9db6582cdc0b
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
- undeploy policy timing
- deploy policy timing
- unit tests for actuator endpoints
Issue-ID: POLICY-4469
Change-Id: I3298888e59824347b8d2a57fb531c10f2f4ca125
Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
|
|
This commit:
- Remove SpringFox
- Adds SpringDoc
- Enables the .../v3/api-docs endpoint
Note that the Swagger annotations from the OpenAPI specification
generated code need to be enabled so that the API specification is
available over the ..../v3/api-docs endpoint. THis will be done in
subsequent commits.
Issue-ID: POLICY-4404
Change-Id: I42c1575a3ce76d9b3e753ad51f85df027d12b980
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
- for using Kafka instead of dmaap, topics names need to be lowercase
- fix for unit/integration tests using default names and changed names
for topics and group
- fix for sonar lints found along the way
Issue-ID: POLICY-4455
Change-Id: I89e9e6f7dbb07462f1ae497755965cb5a3f223a3
Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
|
|
Issue-ID: POLICY-4045
Change-Id: I08c3cb1af3dbe2051dcbb0e2726906faff4a37b3
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Change-Id: I72bde10eae615e2c89ccc1a211c6385404b9b3c7
Issue-ID: POLICY-4088
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
policy-models changes for metadataSet db serialization causes
test failure in pap.
Issue-ID: POLICY-3934
Signed-off-by: zrrmmua <ramesh.murugan.iyer@est.tech>
Change-Id: Ibc24e3a27e1cdd6111719651349888157fc31593
|
|
The healthcheck response that is returned by PAP is not inline with the
actual healthreport. Even when the report has
healthy:false, code:503, message:not alive
the response code stays 200. This is fixed, this also makes the improved
readiness probe in OOM to work properly with the healthcheck calls
Change-Id: Ib208e0a84bce74157aacbcad61a11dcf900c7c94
Issue-ID: POLICY-4030
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
1) Swagger was getting generated in a different format
due to a serialization isue. It is fixed.
2) Improved exception handling by taking care of any exceptions
that could occur in and around database operations.
3) AAF enabling/disabling was done using spring profiles.
This is changed to using parameters, as it is more easier to configure
in an OOM helm chart deployment
Change-Id: If1bee01379ba5c4efac29822662896d8aa883fc8
Issue-ID: POLICY-3975
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
|
|
MetadataSet fetched from the db and added to the policy metadata map
with the key "metadataSet" before sending to PDPs
Issue-ID: POLICY-3832
Signed-off-by: zrrmmua <ramesh.murugan.iyer@est.tech>
Change-Id: I14064d82ba6877bd7560af7de7572b4813a98385
|
|
Change-Id: I4b6a93045c1ddfd7fff037e7568b029e2e45b0b3
Issue-ID: POLICY-3757
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Use YamlHttpMessageConverter from policy/common.
Use CustomImplicitNamingStrategy from policy/common.
Fix few sonar issues.
Issue-ID: POLICY-3931
Change-Id: I4720761cbf8da464ec57541f9b19f8d124503e17
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Change-Id: If244237e4aa39e1f3184cab04ae7d5ad7e85e5fa
Issue-ID: POLICY-3897
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
|
|
This commit improves PAP healthcheck API to enable verification of PAP to DB connectivity.
Issue-ID: POLICY-3763
Signed-off-by: Prakhar Pandey <prakhar.pandey@bell.ca>
Change-Id: I14353572a00e68a89161bcffd2ec3476b4a4c303
|
|
Adding yaml support to pap rest api's.
Along with related unit tests.
Issue-ID: POLICY-3864
Change-Id: I43bdbbd4151bcae5dcf4752a9385b115efa947d3
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
This review makes PAP talk to DB directly using the spring repositories
instead of going to policy-models-provider.
The models-provider methods that were just used by PAP (and not used
anymore) will be removed in a different review.
Also a bug identified with the usage of GeneratedValue in
PfGeneratedIdKey (which is just used by PAP in statistics & audit) will
also be fixed in a separate review as part of POLICY-3897.
CSIT changes: https://gerrit.onap.org/r/c/policy/docker/+/127033
WIP OOM review: https://gerrit.onap.org/r/c/oom/+/127035
Change-Id: Idb13ba7eb2767cc718672b582a6518fcfc95320f
Issue-ID: POLICY-3867
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
This review adds the spring repository and service layers to PAP.
Once this is merged, the next work will be to actually use these
spring boot based services to talk to the db directly,
and not using policy-models-provider in PAP.
Change-Id: Ib086b8b405020cb452e51d6359dd1a69d0000f74
Issue-ID: POLICY-3869
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Issue-ID: POLICY-2086
Change-Id: I891feb05d2e964ae8d4454d30672ffc77c1da555
Signed-off-by: Wayne Dunican <wayne.dunican@est.tech>
|
|
Issue-ID: POLICY-3836
Signed-off-by: isaac <isaac.adorno@att.com>
Change-Id: Ia4ed2595984f68bf75ca9dacb6aa76f04a306224
|
|
This commit migrates pap config, startup and controllers to spring boot.
Change-Id: Icf91d728160a23db614dfba6b40ddccd2f6163a5
Issue-ID: POLICY-3754
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Use an account other than healthcheck in PAP for provisioning of policies.
Issue-ID: POLICY-2744
Change-Id: I897f7a4fffbac2d4bbd9cceb059bae1794753aa7
Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
|
|
Added runtime exceptions to the "catch" clause so that the thread
associated with the PDP expiration timer will not terminate.
Also added to a few other "catch" clauses, particularly those in the
REST controllers.
Issue-ID: POLICY-3625
Change-Id: I9206121d3e9b91da593ae771e7586752b13949be
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Add dmaap connectivity check in pap consolidated health check.
Make a rest call to fetch all the topics.
Verify POLICY-PDP-PAP topic is present.
Issue-ID: POLICY-2896
Change-Id: Ide39c70999eaca61205225c95b904e3009d41408
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Issue-ID: POLICY-3531
Change-Id: I1e66779f4ac05862649828e79914e902a99400d3
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Updating query params in audit api's
to keep them in sync with statistics api's.
Issue-ID: POLICY-3527
Change-Id: I096436930450c263835ff8852edd40655de4fb0d
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Issue-ID: POLICY-3511
Change-Id: Ifc91e4732b3574da37f55658b23faf8a9f8091f5
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Adding datetime format to audit api's
so that clients can send the request in one common format.
Changed the format to epoch timestamp.
Fixed review comments.
Issue-ID: POLICY-3340
Change-Id: I613ac02154a3e521ae97f7ac2e6129f642164b3f
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Adding api's to fetch policy audit records from db.
This is as per the design documented here -
https://wiki.onap.org/display/DW/PAP+REST+API+changes+for+Istanbul+release
Issue-ID: POLICY-3340
Change-Id: Iff80ab695d17ec38d4fe8ab98c0b95048cbae448
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Replaced generic BusTopicParams with more specific RestClientParameters.
Issue-ID: POLICY-3456
Change-Id: Ic1a3acca5b651730fc74332c2c5d5bc36bccb790
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-3383
Change-Id: Iec7875fb1fa6a4a360b8cfdff0b80f697a289de3
Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
|
|
|
|
While running CSIT to test heartbeat changes with multiple PAPs,
observed an NPE in UpdateReq.reconfigure(). Modified the code to
always use deployment lists instead of null lists.
Issue-ID: POLICY-3460
Change-Id: I884e091817e88309330139a01d060e286bd42008
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Separated the heartbeat processing onto its own POLICY-HEARTBEAT topic,
still on the "real" (i.e., "effective") POLICY-PDP-PAP topic, like we
had originally been doing with the statistics. With this change,
statistics processing continues to be part of the heartbeat
class/processing, thus a separate class is not required to listen for,
and handle, statistics.
This new subscription uses a shared consumer group so that only one PAP
will process any given heartbeat message, which should reduce the
likelihood of DB contention and duplicate keys.
This also means that the "saveStatisticsInDb" flag will still be used,
which is a more obvious mechanism for controlling the storing of
statistics than the presence/absence of a topic in the config file.
Issue-ID: POLICY-3460
Change-Id: Ia07132b1c7aef006af86fddbe677fb1243a4e2c3
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
This reverts commit 7b4a8ec06c8266f368a31cdafe75cf8a59304c83.
Reason for revert:
Decided to have the whole heartbeat processing use its own subscription, thus no need for a new class/topic just to collect statistics.
Issue-ID: POLICY-3405
Change-Id: I71580f877dae86a058ee881bc10f7bd1f57ff338
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
This new class will be tied into the existing code via the next review.
Issue-ID: POLICY-3405
Change-Id: I4317ccba3eda6863ce96a6db4ef20816e59a7f2d
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Adding an ability in pap to turn on/off processing of pdp statistics.
By default it will be turned on and can be changed via configuration.
Issue-ID: POLICY-3450
Change-Id: I093fe3f1390769f9acf2cfe85dd0d4edf0539de8
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Fixed:
- indentation
- use isEmpty()
- use isZero()
Issue-ID: POLICY-3287
Change-Id: Idcfba3a6839a47c3136fca8500128990ed64dcb1
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
|
|
Used the unique name generator to initialize the PAP_NAME constant which
is then stuffed into the various outgoing PdpMessages.
Issue-ID: POLICY-3409
Change-Id: I45d26403b4f3de4b040cad779f29c82f35bacf42
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Because multiple PAPs can be updating the DB, it's possible that a
pdp-update sent by a PAP does not reflect the latest deployment data
in the DB. To solve that problem, modified code to compare any response
received from a PDP with what's in the DB, potentially generating a new
pdp-update (and/or pdp-state-change).
Issue-ID: POLICY-3426
Change-Id: I241994330d7645c0fffe66abc33de67d71d77250
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Creates audits for policy when:
- deploy
- undeploy
- undeploy when failure
Issue-ID: POLICY-2899
Change-Id: Ib1a7cc4f826b5dceefcd5c7ba5250647f2cc0121
Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
|